Re: [PATCH] [media] convert drivers/media/* to use module_platform_driver()

2011-11-29 Thread Matti J. Aaltonen
...@ideasonboard.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Hans Verkuil hans.verk...@cisco.com Cc: Richard Röjfors richard.rojf...@pelagicore.com Cc: Matti J. Aaltonen matti.j.aalto...@nokia.com Cc: Lucas De Marchi lucas.demar...@profusion.mobi Cc: Manjunath Hadli manjunath.ha...@ti.com

Re: [GIT PATCHES FOR 2.6.40] Fixes

2011-06-10 Thread Matti J. Aaltonen
Hello. On Mon, 2011-05-23 at 13:06 +0200, ext Hans Verkuil wrote: Hi Mauro, Here are a few fixes: the first fixes a bug in the wl12xx drivers (I hope Matti's email is still correct). The second fixes a few DocBook validation errors, and I'm still here... And it's a nice surprise that the

[PATCH v21 3/3] ASoC: WL1273 FM radio: Access I2C IO functions through pointers.

2011-03-01 Thread Matti J. Aaltonen
in the copyright statement. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- sound/soc/codecs/Kconfig |2 +- sound/soc/codecs/wl1273.c | 11 --- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index c48b23c

[PATCH v21 1/3] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2011-03-01 Thread Matti J. Aaltonen
audio, without it only analog audio is available. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/mfd/Kconfig |2 +- drivers/mfd/wl1273-core.c | 149 ++- include/linux/mfd/wl1273-core.h |2 + 3 files changed, 149

[PATCH v21 0/3] ASoC/MFD/V4L2: WL1273 FM Radio Driver

2011-03-01 Thread Matti J. Aaltonen
...@linux.intel.com Cheers, Matti Matti J. Aaltonen (3): MFD: WL1273 FM Radio: MFD driver for the FM radio. V4L2: WL1273 FM Radio: TI WL1273 FM radio driver ASoC: WL1273 FM radio: Access I2C IO functions through pointers. drivers/media/radio/radio-wl1273.c | 360

[PATCH v21 2/3] V4L2: WL1273 FM Radio: TI WL1273 FM radio driver

2011-03-01 Thread Matti J. Aaltonen
This module implements V4L2 controls for the Texas Instruments WL1273 FM Radio and handles the communication with the chip. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/media/radio/radio-wl1273.c | 360 +++- 1 files changed, 106

[PATCH v22 0/3] ASoC/MFD/V4L2: WL1273 FM Radio Driver

2011-03-01 Thread Matti J. Aaltonen
Hello. Thanks for the comment Mark. On Tue, 2011-03-01 at 11:54 +, ext Mark Brown wrote: On Tue, Mar 01, 2011 at 10:00:50AM +0200, Matti J. Aaltonen wrote: These changes are needed to keep up with the changes in the MFD core and V4L2 parts of the wl1273 FM radio driver. Use function

[PATCH v22 1/3] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2011-03-01 Thread Matti J. Aaltonen
audio, without it only analog audio is available. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/mfd/Kconfig |2 +- drivers/mfd/wl1273-core.c | 149 ++- include/linux/mfd/wl1273-core.h |2 + 3 files changed, 149

[PATCH v22 3/3] ASoC: WL1273 FM radio: Access I2C IO functions through pointers.

2011-03-01 Thread Matti J. Aaltonen
in the copyright statement. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- sound/soc/codecs/Kconfig |2 +- sound/soc/codecs/wl1273.c | 11 --- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index c48b23c

[PATCH v22 2/3] V4L2: WL1273 FM Radio: TI WL1273 FM radio driver

2011-03-01 Thread Matti J. Aaltonen
This module implements V4L2 controls for the Texas Instruments WL1273 FM Radio and handles the communication with the chip. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/media/radio/radio-wl1273.c | 360 +++- 1 files changed, 106

Re: [PATCH v22 3/3] ASoC: WL1273 FM radio: Access I2C IO functions through pointers.

2011-03-01 Thread Matti J. Aaltonen
On Tue, 2011-03-01 at 13:23 +, ext Mark Brown wrote: On Tue, Mar 01, 2011 at 03:10:37PM +0200, Matti J. Aaltonen wrote: These changes are needed to keep up with the changes in the MFD core and V4L2 parts of the wl1273 FM radio driver. Use function pointers instead of exported

[PATCH v20 1/3] MFD: Wl1273 FM radio core: Add I2C IO functions.

2011-02-28 Thread Matti J. Aaltonen
Add I2C IO functions. Change the IO operation from read to write in wl1273_fm_set_volume. Update the year of the copyright statement. Remove two unnecessary calls to i2c_set_clientdata. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/mfd/Kconfig |2

[PATCH v20 2/3] V4L2: Wl1273 FM Radio: Remove I2C IO functions.

2011-02-28 Thread Matti J. Aaltonen
Remove I2C IO functions. After refactoring they currently belong to the Wl1273 MFD driver. And now the IO functions are accessed through pointers. Update the year in the copyright statement. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/media/radio/radio-wl1273.c | 360

[PATCH v20 3/3] ASoC: WL1273 FM radio: Access I2C IO functions through pointers.

2011-02-28 Thread Matti J. Aaltonen
in the copyright statement. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- sound/soc/codecs/Kconfig |2 +- sound/soc/codecs/wl1273.c | 11 --- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index c48b23c

[PATCH v20 0/3] ASoC/MFD/V4L2: WL1273 FM Radio driver

2011-02-28 Thread Matti J. Aaltonen
: + i2c_set_clientdata(client, NULL); Ditto. Ditto. Cheers, Matti Matti J. Aaltonen (3): MFD: Wl1273 FM radio core: Add I2C IO functions. V4L2: Wl1273 FM Radio: Remove I2C IO functions. ASoC: WL1273 FM radio: Access I2C IO functions through pointers. drivers/media/radio/radio-wl1273.c | 360

[PATCH v19 0/3] TI Wl1273 FM radio driver.

2011-02-15 Thread Matti J. Aaltonen
Hello. Now I've refactored the code so that the I2C I/O functions are in the MFD core. Also now the codec can be compiled without compiling the V4L2 driver. I haven't implemented the audio routing (yet), but I've added a TODO comment about it in the codec file. Cheers, Matti Matti J. Aaltonen

[PATCH v19 3/3] ASoC: WL1273 FM radio: Access I2C IO functions through pointers.

2011-02-15 Thread Matti J. Aaltonen
These changes are needed to keep up with the changes in the MFD core and V4L2 parts of the wl1273 FM radio driver. Use function pointers instead of exported functions for I2C IO. Also move all preprocessor constants from the wl1273.h to include/linux/mfd/wl1273-core.h. Signed-off-by: Matti J

[PATCH v19 1/3] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2011-02-15 Thread Matti J. Aaltonen
audio, without it only analog audio is available. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/mfd/Kconfig | 10 ++ drivers/mfd/Makefile|1 + drivers/mfd/wl1273-core.c | 295 +++ include/linux/mfd

[PATCH v19 2/3] V4L2: WL1273 FM Radio: TI WL1273 FM radio driver

2011-02-15 Thread Matti J. Aaltonen
This module implements V4L2 controls for the Texas Instruments WL1273 FM Radio and handles the communication with the chip. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/media/radio/Kconfig| 16 + drivers/media/radio/Makefile |1 + drivers/media

RE: [alsa-devel] WL1273 FM Radio driver...

2011-02-10 Thread Matti J. Aaltonen
Hello. On Thu, 2011-02-10 at 09:35 +, ext Bensaid, Selma wrote: On Tue, 2011-02-08 at 13:02 +0200, Peter Ujfalusi wrote: For both configuration we have a set of HCI commands to configure the FM audio path and one of my concerns is to know if the wl1273_codec should handle the

Re: [alsa-devel] WL1273 FM Radio driver...

2011-02-10 Thread Matti J. Aaltonen
On Thu, 2011-02-10 at 12:28 +, ext Mark Brown wrote: On Thu, Feb 10, 2011 at 02:10:40PM +0200, Matti J. Aaltonen wrote: But I got the following quick comment from a local BT expert: No you cannot change line discipline if bt is already in use. And it's not uart interface but hci

Re: WL1273 FM Radio driver...

2011-02-09 Thread Matti J. Aaltonen
On Mon, 2011-02-07 at 14:00 -0200, ext Mauro Carvalho Chehab wrote: Em 07-02-2011 12:17, Matti J. Aaltonen escreveu: On Mon, 2011-02-07 at 13:52 +, ext Mark Brown wrote: On Mon, Feb 07, 2011 at 11:48:17AM -0200, Mauro Carvalho Chehab wrote: Em 07-02-2011 11:10, Mark Brown escreveu

Re: [alsa-devel] WL1273 FM Radio driver...

2011-02-08 Thread Matti J. Aaltonen
On Tue, 2011-02-08 at 13:02 +0200, Peter Ujfalusi wrote: For both configuration we have a set of HCI commands to configure the FM audio path and one of my concerns is to know if the wl1273_codec should handle the audio path configuration and the switch between FM and BT SCO? It

Re: [alsa-devel] WL1273 FM Radio driver...

2011-02-08 Thread Matti J. Aaltonen
On Tue, 2011-02-08 at 11:15 +0200, Peter Ujfalusi I have not looked deeply into the wl1273 datasheets, but I'm sure there's a way to nicely divide the parts between the MFD, V4L, and ASoC. I don't think there's much to be moved between the sub-systems after moving the I2C communication to

Re: WL1273 FM Radio driver...

2011-02-07 Thread Matti J. Aaltonen
Hello. Mark Brown wrote: On Wed, Feb 02, 2011 at 01:35:01PM -0200, Mauro Carvalho Chehab wrote: [Reflowed into 80 columns.] My concerns is that the V4L2-specific part of the code should be at drivers/media. I prefer that the specific MFD I/O part to be at drivers/mfd, just like the other

Re: WL1273 FM Radio driver...

2011-02-07 Thread Matti J. Aaltonen
On Mon, 2011-02-07 at 10:48 -0200, ext Mauro Carvalho Chehab wrote: Em 07-02-2011 10:02, Mark Brown escreveu: On Mon, Feb 07, 2011 at 10:00:16AM -0200, Mauro Carvalho Chehab wrote: the MFD part (for example, wl1273_fm_read_reg/wl1273_fm_write_cmd/wl1273_fm_write_data). The logic that

Re: WL1273 FM Radio driver...

2011-02-07 Thread Matti J. Aaltonen
On Mon, 2011-02-07 at 11:48 -0200, ext Mauro Carvalho Chehab wrote: Em 07-02-2011 11:10, Mark Brown escreveu: On Mon, Feb 07, 2011 at 10:48:03AM -0200, Mauro Carvalho Chehab wrote: Em 07-02-2011 10:02, Mark Brown escreveu: On Mon, Feb 07, 2011 at 10:00:16AM -0200, Mauro Carvalho Chehab

Re: WL1273 FM Radio driver...

2011-02-07 Thread Matti J. Aaltonen
On Mon, 2011-02-07 at 13:52 +, ext Mark Brown wrote: On Mon, Feb 07, 2011 at 11:48:17AM -0200, Mauro Carvalho Chehab wrote: Em 07-02-2011 11:10, Mark Brown escreveu: There is an audio driver for this chip and it is using those functions. Where are the other drivers that depend on

WL1273 FM Radio driver...

2011-01-18 Thread Matti J. Aaltonen
Hello I have been trying to get the WL1273 FM radio driver into the kernel for some time. It has been kind of difficult, one of the reasons is that I didn't realize I should have tried to involve all relevant maintainers to the discussion form the beginning (AsoC, Media and MFD). At Mark's

Re: [PATCH 8/8] [media] saa7134: Kworld SBTVD: make both analog and digital to work

2011-01-17 Thread Matti J. Aaltonen
On Sat, 2011-01-15 at 16:04 -0200, ext Mauro Carvalho Chehab wrote: There are some weird bugs at tda8290/tda18271 initialization, as it insits do do analog initialization during DVB frontend attach: diff --git a/drivers/media/common/tuners/tda8290.c b/drivers/media/common/tuners/tda8290.c

[PATCH] V4L2: WL1273 FM Radio: Replace ioctl with unlocked_ioctl.

2011-01-04 Thread Matti J. Aaltonen
Use unlocked_ioctl in v4l2_file_operations. The locking is already in place. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/media/radio/radio-wl1273.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/radio/radio-wl1273.c b/drivers

Re: [git:v4l-dvb/for_v2.6.38] [media] [v18, 2/2] V4L2: WL1273 FM Radio: TI WL1273 FM radio driver

2010-12-22 Thread Matti J. Aaltonen
-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com drivers/media/radio/Kconfig| 16 + drivers/media/radio/Makefile |1 + drivers/media/radio/radio-wl1273.c | 2331 3

[PATCH v18 1/2] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-12-10 Thread Matti J. Aaltonen
audio, without it only analog audio is available. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/mfd/Kconfig | 10 ++ drivers/mfd/Makefile|1 + drivers/mfd/wl1273-core.c | 148 include/linux/mfd/wl1273-core.h | 288

[PATCH v18 0/2] WL1273 FM Radio driver...

2010-12-10 Thread Matti J. Aaltonen
add my: Acked-by: Samuel Ortiz sa...@linux.intel.com OK. \ No newline at end of file Please add a new line here. Added... Cheers, Matti Matti J. Aaltonen (2): MFD: WL1273 FM Radio: MFD driver for the FM radio. V4L2: WL1273 FM Radio: TI WL1273 FM radio driver drivers/media/radio/Kconfig

[PATCH v17 0/2] WL1273 FM radio driver...

2010-12-03 Thread Matti J. Aaltonen
Matti J. Aaltonen (2): MFD: WL1273 FM Radio: MFD driver for the FM radio. V4L2: WL1273 FM Radio: TI WL1273 FM radio driver drivers/media/radio/Kconfig| 16 + drivers/media/radio/Makefile |1 + drivers/media/radio/radio-wl1273.c | 2331

[PATCH v17 1/2] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-12-03 Thread Matti J. Aaltonen
audio, without it only analog audio is available. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/mfd/Kconfig | 10 ++ drivers/mfd/Makefile|1 + drivers/mfd/wl1273-core.c | 148 include/linux/mfd/wl1273-core.h | 288

Re: [PATCH v16 1/2] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-11-22 Thread Matti J. Aaltonen
Hello Samuel, On Wed, 2010-11-17 at 15:42 +0200, Matti J. Aaltonen wrote: This is the core of the WL1273 FM radio driver, it connects the two child modules. This is a parent for two child drivers: drivers/media/radio/radio-wl1273.c and sound/soc/codecs/wl1273.c Radio-wl1273 implements

[PATCH v16 0/2] *** SUBJECT HERE ***

2010-11-17 Thread Matti J. Aaltonen
/radio... I also want mfd's maintainer ack of the mfd patch. Sending this also to Samuel Ortiz... Cheers, Matti Matti J. Aaltonen (2): MFD: WL1273 FM Radio: MFD driver for the FM radio. V4L2: WL1273 FM Radio: TI WL1273 FM radio driver drivers/media/radio/Kconfig| 16 + drivers

[PATCH v16 1/2] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-11-17 Thread Matti J. Aaltonen
is for digital audio. Without the codec only analog audio is available. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/mfd/Kconfig |6 + drivers/mfd/Makefile|1 + drivers/mfd/wl1273-core.c | 154 include/linux/mfd/wl1273

[GIT PULL REQUEST v2.] WL1273 FM Radio driver.

2010-11-16 Thread Matti J. Aaltonen
/wl1273-fm-driver.git master Matti J. Aaltonen (2): MFD: WL1273 FM Radio: MFD driver for the FM radio. V4L2: WL1273 FM Radio: Controls for the FM radio. drivers/media/radio/Kconfig| 16 + drivers/media/radio/Makefile |1 + drivers/media/radio/radio-wl1273.c | 1841

[GIT PULL REQUEST] WL1273 FM Radio driver.

2010-11-15 Thread Matti J. Aaltonen
...@gitorious.org:wl1273-fm-driver/wl1273-fm-driver.git master Matti J. Aaltonen (2): MFD: WL1273 FM Radio: MFD driver for the FM radio. V4L2: WL1273 FM Radio: Controls for the FM radio. drivers/media/radio/Kconfig| 16 + drivers/media/radio/Makefile |1 + drivers/media/radio/radio

[PATCH] v4l-utils: Add support for new RDS CAP bits.

2010-10-21 Thread Matti J. Aaltonen
Add support for V4L2_TUNER_CAP_RDS_BLOCK_IO and V4L2_TUNER_CAP_RDS_CONTROLS tuner/modulator capability bits. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- utils/v4l2-ctl/v4l2-ctl.cpp |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/utils/v4l2-ctl/v4l2

Re: [PATCH v13 1/1] Documentation: v4l: Add hw_seek spacing and two TUNER_RDS_CAP flags.

2010-10-19 Thread Matti J. Aaltonen
Hi. On Mon, 2010-10-18 at 15:57 +0200, ext Hans Verkuil wrote: Em 18-10-2010 11:17, Hans Verkuil escreveu: Just a few very small comments: +For future use the +flag constantV4L2_TUNER_SUB_RDS_CONTROLS/constant has also been +defined. However, a driver for a radio tuner with this

[PATCH RFC 1/1] V4L2: Use new CAP bits in existing RDS capable drivers.

2010-10-18 Thread Matti J. Aaltonen
Add either V4L2_TUNER_CAP_RDS_BLOCK_IO or V4L2_TUNER_CAP_RDS_CONTROLS bit to tuner or modulator capabilities of existing drivers of devices with RDS capability. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/media/radio/radio-cadet.c|3 ++- drivers

[PATCH v13 1/1] Documentation: v4l: Add hw_seek spacing and two TUNER_RDS_CAP flags.

2010-10-18 Thread Matti J. Aaltonen
Add a couple of words about the spacing field in the HW seek struct, also a few words about the new RDS tuner capability flags V4L2_TUNER_CAP_RDS_BLOCK-IO and V4L2_TUNER_CAP_RDS_CONTROLS. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- Documentation/DocBook/v4l/dev-rds.xml

[PATCH v13 0/1] V4L2: Documentation: hw_seek spacing, tuner/modulator

2010-10-18 Thread Matti J. Aaltonen
it is no longer exclusively referring to the receiver API. You should alse add a link to the FM Transmitter Control Reference section when describing the CONTROLS capability. I added Writing RDS data section etc... B.R. Matti Matti J. Aaltonen (1): Documentation: v4l: Add hw_seek spacing

[PATCH v14 1/1] Documentation: v4l: Add hw_seek spacing and two TUNER_RDS_CAP flags.

2010-10-18 Thread Matti J. Aaltonen
Add a couple of words about the spacing field in the HW seek struct, also a few words about the new RDS tuner capability flags V4L2_TUNER_CAP_RDS_BLOCK-IO and V4L2_TUNER_CAP_RDS_CONTROLS. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- Documentation/DocBook/v4l/dev-rds.xml

[PATCH v14 0/1] V4L2: Documentation: hw_seek spacing, tuner/modulator

2010-10-18 Thread Matti J. Aaltonen
. Added read-only comment to these bits. Cheers, Matti Matti J. Aaltonen (1): Documentation: v4l: Add hw_seek spacing and two TUNER_RDS_CAP flags. Documentation/DocBook/v4l/dev-rds.xml | 68 +++- .../DocBook/v4l/vidioc-s-hw-freq-seek.xml | 10 ++- 2 files

Re: [PATCH v13 1/1] Documentation: v4l: Add hw_seek spacing and two TUNER_RDS_CAP flags.

2010-10-18 Thread Matti J. Aaltonen
Hello. On Mon, 2010-10-18 at 11:41 -0200, ext Mauro Carvalho Chehab wrote: Em 18-10-2010 11:17, Hans Verkuil escreveu: Just a few very small comments: +For future use the +flag constantV4L2_TUNER_SUB_RDS_CONTROLS/constant has also been +defined. However, a driver for a radio tuner with

[PATCH v12 1/3] V4L2: Add seek spacing and RDS CAP bits.

2010-10-07 Thread Matti J. Aaltonen
radio text, program ID and so on. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- include/linux/videodev2.h |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index 61490c6..eadcda3 100644 --- a/include

[PATCH v12 3/3] Documentation: v4l: Add hw_seek spacing and two TUNER_RDS_CAP flags.

2010-10-07 Thread Matti J. Aaltonen
Add a couple of words about the spacing field in the HW seek struct, also a few words about the new RDS tuner capability flags V4L2_TUNER_CAP_RDS_BLOCK-IO and V4L2_TUNER_CAP_RDS_CONTROLS. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- Documentation/DocBook/v4l/dev-rds.xml

[PATCH v12 0/3] TI WL1273 FM Radio driver...

2010-10-07 Thread Matti J. Aaltonen
but the driver now has only read and write calls (and a couple of other calls). Also the driver doesn't export anything and it doesn't expose the FM radio bands it uses internally to the outsize world. Cheers, Matti Matti J. Aaltonen (3): V4L2: Add seek spacing and RDS CAP bits. V4L2: WL1273 FM

[PATCH v11 1/4] V4L2: Add seek spacing and RDS CAP bits.

2010-09-29 Thread Matti J. Aaltonen
radio text, program ID and so on. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- include/linux/videodev2.h |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index 61490c6..eadcda3 100644 --- a/include

[PATCH v11 4/4] Documentation: v4l: Add hw_seek spacing and two TUNER_RDS_CAP flags.

2010-09-29 Thread Matti J. Aaltonen
Add a couple of words about the spacing field in the HW seek struct, also a few words about the new RDS tuner capability flags V4L2_TUNER_CAP_RDS_BLOCK-IO and V4L2_TUNER_CAP_RDS_CONTROLS. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- Documentation/DocBook/v4l/dev-rds.xml

[PATCH v11 0/4] WL1273 FM Radio driver.

2010-09-29 Thread Matti J. Aaltonen
the digital audio codec. And in addition removed a reference to FM radio bands from the mfd file. B.R. Matti Matti J. Aaltonen (4): V4L2: Add seek spacing and RDS CAP bits. MFD: WL1273 FM Radio: MFD driver for the FM radio. V4L2: WL1273 FM Radio: Controls for the FM radio. Documentation: v4l

[PATCH v11 2/4] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-09-29 Thread Matti J. Aaltonen
This is a parent for two child drivers: a V4L2 driver and an ALSA codec driver. The MFD part implements I2C communication to the device and provides a couple of functions that are called from both children. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/mfd/wl1273-core.c

[PATCH v11 3/4] V4L2: WL1273 FM Radio: Controls for the FM radio.

2010-09-29 Thread Matti J. Aaltonen
This driver implements V4L2 controls for the Texas Instruments WL1273 FM Radio. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/media/radio/Kconfig| 16 + drivers/media/radio/Makefile |1 + drivers/media/radio/radio-wl1273.c | 1859

[PATCH v10 4/4] Documentation: v4l: Add hw_seek spacing and two TUNER_RDS_CAP flags.

2010-09-24 Thread Matti J. Aaltonen
Add a couple of words about the spacing field in the HW seek struct, also a few words about the new RDS tuner capability flags V4L2_TUNER_CAP_RDS_BLOCK-IO and V4L2_TUNER_CAP_RDS_CONTROLS. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- Documentation/DocBook/v4l/dev-rds.xml

[PATCH v10 2/4] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-09-24 Thread Matti J. Aaltonen
This is a parent for two child drivers: a V4L2 driver and an ALSA codec driver. The MFD part implements I2C communication to the device and provides a couple of functions that are called from both children. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/mfd/wl1273-core.c

[PATCH v10 1/4] V4L2: Add seek spacing and RDS CAP bits.

2010-09-24 Thread Matti J. Aaltonen
radio text, program ID and so on. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- include/linux/videodev2.h |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index 61490c6..eadcda3 100644 --- a/include

[PATCH v10 0/4] WL1273 FM Radio driver.

2010-09-24 Thread Matti J. Aaltonen
already defined. Changed the documentation to reflect the changes in the code. Cheers, Matti Matti J. Aaltonen (4): V4L2: Add seek spacing and RDS CAP bits. MFD: WL1273 FM Radio: MFD driver for the FM radio. V4L2: WL1273 FM Radio: Controls for the FM radio. Documentation: v4l: Add hw_seek

[PATCH v10 3/4] V4L2: WL1273 FM Radio: Controls for the FM radio.

2010-09-24 Thread Matti J. Aaltonen
This driver implements V4L2 controls for the Texas Instruments WL1273 FM Radio. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/media/radio/Kconfig| 15 + drivers/media/radio/Makefile |1 + drivers/media/radio/radio-wl1273.c | 1859

Re: [PATCH v10 3/4] V4L2: WL1273 FM Radio: Controls for the FM radio.

2010-09-24 Thread Matti J. Aaltonen
On Fri, 2010-09-24 at 15:09 +0200, ext Hans Verkuil wrote: This driver implements V4L2 controls for the Texas Instruments WL1273 FM Radio. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/media/radio/Kconfig| 15 + drivers/media/radio/Makefile

Re: [PATCH v9 3/4] V4L2: WL1273 FM Radio: Controls for the FM radio.

2010-09-16 Thread Matti J. Aaltonen
Hi. On Wed, 2010-09-08 at 21:09 +0200, ext Mauro Carvalho Chehab wrote: +static int wl1273_fm_vidioc_s_tuner(struct file *file, void *priv, + struct v4l2_tuner *tuner) +{ + struct wl1273_device *radio = video_get_drvdata(video_devdata(file)); + struct

Re: [PATCH v9 1/4] V4L2: Add seek spacing and FM RX class.

2010-09-15 Thread Matti J. Aaltonen
Hello. On Wed, 2010-09-08 at 20:35 +0200, ext Mauro Carvalho Chehab wrote: + case V4L2_CID_FM_BAND: return FM Band; There's no need for a FM control, as there's already an ioctl pair that allows get/set the frequency bandwidth: VIDIOC_S_TUNER and VIDIOC_G_TUNER. So,

Re: [PATCH v9 0/4] FM Radio driver.

2010-09-13 Thread Matti J. Aaltonen
On Sat, 2010-09-11 at 14:10 +0200, ext Hans Verkuil wrote: There are also up to three ways the RDS data can be received/sent: either as RDS blocks, or using controls, or as a completely raw bitstream. The latter is unlikely to be used for RDS output, but a cheap RDS receiver might just do

Re: [PATCH v9 0/4] FM Radio driver.

2010-09-13 Thread Matti J. Aaltonen
On Mon, 2010-09-13 at 13:32 +0200, ext Hans Verkuil wrote: Anyway the difference between the completely raw bits and the raw blocks is small. And I doubt the usefulness of supporting the completely raw format. I don't intend to support it now. But we need to realize that it exists and we

Re: [PATCH v9 0/4] FM Radio driver.

2010-09-13 Thread Matti J. Aaltonen
On Mon, 2010-09-13 at 13:51 +0200, ext Hans Verkuil wrote: On Monday, September 13, 2010 13:44:31 Matti J. Aaltonen wrote: On Mon, 2010-09-13 at 13:32 +0200, ext Hans Verkuil wrote: Anyway the difference between the completely raw bits and the raw blocks is small. And I doubt

Re: [PATCH v9 0/4] FM Radio driver.

2010-09-13 Thread Matti J. Aaltonen
On Mon, 2010-09-13 at 14:06 +0200, ext Hans Verkuil wrote: On Monday, September 13, 2010 13:59:30 Matti J. Aaltonen wrote: On Mon, 2010-09-13 at 13:51 +0200, ext Hans Verkuil wrote: On Monday, September 13, 2010 13:44:31 Matti J. Aaltonen wrote: On Mon, 2010-09-13 at 13:32 +0200, ext

Re: [PATCH v9 1/4] V4L2: Add seek spacing and FM RX class.

2010-09-09 Thread Matti J. Aaltonen
Hello. And thanks for the comments. On Wed, 2010-09-08 at 20:35 +0200, ext Mauro Carvalho } @@ -386,6 +394,8 @@ const char *v4l2_ctrl_get_name(u32 id) case V4L2_CID_TUNE_PREEMPHASIS: return Pre-emphasis settings; case V4L2_CID_TUNE_POWER_LEVEL: return Tune

[PATCH v9 4/4] Documentation: v4l: Add hw_seek spacing and FM_RX class

2010-08-30 Thread Matti J. Aaltonen
Add a couple of words about the spacing field in the HW seek struct, about the V4L2_CAP_RAW_RDS_ONLY capability flag and about the new FM RX control class. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- Documentation/DocBook/v4l/controls.xml | 71

[PATCH v9 0/4] FM Radio driver.

2010-08-30 Thread Matti J. Aaltonen
be). ... And a second?! + if (ctrl) { + ctrl-is_volatile = 1; + ctrl-priv = radio; + } And it is volatile? I thought that the ANTENNA_CAPACITOR was volatile. Something is messed up here. Fixed. Yes, that was completely messed up... Thanks... Matti Matti J

[PATCH v9 1/4] V4L2: Add seek spacing and FM RX class.

2010-08-30 Thread Matti J. Aaltonen
Add spacing field to v4l2_hw_freq_seek, add V4L2_CAP_RAW_RDS_ONLY to driver capabilities and also add FM RX class to control classes. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/media/video/v4l2-ctrls.c | 12 include/linux/videodev2.h| 16

[PATCH v9 2/4] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-08-30 Thread Matti J. Aaltonen
This is a parent for two child drivers: a V4L2 driver and an ALSA codec driver. The MFD part implements I2C communication to the device and provides a couple of functions that are called from both children. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/mfd/wl1273-core.c

[PATCH v9 3/4] V4L2: WL1273 FM Radio: Controls for the FM radio.

2010-08-30 Thread Matti J. Aaltonen
This driver implements V4L2 controls for the Texas Instruments WL1273 FM Radio. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/media/radio/Kconfig| 15 + drivers/media/radio/Makefile |1 + drivers/media/radio/radio-wl1273.c | 1935

Re: [PATCH v4 2/5] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-08-30 Thread Matti J. Aaltonen
Hello. On Sat, 2010-08-28 at 11:29 +0200, ext Hans Verkuil wrote: On Thursday, August 26, 2010 09:39:45 Matti J. Aaltonen wrote: Hi. On Wed, 2010-08-25 at 23:20 +0200, ext Pavan Savoy wrote: I'm sorry for not answering to you earlier. But I don't have my own public

Re: [PATCH v4 2/5] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-08-26 Thread Matti J. Aaltonen
Hi. On Wed, 2010-08-25 at 23:20 +0200, ext Pavan Savoy wrote: I'm sorry for not answering to you earlier. But I don't have my own public repository. But to create the whole thing is extremely simple: just take the current mainline tree and apply my patches on top of it... Yep,

[PATCH v8 1/5] V4L2: Add seek spacing and FM RX class.

2010-08-26 Thread Matti J. Aaltonen
Add spacing field to v4l2_hw_freq_seek and also add FM RX class to control classes. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/media/video/v4l2-ctrls.c | 12 include/linux/videodev2.h| 15 ++- 2 files changed, 26 insertions(+), 1

[PATCH v8 2/5] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-08-26 Thread Matti J. Aaltonen
This is a parent for two child drivers: a V4L2 driver and an ALSA codec driver. The MFD part implements I2C communication to the device and provides a couple of functions that are called from both children. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/mfd/wl1273-core.c

[PATCH v8 5/5] Documentation: v4l: Add hw_seek spacing and FM_RX class

2010-08-26 Thread Matti J. Aaltonen
Add a couple of words about the spacing field in ithe HW seek struct and about the new FM RX control class. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- Documentation/DocBook/v4l/controls.xml | 71 .../DocBook/v4l/vidioc-s-hw-freq-seek.xml

[PATCH v8 4/5] V4L2: WL1273 FM Radio: Controls for the FM radio.

2010-08-26 Thread Matti J. Aaltonen
This driver implements V4L2 controls for the Texas Instruments WL1273 FM Radio. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/media/radio/Kconfig| 15 + drivers/media/radio/Makefile |1 + drivers/media/radio/radio-wl1273.c | 1947

[PATCH v8 3/5] ASoC: WL1273 FM Radio Digital audio codec.

2010-08-26 Thread Matti J. Aaltonen
The codec handles digital audio input to and output from the WL1273 FM radio. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- sound/soc/codecs/Kconfig |6 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/wl1273.c | 593

[PATCH v8 0/5] TI WL1273 FM Radio driver.

2010-08-26 Thread Matti J. Aaltonen
specified using V4L2_CID_TUNE_POWER_LEVEL is 122 (dB/uV), then power level value to be passed for WL1273 should be '0'. Please correct me, if I got this conversion wrong. Fixed the TX power level handling... Thanks Matti Matti J. Aaltonen (5): V4L2: Add seek spacing and FM RX class. MFD: WL1273

Re: [PATCH v7 4/5] V4L2: WL1273 FM Radio: Controls for the FM radio.

2010-08-23 Thread Matti J. Aaltonen
Hi. On Fri, 2010-08-20 at 14:04 +0200, ext pramodh ag wrote: Hello, +static ssize_t wl1273_fm_fops_write(struct file *file, const char __user *buf, +size_t count, loff_t *ppos) +{ +struct wl1273_device *radio = video_get_drvdata(video_devdata(file)); +

Re: [PATCH v4 2/5] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-08-19 Thread Matti J. Aaltonen
Hello. On Wed, 2010-08-18 at 20:14 +0200, ext Pavan Savoy wrote: --- On Wed, 7/7/10, Pavan Savoy pavan_sa...@ti.com wrote: From: Pavan Savoy pavan_sa...@ti.com Subject: Re: [PATCH v4 2/5] MFD: WL1273 FM Radio: MFD driver for the FM radio. To: Matti J. Aaltonen matti.j.aalto

Re: A problem with http://git.linuxtv.org/media_tree.git

2010-08-12 Thread Matti J. Aaltonen
On Wed, 2010-08-11 at 15:16 +0200, ext Mauro Carvalho Chehab wrote: Em 11-08-2010 08:44, Matti J. Aaltonen escreveu: Hi again. On Wed, 2010-08-11 at 14:34 +0300, Matti J. Aaltonen wrote: Hello. On Wed, 2010-08-11 at 12:56 +0200, ext Hans Verkuil wrote: Hi. I cloned your tree

Re: A problem with http://git.linuxtv.org/media_tree.git

2010-08-12 Thread Matti J. Aaltonen
On Thu, 2010-08-12 at 12:29 +0200, ext Hans Verkuil wrote: On Wed, 2010-08-11 at 15:16 +0200, ext Mauro Carvalho Chehab wrote: Em 11-08-2010 08:44, Matti J. Aaltonen escreveu: Hi again. On Wed, 2010-08-11 at 14:34 +0300, Matti J. Aaltonen wrote: Hello. On Wed, 2010-08-11

Re: [PATCH v7 4/5] V4L2: WL1273 FM Radio: Controls for the FM radio.

2010-08-12 Thread Matti J. Aaltonen
Hello Alexey On Wed, 2010-08-11 at 10:06 +0200, ext Alexey Klimov wrote: + + radio = kzalloc(sizeof(*radio), GFP_KERNEL); + if (!radio) + return -ENOMEM; + + radio-write_buf = kmalloc(256, GFP_KERNEL); + if (!radio-write_buf) +

Re: [PATCH v7 4/5] V4L2: WL1273 FM Radio: Controls for the FM radio.

2010-08-12 Thread Matti J. Aaltonen
Hello. On Thu, 2010-08-12 at 14:10 +0200, ext pramodh ag wrote: Matti, +/** + * wl1273_fm_set_tx_power() -Set the transmission power value. + * @core:A pointer to the device struct. + * @power:The new power value. + */ +static int

A problem with http://git.linuxtv.org/media_tree.git

2010-08-11 Thread Matti J. Aaltonen
Hi. I cloned your tree at http://linuxtv.org/git/media_tree.git and checked out the origin/staging/v2.6.37 branch and the Documentation/video4linux/v4l2-controls.txt just isn't there. I asked one of my colleagues to do the same and the result was also the same. The latest commit in this

Re: [PATCH v7 4/5] V4L2: WL1273 FM Radio: Controls for the FM radio.

2010-08-11 Thread Matti J. Aaltonen
Hello Alexey On Wed, 2010-08-11 at 10:06 +0200, ext Alexey Klimov wrote: + + radio = kzalloc(sizeof(*radio), GFP_KERNEL); + if (!radio) + return -ENOMEM; + + radio-write_buf = kmalloc(256, GFP_KERNEL); + if (!radio-write_buf) +

Re: A problem with http://git.linuxtv.org/media_tree.git

2010-08-11 Thread Matti J. Aaltonen
Hello. On Wed, 2010-08-11 at 12:56 +0200, ext Hans Verkuil wrote: Hi. I cloned your tree at http://linuxtv.org/git/media_tree.git and checked out the origin/staging/v2.6.37 branch and the Documentation/video4linux/v4l2-controls.txt just isn't there. I asked one of my

Re: A problem with http://git.linuxtv.org/media_tree.git

2010-08-11 Thread Matti J. Aaltonen
Hi again. On Wed, 2010-08-11 at 14:34 +0300, Matti J. Aaltonen wrote: Hello. On Wed, 2010-08-11 at 12:56 +0200, ext Hans Verkuil wrote: Hi. I cloned your tree at http://linuxtv.org/git/media_tree.git and checked out the origin/staging/v2.6.37 branch

Re: [PATCH v7 1/5] V4L2: Add seek spacing and FM RX class.

2010-08-10 Thread Matti J. Aaltonen
On Mon, 2010-08-09 at 18:38 +0200, ext Hans Verkuil wrote: On Monday 02 August 2010 16:06:39 Matti J. Aaltonen wrote: Add spacing field to v4l2_hw_freq_seek and also add FM RX class to control classes. This will no longer apply now that the control framework has been merged. I strongly

Re: [PATCH v7 1/5] V4L2: Add seek spacing and FM RX class.

2010-08-10 Thread Matti J. Aaltonen
On Tue, 2010-08-10 at 10:04 +0200, ext Hans Verkuil wrote: On Mon, 2010-08-09 at 18:38 +0200, ext Hans Verkuil wrote: On Monday 02 August 2010 16:06:39 Matti J. Aaltonen wrote: Add spacing field to v4l2_hw_freq_seek and also add FM RX class to control classes. This will no longer

Re: [PATCH v7 1/5] V4L2: Add seek spacing and FM RX class.

2010-08-10 Thread Matti J. Aaltonen
On Tue, 2010-08-10 at 10:04 +0200, ext Hans Verkuil wrote: On Mon, 2010-08-09 at 18:38 +0200, ext Hans Verkuil wrote: On Monday 02 August 2010 16:06:39 Matti J. Aaltonen wrote: Add spacing field to v4l2_hw_freq_seek and also add FM RX class to control classes. This will no longer

Re: [PATCH v7 1/5] V4L2: Add seek spacing and FM RX class.

2010-08-10 Thread Matti J. Aaltonen
On Tue, 2010-08-10 at 14:14 +0200, ext Mauro Carvalho Chehab wrote: Em 10-08-2010 09:03, Matti J. Aaltonen escreveu: On Tue, 2010-08-10 at 10:04 +0200, ext Hans Verkuil wrote: On Mon, 2010-08-09 at 18:38 +0200, ext Hans Verkuil wrote: On Monday 02 August 2010 16:06:39 Matti J. Aaltonen

Re: [PATCH v7 0/5] TI WL1273 FM Radio driver.

2010-08-09 Thread Matti J. Aaltonen
Hello. It starts to look like the ALSA codec could be accepted on the ALSA list pretty soon. So I'd be very interested to hear from you if the rest of the driver still needs fixes... By the way, now the newest wl1273 firmware supports a special form of hardware seek, they call it the 'bulk

[PATCH v7 5/5] Documentation: v4l: Add hw_seek spacing and FM_RX class

2010-08-02 Thread Matti J. Aaltonen
Add a couple of words about the spacing field in ithe HW seek struct and about the new FM RX control class. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- Documentation/DocBook/v4l/controls.xml | 71 .../DocBook/v4l/vidioc-s-hw-freq-seek.xml

[PATCH v7 0/5] TI WL1273 FM Radio driver.

2010-08-02 Thread Matti J. Aaltonen
can be used (67.5 Hz or 67.5 kHz, depending on the CAP_LOW capability). Not sure which is best, though. I think using Hz is the most straightforward policy here so I chose that. Cheers, Matti Matti J. Aaltonen (5): V4L2: Add seek spacing and FM RX class. MFD: WL1273 FM Radio: MFD driver

  1   2   >