Re: [PATCH v2] [RFC v2] v4l2: add support for colorspace conversion for video capture

2018-12-07 Thread Mauro Carvalho Chehab
Em Thu, 6 Sep 2018 11:02:28 +0200 Hans Verkuil escreveu: > Hi Philipp, > > It is much appreciated that this old RFC of mine is picked up again. > I always wanted to get this in, but I never had a driver where it would > make sense to do so. What's the status of this? Hans, As this is an old

Re: [RFC PATCH] media/Kconfig: always enable MEDIA_CONTROLLER and VIDEO_V4L2_SUBDEV_API

2018-12-07 Thread Mauro Carvalho Chehab
Em Fri, 7 Dec 2018 11:53:17 -0200 Mauro Carvalho Chehab escreveu: > Em Fri, 7 Dec 2018 14:27:48 +0100 > Hans Verkuil escreveu: > > > On 12/07/2018 01:42 PM, Mauro Carvalho Chehab wrote: > > > Em Fri, 7 Dec 2018 12:47:24 +0100 > > > Hans Verkuil escreveu: >

Re: [RFC PATCH] media/Kconfig: always enable MEDIA_CONTROLLER and VIDEO_V4L2_SUBDEV_API

2018-12-07 Thread Mauro Carvalho Chehab
Em Fri, 7 Dec 2018 14:27:48 +0100 Hans Verkuil escreveu: > On 12/07/2018 01:42 PM, Mauro Carvalho Chehab wrote: > > Em Fri, 7 Dec 2018 12:47:24 +0100 > > Hans Verkuil escreveu: > > > >> On 12/07/2018 12:26 PM, Mauro Carvalho Chehab wrote: > >>> Em

Re: [PATCH v2] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Mauro Carvalho Chehab
Em Fri, 07 Dec 2018 14:21:44 +0100 Paul Kocialkowski escreveu: > Hi, > > On Fri, 2018-12-07 at 08:03 -0500, Mauro Carvalho Chehab wrote: > > A common mistake is to assume that initializing a var with: > > struct foo f = { 0 }; > > > > Would initializ

[PATCH 1/2] media: pxa_camera: don't deferenciate a NULL pointer

2018-12-07 Thread Mauro Carvalho Chehab
ned-off-by: Mauro Carvalho Chehab --- drivers/media/platform/pxa_camera.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/pxa_camera.c b/drivers/media/platform/pxa_camera.c index 5f930560eb30..f91f8fd424c4 100644 --- a/drivers/media/platform/pxa_camera.c +++ b/driv

[PATCH 2/2] media: drxk_hard: check if parameter is not NULL

2018-12-07 Thread Mauro Carvalho Chehab
, but it doesn't hurt to add a check, in order to shut up smatch. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drxk_hard.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb-frontends/drxk_hard.c b/drivers/media/dvb-frontends

[PATCH v2] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Mauro Carvalho Chehab
\s*\}"|wc -l 1951 The standard-C compliant pattern has about 2500 entries: $ git grep -E "=\s*\{\s*NULL\s*\}"|wc -l 137 $ git grep -E "=\s*\{\s*0\s*\}"|wc -l 2323 Meaning that developers have split options on that. So, let's opt t

Re: [PATCH] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Mauro Carvalho Chehab
Em Fri, 7 Dec 2018 12:27:09 + Ian Arkver escreveu: > On 07/12/2018 11:37, Hans Verkuil wrote: > > On 12/07/2018 12:31 PM, Mauro Carvalho Chehab wrote: > >> Em Fri, 7 Dec 2018 12:14:50 +0100 > >> Hans Verkuil escreveu: > >> > >>> On

Re: [RFC PATCH] media/Kconfig: always enable MEDIA_CONTROLLER and VIDEO_V4L2_SUBDEV_API

2018-12-07 Thread Mauro Carvalho Chehab
Em Fri, 7 Dec 2018 12:47:24 +0100 Hans Verkuil escreveu: > On 12/07/2018 12:26 PM, Mauro Carvalho Chehab wrote: > > Em Fri, 7 Dec 2018 10:09:04 +0100 > > Hans Verkuil escreveu: > > > >> This patch selects MEDIA_CONTROLLER for all camera, analog TV and >

[PATCH] media: imx214: don't de-reference a NULL pointer

2018-12-07 Thread Mauro Carvalho Chehab
internally with the pointer set, and via subdev API (with should also set it). Also, the entire logic there depends on having format != NULL, so just remove the bogus broken support for a null format. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/imx214.c | 10 -- 1 file changed, 4

Re: [PATCH] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Mauro Carvalho Chehab
Em Fri, 7 Dec 2018 12:14:50 +0100 Hans Verkuil escreveu: > On 12/07/2018 11:56 AM, Mauro Carvalho Chehab wrote: > > A common mistake is to assume that initializing a var with: > > struct foo f = { 0 }; > > > > Would initialize a zeroed struct. Actually, what thi

Re: [RFC PATCH] media/Kconfig: always enable MEDIA_CONTROLLER and VIDEO_V4L2_SUBDEV_API

2018-12-07 Thread Mauro Carvalho Chehab
Em Fri, 7 Dec 2018 10:09:04 +0100 Hans Verkuil escreveu: > This patch selects MEDIA_CONTROLLER for all camera, analog TV and > digital TV drivers and selects VIDEO_V4L2_SUBDEV_API automatically. > > This will allow us to simplify drivers that currently have to add > #ifdef

[PATCH] media: cetrus: return an error if alloc fails

2018-12-07 Thread Mauro Carvalho Chehab
ned-off-by: Mauro Carvalho Chehab --- drivers/staging/media/sunxi/cedrus/cedrus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c index 44c45c687503..24b89cd2b692 100644 --- a/driv

[PATCH] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Mauro Carvalho Chehab
$ git grep -E "=\s*\{\s*0\s*\}"|wc -l 2323 So, let's initialize those structs with: = { NULL } Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/sunxi/cedrus/cedrus.c | 2 +- drivers/staging/media/sunxi/cedrus/cedrus_dec.c | 2 +- 2 files changed, 2 i

Re: [PATCH] Revert 95f408bb Ryzen DMA related RiSC engine stall fixes

2018-12-06 Thread Mauro Carvalho Chehab
Em Thu, 6 Dec 2018 17:07:52 -0200 Mauro Carvalho Chehab escreveu: > Em Thu, 6 Dec 2018 13:36:24 -0500 > Alex Deucher escreveu: > > > On Thu, Dec 6, 2018 at 1:05 PM Mauro Carvalho Chehab > > wrote: > > > > > > Em Thu, 06 Dec 2018 18:1

Re: [PATCH] Revert 95f408bb Ryzen DMA related RiSC engine stall fixes

2018-12-06 Thread Mauro Carvalho Chehab
Em Thu, 6 Dec 2018 13:36:24 -0500 Alex Deucher escreveu: > On Thu, Dec 6, 2018 at 1:05 PM Mauro Carvalho Chehab > wrote: > > > > Em Thu, 06 Dec 2018 18:18:23 +0100 > > Markus Dobel escreveu: > > > > > Hi everyone, > > > > > >

Re: [PATCH] Revert 95f408bb Ryzen DMA related RiSC engine stall fixes

2018-12-06 Thread Mauro Carvalho Chehab
Em Thu, 06 Dec 2018 18:18:23 +0100 Markus Dobel escreveu: > Hi everyone, > > I will try if the hack mentioned fixes the issue for me on the weekend (but I > assume, as if effectively removes the function). It should, but it keeps a few changes. Just want to be sure that what would be left

[PATCH v2] media: rockchip vpu: remove some unused vars

2018-12-05 Thread Mauro Carvalho Chehab
; ^~~ Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c | 5 - drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_jpeg_enc.c | 5 - drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c | 6

[PATCH] media: rockchip vpu: remove some unused vars

2018-12-05 Thread Mauro Carvalho Chehab
; ^~~ Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c b/drivers/staging/media/rockchip

Re: [GIT PULL FOR v4.21] Rockchip VPU JPEG encoder driver

2018-12-05 Thread Mauro Carvalho Chehab
Em Wed, 05 Dec 2018 17:02:46 -0300 Ezequiel Garcia escreveu: > On Wed, 2018-12-05 at 16:37 -0200, Mauro Carvalho Chehab wrote: > > Em Wed, 5 Dec 2018 16:34:04 -0200 > > Mauro Carvalho Chehab escreveu: > > > > > Em Wed, 5 Dec 2018 17:29:38 +010

Re: [PATCH] media: rockchip/vpu: fix a few alignments

2018-12-05 Thread Mauro Carvalho Chehab
Em Wed, 5 Dec 2018 19:48:25 +0100 Hans Verkuil escreveu: > On 12/05/2018 07:43 PM, Mauro Carvalho Chehab wrote: > > As reported by checkpatch.pl, some function calls have a wrong > > alignment. > > > > Signed-off-by: Mauro Carvalho Chehab > > --- > &

Re: [PATCH 2/3] media: stkwebcam: Bugfix for not correctly initialized camera

2018-12-05 Thread Mauro Carvalho Chehab
Em Wed, 5 Dec 2018 16:56:39 -0200 Mauro Carvalho Chehab escreveu: > Em Fri, 30 Nov 2018 15:58:07 +0100 > Andreas Pape escreveu: > > > Hi Kieran, > > > > thanks for the review. > > > > On Mon, 26 Nov 2018 12:48:08 + > > Kieran Bingham w

Re: [PATCH 2/3] media: stkwebcam: Bugfix for not correctly initialized camera

2018-12-05 Thread Mauro Carvalho Chehab
Em Fri, 30 Nov 2018 15:58:07 +0100 Andreas Pape escreveu: > Hi Kieran, > > thanks for the review. > > On Mon, 26 Nov 2018 12:48:08 + > Kieran Bingham wrote: > > > This one worries me a little... (but hopefully not too much) > > > > As mentioned, I don't have any experience concerning

[PATCH] media: rockchip/vpu: fix a few alignments

2018-12-05 Thread Mauro Carvalho Chehab
As reported by checkpatch.pl, some function calls have a wrong alignment. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c | 4 ++-- drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_jpeg_enc.c | 4 ++-- 2 files changed, 4 insertions(+), 4

Re: [GIT PULL FOR v4.21] Rockchip VPU JPEG encoder driver

2018-12-05 Thread Mauro Carvalho Chehab
Em Wed, 5 Dec 2018 16:34:04 -0200 Mauro Carvalho Chehab escreveu: > Em Wed, 5 Dec 2018 17:29:38 +0100 > Hans Verkuil escreveu: > > > Note regarding the first 'Revert' patch: that is this patch: > > > > https://patchwork.linuxtv.org/patch/52869/ > > >

Re: [GIT PULL FOR v4.21] Rockchip VPU JPEG encoder driver

2018-12-05 Thread Mauro Carvalho Chehab
Em Wed, 5 Dec 2018 17:29:38 +0100 Hans Verkuil escreveu: > Note regarding the first 'Revert' patch: that is this patch: > > https://patchwork.linuxtv.org/patch/52869/ > > It is currently pending for 4.20 as a fix, but since it is not merged upstream > yet, our master branch still has those old

Re: [PATCH v2 1/1] media: Add a Kconfig option for the Request API

2018-12-05 Thread Mauro Carvalho Chehab
Em Wed, 5 Dec 2018 19:23:54 +0200 Sakari Ailus escreveu: > The Request API is now merged to the kernel but the confidence on the > stability of that API is not great, especially regarding the interaction > with V4L2. > > Add a Kconfig option for the API, with a scary-looking warning. > > The

Re: [PATCH] Revert 95f408bb Ryzen DMA related RiSC engine stall fixes

2018-12-05 Thread Mauro Carvalho Chehab
Em Sun, 21 Oct 2018 15:45:39 +0200 Markus Dobel escreveu: > The original commit (the one reverted in this patch) introduced a > regression, > making a previously flawless adapter unresponsive after running a few > hours > to days. Since I never experienced the problems that the original commit

[PATCH] media: ddbridge: remove another duplicate of io.h and sort includes

2018-12-05 Thread Mauro Carvalho Chehab
it. Fixes: 12645e0655e4 ("media: ddbridge: remove some duplicated include file") Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/ddbridge/ddbridge.h | 52 +-- 1 file changed, 25 insertions(+), 27 deletions(-) diff --git a/drivers/media/pci/ddbridge/ddb

Re: [PATCH v3 0/9] TVP5150 fixes and new features

2018-12-05 Thread Mauro Carvalho Chehab
Hi Marco, Em Fri, 9 Nov 2018 14:46:24 +0100 Marco Felsch escreveu: > Hi Mauro, > > I don't want to spam you. Can you give me some feedback? I know the > merge window is a busy time, so maybe you have some time now. Sorry for taking so long on looking into it... has been really busy those days

Re: [PATCH 1/4] libdvbv5: do not adjust DVB time daylight saving

2018-12-05 Thread Mauro Carvalho Chehab
Em Sat, 7 Jul 2018 13:20:54 +0200 André Roth escreveu: > This makes dvb_time available outside of EIT parsing, and > struct tm to reflect the actual values received from DVB. > > Signed-off-by: André Roth > --- > lib/include/libdvbv5/descriptors.h | 11 +++ >

Re: [PATCH v2 1/1] media: Use common test pattern menu entries

2018-12-04 Thread Mauro Carvalho Chehab
Em Tue, 4 Dec 2018 15:40:42 +0200 Sakari Ailus escreveu: > While the test pattern menu itself is not standardised, many devices > support the same test patterns. Aligning the menu entries helps the user > space to use the interface, and adding macros for the menu entry strings > helps to keep

Re: [PATCH 1/1] v4l uapi: Make "Vertical Colour Bars" menu item a little more generic

2018-12-04 Thread Mauro Carvalho Chehab
Em Tue, 4 Dec 2018 12:32:32 -0200 Mauro Carvalho Chehab escreveu: > Em Tue, 4 Dec 2018 15:45:06 +0200 > Sakari Ailus escreveu: > > > The test pattern could contain a different number of colour bars than > > eight, make the entry more useful by removing "Eight "

Re: [PATCH 1/1] v4l uapi: Make "Vertical Colour Bars" menu item a little more generic

2018-12-04 Thread Mauro Carvalho Chehab
Em Tue, 4 Dec 2018 15:45:06 +0200 Sakari Ailus escreveu: > The test pattern could contain a different number of colour bars than > eight, make the entry more useful by removing "Eight " from the name. > > Signed-off-by: Sakari Ailus > --- > include/uapi/linux/v4l2-controls.h | 2 +- > 1 file

Re: [GIT PULL FOR v4.21] dvb fixes

2018-12-03 Thread Mauro Carvalho Chehab
Em Wed, 28 Nov 2018 19:40:30 + Sean Young escreveu: > Hi Mauro, > > So I've gone through the outstanding DVB patches and picked up the easier > ones to deal with first. Please scrutinise. Thanks! Just one note. See below. > > Thanks, > > Sean > > The following changes since commit

[PATCH] dvb-sat: rename Astra 1E to Astra 19.2 E and move it to beginning

2018-11-27 Thread Mauro Carvalho Chehab
osition. Signed-off-by: Mauro Carvalho Chehab --- lib/libdvbv5/dvb-sat.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/lib/libdvbv5/dvb-sat.c b/lib/libdvbv5/dvb-sat.c index 8c04f66f973b..18e2359c053b 100644 --- a/lib/libdvbv5/dvb-sat.c ++

[PATCH 6/6] media: pixfmt-meta-d4xx.rst: Add a license to it

2018-11-23 Thread Mauro Carvalho Chehab
Carvalho Chehab --- Documentation/media/uapi/v4l/pixfmt-meta-d4xx.rst | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Documentation/media/uapi/v4l/pixfmt-meta-d4xx.rst b/Documentation/media/uapi/v4l/pixfmt-meta-d4xx.rst index 63bf1a2c9116..862e1f327150 100644

[PATCH 4/6] media: svg files: dual-licence some files with GPL and GFDL

2018-11-23 Thread Mauro Carvalho Chehab
Along the time, several image files got replaced by me by new ones with similar contents. As those were not simple conversions, dual-license them. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/dvb/dvbstb.svg | 33 ++- Documentation/media/uapi/v4l

[PATCH 1/6] Documentation/media: uapi: Explicitly say there are no Invariant Sections

2018-11-23 Thread Mauro Carvalho Chehab
, but it also doesn't say there are none (as is recommended by the license text). Make it explicit that there are none. References: https://bugs.debian.org/698668 Signed-off-by: Ben Hutchings Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Gerd Hoffmann Signed-off-by: Hans Verkuil Signed-off

[PATCH 0/6] Add license tags/texts to all media documentation files

2018-11-23 Thread Mauro Carvalho Chehab
w uAPI documents should be dual-licensed GPL/GFDL. All other documents should be at least GPL. Ben Hutchings (1): Documentation/media: uapi: Explicitly say there are no Invariant Sections Mauro Carvalho Chehab (5): media: remove text encoding from rst files media: add SPDX header to medi

[PATCH] media: dvb-pll: don't re-validate tuner frequencies

2018-11-23 Thread Mauro Carvalho Chehab
The dvb_frontend core already checks for the frequencies. No need for any additional check inside the driver. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/dvb-pll.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/dvb-frontends/dvb-pll.c b/drivers

[PATCH] media: vb2: be sure to free on errors

2018-11-23 Thread Mauro Carvalho Chehab
113 line 2118 line 2156 line 2159 There is one error condition that doesn't unlock a mutex. Fixes: cd26d1c4d1bc ("media: vb2: vb2_mmap: move lock up") Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/videobuf2/videobuf2-core.c | 3 ++- 1 fi

[PATCH] media: seco-cec: declare ops as static const

2018-11-23 Thread Mauro Carvalho Chehab
As warned by smatch: drivers/media/platform/seco-cec/seco-cec.c:338:21: warning: symbol 'secocec_cec_adap_ops' was not declared. Should it be static? This struct should be static. Also, it is const, so declare it as such. Signed-off-by: Mauro Carvalho Chehab --- drivers/media

[PATCH 1/2] media: sum6i-csi: Fix a few coding style issues

2018-11-23 Thread Mauro Carvalho Chehab
Make checkpatch.pl happier by running it on strict mode and using the --fix-inline to solve some issues. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 9 - drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h | 2 +- drivers/media

[PATCH 2/2] media: sun6i-csi: manually fix other coding style issues

2018-11-23 Thread Mauro Carvalho Chehab
There are a few other coding style issues reported by checkpatch while in --strict mode. Fix the ones that make sense. Signed-off-by: Mauro Carvalho Chehab --- .../platform/sunxi/sun6i-csi/sun6i_csi.c | 9 +++ .../platform/sunxi/sun6i-csi/sun6i_csi_reg.h | 24

Re: [GIT PULL FOR v4.18] v2: Various fixes/improvements

2018-11-22 Thread Mauro Carvalho Chehab
Hi Hans, Em Thu, 22 Nov 2018 23:26:07 +0100 Hans Verkuil escreveu: > On 11/22/2018 09:52 PM, Mauro Carvalho Chehab wrote: > > Em Tue, 8 May 2018 12:48:45 +0200 > > Hans Verkuil escreveu: > > > >> Fixes/improvements all over the place. > >> > >

Re: [GIT PULL FOR v4.18] v2: Various fixes/improvements

2018-11-22 Thread Mauro Carvalho Chehab
Em Tue, 8 May 2018 12:48:45 +0200 Hans Verkuil escreveu: > Fixes/improvements all over the place. > > Changes since v1: > > Replaced "media: media-device: fix ioctl function types" with the v2 version > of that patch. My fault, I missed Sakari's request for a change of v1. You should

Re: [GIT PULL FOR v4.21] Various fixes

2018-11-22 Thread Mauro Carvalho Chehab
Hi Hans, Em Wed, 7 Nov 2018 11:31:14 +0100 Hans Verkuil escreveu: > Just one note: the "cec: keep track of outstanding transmits" is CC-ed to > stable > for v4.18 and up, but I prefer to wait until v4.21 before merging it to give > it > more test time. It is not something that happens in

Re: [PATCH v2 for v4.4 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-20 Thread Mauro Carvalho Chehab
Em Tue, 20 Nov 2018 12:49:46 +0200 Sakari Ailus escreveu: > Hi Greg, > > On Mon, Nov 19, 2018 at 06:46:21PM +0100, Greg Kroah-Hartman wrote: > > On Mon, Nov 19, 2018 at 07:03:54PM +0200, Sakari Ailus wrote: > > > Hi Greg, > > > > > > On Mon, Nov 19, 2018 at 04:14:00PM +0100, Greg

[PATCH 1/3] media: dvb_frontend: don't print function names twice

2018-11-20 Thread Mauro Carvalho Chehab
The dvb_frontend dprintk() macro already prints __func__. So, we don't need to add it again at the printed message. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_frontend.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/dvb-core

[PATCH 2/3] media: dvb_frontend: add debug message for frequency intervals

2018-11-20 Thread Mauro Carvalho Chehab
As we did an internal change inside the subsystem to always represent min/max frequencies in Hz, add a debug message, as this would help to discover bugs on drivers, if any. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_frontend.c | 3 +++ 1 file changed, 3 insertions

[PATCH 3/3] media: dvb-pll: fix tuner frequency ranges

2018-11-20 Thread Mauro Carvalho Chehab
, the delivery system may be wrong. Fix it by ensuring that all frequencies are in Hz at the per-tuner max/min values. While here, add a debug message, as this would help to debug any issues there. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/dvb-pll.c | 103

raw notes from the Media summit

2018-11-08 Thread Mauro Carvalho Chehab
In order to help writing a media summit report, I'm sending the raw notes that were at Etherpad after the end of the meeting. Thanks, Mauro Media summit 25-10-2018 Edinburgh https://www.spinics.net/lists/linux-media/msg141095.html Attendees Brad Love Ezequiel Garcia Gustavo

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Mauro Carvalho Chehab
Em Wed, 07 Nov 2018 21:35:32 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > On Wednesday, 7 November 2018 21:10:35 EET Mauro Carvalho Chehab wrote: > > Em Wed, 07 Nov 2018 12:06:55 +0200 Laurent Pinchart escreveu: > > > On Wednesday, 7 November 2018 10:05:1

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Mauro Carvalho Chehab
Em Wed, 07 Nov 2018 12:06:55 +0200 Laurent Pinchart escreveu: > Hi Hans, > > On Wednesday, 7 November 2018 10:05:12 EET Hans Verkuil wrote: > > On 11/06/2018 08:58 PM, Laurent Pinchart wrote: > > > On Tuesday, 6 November 2018 15:56:34 EET Hans Verkuil wrote: > > >> On 11/06/18 14:12,

[PATCH] cedrus: check if kzalloc() fails

2018-11-06 Thread Mauro Carvalho Chehab
ays succeed. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/sunxi/cedrus/cedrus.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c index dd121f66fa2d..6a73a7841303 100644 --- a/driv

[PATCH] media: dm365_ipipeif: better annotate a fall though

2018-11-06 Thread Mauro Carvalho Chehab
) { ^~ drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:314:2: note: here case IPIPEIF_SDRAM_YUV: ^~~~ By annotating a fall though case at the right place. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/davinci_vpfe/dm365_ipipeif.c | 1 + 1 file

[PATCH] davinci_vpfe: add a missing break

2018-11-06 Thread Mauro Carvalho Chehab
/davinci_vpfe/dm365_ipipeif.c:314:2: note: here case IPIPEIF_SDRAM_YUV: ^~~~ There is a missing break for the raw format. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/davinci_vpfe/dm365_ipipeif.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/davinci_vpfe

Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-02 Thread Mauro Carvalho Chehab
Em Mon, 29 Oct 2018 15:22:57 -0700 Yong Zhi escreveu: > These meta formats are used on Intel IPU3 ImgU video queues > to carry 3A statistics and ISP pipeline parameters. Just minor things. See below. > > V4L2_META_FMT_IPU3_3A > V4L2_META_FMT_IPU3_PARAMS > > Signed-off-by: Yong Zhi >

Re: [PATCH v7 01/16] v4l: Add Intel IPU3 meta buffer formats

2018-11-02 Thread Mauro Carvalho Chehab
Em Fri, 2 Nov 2018 09:59:31 -0300 Mauro Carvalho Chehab escreveu: > Hi Zhi-san, > > Em Mon, 29 Oct 2018 15:22:55 -0700 > Yong Zhi escreveu: > > > Add IPU3-specific meta formats for parameter > > processing and 3A, DVS statistics: > >

Re: [PATCH v7 01/16] v4l: Add Intel IPU3 meta buffer formats

2018-11-02 Thread Mauro Carvalho Chehab
Hi Zhi-san, Em Mon, 29 Oct 2018 15:22:55 -0700 Yong Zhi escreveu: > Add IPU3-specific meta formats for parameter > processing and 3A, DVS statistics: > > V4L2_META_FMT_IPU3_PARAMS > V4L2_META_FMT_IPU3_STAT_3A > > Signed-off-by: Yong Zhi > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 2

[PATCH] v4l2-controls: add a missing include

2018-11-02 Thread Mauro Carvalho Chehab
data") Reported-by: Linus Torvalds Reported-by: Stephen Rothwell Signed-off-by: Mauro Carvalho Chehab --- include/uapi/linux/v4l2-controls.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h index 51b095898f4b.

Re: [PATCH 4/4] SoC camera: Tidy the header

2018-10-31 Thread Mauro Carvalho Chehab
Em Wed, 31 Oct 2018 11:00:22 +0100 Hans Verkuil escreveu: > On 10/31/2018 10:40 AM, Mauro Carvalho Chehab wrote: > > Em Wed, 31 Oct 2018 11:29:45 +0200 > > Sakari Ailus escreveu: > > > >> Hi Mauro, > >> > >> On Tue, Oct 30, 2018 at 09:06:18A

Re: [PATCH 3/4] SoC camera: Remove the framework and the drivers

2018-10-31 Thread Mauro Carvalho Chehab
Em Wed, 31 Oct 2018 11:32:02 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Tue, Oct 30, 2018 at 05:35:23PM -0300, Mauro Carvalho Chehab wrote: > > Em Tue, 30 Oct 2018 21:28:57 +0100 > > jacopo mondi escreveu: > > > > > Hi Mauro, > > > > >

Re: [PATCH 4/4] SoC camera: Tidy the header

2018-10-31 Thread Mauro Carvalho Chehab
Em Wed, 31 Oct 2018 11:29:45 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Tue, Oct 30, 2018 at 09:06:18AM -0300, Mauro Carvalho Chehab wrote: > > Em Tue, 30 Oct 2018 01:00:29 +0200 > > Sakari Ailus escreveu: > > > > > Clean up the SoC camera framewor

Re: [PATCH 3/4] SoC camera: Remove the framework and the drivers

2018-10-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Oct 2018 21:28:57 +0100 jacopo mondi escreveu: > Hi Mauro, > > On Tue, Oct 30, 2018 at 09:14:09AM -0300, Mauro Carvalho Chehab wrote: > > Em Tue, 30 Oct 2018 01:21:34 +0200 > > Sakari Ailus escreveu: > > > > > The SoC camera frame

Re: [PATCH 4/4] SoC camera: Tidy the header

2018-10-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Oct 2018 01:00:29 +0200 Sakari Ailus escreveu: > Clean up the SoC camera framework header. It only exists now to keep board > code compiling. The header can be removed once the board code dependencies > to it has been removed. > > Signed-off-by: Sakari Ailus > --- >

Re: [PATCH 3/4] SoC camera: Remove the framework and the drivers

2018-10-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Oct 2018 01:21:34 +0200 Sakari Ailus escreveu: > The SoC camera framework has been obsolete for some time and it is no > longer functional. A few drivers have been converted to the V4L2 > sub-device API but for the rest the conversion has not taken place yet. > > In order to keep the

Re: Adding to input-event-codes.h - feedback welcome

2018-10-30 Thread Mauro Carvalho Chehab
Em Tue, 23 Oct 2018 06:55:13 -0700 VDR User escreveu: > Hi, > > I've noticed a lot of common & useful remote control buttons are > missing. I'd like to suggest or submit patches to add some of them > since Linux is so wildly used for media playback (via remote > controls). I've spoken to Sean

Re: [PATCH] dvb: Allow MAC addresses to be mapped to stable device names with udev

2018-10-30 Thread Mauro Carvalho Chehab
Em Mon, 24 Sep 2018 11:10:31 +0100 David Howells escreveu: > Some devices, such as the DVBSky S952 and T982 cards, are dual port cards > that provide two cx23885 devices on the same PCI device, which means the > attributes available for writing udev rules are exactly the same, apart > from the

Re: [PATCH 3/4] SoC camera: Remove the framework and the drivers

2018-10-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Oct 2018 09:06:08 -0300 Mauro Carvalho Chehab escreveu: > Em Tue, 30 Oct 2018 06:43:41 -0300 > Mauro Carvalho Chehab escreveu: Please ignore this e-mail. I'm experiencing some e-mail troubles today. Will resend it properly. Regards, Mauro

Re: [PATCH 3/4] SoC camera: Remove the framework and the drivers

2018-10-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Oct 2018 06:43:41 -0300 Mauro Carvalho Chehab escreveu: > Em Tue, 30 Oct 2018 01:21:34 +0200 > Sakari Ailus escreveu: > > > The SoC camera framework has been obsolete for some time and it is no > > longer functional. A few drivers have been converted to the V4

Re: [PATCH 4/4] SoC camera: Tidy the header

2018-10-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Oct 2018 01:00:29 +0200 Sakari Ailus escreveu: > Clean up the SoC camera framework header. It only exists now to keep board > code compiling. The header can be removed once the board code dependencies > to it has been removed. > > Signed-off-by: Sakari Ailus > --- >

Re: [PATCH 3/4] SoC camera: Remove the framework and the drivers

2018-10-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Oct 2018 01:21:34 +0200 Sakari Ailus escreveu: > The SoC camera framework has been obsolete for some time and it is no > longer functional. A few drivers have been converted to the V4L2 > sub-device API but for the rest the conversion has not taken place yet. > > In order to keep the

Re: Kaffeine: cool pull request in GitHub

2018-10-28 Thread Mauro Carvalho Chehab
Hi Antoni, Em Sun, 28 Oct 2018 01:02:39 +0200 Antoni Bella Pérez escreveu: > Hi > > I found three pull request in GitHub and this code has not been included in > the master branch. > > > > * Fix audio CD playing >

Re: [RFC] Informal meeting during ELCE to discuss userspace support for stateless codecs

2018-10-23 Thread Mauro Carvalho Chehab
Em Mon, 22 Oct 2018 22:21:04 +0100 Hans Verkuil escreveu: > On 10/22/2018 10:17 PM, Hans Verkuil wrote: > > A quick update: > > > > As said in my previous email: we'll meet at 11 am at the registration desk. > > From there we go to the Platform 5 Cafe. If that's too crowded/noisy, then > >

Re: [PATCH] media: rename soc_camera I2C drivers

2018-10-19 Thread Mauro Carvalho Chehab
Em Fri, 19 Oct 2018 13:45:32 +0200 Hans Verkuil escreveu: > On 10/19/18 13:43, Mauro Carvalho Chehab wrote: > > Those drivers are part of the legacy SoC camera framework. > > They're being converted to not use it, but sometimes we're > > keeping both legacy any new drive

[PATCH] media: rename soc_camera I2C drivers

2018-10-19 Thread Mauro Carvalho Chehab
prepend the SoC legacy drivers with soc_. No functional changes. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/soc_camera/Makefile | 18 +- .../soc_camera/{mt9m001.c => soc_mt9m001.c}| 0 .../soc_camera/{mt9t112.c => soc_mt9t112.c}| 0 .../soc_

Re: [ANN] Agenda for the media summit on Thursday Oct 25th in Edinburgh

2018-10-15 Thread Mauro Carvalho Chehab
g all of them here, just those that I know are active > media developers: ... > Mauro Carvalho Chehab On a side note, please always use my @kernel.org e-mail, e. g: Mauro Carvalho Chehab (with is the canonical e-mail it is set at Kernel tree) or Mauro Carvalho Ch

Re: [RFC] Informal meeting during ELCE to discuss userspace support for stateless codecs

2018-10-09 Thread Mauro Carvalho Chehab
Em Mon, 8 Oct 2018 13:53:29 +0200 Hans Verkuil escreveu: > Hi all, > > I would like to meet up somewhere during the ELCE to discuss userspace support > for stateless (and perhaps stateful as well?) codecs. > > It is also planned as a topic during the summit, but I would prefer to prepare > for

Re: [GIT PULL for 4.20] Lens driver fixes, imx214 sensor driver

2018-10-08 Thread Mauro Carvalho Chehab
Em Sun, 7 Oct 2018 16:05:57 +0300 Sakari Ailus escreveu: > Hi Mauro, > > This last pull for 4.20 contains dw9714 and dw9807 lens driver probe error > handling fixes and the Sony imx214 sensor driver. In other words, patches > that have roughly nil changes of breaking something. > > Compile

Re: [PATCH] MAINTAINERS: Remove stale file entry for the Atmel ISI driver

2018-10-05 Thread Mauro Carvalho Chehab
Em Thu, 04 Oct 2018 23:06:02 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Thursday, 4 October 2018 21:45:05 EEST Mauro Carvalho Chehab wrote: > > Em Tue, 2 Oct 2018 08:35:47 +0200 Ludovic Desroches escreveu: > > > On Mon, Oct 01, 2018 at 01:51:01PM -0300, Mau

Re: [PATCH v6 0/6] Add Rockchip VPU JPEG encoder

2018-10-05 Thread Mauro Carvalho Chehab
Em Fri, 05 Oct 2018 12:37:43 -0300 Ezequiel Garcia escreveu: > On Fri, 2018-10-05 at 09:10 -0300, Mauro Carvalho Chehab wrote: > > Em Thu, 04 Oct 2018 20:39:31 -0300 > > Ezequiel Garcia escreveu: > > > > > On Mon, 2018-10-01 at 14:54 -0300, Ezequiel Garcia wrote

Re: [PATCH RESEND] Revert "media: dvbsky: use just one mutex for serializing device R/W ops"

2018-10-05 Thread Mauro Carvalho Chehab
Em Fri, 5 Oct 2018 16:34:28 +0200 Oliver Freyermuth escreveu: > Dear Mauro, > > thanks! Just to clarify, the issue I described in > https://bugzilla.kernel.org/show_bug.cgi?id=199323 > was on an Intel x86_64 system, with an onboard USB Controller handled by the > standard xhci driver, > so

[PATCH RESEND] Revert "media: dvbsky: use just one mutex for serializing device R/W ops"

2018-10-05 Thread Mauro Carvalho Chehab
it. This reverts commit 7d95fb746c4eece67308f1642a666ea1ebdbd2cc. Cc: sta...@vger.kernel.org # For Kernel 4.18 Signed-off-by: Mauro Carvalho Chehab --- Re-sending it with the right message ID drivers/media/usb/dvb-usb-v2/dvbsky.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions

[PATCH] Revert "media: dvbsky: use just one mutex for serializing device R/W ops"

2018-10-05 Thread Mauro Carvalho Chehab
it. This reverts commit 7d95fb746c4eece67308f1642a666ea1ebdbd2cc. Cc: sta...@vger.kernel.org # For Kernel 4.18 Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/dvb-usb-v2/dvbsky.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2

[PATCH] media: imx355: fix a few coding style issues

2018-10-05 Thread Mauro Carvalho Chehab
Function alignments are off by 1 space, as reported by checkpatch.pl --strict. Fix those. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/imx355.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/media/i2c/imx355.c b

[PATCH] media: imx319: fix a few coding style issues

2018-10-05 Thread Mauro Carvalho Chehab
Function alignments are off by 1 space, as reported by checkpatch.pl --strict. Fix those. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/imx319.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/media/i2c/imx319.c b

Re: [PATCH v7 4/6] media: Add JPEG_RAW format

2018-10-05 Thread Mauro Carvalho Chehab
Em Fri, 05 Oct 2018 08:53:14 -0300 Ezequiel Garcia escreveu: > On Fri, 2018-10-05 at 08:09 -0300, Mauro Carvalho Chehab wrote: > > Em Thu, 4 Oct 2018 21:12:24 -0300 > > Ezequiel Garcia escreveu: > > > > > From: Shunqian Zheng > > > > >

Re: [PATCH v6 0/6] Add Rockchip VPU JPEG encoder

2018-10-05 Thread Mauro Carvalho Chehab
Em Thu, 04 Oct 2018 20:39:31 -0300 Ezequiel Garcia escreveu: > On Mon, 2018-10-01 at 14:54 -0300, Ezequiel Garcia wrote: > > On Fri, 2018-09-28 at 14:33 +0200, Hans Verkuil wrote: > > > On 09/17/2018 07:30 PM, Ezequiel Garcia wrote: > > > > This series adds support for JPEG encoding via the

Re: [RFC] V4L2_PIX_FMT_MJPEG vs V4L2_PIX_FMT_JPEG

2018-10-05 Thread Mauro Carvalho Chehab
Em Mon, 1 Oct 2018 18:19:21 +0100 Dave Stevenson escreveu: > Hi All, > > On Mon, 1 Oct 2018 at 17:32, Ezequiel Garcia wrote: > > > > Hi Hans, > > > > Thanks for looking into. I remember MJPEG vs. JPEG being a source > > of confusion for me a few years ago, so clarification is greatly > >

Re: [RFC] V4L2_PIX_FMT_MJPEG vs V4L2_PIX_FMT_JPEG

2018-10-05 Thread Mauro Carvalho Chehab
Em Mon, 01 Oct 2018 08:42:56 -0400 Nicolas Dufresne escreveu: > Hello Hans, > > Le lundi 01 octobre 2018 à 10:43 +0200, Hans Verkuil a écrit : > > It turns out that we have both JPEG and Motion-JPEG pixel formats defined. > > > > Furthermore, some drivers support one, some the other and some

Re: [PATCH v7 4/6] media: Add JPEG_RAW format

2018-10-05 Thread Mauro Carvalho Chehab
Em Thu, 4 Oct 2018 21:12:24 -0300 Ezequiel Garcia escreveu: > From: Shunqian Zheng > > Add V4L2_PIX_FMT_JPEG_RAW format that does not contain > JPEG header in the output frame. > > Signed-off-by: Shunqian Zheng > Signed-off-by: Ezequiel Garcia > --- >

Re: [PATCH 2/3] media: v4l2-fwnode: cleanup functions that parse endpoints

2018-10-05 Thread Mauro Carvalho Chehab
Em Fri, 5 Oct 2018 13:08:25 +0300 Sakari Ailus escreveu: > > > This is still over 80 here. I think we could think of abbreviating what's > > > in the function name, not limiting to the endpoint. I think I'd prefer to > > > leave that for 4.21 as there's not much time anymore. > > > > Yes, I

Re: [PATCH 3/3] media: v4l2-fwnode: simplify v4l2_fwnode_reference_parse_int_props() call

2018-10-05 Thread Mauro Carvalho Chehab
Em Fri, 5 Oct 2018 13:06:04 +0300 Sakari Ailus escreveu: > > > > - unsigned int i; > > > > > > I'd like to keep this here. > > > > Why? IMHO, it makes harder to read (yet, if you insist, I'm ok with > > both ways). > > Generally loop, temporary, return etc. variables are nice

[PATCH v2 1/3] media: v4l2-core: cleanup coding style at V4L2 async/fwnode

2018-10-05 Thread Mauro Carvalho Chehab
/media/v4l2-core/v4l2-async.c drivers/media/v4l2-core/v4l2-fwnode.c and then manually adjusting the style where needed. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/v4l2-core/v4l2-async.c | 45 --- drivers/media/v4l2-core/v4l2-fwnode.c | 185 +++--- include

[PATCH v2 0/3] Coding style cleanups after the fwnode patchset

2018-10-05 Thread Mauro Carvalho Chehab
on some future change. - v2: - fixed a weird line break at patch 1/3; - kept the order of arguments inside a function at patch 3/3. Mauro Carvalho Chehab (3): media: v4l2-core: cleanup coding style at V4L2 async/fwnode media: v4l2-fwnode: cleanup functions that parse endpoints media

[PATCH v2 3/3] media: v4l2-fwnode: simplify v4l2_fwnode_reference_parse_int_props() call

2018-10-05 Thread Mauro Carvalho Chehab
some coding style issues. Acked-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab --- drivers/media/v4l2-core/v4l2-fwnode.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2

[PATCH v2 2/3] media: v4l2-fwnode: cleanup functions that parse endpoints

2018-10-05 Thread Mauro Carvalho Chehab
There is already a typedef for the parse endpoint function. However, instead of using it, it is redefined at the C file (and on one of the function headers). Replace them by the function typedef, in order to cleanup several related coding style warnings. Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH 1/3] media: v4l2-core: cleanup coding style at V4L2 async/fwnode

2018-10-05 Thread Mauro Carvalho Chehab
Em Fri, 5 Oct 2018 10:55:58 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Thu, Oct 04, 2018 at 06:13:46PM -0400, Mauro Carvalho Chehab wrote: > > There are several coding style issues at those definitions, > > and the previous patchset added even more. > > &

  1   2   3   4   5   6   7   8   9   10   >