Re: [PATCH] media: pvrusb2: Convert timers to use timer_setup()

2017-10-25 Thread Mike Isely
:22 PM, Kees Cook <keesc...@chromium.org> wrote: > > In preparation for unconditionally passing the struct timer_list pointer to > > all timer callbacks, switch to using the new timer_setup() and from_timer() > > to pass the timer pointer explicitly. > > > > Cc: Mike

Re: [PATCH] media: pvrusb2: Convert timers to use timer_setup()

2017-10-25 Thread Mike Isely
Acked-By: Mike Isely <is...@pobox.com> On Tue, 24 Oct 2017, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. >

Re: [PATCH 05/24] media: v4l2-dev: convert VFL_TYPE_* into an enum

2017-10-09 Thread Mike Isely
Acked-By: Mike Isely <is...@pobox.com> On Mon, 9 Oct 2017, Mauro Carvalho Chehab wrote: > Using enums makes easier to document, as it can use kernel-doc > markups. It also allows cross-referencing, with increases the > kAPI readability. > > Signed-off-by: Mauro Carva

Re: usb/media/pvrusb2: warning in pvr2_send_request_ex/usb_submit_urb

2017-09-20 Thread Mike Isely
; drivers/media/usb/pvrusb2/pvrusb2-context.c:167 > kthread+0x3a1/0x470 kernel/kthread.c:231 > ret_from_fork+0x2a/0x40 arch/x86/entry/entry_64.S:431 > Code: 48 8b 85 30 ff ff ff 48 8d b8 98 00 00 00 e8 ee 82 89 fe 45 89 > e8 44 89 f1 4c 89 fa 48 89 c6 48 c7 c7 40 c0 ea 86 e8 30 1b dc f

Re: [PATCH v2 5/6] media/usb/pvrusb2: Support for V4L2_CTRL_WHICH_DEF_VAL

2015-10-29 Thread Mike Isely
rol infrastructure. > Add support for the new field which on structure > v4l2_ext_controls > > Acked-by: Mike Isely <is...@pobox.com> > Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> > --- > drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 16 ++-- &g

Re: [PATCH v2 07/10] media/usb/pvrusb2: Support for V4L2_CTRL_WHICH_DEF_VAL

2015-08-21 Thread Mike Isely
pvr2_ctrl_get_value() vs pvr2_ctrl_get_def(). It's not a correctness comment; what you have should work fine. So I'm ack'ing this in any case: Acked-By: Mike Isely is...@pobox.com But you can do the above pretty easily safely, and simplify it a bit further. -Mike On Fri, 21 Aug 2015

Re: [PATCH] [media] [pvrusb2]: remove dead retry cmd code

2015-01-24 Thread Mike Isely
/majordomo-info.html -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 02/14] pvrusb2: fix sparse warning

2013-10-04 Thread Mike Isely
Acked-by: Mike Isely is...@pobox.com -Mike On Fri, 4 Oct 2013, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com drivers/media/usb/pvrusb2/pvrusb2-hdw.c:2871:13: warning: symbol 'pvr2_hdw_get_detected_std' was not declared. Should it be static? Signed-off-by: Hans

Re: [REVIEWv2 PATCH 07/12] pvrusb2: use v4l2_dev instead of the deprecated parent field.

2013-06-12 Thread Mike Isely
Acked-By: Mike Isely is...@pobox.com -Mike On Wed, 12 Jun 2013, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/pvrusb2/pvrusb2-hdw.c |4 drivers/media/usb/pvrusb2/pvrusb2-hdw.h |4

Re: [PATCH 33/68] [media] pvrusb2: get rid of warning: no previous prototype

2012-10-27 Thread Mike Isely
Acked-By: Mike Isely is...@pobox.com On Sat, 27 Oct 2012, Mauro Carvalho Chehab wrote: drivers/media/usb/pvrusb2/pvrusb2-v4l2.c:199:5: warning: no previous prototype for 'pvr2_s_std' [-Wmissing-prototypes] drivers/media/usb/pvrusb2/pvrusb2-v4l2.c:368:5: warning: no previous prototype

Re: [PATCH] pvr2: fix minor storage

2012-10-25 Thread Mike Isely
Completely agree! Thanks for spotting that one. Signed-off-by: Mike Isely is...@pobox.com -Mike On Thu, 25 Oct 2012, Alan Cox wrote: From: Alan Cox a...@linux.intel.com This should have break statements in it. Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/media/usb

Re: RFC: Core + Radio profile

2012-08-22 Thread Mike Isely
, then that will be a very big deal for this driver. -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] pvrusb2: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Mike Isely
Acked-By: Mike Isely is...@pobox.com -Mike On Thu, 26 Jul 2012, Tim Gardner wrote: Cc: Mike Isely is...@pobox.com Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: linux-media@vger.kernel.org Signed-off-by: Tim Gardner tim.gard...@canonical.com --- drivers/media/video/pvrusb2

[GIT PULL FOR 3.5] pvrusb2 driver updates

2012-05-04 Thread Mike Isely
Mauro: Please pull - this includes a long-awaited change courtesy of Hans Verkuil which finally transitions the driver to video_ioctl2. -Mike Isely The following changes since commit a1ac5dc28d2b4ca78e183229f7c595ffd725241c: [media] gspca - sn9c20x: Change the exposure setting

Re: [PATCHv2 5/8] [media] pvrusb2: initialize standards mask before detecting standard

2011-10-05 Thread Mike Isely
*file, unsigned int cmd, void *arg) case VIDIOC_QUERYSTD: { v4l2_std_id *std = arg; + *std = V4L2_STD_ALL; ret = pvr2_hdw_get_detected_std(hdw, std); break; } -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75

Re: [PATCHv2 5/8] [media] pvrusb2: initialize standards mask before detecting standard

2011-10-05 Thread Mike Isely
On Wed, 5 Oct 2011, Mauro Carvalho Chehab wrote: Em 05-10-2011 11:00, Mike Isely escreveu: Mauro: With the line you've just added, then the = arg assignment in the immediate prior line is effectively dead code. Try this instead: Look better: v4l2_std_id

Re: [PATCH 2/2] [media] pvrusb2: implement VIDIOC_QUERYSTD

2011-10-03 Thread Mike Isely
Acked-By: Mike Isely is...@pobox.com -Mike On Mon, 3 Oct 2011, Mauro Carvalho Chehab wrote: Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com --- drivers/media/video/pvrusb2/pvrusb2-hdw.c |7 +++ drivers/media/video/pvrusb2/pvrusb2-hdw.h |3 +++ drivers/media/video

Re: [RFCv6 PATCH 04/10] pvrusb2: fix g/s_tuner support.

2011-06-19 Thread Mike Isely
I understand that this patch would not have been need had the pvrusb2 driver been using videodev_ioctl2. This is a situation that I'm going to (finally) remedy ASAP. In the mean time... Acked-By: Mike Isely is...@pobox.com -Mike On Tue, 14 Jun 2011, Hans Verkuil wrote: From: Hans

Re: [PATCH 3/6] [media] pvrusb2: check for allocation failures

2011-03-26 Thread Mike Isely
I'll look at the surrounding code and see what makes sense there. Having an error leg for allocation failures is a useful thing. -Mike Dan Carpenter wrote: On Fri, Mar 25, 2011 at 11:33:36PM -0500, Mike Isely wrote: Acked-By: Mike Isely is...@pobox.com I'd need to reformat

Re: [PATCH 1/6] [media] pvrusb2: white space changes

2011-03-25 Thread Mike Isely
I vehemently object to this scale of disruption to the pvrusb2 driver source code purely to move around a bunch of braces and whitespace. ESPECIALLY the massive ridiculous changes having to do with if-statement syntax! Nacked-By: Mike Isely is...@pobox.com On Sat, 26 Mar 2011, Dan

Re: [PATCH 2/6] [media] pvrusb2: fix remaining checkpatch.pl complaints

2011-03-25 Thread Mike Isely
I am OK with the #include change, but NOT the if-statement change. But since it's bundled into one patch... Nacked-By: Mike Isely is...@pobox.com On Sat, 26 Mar 2011, Dan Carpenter wrote: * Include linux/string.h instead of asm/string.h. * Remove unneeded curly braces. Signed-off

Re: [PATCH 3/6] [media] pvrusb2: check for allocation failures

2011-03-25 Thread Mike Isely
Acked-By: Mike Isely is...@pobox.com On Sat, 26 Mar 2011, Dan Carpenter wrote: This function returns NULL on failure so lets do that if kzalloc() fails. There is a separate problem that the caller for this function doesn't check for errors... Signed-off-by: Dan Carpenter erro

Re: [PATCH 4/6] [media] pvrusb2: fix camel case variables

2011-03-25 Thread Mike Isely
It not worth this scale of source code disruption to the source code just to rename a bunch of variables. I'm sorry, but... Nacked-By: Mike Isely is...@pobox.com On Sat, 26 Mar 2011, Dan Carpenter wrote: This patch renames some variables to bring them more in line with kernel CodingStyle

Re: [PATCH 5/5] [media] pvrusb2: delete generic_standards_cnt

2011-03-25 Thread Mike Isely
Are you actually serious about this? Well it's a small change... Acked-By: Mike Isely is...@pobox.com On Sat, 26 Mar 2011, Dan Carpenter wrote: The generic_standards_cnt define is only used in one place and it's more readable to just call ARRAY_SIZE(generic_standards) directly. Signed

Re: [PATCH 6/6] [media] pvrusb2: replace !0 with 1

2011-03-25 Thread Mike Isely
That's an opinion which I as the driver author disagree with. Strongly. How hard is it to read not false? Nacked-By: Mike Isely is...@pobox.com On Sat, 26 Mar 2011, Dan Carpenter wrote: Using !0 is less readable than just saying 1. Signed-off-by: Dan Carpenter erro...@gmail.com diff

Re: compilation warnings/errors

2011-03-13 Thread Mike Isely
On Fri, 11 Mar 2011, Mike Isely wrote: On Fri, 11 Mar 2011, Mauro Carvalho Chehab wrote: /home/mchehab/new_build/v4l/pvrusb2-v4l2.c: In function 'pvr2_v4l2_do_ioctl': /home/mchehab/new_build/v4l/pvrusb2-v4l2.c:798:23: warning: variable 'cap' set but not used [-Wunused-but-set

[GIT PATCHES FOR 2.6.39] pvrusb2 driver fixes / improvements

2011-03-13 Thread Mike Isely
://git.linuxtv.org/mcisely/pvrusb2-dev.git pvrusb2-merge-2 Mike Isely (2): pvrusb2: Implement support for Terratec Grabster AV400 pvrusb2: Remove dead code Xiaochen Wang (1): pvrusb2: check kmalloc return value drivers/media/video/pvrusb2/pvrusb2-cx2584x-v4l.c | 18

Re: compilation warnings/errors

2011-03-11 Thread Mike Isely
puzzled right now since silly stuff like this usually doesn't get by me. Unfortunately I can't look at it right this minute. Expect to hear from me on Sunday. -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send

[GIT PULL FOR 2.6.39] pvrusb2 driver

2011-02-20 Thread Mike Isely
Isely] The following changes since commit 5ed4bbdae09d207d141759e013a0f3c24ae76ecc: Mauro Carvalho Chehab (1): [media] tuner-core: Don't touch at standby during tuner_lookup are available in the git repository at: git://git.linuxtv.org/mcisely/pvrusb2-dev.git pvrusb2-merge-1 Mike

Re: [PATCH 3/3] ir-kbd-i2c: improve remote behavior with z8 behind usb

2011-01-21 Thread Mike Isely
The pvrusb2 change is obviously trivial so I have no issue with it. Acked-By: Mike Isely is...@pobox.com Note the spelling of my last name Isely not Isley. A good way to remember is to think of the normal word wisely and just drop the leading w. (And yes, is...@isely.net and is...@pobox.com

Re: [PATCH 3/3] ir-kbd-i2c: improve remote behavior with z8 behind usb

2011-01-21 Thread Mike Isely
On Fri, 21 Jan 2011, Mike Isely wrote: Note the spelling of my last name Isely not Isley. A good way to remember is to think of the normal word wisely and just drop the leading w. (And yes, is...@isely.net and is...@pobox.com lead to the same inbox.) And of course having said that, I

Re: [PATCH 3/3] ir-kbd-i2c: improve remote behavior with z8 behind usb

2011-01-21 Thread Mike Isely
On Fri, 21 Jan 2011, Jarod Wilson wrote: On Fri, Jan 21, 2011 at 10:31:42AM -0600, Mike Isely wrote: The pvrusb2 change is obviously trivial so I have no issue with it. Acked-By: Mike Isely is...@pobox.com Note the spelling of my last name Isely not Isley. A good way

Re: [GIT PATCHES for 2.6.38] Zilog Z8 IR unit fixes

2011-01-19 Thread Mike Isely
-- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [GIT PATCHES for 2.6.38] Zilog Z8 IR unit fixes

2011-01-19 Thread Mike Isely
device (targeting 0x71) in order to determine if it is dealing with the MCE variant. -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [GIT PATCHES for 2.6.38] Zilog Z8 IR unit fixes

2011-01-19 Thread Mike Isely
-- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [GIT PATCHES for 2.6.38] Zilog Z8 IR unit fixes

2011-01-19 Thread Mike Isely
-- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [GIT PATCHES for 2.6.38] Zilog Z8 IR unit fixes

2011-01-19 Thread Mike Isely
On Wed, 19 Jan 2011, Jarod Wilson wrote: On Jan 19, 2011, at 8:20 AM, Mike Isely wrote: This probing behavior does not happen for HVR-1950 (or HVR-1900) since there's only one possible IR configuration there. Just to be 100% clear, the device I'm poking it is definitely an HVR-1950

Re: [RFC PATCH] pvrusb2: Provide more information about IR units to lirc_zilog and ir-kbd-i2c

2011-01-16 Thread Mike Isely
in a single spot. Just thinking ahead about making the setup table-driven and not requiring data segment storage. -Mike Acked-By: Mike Isely is...@pobox.com On Sun, 16 Jan 2011, Andy Walls wrote: When registering an IR Rx device with the I2C subsystem, provide more detailed information

Re: [RFC PATCH] pvrusb2: Provide more information about IR units to lirc_zilog and ir-kbd-i2c

2011-01-16 Thread Mike Isely
On Sun, 16 Jan 2011, Andy Walls wrote: On Sun, 2011-01-16 at 20:27 -0600, Mike Isely wrote: [,,,] Right now, yes. In the near future, I need to use to to pass 3 non-const items though: 1. A struct mutex *transceiver_lock so that the bridge driver can pass a mutex to multiple

Re: Volunteers needed: BKL removal: replace .ioctl by .unlocked_ioctl

2010-12-18 Thread Mike Isely
) cx23885 (Steve Toth) cx18-alsa (Andy Walls) omap24xxcam (Sakari Ailus or David Cohen) au0828 (Janne Grunau) cpia2 (Andy Walls or Hans Verkuil) cx231xx (Mauro Carvalho Chehab) davinci (Muralidharan Karicheri) saa6588 (Hans Verkuil) pvrusb2 (Mike Isely) usbvision (Hans Verkuil) s5p

Re: [PATCH 16/16] v4l: Remove module_name argument to the v4l2_i2c_new_subdev* functions

2010-10-03 Thread Mike Isely
For just the pvrusb2 part of the patch series below Acked-By: Mike Isely is...@pobox.com On Fri, 24 Sep 2010, Laurent Pinchart wrote: The argument isn't used anymore by the functions, remote it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media

Re: [PATCH 07/16] pvrusb2: Don't use module names to load I2C modules

2010-10-03 Thread Mike Isely
Acked-By: Mike Isely is...@pobox.com On Fri, 24 Sep 2010, Laurent Pinchart wrote: With the v4l2_i2c_new_subdev* functions now supporting loading modules based on modaliases, replace the hardcoded module name passed to those functions by NULL. All corresponding I2C modules have been

Re: [patch] V4L/DVB: pvrusb2: remove unneeded NULL checks

2010-08-19 Thread Mike Isely
Based on the surrounding code (the unconditional dereference), I agree that this particular bit of coding paranoia is not doing much good. Acked-by: Mike Isely is...@pobox.com On Thu, 19 Aug 2010, Dan Carpenter wrote: We dereference maskptr unconditionally at the start of the function

Re: [PATCH 2/2] media: video: pvrusb2: remove custom hex_to_bin()

2010-07-27 Thread Mike Isely
Andy: Acked-By: Mike Isely is...@pobox.com -Mike On Tue, 27 Jul 2010, Andy Shevchenko wrote: Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com Cc: Mike Isely is...@pobox.com --- drivers/media/video/pvrusb2/pvrusb2-debugifc.c | 14 ++ 1 files changed, 2 insertions

Re: Status of the patches under review at LMML (60 patches)

2010-07-07 Thread Mike Isely
the pvrusb2 driver (which is what I was planning on doing). -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: Status of the patches under review at LMML (60 patches)

2010-07-07 Thread Mike Isely
email). P.S.: This email is c/c to the developers where some action is expected. If you were copied, please review the patches, acking/nacking or submitting an update. [...] == Waiting for Mike Isely is...@isely.net review == Apr,25 2010: Problem

Re: [git:v4l-dvb/other] V4L/DVB: drivers/media/video/pvrusb2: Add missing mutex_unlock

2010-07-03 Thread Mike Isely
On Sat, 3 Jul 2010, Douglas Schilling Landgraf wrote: Hello Mike, Mike Isely wrote: Mauro: FYI, I posted an Acked-By: Mike Isely is...@pobox.com weeks ago, back on 27-May, immediately after the patch was posted. It's a great catch, and the bug has been there since basically

Re: Subject: Composite input from OnAir Creator - use as security camera

2010-05-26 Thread Mike Isely
hints welcome. Thanks. A. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71

Re: [PATCH 5/17] drivers/media/video/pvrusb2: Add missing mutex_unlock

2010-05-26 Thread Mike Isely
I looked through my revision history and that bug has been there in the driver source since at least May 2005, long before it was ever merged into the kernel. Wow, what a great catch. Thanks! Acked-By: Mike Isely is...@pobox.com -Mike On Wed, 26 May 2010, Julia Lawall wrote: From

Re: [PULL] http://linuxtv.org/hg/~mcisely/pvrusb2-patches

2010-05-21 Thread Mike Isely
doing in the past, that it's definitely causing a problem now and thus that is why this patch exists. I'd really rather you not mess with my comment. Probably too late however. -Mike On Fri, 21 May 2010, Mauro Carvalho Chehab wrote: Mike Isely wrote: Please from http://linuxtv.org/hg

Re: [PULL] http://linuxtv.org/hg/~mcisely/pvrusb2-patches

2010-05-21 Thread Mike Isely
On Fri, 21 May 2010, Mauro Carvalho Chehab wrote: Mike Isely wrote: On Fri, 21 May 2010, Mauro Carvalho Chehab wrote: Mike Isely wrote: Mauro: You are reading too much into that comment. I never said it was valid to do what had been done, only that for the longest time

Re: [PULL] http://linuxtv.org/hg/~mcisely/pvrusb2-patches

2010-05-21 Thread Mike Isely
On Fri, 21 May 2010, Mauro Carvalho Chehab wrote: Mike Isely wrote: [snip] The point when the kernel started complaining about the use of a stack based USB I/O buffers is the relevant point, which was not back in 2.6.12. I learned of this behavior (that is, receiving warnings about

[PULL] http://linuxtv.org/hg/~mcisely/pvrusb2-patches

2010-05-16 Thread Mike Isely
insertions(+), 9 deletions(-) These are primarily a collection of stability fixes. Thanks, -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: Problem with cx25840 and Terratec Grabster AV400

2010-04-24 Thread Mike Isely
On Sat, 24 Apr 2010, Sven Barth wrote: On 24.04.2010 19:13, Mike Isely wrote: Actually the support in the pvrusb2 driver was never really completed. But since I don't have a sample of the hardware here I went on ahead and merged what was there so that it could get exposure

Re: Problem with cx25840 and Terratec Grabster AV400

2010-04-24 Thread Mike Isely
On Sat, 24 Apr 2010, Sven Barth wrote: Hi! On 24.04.2010 22:24, Mike Isely wrote: On Sat, 24 Apr 2010, Sven Barth wrote: Hi! Although you never really completed that support for the AV400 it runs pretty well once you've touched the cx25840 source. I'm using it for months

Re: [PATCH] device_attributes: add sysfs_attr_init() for dynamic attributes

2010-04-10 Thread Mike Isely
Acked-By: Mike Isely is...@pobox.com (in the context of the pvrusb2 driver related changes) -Mike On Mon, 22 Mar 2010, Wolfram Sang wrote: Made necessary by 6992f5334995af474c2b58d010d08bc597f0f2fe. Found by this semantic patch: @ init @ type T; identifier A; @@ T

Re: [PATCH 09/11] pvrusb2-v4l2: Rename dev_info to pdi

2010-04-10 Thread Mike Isely
Acked-By: Mike Isely is...@pobox.com -Mike On Mon, 5 Apr 2010, Joe Perches wrote: There is a macro called dev_info that prints struct device specific information. Having variables with the same name can be confusing and prevents conversion of the macro to a function. Rename

Re: RFC: exposing controls in sysfs

2010-04-07 Thread Mike Isely
On Thu, 8 Apr 2010, hermann pitton wrote: Hi, Am Mittwoch, den 07.04.2010, 20:50 +0200 schrieb Lars Hanisch: Am 06.04.2010 16:33, schrieb Mike Isely: [snip] Mike, do you know of anyone actively using that additional information? Yes. The VDR project at one time

Re: RFC: exposing controls in sysfs

2010-04-07 Thread Mike Isely
not necessarily mean that I would agree with eventual removal of the pvrusb2 driver's existing sysfs interface. That would depend on whether or not doing such a thing loses functionality and what the driver's user community would think about it. -Mike -- Mike Isely isely @ isely (dot) net

Re: RFC: exposing controls in sysfs

2010-04-06 Thread Mike Isely
building the driver.) -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: RFC: exposing controls in sysfs

2010-04-06 Thread Mike Isely
for any program that tries to use it. I also think it's probably a bad idea for example to define a format where the whitespace conveys additional information. The case where I've seen whitespace as part of the syntax actually work cleanly is in Python. -- Mike Isely isely @ isely (dot) net

Re: RFC: exposing controls in sysfs

2010-04-06 Thread Mike Isely
not to say that we should all be screaming for this - but if people didn't really understand what was possible, then how could they ask for it? -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line

Re: RFC: exposing controls in sysfs

2010-04-06 Thread Mike Isely
to change the owner / group from userspace, and I *think* it's possible to create a udev rule to do this, but honestly I have not investigated this possibility so I don't fully know. This is one serious potential drawback to using sysfs as a driver API. -Mike -- Mike Isely isely @ isely (dot

Re: RFC: exposing controls in sysfs

2010-04-06 Thread Mike Isely
of concerns about testing / maintenance going forward. -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

Re: OnAir USB HDTV Creator

2010-02-26 Thread Mike Isely
in the wiki is over a year out of date. -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PULL] http://linuxtv.org/hg/~mcisely/pvrusb2-patches

2010-02-21 Thread Mike Isely
an saa7115 video digitizer. Thanks, -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: Do any drivers access the cx25840 module in an atomic context?

2010-01-18 Thread Mike Isely
On Mon, 18 Jan 2010, Andy Walls wrote: On Mon, 2010-01-18 at 14:18 -0600, Mike Isely wrote: On Mon, 18 Jan 2010, Andy Walls wrote: Any definitive confirmation anyone can give on any of these drivers would be helpful and would save me some time. Mike, Great! Thank you

Re: [GIT PULL for 2.6.32] V4L/DVB updates

2009-12-01 Thread Mike Isely
On Tue, 1 Dec 2009, Mauro Carvalho Chehab wrote: Mike Isely wrote: On Mon, 30 Nov 2009, Mauro Carvalho Chehab wrote: Em Sat, 28 Nov 2009 14:33:30 -0600 (CST) Mike Isely is...@isely.net escreveu: Mauro: I had also posted up two high priority pvrusb2 patches that should really

Re: [GIT PULL for 2.6.32] V4L/DVB updates

2009-11-28 Thread Mike Isely
have any ordering dependencies with other patches, though between the two the second one technically should come after the first. Thanks, -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line

[PULL] http://linuxtv.org/hg/~mcisely/pvrusb2-20091124

2009-11-24 Thread Mike Isely
. They are marked high priority. Thanks, -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PULL] http://linuxtv.org/hg/~mcisely/pvrusb2-20091011

2009-10-29 Thread Mike Isely
On Thu, 29 Oct 2009, Mauro Carvalho Chehab wrote: Em Sun, 11 Oct 2009 22:53:14 -0500 (CDT) Mike Isely is...@isely.net escreveu: Mauro: Please from http://linuxtv.org/hg/~mcisely/pvrusb2-20091011 for a few various pvrusb2 fixes / improvements. No critical bug fixes here, just

[PULL] http://linuxtv.org/hg/~mcisely/pvrusb2-20091011

2009-10-11 Thread Mike Isely
-debugifc.c |3 +++ pvrusb2-encoder.c |5 - pvrusb2-hdw-internal.h |1 + pvrusb2-hdw.c | 33 - pvrusb2-v4l2.c | 21 - 5 files changed, 52 insertions(+), 11 deletions(-) -Mike -- Mike Isely isely

Re: How to make my device work with linux?

2009-10-01 Thread Mike Isely
out there which can handle this part, but I can't help you there. -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org

Re: How to make my device work with linux?

2009-10-01 Thread Mike Isely
frustrated. Things aren't hopeless. The cxusb module in DVB might be something you should look at. I guess it depends on how deep you wish to dive here. -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send

[PATCH] s2255drv: Don't conditionalize video buffer completion on waiting processes

2009-09-23 Thread Mike Isely
# HG changeset patch # User Mike Isely is...@pobox.com # Date 1253739604 18000 # Node ID 522a74147753ba59c7f45e368439928090a286f2 # Parent e349075171ddf939381fad432c23c1269abc4899 s2255drv: Don't conditionalize video buffer completion on waiting processes From: Mike Isely is...@pobox.com

Re: [PATCH] s2255drv: Don't conditionalize video buffer completion on waiting processes

2009-09-23 Thread Mike Isely
as well?) -Mike Mike Isely wrote: # HG changeset patch # User Mike Isely is...@pobox.com # Date 1253739604 18000 # Node ID 522a74147753ba59c7f45e368439928090a286f2 # Parent e349075171ddf939381fad432c23c1269abc4899 s2255drv: Don't conditionalize video buffer completion

[PATCH] bttv: Fix potential out-of-order field processing

2009-09-21 Thread Mike Isely
# HG changeset patch # User Mike Isely is...@pobox.com # Date 1253545748 18000 # Node ID 760a8bc4028014493ccbbe85d0c9e8c91873fc23 # Parent 29e4ba1a09bcf9a03a653b2124929f5359fef772 bttv: Fix potential out-of-order field processing From: Mike Isely is...@pobox.com There is a subtle interaction

[PATCH] bttv: Fix reversed polarity error when switching video standard

2009-09-21 Thread Mike Isely
changeset patch # User Mike Isely is...@pobox.com # Date 1253547742 18000 # Node ID e349075171ddf939381fad432c23c1269abc4899 # Parent 760a8bc4028014493ccbbe85d0c9e8c91873fc23 bttv: Fix reversed polarity error when switching video standard From: Mike Isely is...@pobox.com The bttv driver function

Re: [linuxtv-commits] [hg:v4l-dvb] cx25840: fix determining the firmware name

2009-09-07 Thread Mike Isely
On Mon, 7 Sep 2009, Mauro Carvalho Chehab wrote: [...] I remember I asked both Mikes (Michael Krufky and Mike Isely) on March for some tests with the new firmware. I'm not sure if they had some time for testing it. Yes, I remember this exchange. At the time you had mentioned only

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-misc

2009-08-07 Thread Mike Isely
Acked-By: Mike Isely is...@pobox.com -Mike On Fri, 7 Aug 2009, Hans Verkuil wrote: Hi Mauro, Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-misc for the following: - pvrusb2: fix compile warning - cx24113: fix mips compiler warning - hdpvr: add missing initialization

Re: offering bounty for GPL'd dual em28xx support

2009-07-29 Thread Mike Isely
supply. I've actually successfully tested such a configuration here. The hardware works fine over USB 1.1. -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

[PULL] http://linuxtv.org/hg/~mcisely/pvrusb2-dev

2009-06-20 Thread Mike Isely
-- pvrusb2-video-v4l.c | 37 +- 5 files changed, 98 insertions(+), 78 deletions(-) -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: s5h1411_readreg: readreg error (ret == -5)

2009-06-12 Thread Mike Isely
it will be very difficult for me to track the problem down here since I don't have that device variant. -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

Re: s5h1411_readreg: readreg error (ret == -5)

2009-06-12 Thread Mike Isely
Well now I feel like an idiot. Thanks for pointing that out in my own code :-) Still digging through this. -Mike On Fri, 12 Jun 2009, Andy Walls wrote: On Fri, 2009-06-12 at 15:33 -0500, Mike Isely wrote: I am unable to reproduce the s5h1411 error here. However my HVR-1950 loads

Re: s5h1411_readreg: readreg error (ret == -5)

2009-06-11 Thread Mike Isely
On Thu, 11 Jun 2009, Steven Toth wrote: Mike Isely wrote: On Sun, 7 Jun 2009, Roger wrote: From looking at linux/drivers/media/dvb/frontends/s5h1411.c, The s5h1411_readreg wants to see 2 but is getting -5 from the i2c bus. --- Snip --- s5h1411_readreg: readreg error

Re: s5h1411_readreg: readreg error (ret == -5)

2009-06-10 Thread Mike Isely
behave this way. It's also possible that the part might have been busy and unable to respond - but usually in that case the driver for such a part will be written with this in mind and will know how / when to communicate with the hardware. -Mike -- Mike Isely isely @ isely (dot) net PGP

Re: [PULL] http://kernellabs.com/hg/~stoth/tda10048-merge/

2009-05-21 Thread Mike Isely
I see no issues here with the pvrusb2 part of it... Acked-by: Mike Isely is...@pobox.com On Wed, 20 May 2009, Steven Toth wrote: Mauro, Please pull from http://kernellabs.com/hg/~stoth/tda10048-merge/ - TDA10048: Ensure the I/F changes during DVB-T 6/7/8 bandwidth changes

Re: [PATCH 0/8] ir-kbd-i2c conversion to the new i2c binding model (v3)

2009-05-17 Thread Mike Isely
. Jean: I tried the all-in-one patch here on a PVR-USB2 24xxx model (slightly older v4l-dvb repo and 2.6.27.13 vanilla kernel) and it worked fine. I'll add an acked-by to the corresponding (trivial) pvrusb2 patch that you've posted. -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D

Re: [PATCH 8/8] pvrusb2: Instantiate ir_video I2C device by default

2009-05-17 Thread Mike Isely
purpose. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Mike Isely is...@pobox.com Acked-by: Mike Isely is...@pobox.com --- linux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- v4l-dvb.orig/linux/drivers/media/video/pvrusb2

Re: [PULL] http://linuxtv.org/hg/~mcisely/pvrusb2-dev

2009-05-12 Thread Mike Isely
On Mon, 11 May 2009, Mauro Carvalho Chehab wrote: Em Mon, 11 May 2009 22:09:26 -0300 Mauro Carvalho Chehab mche...@infradead.org escreveu: Em Sat, 9 May 2009 16:49:31 -0500 (CDT) Mike Isely is...@isely.net escreveu: Mauro: Please pull from http://linuxtv.org/hg/~mcisely

[PULL] http://linuxtv.org/hg/~mcisely/pvrusb2-dev

2009-05-09 Thread Mike Isely
- pvrusb2-i2c-core.c | 53 +++-- pvrusb2-sysfs.c| 22 ++--- pvrusb2-v4l2.c |2 - 7 files changed, 106 insertions(+), 76 deletions(-) -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2

Re: [PULL] http://linuxtv.org/hg/~stoth/tda10048

2009-05-05 Thread Mike Isely
, 237 insertions(+), 2 deletions(-) The TDA10048 used to have a hard-coded I/F, I've improved this to support different I/F's and ensured that all current bridge drivers specify their needs. Regards, - Steve -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC

Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-05-01 Thread Mike Isely
On Fri, 1 May 2009, Alexey Klimov wrote: Hello, On Mon, Apr 20, 2009 at 3:59 AM, Mike Isely is...@isely.net wrote: [...] So the kernel already has this; it just needs to be pulled back into v4l-dvb.  It's an obvious trivial thing for now and I've acked it there. Obviously we're

Re: [PATCH 2/6] ir-kbd-i2c: Switch to the new-style device binding model

2009-05-01 Thread Mike Isely
messing with module options, and once you're reading, just include the 1-line change above and you're set. There's no race here, no gap in IR handling. -Mike On Thu, 23 Apr 2009, Mike Isely wrote: Hi Jean, I had actually written out a longer, detailed, point-by-point reply earlier today

Re: [PATCH] media: remove driver_data direct access of struct device

2009-05-01 Thread Mike Isely
Acked-By: Mike Isely is...@pobox.com Note #1: I am just acking the pvrusb2 part of this. Note #2: I am immediately pulling the pvrusb2 part of these changes into that driver. -Mike On Thu, 30 Apr 2009, Greg Kroah-Hartman wrote: From: Greg Kroah-Hartman gre...@suse.de In the near

Re: [PATCH] pvrusb2: Don't use the internal i2c client list

2009-04-30 Thread Mike Isely
of v4l. That would include, uh, lirc. I will review and test this first chance I get which should be tomorrow. -Mike Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Mike Isely is...@pobox.com --- Mike, can you please review and test this patch? Thanks. linux/drivers/media/video

Re: [PATCH 2/6] ir-kbd-i2c: Switch to the new-style device binding model

2009-04-23 Thread Mike Isely
with the steamer that pobox.com has just handed me :-( -Mike -- Mike Isely isely @ pobox (dot) com PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-04-19 Thread Mike Isely
to cause a problem I'll make a follow-up fix upstream. Acked-By: Mike Isely is...@pobox.com -Mike /quote So the kernel already has this; it just needs to be pulled back into v4l-dvb. It's an obvious trivial thing for now and I've acked it there. Obviously we're getting had here because you're

Re: [PATCH 2/6] ir-kbd-i2c: Switch to the new-style device binding model

2009-04-17 Thread Mike Isely
: Andy Walls awa...@radix.net Cc: Mike Isely is...@pobox.com --- linux/drivers/media/video/bt8xx/bttv-i2c.c | 21 + linux/drivers/media/video/cx231xx/cx231xx-cards.c| 11 linux/drivers/media/video/cx231xx/cx231xx-i2c.c |3 linux/drivers/media/video/cx231xx/cx231xx.h

Re: [RFC] Anticipating lirc breakage

2009-04-08 Thread Mike Isely
above is correct, I'll just fix the second patch and the pvrusb2 driver should be ready to go for this. -Mike -- Mike Isely isely @ pobox (dot) com PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

  1   2   >