Re: [PATCH 1/2] MAINTAINERS: linux-media: update Microchip ISI and ISC entries

2018-01-12 Thread Nicolas Ferre
On 09/01/2018 at 14:46, Nicolas Ferre wrote: > These two image capture interface drivers are now handled > by Wenyou Yang. > I benefit from this change to update the two entries by correcting the > binding documentation link for ISC and moving the ISI to the new > MICROCHIP /

[PATCH v2] MAINTAINERS: mtd/nand: update Microchip nand entry

2018-01-11 Thread Nicolas Ferre
Update Wenyou Yang email address. Take advantage of this update to move this entry to the MICROCHIP / ATMEL location and add the DT binding documentation link. Signed-off-by: Nicolas Ferre Acked-by: Wenyou Yang --- v2: - patch agains 09ec417b0ea8 ("mtd: nand: samsung: Disable su

[PATCH 1/2] MAINTAINERS: linux-media: update Microchip ISI and ISC entries

2018-01-09 Thread Nicolas Ferre
These two image capture interface drivers are now handled by Wenyou Yang. I benefit from this change to update the two entries by correcting the binding documentation link for ISC and moving the ISI to the new MICROCHIP / ATMEL location. Signed-off-by: Nicolas Ferre --- Hi, Patch against next

[PATCH 2/2] MAINTAINERS: mtd/nand: update Microchip nand entry

2018-01-09 Thread Nicolas Ferre
Update Wenyou Yang email address. Take advantage of this update to move this entry to the MICROCHIP / ATMEL location and add the DT binding documentation link. Signed-off-by: Nicolas Ferre --- Hi, Patch against next-20180109. This patch is somehow dependent on the previous one in the series

Re: [PATCH] media: Convert to using %pOF instead of full_name

2017-07-19 Thread Nicolas Ferre
ux-samsung-...@vger.kernel.org > Cc: linux-media...@lists.infradead.org > Cc: linux-renesas-...@vger.kernel.org > --- > drivers/media/i2c/s5c73m3/s5c73m3-core.c | 3 +- > drivers/media/i2c/s5k5baf.c| 7 ++-- > drivers/media/platform/am437x/am437x-vpf

Re: [PATCH] [media] atmel-isc: Set the default DMA memory burst size

2017-04-27 Thread Nicolas Ferre
Le 20/04/2017 à 10:51, Songjun Wu a écrit : > Sometimes 'DMA single access' is not enough to transfer > a frame of image, '8-beat burst access' is set as the > default DMA memory burst size. > > Signed-off-by: Songjun Wu Seems okay: Acked-by: Nicolas Ferre

Re: [PATCHv6 00/14] atmel-isi/ov7670/ov2640: convert to standalone drivers

2017-04-04 Thread Nicolas Ferre
atmel-isi: remove dependency of the soc-camera framework > atmel-isi: move out of soc_camera to atmel > ov2640: fix colorspace handling > ov2640: update bindings > ov2640: convert from soc-camera to a standard subdev sensor driver. > ov2640: use standard clk and e

Re: [PATCHv5 07/16] atmel-isi: remove dependency of the soc-camera framework

2017-03-13 Thread Nicolas Ferre
e >> we sure there aren't going to be any SoCs with more than one ISI? > > When that happens, this should be changed at that time. I think it is unlikely > since as I understand it ISI has been replaced by ISC (atmel-isc). Yes, ISC has replaced ISI for all Atmel/Microchip MPUs onwards. We may have several of them, but very likely never more than one ISI. Regards, -- Nicolas Ferre

Re: [PATCH v10 3/3] MAINTAINERS: atmel-isc: add entry for Atmel ISC

2016-08-17 Thread Nicolas Ferre
Le 16/08/2016 à 23:05, Songjun Wu a écrit : > Add the MAINTAINERS' entry for Microchip / Atmel Image Sensor Controller. > > Signed-off-by: Songjun Wu Acked-by: Nicolas Ferre > --- > > Changes in v10: None > Changes in v9: None > Changes in v8: None > Changes i

[PATCH] MAINTAINERS: atmel-isc: add entry for Atmel ISC

2016-08-15 Thread Nicolas Ferre
Add the MAINTAINERS' entry for Microchip / Atmel Image Sensor Controller. Signed-off-by: Nicolas Ferre Cc: Songjun Wu --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 45c98485c3f0..84786643ba4c 100644 --- a/MAINTAINERS

Re: [PATCH 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-04-19 Thread Nicolas Ferre
cfg); >>> + } >>> + >>> + val |= subdev->hsync_active | subdev->vsync_active | >>> + subdev->pclk_sample | ISC_PFE_CFG0_MODE_PROGRESSIVE; >>> + mask = ISC_PFE_CFG0_BPS_MASK | ISC_PFE_CFG0_HPOL_MASK | >>> + ISC_PFE_CFG0_VPOL_MASK | ISC_PFE_CFG0_PPOL_MASK | >>> + ISC_PFE_CFG0_MODE_MASK; >>> + >>> + regmap_update_bits(regmap, ISC_PFE_CFG0, mask, val); >>> + >>> + regmap_update_bits(regmap, ISC_RLP_CFG, ISC_RLP_CFG_MODE_MASK, >>> + current_fmt->reg_rlp_mode); >>> + >>> + regmap_update_bits(regmap, ISC_DCFG, ISC_DCFG_IMODE_MASK, >>> + current_fmt->reg_dcfg_imode); >>> + >>> + isc_set_pipeline(regmap, pipeline); >>> + >>> + /* Update profile */ >>> + regmap_update_bits(regmap, ISC_CTRLEN, >>> + ISC_CTRLEN_UPPRO_MASK, ISC_CTRLEN_UPPRO); >>> + >>> + regmap_read(regmap, ISC_CTRLSR, &val); >>> + while (val & ISC_CTRLSR_UPPRO) { >>> + cpu_relax(); >>> + regmap_read(regmap, ISC_CTRLSR, &val); >>> + } >> >> You need an exit condition here too in case the hardware gets stuck for some >> reason. It shouldn't happen in theory, and always does in practice :-) Absolutely. > Accept, I will add the number of iterations or a timer. Do you think > which is better? Is there any hints in the datasheet? Is the checking of CTRLSR is advised in the datasheet as well? Otherwise, you can contact the ISC designer to ask him what makes more sense to him. Laurent, thanks a lot for your valuable review! Bye, -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [TRIVIAL PATCH] treewide: Remove unnecessary 0x prefixes before %pa extension uses

2016-03-07 Thread Nicolas Ferre
dma_chan *atchan) {} > static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli) > { > dev_crit(chan2dev(&atchan->chan_common), > - " desc: s%pad d%pad ctrl0x%x:0x%x l0x%pad\n", > + " desc: s%pad d%pad ctrl

Re: [PATCH v3] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity

2015-09-18 Thread Nicolas Ferre
NC_ACTIVE_LOW) >> + isi->pdata.hsync_act_low = true; >> +if (ep.bus.parallel.flags & V4L2_MBUS_VSYNC_ACTIVE_LOW) >> +isi->pdata.vsync_act_low = true; >> +if (ep.bus.parallel.flags & V4L2_MBUS_PCLK_SAMPLE_FALLING) >> +isi->pdata.pclk_act_falling = true; >> + >> +if (ep.bus_type == V4L2_MBUS_BT656) >> +isi->pdata.has_emb_sync = true; >> + >> return 0; >> } > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] genalloc: rename dev_get_gen_pool() to gen_pool_get()

2015-06-11 Thread Nicolas Ferre
gt;dev); > if (!sram_pool) { > pr_warn("%s: sram pool unavailable!\n", __func__); > return; No blocked on my side. For AT91: Acked-by: Nicolas Ferre > diff --git a/arch/arm/mach-imx/pm-imx5.c b/arch/arm/mach-imx/pm-imx5.c > index 0309ccd..18

Re: [PATCH v2 0/8] ARM: at91: dts: sama5d3: add dt support for atmel isi and ov2640 sensor

2015-01-15 Thread Nicolas Ferre
dts: sama5d3: change name of pinctrl of ISI_MCK > ARM: at91: dts: sama5d3: add ov2640 camera sensor support > ARM: at91: sama5: enable atmel-isi and ov2640 in defconfig The whole series: Acked-by: Nicolas Ferre stacked on top of at91-3.20-dt. The defconfig update on his side

Re: [PATCH v2 0/8] ARM: at91: dts: sama5d3: add dt support for atmel isi and ov2640 sensor

2015-01-13 Thread Nicolas Ferre
n you please send it(them?)? Bye, > arch/arm/boot/dts/sama5d3.dtsi| 24 ++- > arch/arm/boot/dts/sama5d3xmb.dtsi | 40 > +++ > arch/arm/configs/sama5_defconfig | 6 ++ > 3 files changed, 61 insertions(+), 9 deletions(-) >

Re: [PATCH 37/51] DMA-API: usb: use new dma_coerce_mask_and_coherent()

2013-09-23 Thread Nicolas Ferre
On 20/09/2013 00:02, Russell King : Signed-off-by: Russell King --- drivers/usb/chipidea/ci_hdrc_imx.c |4 +--- drivers/usb/dwc3/dwc3-exynos.c |4 +--- drivers/usb/host/ehci-atmel.c |4 +--- For Atmel driver: Acked-by: Nicolas Ferre [..] diff --git a/drivers/usb

Re: [PATCH 36/51] DMA-API: usb: use dma_set_coherent_mask()

2013-09-23 Thread Nicolas Ferre
the correct API. Signed-off-by: Russell King --- drivers/usb/chipidea/ci_hdrc_imx.c |5 +++-- drivers/usb/dwc3/dwc3-exynos.c |5 +++-- drivers/usb/gadget/lpc32xx_udc.c |4 +++- drivers/usb/host/ehci-atmel.c |5 +++-- For Atmel driver: Acked-by: Nicolas Ferre

Re: [PATCH] [media] V4L: atmel-isi: add code to enable/disable ISI_MCK clock

2011-11-28 Thread Nicolas Ferre
On 11/28/2011 02:50 PM, Guennadi Liakhovetski : > Hi Nicolas > > On Mon, 28 Nov 2011, Nicolas Ferre wrote: > >> From: Josh Wu >> >> This patch >> - add ISI_MCK clock enable/disable code. >> - change field name in isi_platform_data structure >

[PATCH] [media] V4L: atmel-isi: add code to enable/disable ISI_MCK clock

2011-11-28 Thread Nicolas Ferre
From: Josh Wu This patch - add ISI_MCK clock enable/disable code. - change field name in isi_platform_data structure Signed-off-by: Josh Wu [g.liakhovet...@gmx.de: fix label names] Signed-off-by: Guennadi Liakhovetski Acked-by: Nicolas Ferre --- Guennadi, Here is the pach form Josh and

Re: [PATCH v3 2/2] at91: add Atmel ISI and ov2640 support on sam9m10/sam9g45 board.

2011-09-26 Thread Nicolas Ferre
or at91 core and one for the specific board, but that's up >> to arch maintainers to decide. >> >> You also want to patch arch/arm/mach-at91/at91sam9263_devices.c, don't >> you? > agreed No, I am not sure. The IP is not the same between 9263 and 9g45/9m10. So this inclusion

Re: [PATCH v2] [media] at91: add code to initialize and manage the ISI_MCK for Atmel ISI driver.

2011-09-09 Thread Nicolas Ferre
and how to set the programmable clocks rate... >> +clk_put(pck_parent); >> +if (ret) >> +goto err_init_mck; >> + >> +ret = clk_set_rate(isi->mck, pdata->isi_mck_hz); >> +if (ret < 0) >> +goto err_init_mck; >