Re: [PATCH V3 03/15] [media] marvell-ccic: add clock tree support for marvell-ccic driver

2013-01-03 Thread Nicolas THERY
On 2012-12-16 22:51, Albert Wang wrote: [...] +static void mcam_clk_set(struct mcam_camera *mcam, int on) +{ + unsigned int i; + + if (on) { + for (i = 0; i mcam-clk_num; i++) { + if (mcam-clk[i]) + clk_enable(mcam-clk[i]); +

[PATCH TRIVIAL for 3.7] Documentation: fix outdated statement re. v4l2

2012-10-26 Thread Nicolas THERY
Fix tense used for describing struct v4l2_fh as it has been added a while ago. Signed-off-by: Nicolas Thery nicolas.th...@st.com --- Documentation/video4linux/v4l2-framework.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/video4linux/v4l2-framework.txt b

[PATCH TRIVIAL for 3.7] mem2mem: replace BUG_ON with WARN_ON

2012-10-23 Thread Nicolas THERY
See following thread for rationale: http://www.spinics.net/lists/linux-media/msg52462.html Tested by compilation only. Signed-off-by: Nicolas Thery nicolas.th...@st.com --- drivers/media/v4l2-core/v4l2-mem2mem.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

how to crop/scale in mono-subdev camera sensor driver?

2012-09-14 Thread Nicolas THERY
Hello, I'm studying how to support cropping and scaling (binning, skipping, digital scaling if any) for different models for camera sensor drivers. There seems to be (at least) two kinds of sensor drivers: 1) The smiapp driver has 2 or 3 subdevs: pixel array - binning (- scaling). It gives

Re: [PATCH] drivers: media: video: Add support for Aptina ar0130 sensor

2012-09-11 Thread Nicolas THERY
Hello, I've spotted a minor issue while glancing through the code. Cheers, Nicolas On 2012-09-07 11:30, Prashanth Subramanya wrote: This driver adds basic support for Aptina ar0130 1.2M sensor. Signed-off-by: Prashanth Subramanya sprasha...@aptina.com --- [snip]

Re: [RFC v4] V4L DT bindings

2012-08-31 Thread Nicolas THERY
Hello, Thanks for the feedback. On 2012-08-30 22:21, Sylwester Nawrocki wrote: On 08/30/2012 05:19 PM, Nicolas THERY wrote: [snip] In imx074@0x1a above, the data-lanes property is1,2. Is it reversed here to show that lanes are swapped between the sensor and the CSI rx? If not, how

Re: [RFC v4] V4L DT bindings

2012-08-31 Thread Nicolas THERY
Hello, On 2012-08-25 01:27, Guennadi Liakhovetski wrote: [snip] csi2: csi2@0xffc9 { compatible = renesas,sh-mobile-csi2; reg = 0xffc9 0x1000; interrupts = 0x17a0; #address-cells = 1; #size-cells = 0;

Re: [PATCH RFC 0/4] V4L2: Vendor specific media bus formats/ frame size control

2012-08-30 Thread Nicolas THERY
Hello, Thanks for your reply. It's good to know your proposal is simply on the back-burner. Best regards, Nicolas On 2012-08-29 20:41, sakari.ai...@iki.fi wrote: Hi Nicolas, On Mon, Aug 27, 2012 at 05:48:43PM +0200, Nicolas THERY wrote: Hello, On 2012-08-23 11:51, Sylwester Nawrocki

Re: [PATCH RFC 0/4] V4L2: Vendor specific media bus formats/ frame size control

2012-08-30 Thread Nicolas THERY
Hello, Thanks for your reply. I overlooked this sensor packages multiple streams in a single DT. It seems indeed that Sakari's RFC would not help. Best regards, On 2012-08-29 23:51, Sylwester Nawrocki wrote: Hi Nicolas, On 08/27/2012 05:48 PM, Nicolas THERY wrote: Hello, On 2012-08-23

Re: [RFC v4] V4L DT bindings

2012-08-30 Thread Nicolas THERY
Hello, I've got a couple of questions regarding lane swapping and polarity inversion. On 2012-08-25 01:27, Guennadi Liakhovetski wrote: Hi all After an initial RFC [1] and taking into consideration an even earlier patch-set [2], Sylwester and I have spent some time discussing V4L DT

Re: [PATCH] [media] atmel_isi: allocate memory to store the isi platform data.

2012-08-29 Thread Nicolas THERY
Hello, On 2012-08-29 12:11, Josh Wu wrote: This patch fix the bug: ISI driver's platform data became invalid when isi platform data's attribution is __initdata. If the isi platform data is passed as __initdata. Then we need store it in driver allocated memory. otherwise when we use it out

Re: [PATCH RFC 0/4] V4L2: Vendor specific media bus formats/ frame size control

2012-08-27 Thread Nicolas THERY
Hello, On 2012-08-23 11:51, Sylwester Nawrocki wrote: This patch series introduces new image source class control - V4L2_CID_FRAMESIZE and vendor or device specific media bus format section. There was already a discussion WRT handling interleaved image data [1]. I'm not terribly happy

[PATCH] media: fix MEDIA_IOC_DEVICE_INFO return code

2012-08-07 Thread Nicolas THERY
The MEDIA_IOC_DEVICE_INFO ioctl was returning a positive value rather than a negative error code when failing to copy output parameter to user-space. Tested by compilation only. Signed-off-by: Nicolas Thery nicolas.th...@st.com --- drivers/media/media-device.c | 4 +++- 1 file changed, 3

[PATCH for 3.6] videobuf2: fix sparse warning

2012-08-03 Thread Nicolas THERY
Fix symbol 'vb2_vmalloc_memops' was not declared. Should it be static? sparse warning. Signed-off-by: Nicolas Thery nicolas.th...@st.com --- drivers/media/video/videobuf2-vmalloc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/video/videobuf2-vmalloc.c b/drivers/media/video

[PATCH for 3.6] v4l: fix copy/paste typo in vb2_reqbufs comment

2012-07-20 Thread Nicolas THERY
Signed-off-by: Nicolas Thery nicolas.th...@st.com --- diff --git a/drivers/media/video/videobuf2-core.c b/drivers/media/video/videobuf2-core.c index 4e0290a..268c7dd 100644 --- a/drivers/media/video/videobuf2-core.c +++ b/drivers/media/video/videobuf2-core.c @@ -715,8 +715,8 @@ static int

[PATCH for 3.6] v4l: DocBook: VIDIOC_CREATE_BUFS: add hyperlink

2012-07-18 Thread Nicolas THERY
Signed-off-by: Nicolas Thery nicolas.th...@st.com --- diff --git a/Documentation/DocBook/media/v4l/vidioc-create-bufs.xml b/Documentation/DocBook/media/v4l/vidioc-create-bufs.xml index 5e73b1c..a8cda1a 100644 --- a/Documentation/DocBook/media/v4l/vidioc-create-bufs.xml +++ b/Documentation/DocBook

[PATCH for 3.6] v4l: DocBook: fix version number typo

2012-07-12 Thread Nicolas THERY
Signed-off-by: Nicolas Thery nicolas.th...@st.com --- Documentation/DocBook/media/v4l/compat.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/DocBook/media/v4l/compat.xml b/Documentation/DocBook/media/v4l/compat.xml index 97b8951..e519ce6 100644