RE: [PATCH - stable v3.2] omap3isp: ccdc: Fix crash in HS/VS interrupt handler

2012-03-11 Thread Nori, Sekhar
Hi Laurent, On Sun, Mar 11, 2012 at 17:20:08, Laurent Pinchart wrote: The HS/VS interrupt handler needs to access the pipeline object. It erronously tries to get it from the CCDC output video node, which isn't necessarily included in the pipeline. This leads to a NULL pointer dereference.

RE: [PATCH 1/4] davinci: vpif: add check for genuine interrupts in the isr

2012-02-28 Thread Nori, Sekhar
Hi Manju, On Wed, Jan 25, 2012 at 20:35:31, Hadli, Manjunath wrote: add a condition to in the isr to check for interrupt ownership and to is misplaced here? channel number to make sure we do not service wrong interrupts. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com I think it will

RE: [PATCH 4/4] davinci: da850: add build configuration for vpif drivers

2012-02-22 Thread Nori, Sekhar
Hi Manju, On Wed, Jan 25, 2012 at 20:35:34, Hadli, Manjunath wrote: add build configuration for da850/omapl-138 for vpif capture and display drivers. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- drivers/media/video/davinci/Kconfig | 26 +-

RE: [PATCH v7 1/8] davinci: vpif: remove machine specific inclusion from driver

2011-12-22 Thread Nori, Sekhar
Hi Manju, On Wed, Dec 21, 2011 at 19:13:34, Hadli, Manjunath wrote: remove machine specific inclusion from the driver which comes in the way of platform code consolidation. I think it would be more readable to use the term header file here and in the headline. Just machine specific inclusion

RE: [PATCH v3 0/5] ARM: davinci: re-arrange definitions to have a common davinci header

2011-12-02 Thread Nori, Sekhar
On Fri, Dec 02, 2011 at 11:59:49, Hadli, Manjunath wrote: Sekhar, On Wed, Nov 30, 2011 at 17:07:21, Nori, Sekhar wrote: Hi Manju, On Thu, Nov 17, 2011 at 15:48:53, Hadli, Manjunath wrote: Re-arrange definitions and remove unnecessary code so that we canx These are two different

RE: [PATCH RESEND] davinci: dm646x: move vpif related code to driver core header from platform

2011-11-30 Thread Nori, Sekhar
On Fri, Nov 25, 2011 at 01:36:01, Mauro Carvalho Chehab wrote: Em 24-11-2011 16:22, Nori, Sekhar escreveu: Hi Mauro, On Thu, Nov 24, 2011 at 23:35:24, Mauro Carvalho Chehab wrote: Em 12-11-2011 13:06, Manjunath Hadli escreveu: move vpif related code for capture and display drivers

RE: [PATCH v3 0/5] ARM: davinci: re-arrange definitions to have a common davinci header

2011-11-30 Thread Nori, Sekhar
Hi Manju, On Thu, Nov 17, 2011 at 15:48:53, Hadli, Manjunath wrote: Re-arrange definitions and remove unnecessary code so that we canx These are two different things and should be done in separate patches. Sergei has already pointed out couple of instances. have a common header for all

RE: [PATCH] board-dm646x-evm.c: wrong register used in setup_vpif_input_channel_mode

2011-11-30 Thread Nori, Sekhar
Hi Hans, On Mon, Nov 14, 2011 at 23:50:49, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com The function setup_vpif_input_channel_mode() used the VSCLKDIS register instead of VIDCLKCTL. This meant that when in HD mode videoport channel 0 used a different clock from channel 1.

RE: [PATCH RESEND] davinci: dm646x: move vpif related code to driver core header from platform

2011-11-24 Thread Nori, Sekhar
Hi Mauro, On Thu, Nov 24, 2011 at 23:35:24, Mauro Carvalho Chehab wrote: Em 12-11-2011 13:06, Manjunath Hadli escreveu: move vpif related code for capture and display drivers from dm646x platform header file to vpif_types.h as these definitions are related to driver code more than the

RE: [PATCH 1/1] davinci: dm646x: move vpif related code to driver core header from platform

2011-08-03 Thread Nori, Sekhar
Manju, On Fri, May 20, 2011 at 19:28:49, Hadli, Manjunath wrote: move vpif related code for capture and display drivers from dm646x platform header file to vpif.h as these definitions are related to driver code more than the platform or board. Signed-off-by: Manjunath Hadli

RE: [PATCH 1/1] davinci: dm646x: move vpif related code to driver core header from platform

2011-07-06 Thread Nori, Sekhar
Hi Mauro, On Wed, Jun 22, 2011 at 09:35:58, Nori, Sekhar wrote: On Thu, Jun 02, 2011 at 22:51:58, Nori, Sekhar wrote: Hi Mauro, On Fri, May 20, 2011 at 19:28:49, Hadli, Manjunath wrote: move vpif related code for capture and display drivers from dm646x platform header file to vpif.h

RE: [PATCH 1/1] davinci: dm646x: move vpif related code to driver core header from platform

2011-06-21 Thread Nori, Sekhar
On Thu, Jun 02, 2011 at 22:51:58, Nori, Sekhar wrote: Hi Mauro, On Fri, May 20, 2011 at 19:28:49, Hadli, Manjunath wrote: move vpif related code for capture and display drivers from dm646x platform header file to vpif.h as these definitions are related to driver code more than

RE: [PATCH 1/1] davinci: dm646x: move vpif related code to driver core header from platform

2011-06-02 Thread Nori, Sekhar
Hi Mauro, On Fri, May 20, 2011 at 19:28:49, Hadli, Manjunath wrote: move vpif related code for capture and display drivers from dm646x platform header file to vpif.h as these definitions are related to driver code more than the platform or board. Signed-off-by: Manjunath Hadli

RE: [PATCH v17 5/6] davinci vpbe: Build infrastructure for VPBE driver

2011-05-23 Thread Nori, Sekhar
On Fri, May 20, 2011 at 20:02:08, Sergei Shtylyov wrote: Hello. Manjunath Hadli wrote: This patch adds the build infra-structure for Davinci VPBE dislay driver. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Acked-by: Muralidharan Karicheri m-kariche...@ti.com Acked-by:

RE: [PATCH v18 07/13] davinci: move DM64XX_VDD3P3V_PWDN to devices.c

2011-05-23 Thread Nori, Sekhar
On Sat, Apr 02, 2011 at 15:13:00, Hadli, Manjunath wrote: Move the definition of DM64XX_VDD3P3V_PWDN from hardware.h to devices.c since it is used only there. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Acked-by: Sekhar Nori nsek...@ti.com Applying this after updating the patch

RE: [PATCH 1/1] davinci: dm646x: move vpif related code to driver core header from platform

2011-05-23 Thread Nori, Sekhar
On Fri, May 20, 2011 at 19:28:49, Hadli, Manjunath wrote: move vpif related code for capture and display drivers from dm646x platform header file to vpif.h as these definitions are related to driver code more than the platform or board. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com

RE: [PATCH v18 08/13] davinci: eliminate use of IO_ADDRESS() on sysmod

2011-04-05 Thread Nori, Sekhar
Hi Manju, On Sat, Apr 02, 2011 at 15:13:17, Hadli, Manjunath wrote: Current devices.c file has a number of instances where IO_ADDRESS() is used for system module register access. Eliminate this in favor of a ioremap() based access. Consequent to this, a new global pointer

RE: [PATCH v17 08/13] davinci: eliminate use of IO_ADDRESS() on sysmod

2011-03-23 Thread Nori, Sekhar
On Tue, Mar 22, 2011 at 18:45:03, Arnd Bergmann wrote: On Tuesday 22 March 2011, Nori, Sekhar wrote: .. but forgot to fix this. There is nothing wrong with using writel, but it doesn't fit into what the subject of this patch is. Well, to be more exact, the __raw_writel was actually

RE: [PATCH v17 08/13] davinci: eliminate use of IO_ADDRESS() on sysmod

2011-03-22 Thread Nori, Sekhar
On Tue, Mar 15, 2011 at 19:28:43, Hadli, Manjunath wrote: Current devices.c file has a number of instances where IO_ADDRESS() is used for system module register access. Eliminate this in favor of a ioremap() based access. Consequent to this, a new global pointer davinci_sysmodbase has been

RE: [PATCH v17 10/13] davinci: dm644x: change vpfe capture structure variables for consistency

2011-03-22 Thread Nori, Sekhar
On Tue, Mar 15, 2011 at 19:29:12, Hadli, Manjunath wrote: change the vpfe capture related configuration structure variables from config to dm644xevm_config to make it consistent with the rest of the file. This description is not fully accurate. You also have changes where you add SoC prefix to

RE: [PATCH v17 13/13] davinci: dm644x EVM: add support for VPBE display

2011-03-22 Thread Nori, Sekhar
On Tue, Mar 15, 2011 at 19:29:55, Hadli, Manjunath wrote: This patch adds support for V4L2 video display to DM6446 EVM. Support for SD and ED modes is provided, along with Composite and Component outputs. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com ---

RE: [PATCH v17 00/13] davinci vpbe: dm6446 v4l2 driver

2011-03-22 Thread Nori, Sekhar
Manju, On Tue, Mar 22, 2011 at 12:23:14, Hadli, Manjunath wrote: Sekhar, Kevin, These patches have gone through considerable reviews. Could you please ACK from your end? I have some minor comments which I have already posted and once you fix those you can add: Acked-by: Sekhar Nori

RE: [PATCH v17 12/13] davinci: dm644x: add support for v4l2 video display

2011-03-22 Thread Nori, Sekhar
On Tue, Mar 15, 2011 at 19:29:40, Hadli, Manjunath wrote: Create platform devices for various video modules like venc,osd, vpbe and v4l2 driver for dm644x. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- +struct venc_platform_data dm644x_venc_pdata = { + .venc_type =

RE: [PATCH 2/7] davinci: eliminate use of IO_ADDRESS() on sysmod

2011-03-15 Thread Nori, Sekhar
Hi Arnd, On Mon, Mar 14, 2011 at 21:51:51, Arnd Bergmann wrote: On Monday 14 March 2011, Manjunath Hadli wrote: Current devices.c file has a number of instances where IO_ADDRESS() is used for system module register access. Eliminate this in favor of a ioremap() based access.

RE: [PATCH v16 1/3] davinci vpbe: changes to common files

2011-01-18 Thread Nori, Sekhar
Hi Manju, You have got a wrong address for linux-arm-kernel ML. The right address is: linux-arm-ker...@lists.infradead.org Also, I think you need to subscribe to this list for your messages to get posted automatically. Subscription information is available here:

RE: [PATCH v13 5/8] davinci vpbe: platform specific additions

2011-01-10 Thread Nori, Sekhar
On Mon, Jan 10, 2011 at 16:58:41, Sergei Shtylyov wrote: + +#define OSD_REG_SIZE 0x01ff +#define VENC_REG_SIZE 0x017f Well, actually that's not the size but limit -- sizes should be 0x200 and 0x180 respectively... In most resource

RE: [PATCH v13 5/8] davinci vpbe: platform specific additions

2011-01-10 Thread Nori, Sekhar
On Mon, Jan 10, 2011 at 18:21:34, Hadli, Manjunath wrote: On Mon, Jan 10, 2011 at 17:25:33, Nori, Sekhar wrote: On Mon, Jan 10, 2011 at 16:58:41, Sergei Shtylyov wrote: + +#define OSD_REG_SIZE 0x01ff +#define VENC_REG_SIZE 0x017f

RE: [PATCH 5/8] davinci vpbe: platform specific additions

2011-01-10 Thread Nori, Sekhar
Hi Manju, Please CC linux-arm-ker...@lists.infradead.org for mach-davinci patches. On Mon, Jan 10, 2011 at 18:57:37, Hadli, Manjunath wrote: This patch implements the overall device creation for the Video display driver. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Acked-by:

RE: [RFC PATCH 0/2] davinci: convert to core-assisted locking

2011-01-06 Thread Nori, Sekhar
Hi Mauro, On Thu, Jan 06, 2011 at 12:10:07, Hadli, Manjunath wrote: Tested for SD loopback and other IOCTLS. Reviewed the patches. Patch series Acked by: Manjunath Hadli manjunath.ha...@ti.com Shall I add these two patches as well to the pull request I sent yesterday[1]? These changes

[GIT PATCHES FOR 2.6.38] DaVinci VPIF: Support for DV preset and DV timings and core-assisted locking (v2)

2011-01-06 Thread Nori, Sekhar
Hi Mauro, Here is an updated pull request for DV preset and DV timing support on VPIF as well as core-assisted locking support. All the changes are local to DaVinci VPIF driver. The patches have been reviewed on linux-media and acked by TI developers. Thanks, Sekhar The following changes since

[GIT PATCHES FOR 2.6.38] DaVinci VPIF: Support for DV preset and DV timings

2011-01-05 Thread Nori, Sekhar
Hi Mauro, Can you please pull from the following tree for DV preset and DV timings support for DaVinci VPIF. Sorry for the late request, but we were waiting for an ack from Manju. The patches themselves have been reviewed on the list quite a while ago. The patches affect only DaVinci VPIF video

RE: [PATCH v2 0/6] davinci vpbe: display driver for DM644X

2010-11-28 Thread Nori, Sekhar
Hi Murali, On Sat, Nov 27, 2010 at 20:14:46, Muralidharan Karicheri wrote: Manjunath, Could you re-send the patch 1/6? I can't find it either at my inbox or mailing list. I received the 1/6 in my inbox and also see it on patchwork and gmane. https://patchwork.kernel.org/patch/353081/

RE: [PATCH - v1 4/6] V4L - vpfe_capture bug fix and enhancements

2009-12-17 Thread Nori, Sekhar
On Wed, Dec 16, 2009 at 13:11:57, Hans Verkuil wrote: On Wednesday 16 December 2009 00:37:52 Karicheri, Muralidharan wrote: Hans, I remember there was a comment against an earlier patch that asks for combining such statements since it makes the function appear as big. Not sure who had

RE: [PATCH v0 1/2] V4L - vpfe capture - convert ccdc drivers to platform drivers

2009-12-03 Thread Nori, Sekhar
On Fri, Dec 04, 2009 at 01:21:43, Karicheri, Muralidharan wrote: [...] + if (!res) { + status = -EBUSY; + goto fail_nores; + } + + ccdc_base_addr = ioremap_nocache(res-start, res_len); + if (!ccdc_base_addr) { + status = -EBUSY; [Hiremath,

RE: [PATCH 1/5 - v0] V4L-vpfe capture - adding CCDC driver for DM365

2009-12-02 Thread Nori, Sekhar
Hi Murali, Here is a (styling related) review from an non-video person. The review is neither complete nor exhaustive (the patch is huge!), but I thought will send across whatever I have for you to take a look. On Wed, Dec 02, 2009 at 03:08:49, Karicheri, Muralidharan wrote: From: Muralidharan