Hi,
On Fri, May 19, 2017 at 1:08 AM, Hugues FRUCHET wrote:
> Before merging this work Hans would like to have feedback from peers, in
> order to be sure that this is inline with other SoC vendors drivers
> expectations.
>
> Thomasz, Pawel, could you give your view regarding ChromeOS and Rockchip
Hi,
On Wed, Mar 25, 2015 at 2:46 AM, Philipp Zabel wrote:
> If the last buffer was dequeued from a capture queue, let poll return
> immediately and let DQBUF return -EPIPE to signal there will no more
> buffers to dequeue until STREAMOFF.
> The driver signals the last buffer by setting the V4L2_B
Hi,
Thanks for working on this!
On Wed, Mar 25, 2015 at 2:46 AM, Philipp Zabel wrote:
> From: Peter Seiderer
>
> This v4l2_buffer flag can be used by drivers to mark a capture buffer
> as the last generated buffer, for example after a V4L2_DEC_CMD_STOP
> command was issued.
> The DocBook is upda
Hi,
On Tue, Apr 7, 2015 at 11:44 PM, Kamil Debski wrote:
> Hi,
>
> From: Hans Verkuil [mailto:hverk...@xs4all.nl]
> Sent: Tuesday, March 17, 2015 5:09 PM
>>
>> On 03/17/2015 11:46 AM, Philipp Zabel wrote:
>> > Hi,
>> >
>> > Am Freitag, den 06.03.2015, 11:18 +0100 schrieb Philipp Zabel:
>> >> At t
Hi Philipp,
On Thu, Jan 22, 2015 at 11:58 PM, Philipp Zabel wrote:
> Hi,
>
> Are you planning to pour the workshop's codec API document into a V4L2
> documentation patch?
Yes, definitely, I am a bit delayed, but will do this eventually, this
is in progress. Sorry for the delay. Please feel free
e reverse is true for dma_unmap_sg, buf_finish and the finish
> memop.
>
> To prevent unnecessary syncs we ask dma_(un)map_sg to skip the
> sync.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
> ---
> drivers/media/v4l2-core/videobuf2-dma-contig.c | 24 +++
On Tue, Nov 18, 2014 at 9:50 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Document that drivers can access/modify the buffer contents in buf_prepare
> and buf_finish. That was not clearly stated before.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
>
On Tue, Nov 18, 2014 at 9:51 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Add support for DMABUF exporting to the vb2-vmalloc implementation.
>
> All memory models now have support for both importing and exporting of
> DMABUFs.
>
> Signed-off-by: Hans Verkuil
On Tue, Nov 18, 2014 at 9:51 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Require that dma-sg also uses an allocation context. This is in preparation
> for adding prepare/finish memops to sync the memory between DMA and CPU.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel
On Tue, Nov 18, 2014 at 9:51 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Don't try to free a pointer containing an ERR_PTR().
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line &quo
direction */
> - ret = dma_map_sg(db_attach->dev, sgt->sgl, sgt->orig_nents, dma_dir);
> + /* Mapping to the client with new direction */
> + ret = dma_map_sg(db_attach->dev, sgt->sgl, sgt->orig_nents,
> +dma_dir);
Do we need this
On Mon, Nov 10, 2014 at 8:49 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Now that vb2 supports DMABUF export for dma-sg and vmalloc memory
> modes, we can enable the vb2_expbuf support in vivid.
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Pawel Osciak
> ---
>
*dbuf;
> +
> + /* DMABUF related */
> + struct dma_buf_attachment *db_attach;
Unused?
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Nov 10, 2014 at 8:49 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Pawel Osciak
> ---
> drivers/media/platform/vim2m.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/vim2m.c b/driver
On Mon, Nov 10, 2014 at 8:49 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Add DMABUF export support to vb2-dma-sg.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line "unsubscribe linu
On Mon, Nov 10, 2014 at 8:49 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Add support for importing dmabuf to videobuf2-dma-sg.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line "uns
f *conf;
> +
> + conf = kzalloc(sizeof(*conf), GFP_KERNEL);
> + if (!conf)
> + return ERR_PTR(-ENOMEM);
> +
> + conf->dev = dev;
> +
> + return conf;
> +}
> +EXPORT_SYMBOL_GPL(vb2_dma_sg_init_ctx);
> +
> +void vb2_dma_sg_cleanup_
On Mon, Nov 10, 2014 at 8:49 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> This is needed for the next patch where the dma-sg alloc memop needs
> to know the dma_dir.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
--
Best regards,
Pawel Osciak
--
To unsubscr
alue anyway it is now replaced by
> the correct dma_dir value which is unambiguous.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to ma
he dma_dir value anyway it is now replaced by
> the correct dma_dir value which is unambiguous.
Do we need the first patch adding write then? Maybe we could squash
somehow and redo the series please?
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line "unsubscribe
_direction dir)
> +{
> + /* nothing to be done here */
> +}
> +
> +static void vb2_dma_sg_dmabuf_ops_release(struct dma_buf *dbuf)
> +{
> + /* drop reference obtained in vb2_dma_sg_get_dmabuf */
> + vb2_dma_sg_put(dbuf->priv);
> +}
> +
> +static void *vb2_dma_sg_dmabuf_ops_kmap(struct dma_buf *dbuf, unsigned long
> pgnum)
> +{
> + struct vb2_dma_sg_buf *buf = dbuf->priv;
> +
> + return buf->vaddr + pgnum * PAGE_SIZE;
As opposed to contig, which assigns vaddr on alloc(), vaddr can very
well be NULL here for sg.
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Nov 8, 2014 at 7:20 PM, Pawel Osciak wrote:
> Hi Hans,
> Thank you for the patch.
>
> On Fri, Nov 7, 2014 at 5:50 PM, Hans Verkuil wrote:
>> From: Hans Verkuil
>>
>> Add support for dmabuf to vb2-dma-sg.
>
> importing dmabuf into videobuf2-dma-sg.
&g
or the dmabuf with the user device */
I'd remove this comment, it's not that correct either.
> + dba = dma_buf_attach(dbuf, buf->dev);
> + if (IS_ERR(dba)) {
> + pr_err("failed to attach dmabuf\n");
> + kfree(buf);
> +
ffer is fine.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
kfree(buf);
> }
>
> @@ -354,6 +373,27 @@ const struct vb2_mem_ops vb2_dma_sg_memops = {
> };
> EXPORT_SYMBOL_GPL(vb2_dma_sg_memops);
>
> +void *vb2_dma_sg_init_ctx(struct device *dev)
> +{
> + struct vb2_dma_sg_conf *conf;
> +
> + conf = kzalloc(sizeof(*conf), GF
t device *alloc_ctx;
>
> That simplifies the code quite a bit and I don't see and need for anything
> else. The last option would make it impossible to have different allocation
> contexts for different planes, but that might be something that Samsumg needs.
>
&
e.
Perhaps I'm missing something, but couldn't we just dma_map_sg on
allocation/get in dma-sg and unmap on put?
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
Mor
/
> +
> +static int vb2_dma_sg_map_dmabuf(void *mem_priv)
> +{
> + struct vb2_dma_sg_buf *buf = mem_priv;
> + struct sg_table *sgt;
> +
> + if (WARN_ON(!buf->db_attach)) {
> + pr_err("trying to pin a non attached buffer\n");
s/a non attached/a
a buffer, while prepare and finish should only sync.
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
gfp_t gfp_flags)
I agree with Laurent that "write" is confusing, this could be a
direction flag, but the dma direction allows bidirectional, which we
would not be using. So I would personally prefer a binary flag or
enum. So perhaps we should keep this, only documenting it please.
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Sep 4, 2014 at 4:40 AM, Vincent Palatin wrote:
> Map V4L2_CID_TILT_SPEED and V4L2_CID_PAN_SPEED to the standard UVC
> CT_PANTILT_RELATIVE_CONTROL terminal control request.
>
> Tested by plugging a Logitech ConferenceCam C3000e USB camera
> and controlling pan/tilt from the userspace using
userspace using the VIDIOC_S_CTRL ioctl.
> Verified that it can pan and tilt at the same time in both directions.
>
> Signed-off-by: Vincent Palatin
Reviewed-by: Pawel Osciak
> Change-Id: I7b70b228e5c0126683f5f0be34ffd2807f5783dc
> ---
> driv
On Sat, Aug 16, 2014 at 4:08 AM, Vincent Palatin wrote:
>
> The V4L2_CID_PAN_SPEED and V4L2_CID_TILT_SPEED controls allow to move the
> camera by setting its rotation speed around its axis.
>
> Signed-off-by: Vincent Palatin
Reviewed-by: Pawel Osciak
>
> ---
> Changes
Hi Philipp,
On Fri, Aug 22, 2014 at 10:09 PM, Philipp Zabel wrote:
> - Helping userspace to use mem2mem devices; clarification of
> encoder/decoder handling, clarification of format/size setting
> in case of dependencies between input and output formats,
> possibly broad categorisation of m
sers, mem_priv) >= 1)
> return true;
> }
> return false;
> --
> 1.7.9.5
--
Thanks,
Pawel Osciak
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Aug 7, 2014 at 12:10 AM, Vincent Palatin wrote:
>
> On Sun, Aug 3, 2014 at 10:52 PM, Pawel Osciak wrote:
> > This looks good to me in general (with one comment below). I don't think we
> > can easily implement current V4L2 pan and tilt controls that are for
>
obuf2-core.h header that explains what drivers are supposed
> to do in these situations. That should help point developers in the
> right direction if they see these warnings.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
> ---
> drivers/media/v4l2-core/videobuf2-core
Hi Laurent,
Thanks for the patch. Did you test this to work in fileio mode? Looks
like it should, but would like to make sure.
Thanks,
Pawel
On Thu, Jun 5, 2014 at 9:23 PM, Laurent Pinchart
wrote:
> When a fatal error occurs that render the device unusable, the only
> options for a driver to sign
ueue is not streaming. Buffer underruns during
> streaming are not treated specially anymore and just result in poll()
> blocking until the next event.
>
> Signed-off-by: Laurent Pinchart
> Acked-by: Hans Verkuil
Acked-by: Pawel Osciak
> ---
> drivers/media/v4l2-core/videob
Hi Kamil,
I like the solution as well. Two suggestions to consider below.
On Fri, May 16, 2014 at 9:03 PM, Kamil Debski wrote:
> MFC versions support a different set of formats, this specially applies
> to the raw YUV formats. This patch changes enum_fmt, so that it only
> reports formats that ar
M
>> To: linux-media@vger.kernel.org; linux-samsung-...@vger.kernel.org
>> Cc: k.deb...@samsung.com; s.nawro...@samsung.com; posc...@chromium.org;
>> arunkk.sams...@gmail.com
>> Subject: [PATCH] [media] s5p-mfc: Add a control for IVF format for VP8
>> encoder
>>
>>
Hi Kamil,
On Fri, May 9, 2014 at 1:22 AM, Kamil Debski wrote:
> Hi,
>
>> From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] On Behalf Of Arun
>> Kumar K
>> Sent: Friday, March 21, 2014 9:37 AM
>>
>> From: Pawel Osciak
>>
>> Currently, we alloc
t;
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 58
>
> 1 file changed, 29 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/videobuf2-core.c
> b/driver
Ah, alas, Sakari is right. This should not be needed, since we memcpy
vb->v4l2_buf to this, also overwriting bytesused.
On Thu, Apr 10, 2014 at 10:08 AM, Pawel Osciak wrote:
> On Mon, Apr 7, 2014 at 10:11 PM, Hans Verkuil wrote:
>> From: Hans Verkuil
>>
>> The b
On Mon, Apr 7, 2014 at 10:11 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> The bytesused field of struct v4l2_buffer is not used for multiplanar
> formats, so just zero it to prevent it from having some random value.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
ell, that's why the internal
> functions were created...
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 39
>
> include/media/videobuf2-core.h | 17 ++
> 2 fi
On Mon, Apr 7, 2014 at 10:11 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> This is not allowed by the spec and does in fact not make any sense.
> Return -EINVAL if this is the case.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
> ---
> drivers/media/v4
@ static size_t __vb2_perform_fileio(struct vb2_queue *q,
> char __user *data, size_
> struct vb2_fileio_buf *buf;
> int ret, index;
>
> - dprintk(3, "file io: mode %s, offset %ld, count %zd, %sblocking\n",
> + dprintk(3, "mode %s, offset %ld, count %zd, %sblocking\n",
> read ? "read" : "write", (long)*ppos, count,
> nonblock ? "non" : "");
>
> @@ -2768,7 +2765,7 @@ static size_t __vb2_perform_fileio(struct vb2_queue *q,
> char __user *data, size_
> */
> if (!q->fileio) {
> ret = __vb2_init_fileio(q, read);
> - dprintk(3, "file io: vb2_init_fileio result: %d\n", ret);
> + dprintk(3, "vb2_init_fileio result: %d\n", ret);
> if (ret)
> return ret;
> }
> @@ -2786,7 +2783,7 @@ static size_t __vb2_perform_fileio(struct vb2_queue *q,
> char __user *data, size_
> fileio->b.type = q->type;
> fileio->b.memory = q->memory;
> ret = vb2_internal_dqbuf(q, &fileio->b, nonblock);
> - dprintk(5, "file io: vb2_dqbuf result: %d\n", ret);
> + dprintk(5, "vb2_dqbuf result: %d\n", ret);
> if (ret)
> return ret;
> fileio->dq_count += 1;
> @@ -2816,14 +2813,14 @@ static size_t __vb2_perform_fileio(struct vb2_queue
> *q, char __user *data, size_
> /*
> * Transfer data to userspace.
> */
> - dprintk(3, "file io: copying %zd bytes - buffer %d, offset %u\n",
> + dprintk(3, "copying %zd bytes - buffer %d, offset %u\n",
> count, index, buf->pos);
> if (read)
> ret = copy_to_user(data, buf->vaddr + buf->pos, count);
> else
> ret = copy_from_user(buf->vaddr + buf->pos, data, count);
> if (ret) {
> - dprintk(3, "file io: error copying data\n");
> + dprintk(3, "error copying data\n");
> return -EFAULT;
> }
>
> @@ -2843,7 +2840,7 @@ static size_t __vb2_perform_fileio(struct vb2_queue *q,
> char __user *data, size_
> */
> if (read && (fileio->flags & VB2_FILEIO_READ_ONCE) &&
> fileio->dq_count == 1) {
> - dprintk(3, "file io: read limit reached\n");
> + dprintk(3, "read limit reached\n");
> return __vb2_cleanup_fileio(q);
> }
>
> @@ -2856,7 +2853,7 @@ static size_t __vb2_perform_fileio(struct vb2_queue *q,
> char __user *data, size_
> fileio->b.index = index;
> fileio->b.bytesused = buf->pos;
> ret = vb2_internal_qbuf(q, &fileio->b);
> - dprintk(5, "file io: vb2_dbuf result: %d\n", ret);
> + dprintk(5, "vb2_dbuf result: %d\n", ret);
> if (ret)
> return ret;
>
> --
> 1.9.1
>
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
t; else is able to provide this information with the write() operation.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/media/v4l2-core/videobuf2
et.
>
> All these issues were found with v4l2-compliance.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 13 -
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/media/v4l2
e in addition to the "vb2:"
> prefix. Superfluous prefixes elsewhere in the code have been removed.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 133
> +++
> 1 file changed,
; Divneil --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Best regards,
P
On Tue, Mar 11, 2014 at 6:20 AM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> q->start_streaming_called is always true, so the WARN_ON check against
> it being false can be dropped.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
> ---
> drivers/media/v4l
confusing,
since we don't check TOP/BOTTOM
anyway. I think it would be better to say why ALTERNATE doesn't make
sense instead.
> +*/
> + return -EINVAL;
> + }
>
> vb->state = VB2_BUF_STATE_PREPARING;
> vb->v4l2_buf.timestamp.tv_sec = 0
buf->pos;
> + if (set_timestamp)
> + v4l2_get_timestamp(&fileio->b.timestamp);
> ret = vb2_internal_qbuf(q, &fileio->b);
> dprintk(5, "file io: vb2_internal_qbuf result: %d\n", ret);
&g
lemented: first
> mmap, then userptr, then dmabuf.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 28 ++--
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/media/
On Mon, Apr 7, 2014 at 4:39 PM, Hans Verkuil wrote:
> On 04/07/2014 09:20 AM, Pawel Osciak wrote:
>> I'm thinking, that if we are doing this, perhaps we should just update
>> the API to allow this case, i.e. say that if the bytesused is not set
>
> With 'not se
vb2_queue *q,
> enum v4l2_buf_type type)
> int vb2_streamon(struct vb2_queue *q, enum v4l2_buf_type type)
> {
> if (q->fileio) {
> - dprintk(1, "streamon: file io in progress\n");
> + dprintk(1, "%s: file io in progress\n", __func__);
> return -EBUSY;
> }
> return vb2_internal_streamon(q, type);
> @@ -2144,7 +2150,7 @@ EXPORT_SYMBOL_GPL(vb2_streamon);
> static int vb2_internal_streamoff(struct vb2_queue *q, enum v4l2_buf_type
> type)
> {
> if (type != q->type) {
> - dprintk(1, "streamoff: invalid stream type\n");
> + dprintk(1, "%s: invalid stream type\n", __func__);
> return -EINVAL;
> }
>
> @@ -2181,7 +2187,7 @@ static int vb2_internal_streamoff(struct vb2_queue *q,
> enum v4l2_buf_type type)
> int vb2_streamoff(struct vb2_queue *q, enum v4l2_buf_type type)
> {
> if (q->fileio) {
> - dprintk(1, "streamoff: file io in progress\n");
> + dprintk(1, "%s: file io in progress\n", __func__);
> return -EBUSY;
> }
> return vb2_internal_streamoff(q, type);
> @@ -2249,7 +2255,7 @@ int vb2_expbuf(struct vb2_queue *q, struct
> v4l2_exportbuffer *eb)
> }
>
> if (eb->type != q->type) {
> - dprintk(1, "qbuf: invalid buffer type\n");
> + dprintk(1, "%s: invalid buffer type\n", __func__);
> return -EINVAL;
> }
>
> @@ -2863,7 +2869,7 @@ static size_t __vb2_perform_fileio(struct vb2_queue *q,
> char __user *data, size_
> fileio->b.index = index;
> fileio->b.bytesused = buf->pos;
> ret = vb2_internal_qbuf(q, &fileio->b);
> - dprintk(5, "file io: vb2_dbuf result: %d\n", ret);
> + dprintk(5, "file io: vb2_internal_qbuf result: %d\n", ret);
> if (ret)
> return ret;
>
> --
> 1.9.0
>
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
used
> at all and just use the buffer length instead.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 32
> +++-
> 1 file changed, 27 insertions(+), 5 deletions(-)
>
> diff --git a/drivers
nes[plane].length = dbuf->size;
>
> - if (planes[plane].length < planes[plane].data_offset +
> - q->plane_sizes[plane]) {
> + if (planes[plane].length < q->plane_sizes[plane]) {
Good catch!
> dprin
return -ERESTARTSYS;
>
> This has been updated to just call mutex_lock(). The stop_streaming op
> expects this to really stop streaming and I very much doubt this will
> work reliably if stop_streaming just returns without really stopping the
> DMA.
>
> Signed-off-b
now have enough information to determine if the op
> succeeded or not and can increment the op counter only on success. This at
> least
> makes it more robust w.r.t. future changes.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
> ---
> drivers/media/v4l2-core/video
by removing callback").
>
> Signed-off-by: Hans Verkuil
> Acked-by: Laurent Pinchart
Acked-by: Pawel Osciak
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 8 ++--
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/v4l2-c
ion where if he calls
> close() before calling streamoff() the device is kept streaming.
>
> Signed-off-by: Ricardo Ribalda Delgado
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 5 +
> 1 file changed, 5 insertions(+
@num_buffers: number of allocated/used buffers
> * @queued_list: list of buffers currently queued from userspace
> + * @queued_count: number of buffers queued and ready for streaming.
> * @owned_by_drv_count: number of buffers owned by the driver
> * @done_list: list of buffers ready to be dequeued to u
index = fileio->b.index;
> + fileio->buf_index = index = fileio->b.index;
> buf = &fileio->bufs[index];
>
> /*
> @@ -2689,6 +2691,7 @@ static size_t __vb2_perform_fileio(struct vb2_queue *q,
> char __user *dat
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 10 +-
> include/media/videobuf2-core.h | 4 ++--
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/
it's hard to reason if it's ok to do
buf_cleanup and expect mem_priv to be NULL here always.
Could we please add that inited bool into vb2_buffer to make it simpler?
> + goto err;
> + }
> +
> return 0;
> err:
> /* In case of errors, release planes that were already acquired */
> @@ -1420,11 +1459,6 @@ static int __buf_prepare(struct vb2_buffer *vb, const
> struct v4l2_buffer *b)
> ret = -EINVAL;
> }
>
> - if (!ret) {
> - ret = call_vb_qop(vb, buf_prepare, vb);
> - if (ret)
> - fail_vb_qop(vb, buf_prepare);
> - }
> if (ret)
> dprintk(1, "qbuf: buffer preparation failed: %d\n", ret);
> vb->state = ret ? VB2_BUF_STATE_DEQUEUED : VB2_BUF_STATE_PREPARED;
> --
> 1.8.4.rc3
>
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
driver cleanup
> will not happen.
>
> Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/videobuf2-core.c
> b/driver
Thanks Hans.
Acked-by: Pawel Osciak
On Thu, Feb 13, 2014 at 6:40 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Drivers need to be aware that buf_finish can be called when there is no
> streaming going on, so make a note of that.
>
> Also add a bunch of missing per
Thanks!
vb2 parts:
Acked-by: Pawel Osciak
others:
Reviewed-by: Pawel Osciak
On Thu, Feb 13, 2014 at 6:40 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> The buf_finish op should always work, so change the return type to void.
> Update the few drivers that use it. Note that bu
e balanced
with buf_queue(). I know later patches in this series will require it,
but at this point it's not true. Perhaps we should move this to the
8th patch or after it? I don't feel too strong about this though.
One more nit inline.
But in general:
Acked-by: Pawel Osciak
On Thu, Feb
Hi Arun,
On Mon, Dec 9, 2013 at 10:16 PM, Arun Kumar K wrote:
> Add v4l2 controls to set desired profile for VP8 encoder.
> Acceptable levels for VP8 encoder are
> 0: Version 0
> 1: Version 1
> 2: Version 2
> 3: Version 3
>
> Signed-off-by: Pawel Osciak
Sorry, but I&
t;>>>>Benjamin Gaignard
>> >>>>>>Guennadi Liakhovetski
>> >>>>>>Hans Verkuil
>> >>>>>>Hugues FRUCHET
>> >>>>>>Laurent Pinchart
>> >>&
Thanks Philipp.
Acked-by: Pawel Osciak
On Thu, Sep 19, 2013 at 5:30 PM, Philipp Zabel wrote:
> Hi Pawel,
>
> Am Donnerstag, den 19.09.2013, 16:54 +0900 schrieb Pawel Osciak:
>> On Thu, Sep 19, 2013 at 4:37 PM, Philipp Zabel
>> wrote:
>> > __setup_offsets fil
}
>
> - __setup_offsets(q, buffer);
> + if (memory == V4L2_MEMORY_MMAP)
> + __setup_offsets(q, buffer);
>
> dprintk(1, "Allocated %d buffers, %d plane(s) each\n",
> buffer, num_planes);
> --
> 1.8.4.rc3
>
On Tue, Sep 10, 2013 at 6:17 PM, Hans Verkuil wrote:
> On Mon 9 September 2013 11:09:57 Sylwester Nawrocki wrote:
>> On 09/09/2013 11:00 AM, Kamil Debski wrote:
>> [...]
>> We have QP controls separately for H264, H263 and MPEG4. Why is that?
>> Which one should I use for VP8? Shouldn't
On Mon, Sep 9, 2013 at 4:52 PM, Hans Verkuil wrote:
> On 09/09/2013 05:48 AM, Pawel Osciak wrote:
>> Hi Hans,
>> Thanks for the comments, one question inline.
>>
>> On Fri, Aug 30, 2013 at 3:48 PM, Hans Verkuil wrote:
>>> On 08/30/2013 04:17 AM, Pawel Osciak
Hi Hans,
Thanks for the comments, one question inline.
On Fri, Aug 30, 2013 at 3:48 PM, Hans Verkuil wrote:
> On 08/30/2013 04:17 AM, Pawel Osciak wrote:
>> Add defines for controls found in UVC 1.5 encoding cameras.
>>
>> Signed-off-by: Pawel Osciak
>> ---
>&
On Fri, Sep 6, 2013 at 10:45 PM, Laurent Pinchart
wrote:
>
> Hi Hugues,
>
> On Thursday 05 September 2013 13:37:49 Hugues FRUCHET wrote:
> > Hi Mauro,
> >
> > For floating point issue, we have not encountered such issue while
> > integrating various codec (currently H264, MPEG4, VP8 of both Google
Add encoding unit definitions and descriptor parsing code and allow them to
be added to chains.
Signed-off-by: Pawel Osciak
---
drivers/media/usb/uvc/uvc_ctrl.c | 37 ++---
drivers/media/usb/uvc/uvc_driver.c | 67 +-
drivers/media/usb/uvc
Signed-off-by: Pawel Osciak
---
drivers/media/usb/uvc/uvc_ctrl.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c
index b0a19b9..a0493d6 100644
--- a/drivers/media/usb/uvc/uvc_ctrl.c
+++ b/drivers/media
vices/systems.
Thanks,
Pawel Osciak
Pawel Osciak (19):
uvcvideo: Add UVC query tracing.
uvcvideo: Return 0 when setting probe control succeeds.
uvcvideo: Add support for multiple chains with common roots.
uvcvideo: Create separate debugfs entries for each streaming interface.
Add detection and parsing of VP8 format and frame descriptors and
reorganize format parsing code.
Signed-off-by: Pawel Osciak
---
drivers/media/usb/uvc/uvc_driver.c | 120 -
drivers/media/usb/uvc/uvcvideo.h | 4 +-
include/uapi/linux/usb/video.h | 8
These controls allow modifying encoding parameters.
Signed-off-by: Pawel Osciak
---
drivers/media/usb/uvc/uvc_ctrl.c | 445 +++
include/uapi/linux/usb/video.h | 23 ++
2 files changed, 468 insertions(+)
diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b
Signed-off-by: Pawel Osciak
---
drivers/media/usb/uvc/uvc_video.c | 18 +-
drivers/media/usb/uvc/uvcvideo.h | 10 ++
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/uvc/uvc_video.c
b/drivers/media/usb/uvc/uvc_video.c
index 59f57a2
ins.
Also extract control locking into __uvc_ctrl_{lock,unlock} functions.
Signed-off-by: Pawel Osciak
---
drivers/media/usb/uvc/uvc_ctrl.c | 70 -
drivers/media/usb/uvc/uvc_driver.c | 210 +
drivers/media/usb/uvc/uvc_entity.c | 15 ++-
drivers
Add common error handling paths for format parsing failures.
Signed-off-by: Pawel Osciak
---
drivers/media/usb/uvc/uvc_driver.c | 35 ++-
1 file changed, 14 insertions(+), 21 deletions(-)
diff --git a/drivers/media/usb/uvc/uvc_driver.c
b/drivers/media/usb/uvc
Add bits for previous, golden and altref frame types.
Signed-off-by: Pawel Osciak
---
include/uapi/linux/videodev2.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index 437f1b0..c011ee0 100644
--- a/include/uapi/linux
Return 0 instead of returning size of the probe control on successful set.
Signed-off-by: Pawel Osciak
---
drivers/media/usb/uvc/uvc_video.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/usb/uvc/uvc_video.c
b/drivers/media/usb/uvc/uvc_video.c
index 695f6d9..1198989 100644
Create a separate function for parsing UVC payload headers and extract code
from other functions into it. Store the parsed values in a header struct.
Signed-off-by: Pawel Osciak
---
drivers/media/usb/uvc/uvc_video.c | 270 +++---
drivers/media/usb/uvc/uvcvideo.h
Signed-off-by: Pawel Osciak
---
drivers/media/usb/uvc/uvc_ctrl.c | 62
1 file changed, 37 insertions(+), 25 deletions(-)
diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c
index 72d6724..d735c88 100644
--- a/drivers/media
Add a new trace argument enabling UVC query details and contents logging.
Signed-off-by: Pawel Osciak
---
drivers/media/usb/uvc/uvc_video.c | 45 +--
drivers/media/usb/uvc/uvcvideo.h | 9
2 files changed, 38 insertions(+), 16 deletions(-)
diff
Add support for UVC 1.5 Probe & Commit control.
Signed-off-by: Pawel Osciak
---
drivers/media/usb/uvc/uvc_video.c | 52 ---
include/uapi/linux/usb/video.h| 7 ++
2 files changed, 55 insertions(+), 4 deletions(-)
diff --git a/drivers/media/usb
camera capabilities.
Signed-off-by: Pawel Osciak
---
include/uapi/linux/videodev2.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index c011ee0..8b0d4ad 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux
UVC 1.5 introduces the concept of runtime controls, which can be set during
streaming. Non-runtime controls can only be changed while device is idle.
Signed-off-by: Pawel Osciak
---
drivers/media/usb/uvc/uvc_ctrl.c | 45 +---
drivers/media/usb/uvc/uvc_v4l2.c
Add defines for controls found in UVC 1.5 encoding cameras.
Signed-off-by: Pawel Osciak
---
drivers/media/v4l2-core/v4l2-ctrls.c | 29 +
include/uapi/linux/v4l2-controls.h | 31 +++
2 files changed, 60 insertions(+)
diff --git a/drivers
Add interface number to debugfs entry name to be able to create separate
entries for each streaming interface for devices exposing more than one,
instead of failing to create more than one.
Signed-off-by: Pawel Osciak
---
drivers/media/usb/uvc/uvc_debugfs.c | 3 ++-
1 file changed, 2 insertions
Move getting the first buffer from the current queue to a uvc_queue function
and out of the USB completion handler.
Signed-off-by: Pawel Osciak
---
drivers/media/usb/uvc/uvc_isight.c | 6 --
drivers/media/usb/uvc/uvc_queue.c | 14 ++
drivers/media/usb/uvc/uvc_video.c | 29
John, thanks for the patch.
On Thu, May 23, 2013 at 5:41 PM, John Sheu wrote:
> Save flags correctly when taking spinlocks in v4l2_m2m_try_schedule.
>
> Signed-off-by: John Sheu
Acked-by: Pawel Osciak
> ---
> drivers/media/v4l2-core/v4l2-mem2mem.c | 19 +++
&g
1 - 100 of 354 matches
Mail list logo
