Re: [PATCH v4 9/9] drm/bridge: cdns: Convert to phy framework

2019-01-17 Thread Sean Paul
ff-by: Maxime Ripard Aside from the wakeup change mentioned in patch 8, Acked-by: Sean Paul > --- > drivers/gpu/drm/bridge/Kconfig| 1 +- > drivers/gpu/drm/bridge/cdns-dsi.c | 485 +++ > drivers/phy/cadence/cdns-dphy.c | 2 +- > 3 files chang

Re: [PATCH v4 8/9] phy: Add Cadence D-PHY support

2019-01-17 Thread Sean Paul
evm_clk_get(&pdev->dev, "pll_ref"); > + if (IS_ERR(dphy->pll_ref_clk)) > + return PTR_ERR(dphy->pll_ref_clk); > + > + if (dphy->ops->probe) { > + ret = dphy->ops->probe(dphy); > + if (ret) >

Re: [PATCH v4 6/9] drm/bridge: cdns: Separate DSI and D-PHY configuration

2019-01-17 Thread Sean Paul
id(struct drm_bridge *bridge, > if ((mode->hdisplay * bpp) % 32) > return MODE_H_ILLEGAL; > > - nlanes = output->dev->lanes; > - > - ret = cdns_dsi_mode2cfg(dsi, mode, &dsi_cfg, &dphy_cfg, true); > + ret = cdns_dsi_check_conf(dsi, mode, &dsi_cfg, &dphy_cfg, true); > if (ret) > - return MODE_CLOCK_RANGE; > + return MODE_BAD; > > return MODE_OK; > } > @@ -990,7 +1030,7 @@ static void cdns_dsi_bridge_enable(struct drm_bridge > *bridge) > bpp = mipi_dsi_pixel_format_to_bpp(output->dev->format); > nlanes = output->dev->lanes; > > - WARN_ON_ONCE(cdns_dsi_mode2cfg(dsi, mode, &dsi_cfg, &dphy_cfg, false)); > + WARN_ON_ONCE(cdns_dsi_check_conf(dsi, mode, &dsi_cfg, &dphy_cfg, > false)); > > cdns_dsi_hs_init(dsi, &dphy_cfg); > cdns_dsi_init_link(dsi); > -- > git-series 0.9.1 -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v2 1/5] media: cec-notifier: Get notifier by device and connector name

2018-05-18 Thread Sean Paul
t; + * > + * If it doesn't exist, then allocate a new notifier struct and return a > + * pointer to that new struct. You might also want to cover the case where you have multiple named notifiers for the same device. It looks like it just grabs the first one? Sean > + * > + * Return NULL if the memory could not be allocated. > + */ > +static inline struct cec_notifier *cec_notifier_get(struct device *dev) > +{ > + return cec_notifier_get_conn(dev, NULL); > +} > + > +/** > * cec_notifier_phys_addr_invalidate() - set the physical address to INVALID > * > * @n: the CEC notifier > -- > 2.7.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [Outreachy kernel] [PATCH] Staging: media: imx: Prefer using BIT macro

2017-09-08 Thread Sean Paul
On Fri, Sep 8, 2017 at 11:11 AM, Srishti Sharma wrote: > Use BIT(x) instead of (1< > Signed-off-by: Srishti Sharma > --- > drivers/staging/media/imx/imx-media.h | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/media/imx/imx-media.h > b/dr

Re: [PATCH 1/3] drm: add support for DisplayPort CEC-Tunneling-over-AUX

2017-08-10 Thread Sean Paul
m/drm_dp_helper.h > +++ b/include/drm/drm_dp_helper.h > @@ -952,6 +952,8 @@ struct drm_dp_aux_msg { > size_t size; > }; > > +struct cec_adapter; > + > /** > * struct drm_dp_aux - DisplayPort AUX channel > * @name: user-visible name of this AUX channel and the I2C-over-AUX adapter > @@ -1010,6 +1012,10 @@ struct drm_dp_aux { >* @i2c_defer_count: Counts I2C DEFERs, used for DP validation. >*/ > unsigned i2c_defer_count; > + /** > + * @cec_adap: the CEC adapter for CEC-Tunneling-over-AUX support. > + */ > + struct cec_adapter *cec_adap; > }; > > ssize_t drm_dp_dpcd_read(struct drm_dp_aux *aux, unsigned int offset, > @@ -1132,4 +1138,22 @@ drm_dp_has_quirk(const struct drm_dp_desc *desc, enum > drm_dp_quirk quirk) > return desc->quirks & BIT(quirk); > } > > +#ifdef CONFIG_DRM_DP_CEC > +bool drm_dp_cec_irq(struct drm_dp_aux *aux); > +int drm_dp_cec_configure_adapter(struct drm_dp_aux *aux, const char *name, > + struct device *parent); > +#else > +static inline bool drm_dp_cec_irq(struct drm_dp_aux *aux) > +{ > + return false; > +} > + > +static inline int drm_dp_cec_configure_adapter(struct drm_dp_aux *aux, > +const char *name, > +struct device *parent) > +{ > + return -ENODEV; > +} > +#endif > + > #endif /* _DRM_DP_HELPER_H_ */ > -- > 2.11.0 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] dma-buf/sw_sync: Fix timeline/pt overflow cases

2017-06-28 Thread Sean Paul
On Wed, Jun 28, 2017 at 08:45:55PM +0100, Chris Wilson wrote: > Quoting Sean Paul (2017-06-28 17:47:24) > > On Wed, Jun 28, 2017 at 05:00:20PM +0100, Chris Wilson wrote: > > > Quoting Sean Paul (2017-06-28 16:51:11) > > > > Protect against long-running processes

Re: [PATCH] dma-buf/sw_sync: Fix timeline/pt overflow cases

2017-06-28 Thread Sean Paul
On Wed, Jun 28, 2017 at 05:00:20PM +0100, Chris Wilson wrote: > Quoting Sean Paul (2017-06-28 16:51:11) > > Protect against long-running processes from overflowing the timeline > > and creating fences that go back in time. While we're at it, avoid > > overflowing wh

[PATCH] dma-buf/sw_sync: Fix timeline/pt overflow cases

2017-06-28 Thread Sean Paul
Protect against long-running processes from overflowing the timeline and creating fences that go back in time. While we're at it, avoid overflowing while we're incrementing the timeline. Signed-off-by: Sean Paul --- drivers/dma-buf/sw_sync.c | 7 ++- 1 file changed, 6 insert

[PULL] Synopsys Media Formats

2017-04-03 Thread Sean Paul
rtions(+), 1023 deletions(-) -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v3 1/1] video: drm: exynos: Adds display-timing node parsing using video helper function

2013-02-01 Thread Sean Paul
On Fri, Feb 1, 2013 at 6:59 AM, Vikas Sajjan wrote: > This patch adds display-timing node parsing using video helper function > > Signed-off-by: Leela Krishna Amudala > Signed-off-by: Vikas Sajjan > --- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 39 > +++--- > 1 fil

Re: [PATCH v2 1/1] video: drm: exynos: Adds display-timing node parsing using video helper function

2013-01-30 Thread Sean Paul
On Wed, Jan 30, 2013 at 1:30 AM, Vikas Sajjan wrote: > This patch adds display-timing node parsing using video helper function > > Signed-off-by: Leela Krishna Amudala > Signed-off-by: Vikas Sajjan > --- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 38 > +++--- > 1 fi

Re: [PATCH] video: drm: exynos: Adds display-timing node parsing using video helper function

2013-01-28 Thread Sean Paul
On Mon, Jan 28, 2013 at 12:02 PM, Leela Krishna Amudala wrote: > On Mon, Jan 28, 2013 at 9:24 PM, Sean Paul wrote: >> >> On Mon, Jan 28, 2013 at 12:45 AM, Vikas Sajjan >> wrote: >> > This patch adds display-timing node parsing using video helper function >>

Re: [PATCH] video: drm: exynos: Adds display-timing node parsing using video helper function

2013-01-28 Thread Sean Paul
On Mon, Jan 28, 2013 at 12:45 AM, Vikas Sajjan wrote: > This patch adds display-timing node parsing using video helper function > > Signed-off-by: Leela Krishna Amudala > Signed-off-by: Vikas Sajjan > --- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 35 > -- > 1 f

Re: [PATCH] [RFC] video: exynos dp: Making Exynos DP Compliant with CDF

2013-01-11 Thread Sean Paul
On Fri, Jan 11, 2013 at 5:35 AM, Leela Krishna Amudala wrote: > The Exynos DP transmitter is treated as an end entity in the display pipeline > and made this RFC patch compliant with CDF. > > Any suggestions are welcome. > A few comments below. It's hard to get too much of an appreciation for wha