Re: [PATCH] [media] exynos-gsc: Remove PM_RUNTIME dependency

2014-07-22 Thread Shaik Ameer Basha
Hi Sachin, Thanks for testing. Even I tested with both PM enable/disable with EXYNOS_IOMMU. I didn't face any issues. Let me check with out IOMMU. I will update the status soon. Regards, Shaik Ameer Basha On Tue, Jul 22, 2014 at 10:31 AM, Sachin Kamat spk.li...@gmail.com wrote: Hi Shaik

[PATCH] [media] exynos-gsc: Remove PM_RUNTIME dependency

2014-07-20 Thread Shaik Ameer Basha
to be Turned ON before powering on/off the Gscaler power domain. This dependency is taken care by this patch at driver level. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-gsc/gsc-core.c | 10 ++ drivers/media/platform/exynos-gsc/gsc-m2m.c

Re: [PATCH 3/4] gsc-m2m: report correct format bytesperline and sizeimage

2014-04-08 Thread Shaik Ameer Basha
) if ((fmt-corder == GSC_CRCB) (fmt-num_planes == 3)) I think it shoud only applicable to 3 component formats. for example, Incase of two component formats like V4L2_PIX_FMT_NV61, chroma base address becomes zero. Regards, Shaik Ameer Basha swap(addr-cb, addr-cr

Re: [PATCH 3/4] gsc-m2m: report correct format bytesperline and sizeimage

2014-04-08 Thread Shaik Ameer Basha
On Tue, Apr 8, 2014 at 12:26 PM, Shaik Ameer Basha shaik.sams...@gmail.com wrote: Hi John Sheu, Thanks for the patch. Please find the review comments inline. On Wed, Mar 12, 2014 at 4:22 AM, John Sheu s...@google.com wrote: Explicitly specify sampling period for subsampled chroma formats

Re: [PATCH v6 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2014-03-20 Thread Shaik Ameer Basha
Ameer Basha On Wed, Mar 19, 2014 at 1:19 PM, Hans Verkuil hverk...@xs4all.nl wrote: Thanks for this patch series! I've got some comments below... Regards, Hans On 03/19/2014 08:13 AM, Shaik Ameer Basha wrote: This patch adds memory to memory (m2m) interface functionality

[PATCH v6 0/4] Exynos5 Series SCALER Driver

2014-03-19 Thread Shaik Ameer Basha
documentation. 3] Removed the unnecessary header file inclusions. 4] Fix the condition check in mscl_prepare_address for swapping cb/cr addresses. Shaik Ameer Basha (4): [media] exynos-scaler: Add DT bindings for SCALER driver [media] exynos-scaler: Add new driver for Exynos5 SCALER [media] exynos

[PATCH v6 1/4] [media] exynos-scaler: Add DT bindings for SCALER driver

2014-03-19 Thread Shaik Ameer Basha
This patch adds the DT binding documentation for the Exynos5420/5410 based SCALER device driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com --- .../devicetree/bindings/media/exynos5-scaler.txt | 24 1

[PATCH v6 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2014-03-19 Thread Shaik Ameer Basha
This patch adds memory to memory (m2m) interface functionality for the SCALER driver. [arun...@samsung.com: fix compilation issues] Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com

[PATCH v6 4/4] [media] exynos-scaler: Add core functionality for the SCALER driver

2014-03-19 Thread Shaik Ameer Basha
This patch adds the Makefile and core functionality for the SCALER driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com --- drivers/media/platform/Kconfig|8 + drivers/media/platform/Makefile

[PATCH v6 2/4] [media] exynos-scaler: Add new driver for Exynos5 SCALER

2014-03-19 Thread Shaik Ameer Basha
- Input : 16x16 to 8192x8192 - Output: 4x4 to 8192x8192 Size - Exynos5410 - Input/Output: 4x4 to 4096x4096 alpha blending, color fill Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com --- drivers/media

Re: [PATCH v5 4/4] [media] exynos-scaler: Add DT bindings for SCALER driver

2014-01-30 Thread Shaik Ameer Basha
Hi Tomasz, Thanks for the review. Will consider all your comments in the next version of patch series. Regards, Shaik Ameer Basha On Sat, Jan 25, 2014 at 1:09 AM, Tomasz Figa t.f...@samsung.com wrote: Hi Shaik, On 09.01.2014 04:28, Shaik Ameer Basha wrote: This patch adds the DT binding

Re: [PATCH v5 4/4] [media] exynos-scaler: Add DT bindings for SCALER driver

2014-01-20 Thread Shaik Ameer Basha
:) Definitely, I will send the users patches once the driver gets merged. And I will address all your comments in next version of patch series. Regards, Shaik Ameer Basha On Thu, Jan 9, 2014 at 6:20 PM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Hi, On Thursday, January 09, 2014 08:58:14

[PATCH v5 1/4] [media] exynos-scaler: Add new driver for Exynos5 SCALER

2014-01-08 Thread Shaik Ameer Basha
- Input : 16x16 to 8192x8192 - Output: 4x4 to 8192x8192 Size - Exynos5410 - Input/Output: 4x4 to 4096x4096 alpha blending, color fill Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com --- drivers/media

[PATCH v5 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2014-01-08 Thread Shaik Ameer Basha
This patch adds the Makefile and memory to memory (m2m) interface functionality for the SCALER driver. [arun...@samsung.com: fix compilation issues] Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro

[PATCH v5 2/4] [media] exynos-scaler: Add core functionality for the SCALER driver

2014-01-08 Thread Shaik Ameer Basha
This patch adds the core functionality for the SCALER driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com --- drivers/media/platform/exynos-scaler/scaler.c | 1231 + drivers/media/platform/exynos-scaler

[PATCH v5 0/4] Exynos5 Series SCALER Driver

2014-01-08 Thread Shaik Ameer Basha
patches. 2] Added DT binding documentation. 3] Removed the unnecessary header file inclusions. 4] Fix the condition check in mscl_prepare_address for swapping cb/cr addresses. Shaik Ameer Basha (4): [media] exynos-scaler: Add new driver for Exynos5 SCALER [media] exynos-scaler: Add core

[PATCH v5 4/4] [media] exynos-scaler: Add DT bindings for SCALER driver

2014-01-08 Thread Shaik Ameer Basha
This patch adds the DT binding documentation for the Exynos5420/5410 based SCALER device driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com --- .../devicetree/bindings/media/exynos5-scaler.txt | 22 1

Re: [PATCH v4 1/4] [media] exynos-scaler: Add new driver for Exynos5 SCALER

2014-01-06 Thread Shaik Ameer Basha
Hi Mauro, Thanks for the review comments. On Fri, Jan 3, 2014 at 1:48 AM, Mauro Carvalho Chehab m.che...@samsung.com wrote: Em Fri, 4 Oct 2013 17:56:31 +0530 Shaik Ameer Basha shaik.am...@samsung.com escreveu: This patch adds support for SCALER device which is a new device for scaling

Re: [PATCH v4 2/4] [media] exynos-scaler: Add core functionality for the SCALER driver

2014-01-06 Thread Shaik Ameer Basha
Hi Mauro, Thanks for the reveiw. On Fri, Jan 3, 2014 at 1:55 AM, Mauro Carvalho Chehab m.che...@samsung.com wrote: Em Fri, 4 Oct 2013 17:56:32 +0530 Shaik Ameer Basha shaik.am...@samsung.com escreveu: This patch adds the core functionality for the SCALER driver. Signed-off-by: Shaik Ameer

Re: [PATCH v4 1/4] [media] exynos-scaler: Add new driver for Exynos5 SCALER

2013-10-20 Thread Shaik Ameer Basha
on travel and I don't have the environment to rebase and test this driver. I will address your comments in follow up patches. Can you please queue this driver to your branch and send a pull request for 3.13 ? Regards, Shaik Ameer Basha On 04/10/13 14:26, Shaik Ameer Basha wrote: This patch adds

[PATCH v4 0/4] Exynos5 Series SCALER Driver

2013-10-04 Thread Shaik Ameer Basha
single patch into multiple patches. 2] Added DT binding documentation. 3] Removed the unnecessary header file inclusions. 4] Fix the condition check in mscl_prepare_address for swapping cb/cr addresses. Shaik Ameer Basha (4): [media] exynos-scaler: Add new driver for Exynos5 SCALER [media] exynos

[PATCH v4 4/4] [media] exynos-scaler: Add DT bindings for SCALER driver

2013-10-04 Thread Shaik Ameer Basha
This patch adds the DT binding documentation for the Exynos5420/5410 based SCALER device driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- .../devicetree/bindings/media/exynos5-scaler.txt | 22 1 file changed, 22 insertions(+) create mode 100644

[PATCH v4 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-10-04 Thread Shaik Ameer Basha
This patch adds the Makefile and memory to memory (m2m) interface functionality for the SCALER driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/Kconfig|8 + drivers/media/platform/Makefile |1 + drivers

[PATCH v4 1/4] [media] exynos-scaler: Add new driver for Exynos5 SCALER

2013-10-04 Thread Shaik Ameer Basha
- Input : 16x16 to 8192x8192 - Output: 4x4 to 8192x8192 Size - Exynos5410 - Input/Output: 4x4 to 4096x4096 alpha blending, color fill Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-scaler/scaler-regs.c | 336

[PATCH v4 2/4] [media] exynos-scaler: Add core functionality for the SCALER driver

2013-10-04 Thread Shaik Ameer Basha
This patch adds the core functionality for the SCALER driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-scaler/scaler.c | 1238 + drivers/media/platform/exynos-scaler/scaler.h | 375 2 files changed, 1613

Re: [PATCH v3 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-09-30 Thread Shaik Ameer Basha
Hi Hans, Thanks for pointing it out. On Mon, Sep 30, 2013 at 1:38 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Shaik, I have a few questions regarding the selection part... On 09/12/2013 03:09 PM, Shaik Ameer Basha wrote: This patch adds the Makefile and memory to memory (m2m) interface

Re: [PATCH v3 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-09-30 Thread Shaik Ameer Basha
Hi Hans, On Mon, Sep 30, 2013 at 4:02 PM, Hans Verkuil hverk...@xs4all.nl wrote: On 09/30/2013 11:32 AM, Shaik Ameer Basha wrote: Hi Hans, Thanks for pointing it out. On Mon, Sep 30, 2013 at 1:38 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Shaik, I have a few questions regarding

Re: [PATCH v3 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-09-30 Thread Shaik Ameer Basha
On Mon, Sep 30, 2013 at 4:18 PM, Shaik Ameer Basha shaik.sams...@gmail.com wrote: Hi Hans, On Mon, Sep 30, 2013 at 4:02 PM, Hans Verkuil hverk...@xs4all.nl wrote: On 09/30/2013 11:32 AM, Shaik Ameer Basha wrote: Hi Hans, Thanks for pointing it out. On Mon, Sep 30, 2013 at 1:38 PM, Hans

[PATCH] [media] v4l2-mem2mem: Don't schedule the context if abort job is called

2013-09-20 Thread Shaik Ameer Basha
in the v4l2_m2m_job_finish(). Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/v4l2-core/v4l2-mem2mem.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c index 7c43712..d5741be

[PATCH] [media] exynos-gsc: Handle ctx job finish when aborted

2013-09-20 Thread Shaik Ameer Basha
are not getting scheduled. By adding the ABORT state, driver can understand the current job is aborted and not finished. By checking this flag, driver can call v4l2_m2m_job_finish() with VB2_BUF_STATE_ERROR. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com Signed-off-by: avnd kiran avnd.ki

Re: [PATCH v3 2/4] [media] exynos-scaler: Add core functionality for the SCALER driver

2013-09-17 Thread Shaik Ameer Basha
) + return ret; + + scaler_sw_reset(scaler); + + return scaler_m2m_resume(scaler); Shouldn't there be clk_disable() when this function fails ? this funciton scaler_m2m_resume() never fails. Regards, Shaik Ameer Basha -- To unsubscribe from this list: send the line

Re: [PATCH v3 2/4] [media] exynos-scaler: Add core functionality for the SCALER driver

2013-09-17 Thread Shaik Ameer Basha
of +16 offset for output small spelling mistake here.. YCbCr to RGB : Zero offset or -16 offset for input RGB to YCbCr : Zero offset or +16 offset for output Regards, Shaik Ameer Basha I think user should provide this information through some controls. Anyways, will take it later

Re: [PATCH RFC 6/7] exynos-gsc: Use mem-to-mem ioctl helpers

2013-09-13 Thread Shaik Ameer Basha
= v4l2_m2m_ioctl_reqbufs, I think your intention was not to replace gsc_m2m_reqbufs() with v4l2_m2m_ioctl_reqbufs(). you didn't remove the gsc_m2m_reqbufs() function :) On top of that, gsc_m2m_reqbufs() has some buffer count related checks. Regards, Shaik Ameer Basha + .vidioc_querybuf

[PATCH v3 2/4] [media] exynos-scaler: Add core functionality for the SCALER driver

2013-09-12 Thread Shaik Ameer Basha
This patch adds the core functionality for the SCALER driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-scaler/scaler.c | 1261 + drivers/media/platform/exynos-scaler/scaler.h | 385 2 files changed, 1646

[PATCH v3 4/4] [media] exynos-scaler: Add DT bindings for SCALER driver

2013-09-12 Thread Shaik Ameer Basha
This patch adds the DT binding documentation for the Exynos5420/5410 based SCALER device driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- .../devicetree/bindings/media/exynos5-scaler.txt | 22 1 file changed, 22 insertions(+) create mode 100644

[PATCH v3 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-09-12 Thread Shaik Ameer Basha
This patch adds the Makefile and memory to memory (m2m) interface functionality for the SCALER driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/Kconfig|8 + drivers/media/platform/Makefile |1 + drivers

[PATCH v3 1/4] [media] exynos-scaler: Add new driver for Exynos5 SCALER

2013-09-12 Thread Shaik Ameer Basha
- Input : 16x16 to 8192x8192 - Output: 4x4 to 8192x8192 Size - Exynos5410 - Input/Output: 4x4 to 4096x4096 alpha blending, color fill Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-scaler/scaler-regs.c | 334

Re: [PATCH v2 3/5] [media] exynos-mscl: Add m2m functionality for the M-Scaler driver

2013-09-10 Thread Shaik Ameer Basha
Hi Sylwester, Almost all of the comments are already addressed. Will try to post the v3 by tomorrow. I have one doubt? Do I need to rebase this driver on m2m-helpers-v2 or once the driver is merged we can take this up? Regards, Shaik Ameer Basha On Thu, Aug 29, 2013 at 6:51 PM, Sylwester

Re: [PATCH v2 5/5] [media] exynos-mscl: Add Makefile for M-Scaler driver

2013-08-29 Thread Shaik Ameer Basha
Hi Sylwester, On Thu, Aug 29, 2013 at 3:42 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi Shaik, On 08/19/2013 12:58 PM, Shaik Ameer Basha wrote: This patch adds the Makefile for the M-Scaler (M2M scaler). Perhaps we could combine this with patch 3/5 ? Ok. I will do that. are you

Re: [PATCH v2 4/5] [media] exynos-mscl: Add DT bindings for M-Scaler driver

2013-08-26 Thread Shaik Ameer Basha
sylvester.nawro...@gmail.com wrote: On 08/19/2013 02:57 PM, Inki Dae wrote: -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Shaik Ameer Basha Sent: Monday, August 19, 2013 7:59 PM To: linux-media@vger.kernel.org; linux-samsung

Re: [PATCH v2 2/5] [media] exynos-mscl: Add core functionality for the M-Scaler driver

2013-08-20 Thread Shaik Ameer Basha
On Tue, Aug 20, 2013 at 11:57 AM, Hans Verkuil hverk...@xs4all.nl wrote: On 08/20/2013 07:43 AM, Shaik Ameer Basha wrote: + linux-media, linux-samsung-soc Hi Hans, Thanks for the review. Will address all your comments in v3. I have only one doubt regarding try_ctrl... (addressed inline

Re: [PATCH v2 1/5] [media] exynos-mscl: Add new driver for M-Scaler

2013-08-20 Thread Shaik Ameer Basha
Hi Inki Dae, Thanks for the review. On Mon, Aug 19, 2013 at 6:18 PM, Inki Dae inki@samsung.com wrote: Just quick review. -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Shaik Ameer Basha Sent: Monday, August

Re: [PATCH v2 1/5] [media] exynos-mscl: Add new driver for M-Scaler

2013-08-20 Thread Shaik Ameer Basha
On Tue, Aug 20, 2013 at 2:13 PM, Inki Dae inki@samsung.com wrote: -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Shaik Ameer Basha Sent: Tuesday, August 20, 2013 5:07 PM To: Inki Dae Cc: Shaik Ameer Basha

[PATCH v2 1/5] [media] exynos-mscl: Add new driver for M-Scaler

2013-08-19 Thread Shaik Ameer Basha
: 16x16 to 8192x8192 - Output: 4x4 to 8192x8192 alpha blending, color fill Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-mscl/mscl-regs.c | 318 drivers/media/platform/exynos-mscl/mscl-regs.h | 282

[PATCH v2 2/5] [media] exynos-mscl: Add core functionality for the M-Scaler driver

2013-08-19 Thread Shaik Ameer Basha
This patch adds the core functionality for the M-Scaler driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-mscl/mscl-core.c | 1312 drivers/media/platform/exynos-mscl/mscl-core.h | 549 ++ 2 files changed, 1861

[PATCH v2 4/5] [media] exynos-mscl: Add DT bindings for M-Scaler driver

2013-08-19 Thread Shaik Ameer Basha
This patch adds the DT binding documentation for the exynos5 based M-Scaler device driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- .../devicetree/bindings/media/exynos5-mscl.txt | 34 1 file changed, 34 insertions(+) create mode 100644

[PATCH v2 0/5] Exynos5 M-Scaler Driver

2013-08-19 Thread Shaik Ameer Basha
documentation. 3] Removed the unnecessary header file inclusions. 4] Fix the condition check in mscl_prepare_address for swapping cb/cr addresses. Shaik Ameer Basha (5): [media] exynos-mscl: Add new driver for M-Scaler [media] exynos-mscl: Add core functionality for the M-Scaler driver [media

[PATCH v2 5/5] [media] exynos-mscl: Add Makefile for M-Scaler driver

2013-08-19 Thread Shaik Ameer Basha
This patch adds the Makefile for the M-Scaler (M2M scaler). Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/Kconfig |8 drivers/media/platform/Makefile |1 + drivers/media/platform/exynos-mscl/Makefile |3 +++ 3

[PATCH v2 3/5] [media] exynos-mscl: Add m2m functionality for the M-Scaler driver

2013-08-19 Thread Shaik Ameer Basha
This patch adds the memory to memory (m2m) interface functionality for the M-Scaler driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-mscl/mscl-m2m.c | 763 + 1 file changed, 763 insertions(+) create mode 100644 drivers

Re: [PATCH v2 2/5] [media] exynos-mscl: Add core functionality for the M-Scaler driver

2013-08-19 Thread Shaik Ameer Basha
+ linux-media, linux-samsung-soc Hi Hans, Thanks for the review. Will address all your comments in v3. I have only one doubt regarding try_ctrl... (addressed inline) On Mon, Aug 19, 2013 at 6:36 PM, Hans Verkuil hverk...@xs4all.nl wrote: On 08/19/2013 12:58 PM, Shaik Ameer Basha wrote

Re: [PATCH v2 0/5] Exynos5 M-Scaler Driver

2013-08-19 Thread Shaik Ameer Basha
Hi Inki Dae, Thanks for the review. On Mon, Aug 19, 2013 at 5:56 PM, Inki Dae inki@samsung.com wrote: -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Shaik Ameer Basha Sent: Monday, August 19, 2013 7:59 PM

[PATCH] [media] v4l2-mem2mem: clear m2m context from job_queue before ctx streamoff

2013-08-13 Thread Shaik Ameer Basha
] If the current context is queued, then the context will be removed from the job_queue. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/v4l2-core/v4l2-mem2mem.c | 59 1 file changed, 38 insertions(+), 21 deletions(-) diff --git a/drivers

[RFC v2 0/6] Adding media device driver for Exynos5 imaging subsystem

2013-04-24 Thread Shaik Ameer Basha
to pipeline0 will be added later. Once the fimc-is device driver is posted, one more pipeline (pipeline1) will be added for exynos5 media device driver for fimc-is sub-devices. This patchset is rebased on: git://linuxtv.org/snawrocki/samsung.git:for_v3.10_2 Shaik Ameer Basha (6): media: exynos4

[RFC v2 1/6] media: exynos4-is: modify existing mdev to use common pipeline

2013-04-24 Thread Shaik Ameer Basha
series media device drivers. 2] Modifies the existing exynos4-is media device driver to use the updated common pipeline implementation. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos4-is/fimc-capture.c | 47 -- drivers/media/platform/exynos4-is/fimc

[RFC v2 2/6] fimc-lite: Adding Exynos5 compatibility to fimc-lite driver

2013-04-24 Thread Shaik Ameer Basha
This patch adds, 1] Exynos5 soc compatibility to the fimc-lite driver 2] Multiple dma output buffer support as from Exynos5 onwards, fimc-lite h/w ip supports multiple dma buffers. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos4-is/fimc-lite.c

[RFC v2 3/6] media: fimc-lite: Adding support for Exynos5

2013-04-24 Thread Shaik Ameer Basha
FIMC-LITE supports multiple DMA shadow registers from Exynos5 onwards. This patch adds the functionality of using shadow registers by checking the driver data. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos4-is/fimc-lite-reg.c | 13 +++ drivers

[RFC v2 4/6] media: fimc-lite: Fix for DMA output corruption

2013-04-24 Thread Shaik Ameer Basha
Fixes Buffer corruption on DMA output from fimc-lite Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos4-is/fimc-lite-reg.c |3 ++- drivers/media/platform/exynos4-is/fimc-lite.c | 14

[RFC v2 5/6] media: s5p-csis: Adding Exynos5250 compatibility

2013-04-24 Thread Shaik Ameer Basha
FIMC-IS firmware needs all the MIPI-CSIS interrupts to be enabled. This patch enables all those MIPI interrupts and adds the Exynos5 compatible string. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos4-is/mipi-csis.c |3 ++- 1 file changed, 2

[RFC v2 6/6] media: exynos5-is: Adding media device driver for exynos5

2013-04-24 Thread Shaik Ameer Basha
| ++ +---+ +-+ ++ +---+ +---+ +-+ | Sensor | -- | MIPI-CSIS | -- | FIMC-LITE | -- | G-Scaler-capture | ++ +---+ +---+ +-+ Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- .../devicetree/bindings/media/exynos5

Re: [RFC 11/12] media: m5mols: Adding dt support to m5mols driver

2013-03-24 Thread Shaik Ameer Basha
patch for this driver. If you can able to post the dt patch for this driver, I will use that. Regards, Shaik Ameer Basha On Sat, Mar 23, 2013 at 5:26 PM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hi Shaik, On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds the dt

Re: [RFC 01/12] media: s5p-fimc: modify existing mdev to use common pipeline

2013-03-11 Thread Shaik Ameer Basha
patch from next time. please find my review comments inline.. On Mon, Mar 11, 2013 at 3:30 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch modifies the current fimc_pipeline to exynos_pipeline, I think we could leave

Re: [RFC 02/12] fimc-lite: Adding Exynos5 compatibility to fimc-lite driver

2013-03-11 Thread Shaik Ameer Basha
Hi Sylwester, On Mon, Mar 11, 2013 at 2:06 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds the Exynos5 soc compatibility to the fimc-lite driver. It also adds a version checking to deal with the changes between

Re: [RFC 03/12] media: fimc-lite: Adding support for Exynos5

2013-03-11 Thread Shaik Ameer Basha
Hi Sylweter, On Mon, Mar 11, 2013 at 2:09 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds the following functionalities to existing driver 1] FIMC-LITE supports multiple DMA shadow registers from Exynos5 onwards

Re: [RFC 04/12] s5p-csis: Adding Exynos5250 compatibility

2013-03-11 Thread Shaik Ameer Basha
Hi Sylwester, On Mon, Mar 11, 2013 at 2:10 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: Please don't leave the change log empty. I'll apply this patch. I'm just wondering, if there aren't any further changes needed to make

Re: [RFC 05/12] ARM: EXYNOS: Add devicetree node for mipi-csis driver for exynos5

2013-03-11 Thread Shaik Ameer Basha
Hi Sylwester, On Mon, Mar 11, 2013 at 2:24 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds necessary source definations needed for mipi-csis driver and adds devicetree node for exynos5250. Signed-off-by: Shaik Ameer

Re: [RFC 05/12] ARM: EXYNOS: Add devicetree node for mipi-csis driver for exynos5

2013-03-11 Thread Shaik Ameer Basha
On Mon, Mar 11, 2013 at 2:27 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -47,6 +47,8 @@ i2c6 =i2c_6; i2c7 =i2c_7

Re: [RFC 07/12] media: exynos5-is: Adding media device driver for exynos5

2013-03-11 Thread Shaik Ameer Basha
Hi Sylwester, Thanks for the review. I will address all you comments for this patch in the next version. Thanks, Shaik Ameer Basha On Mon, Mar 11, 2013 at 3:58 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds support

Re: [PATCH] [media] fimc-lite: Fix the variable type to avoid possible crash

2013-03-07 Thread Shaik Ameer Basha
On Thu, Mar 7, 2013 at 8:21 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 02/21/2013 12:54 PM, Shaik Ameer Basha wrote: Changing the variable type to 'int' from 'unsigned int'. Driver logic expects the variable type to be 'int'. Signed-off-by: Shaik Ameer Basha shaik.am

[RFC 00/12] Adding media device driver for Exynos imaging subsystem

2013-03-06 Thread Shaik Ameer Basha
Shaik Ameer Basha (12): media: s5p-fimc: modify existing mdev to use common pipeline fimc-lite: Adding Exynos5 compatibility to fimc-lite driver media: fimc-lite: Adding support for Exynos5 s5p-csis: Adding Exynos5250 compatibility ARM: EXYNOS: Add devicetree node for mipi-csis driver

[RFC 01/12] media: s5p-fimc: modify existing mdev to use common pipeline

2013-03-06 Thread Shaik Ameer Basha
This patch modifies the current fimc_pipeline to exynos_pipeline, which can be used across multiple media device drivers. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-capture.c | 96 +++- drivers/media/platform/s5p-fimc/fimc-core.h

[RFC 02/12] fimc-lite: Adding Exynos5 compatibility to fimc-lite driver

2013-03-06 Thread Shaik Ameer Basha
This patch adds the Exynos5 soc compatibility to the fimc-lite driver. It also adds a version checking to deal with the changes between different fimc-lite hardware versions. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-lite.c | 23

[RFC 03/12] media: fimc-lite: Adding support for Exynos5

2013-03-06 Thread Shaik Ameer Basha
fimc-lite 3] Modified the driver to be used as pipeline endpoint Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-lite-reg.c | 16 +- drivers/media/platform/s5p-fimc/fimc-lite-reg.h | 41

[RFC 04/12] s5p-csis: Adding Exynos5250 compatibility

2013-03-06 Thread Shaik Ameer Basha
Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/s5p-fimc/mipi-csis.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/s5p-fimc/mipi-csis.c b/drivers/media/platform/s5p-fimc/mipi-csis.c index df4411c..debda7c 100644 --- a/drivers

[RFC 05/12] ARM: EXYNOS: Add devicetree node for mipi-csis driver for exynos5

2013-03-06 Thread Shaik Ameer Basha
This patch adds necessary source definations needed for mipi-csis driver and adds devicetree node for exynos5250. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi | 18 ++ arch/arm/mach-exynos/clock-exynos5.c| 16

[RFC 06/12] ARM: EXYNOS: Add devicetree node for FIMC-LITE driver for exynos5

2013-03-06 Thread Shaik Ameer Basha
This patch adds necessary source definitions needed for FIMC-LITE driver and adds devicetree node for exynos5250. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi | 21 + arch/arm/mach-exynos/clock-exynos5.c|4

[RFC 07/12] media: exynos5-is: Adding media device driver for exynos5

2013-03-06 Thread Shaik Ameer Basha
| ++ +---+ +-+ ++ +---+ +---+ +-+ | Sensor | -- | MIPI-CSIS | -- | FIMC-LITE | -- | G-Scaler-capture | ++ +---+ +---+ +-+ Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/Kconfig

[RFC 08/12] ARM: dts: add camera specific pinctrl nodes for Exynos5250 SoC

2013-03-06 Thread Shaik Ameer Basha
Add device nodes for pinctrl group-1 for Exynos5250 SoC. This only adds cam1 specific pinctrl nodes to the file. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 41 + arch/arm/boot/dts/exynos5250.dtsi

[RFC 09/12] ARM: dts: Adding pinctrl support to Exynos5250 i2c nodes

2013-03-06 Thread Shaik Ameer Basha
This patch adds the default pinctrl functionality to the i2c device nodes on exynos5250-smdk5250.dts file Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- arch/arm/boot/dts/exynos5250-smdk5250.dts | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff

[RFC 10/12] ARM: dts: Adding media device nodes to Exynos5 SoCs

2013-03-06 Thread Shaik Ameer Basha
This patch adds the media device driver specific dt bindings to the Exynos5 specific SoCs. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi | 64 + 1 file changed, 36 insertions(+), 28 deletions(-) diff --git

[RFC 11/12] media: m5mols: Adding dt support to m5mols driver

2013-03-06 Thread Shaik Ameer Basha
This patch adds the dt support to m5mols driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/i2c/m5mols/m5mols_core.c | 54 +++- 1 file changed, 53 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/m5mols/m5mols_core.c b

[RFC 12/12] ARM: dts: Add camera node to exynos5250-smdk5250.dts

2013-03-06 Thread Shaik Ameer Basha
Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- arch/arm/boot/dts/exynos5250-smdk5250.dts | 43 - 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts index

Re: [PATCH] [media] s5p-mfc: Fix encoder control 15 issue

2013-03-06 Thread Shaik Ameer Basha
). This function expects 'step' value for V4L2_CTRL_TYPE_BOOLEAN type control. If 'step' value doesn't match to '1', it returns -ERANGE error. Its a change in v4l2 core. Regards, Shaik Ameer Basha Signed-off-by: Arun Kumar Karun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c

[PATCH] [media] fimc-lite: Fix the variable type to avoid possible crash

2013-02-21 Thread Shaik Ameer Basha
Changing the variable type to 'int' from 'unsigned int'. Driver logic expects the variable type to be 'int'. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-lite-reg.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] [media] fimc-lite: Initialize 'step' field in fimc_lite_ctrl structure

2013-02-21 Thread Shaik Ameer Basha
v4l2_ctrl_new() uses check_range() for control range checking. This function expects 'step' value for V4L2_CTRL_TYPE_BOOLEAN type control. If 'step' value doesn't match to '1', it returns -ERANGE error. This patch adds the default .step value to 1. Signed-off-by: Shaik Ameer Basha shaik.am

[PATCH] [media] exynos-gsc: send valid m2m ctx to gsc_m2m_job_finish

2013-02-05 Thread Shaik Ameer Basha
() in gsc_resume(). Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-gsc/gsc-core.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b/drivers/media/platform/exynos-gsc/gsc-core.c index

[PATCH] s5p-fimc: send valid m2m ctx to fimc_m2m_job_finish

2013-02-05 Thread Shaik Ameer Basha
fimc_m2m_job_finish() has to be called with the m2m context for the necessary cleanup while resume. But currently fimc_m2m_job_finish() always passes m2m context as NULL. This patch preserves the context before making it null, for necessary cleanup. Signed-off-by: Shaik Ameer Basha shaik.am

[PATCH] s5p-fimc: set m2m context to null at the end of fimc_m2m_resume

2013-01-18 Thread Shaik Ameer Basha
fimc_m2m_job_finish() has to be called with the m2m context for the necessary cleanup while resume. But currently fimc_m2m_job_finish() always passes fimc-m2m.ctx as NULL. This patch changes the order of the calls for proper cleanup while resume. Signed-off-by: Shaik Ameer Basha shaik.am

Re: [PATCH] s5p-fimc: set m2m context to null at the end of fimc_m2m_resume

2013-01-18 Thread Shaik Ameer Basha
Hi Sylwester, On Fri, Jan 18, 2013 at 3:58 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi Shaik, On 01/18/2013 11:01 AM, Shaik Ameer Basha wrote: fimc_m2m_job_finish() has to be called with the m2m context for the necessary cleanup while resume. But currently fimc_m2m_job_finish

[PATCH] [media] exynos-gsc: Support dmabuf export buffer

2012-12-07 Thread Shaik Ameer Basha
This patch adds the dmabuf export buffer feature to the Exynos G-Scaler driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-gsc/gsc-m2m.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform

[PATCH] [media] exynos-gsc: modify number of output/capture buffers

2012-11-27 Thread Shaik Ameer Basha
G-Scaler src buffer count as well as destination buffer count is increased to 32. This is required for G-Scaler to interface with MFC, as MFC demands 32 capture buffers for some H264 streams. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-gsc/gsc

Re: [PATCH v2 0/4] [media] exynos-gsc: Some fixes

2012-11-24 Thread Shaik Ameer Basha
Hi Sylwester, I tested this patch series. Looks good to me. Thanks, Shaik Ameer Basha On Fri, Nov 23, 2012 at 4:34 PM, Sachin Kamat sachin.ka...@linaro.org wrote: Changes since v1: Removed the label 'err' from function gsc_clk_get as suggested by Sylwester Nawrocki s.nawro...@samsung.com

[PATCH v2] [media] exynos-gsc: propagate timestamps from src to dst buffers

2012-11-22 Thread Shaik Ameer Basha
Make gsc-m2m propagate the timestamp field from source to destination buffers Signed-off-by: John Sheu s...@google.com Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-gsc/gsc-m2m.c | 20 +--- 1 files changed, 13 insertions(+), 7

Re: [RFC] Selections targets at V4L2 video mem-to-mem interface

2012-11-22 Thread Shaik Ameer Basha
mentioned, we can use vfl_dir field to select the target before sending it to the driver. apart from using this vfl_dir field, I can't able to see any other solution here. Regards, Shaik Ameer Basha One possible solution would be to get hold of struct video_device and do proper targets

Re: [PATCH] exynos-gsc: Add missing video device vfl_dir flag initialization

2012-11-21 Thread Shaik Ameer Basha
Hi Sylwester, I applied this patch and tested exynos-gsc driver basic features on exynos5250. It's working fine for me. Thanks, Shaik Ameer Basha On Tue, Nov 20, 2012 at 1:36 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hi Shaik, Could you let us know if the driver is working

Re: [PATCH] [media] exynos-gsc: Adding tiled multi-planar format to G-Scaler

2012-11-20 Thread Shaik Ameer Basha
Hi Sylwester, On Tue, Nov 20, 2012 at 3:05 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hi Shaik, On 11/07/2012 07:37 AM, Shaik Ameer Basha wrote: Adding V4L2_PIX_FMT_NV12MT_16X16 to G-Scaler supported formats. If the output or input format is V4L2_PIX_FMT_NV12MT_16X16

[PATCH] [media] exynos-gsc: Adding tiled multi-planar format to G-Scaler

2012-11-06 Thread Shaik Ameer Basha
Adding V4L2_PIX_FMT_NV12MT_16X16 to G-Scaler supported formats. If the output or input format is V4L2_PIX_FMT_NV12MT_16X16, configure G-Scaler to use GSC_IN_TILE_MODE. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-gsc/gsc-core.c |9

[PATCH] [media] exynos-gsc: Fix settings for input and output image RGB type

2012-11-06 Thread Shaik Ameer Basha
Macros used to set input and output RGB type aren't correct. Updating the macros as per register manual. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-gsc/gsc-regs.h | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH] [media] exynos-gsc: propagate timestamps from src to dst buffers

2012-11-06 Thread Shaik Ameer Basha
Make gsc-m2m propagate the timestamp field from source to destination buffers Signed-off-by: John Sheu s...@google.com Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-gsc/gsc-m2m.c | 19 --- 1 files changed, 12 insertions(+), 7

[PATCH] [media] exynos-gsc: fix variable type in gsc_m2m_device_run()

2012-10-15 Thread Shaik Ameer Basha
In gsc_m2m_device_run(), variable ret is accepting signed integer values. But currently it is defined as u32. This patch will modify the type of ret variable to int. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-gsc/gsc-m2m.c |2 +- 1 files

[PATCH] [media] s5p-fimc: fix variable type in fimc_device_run()

2012-10-15 Thread Shaik Ameer Basha
In fimc_device_run(), variable ret is accepting signed integer values. But currently it is defined as u32. This patch will modify the type of ret variable to int. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-m2m.c |2 +- 1 files changed, 1

  1   2   >