DVB-S PCI card regression on 4.19 / 4.20

Hi, we've got a regression report on openSUSE Bugzilla regarding DVB-S PCI card: https://bugzilla.opensuse.org/show_bug.cgi?id=1116374 According to the reporter (Stakanov, Cc'ed), the card worked fine on 4.18.15, but since 4.19, it doesn't give any channels, sound nor picture, but only EPG is

Re: [RFC PATCH] sound, media: array_find() can be static

On Sun, 22 Apr 2018 20:05:03 +0200, kbuild test robot wrote: > > > Fixes: dbd775375e7d ("sound, media: allow building ISA drivers it with > COMPILE_TEST") It's not actually a bug that was introduced by the commit, but it just made appearing clearer. So I dropped this tag. > Signed-off-by:

Re: [PATCH 3/4] sound, media: allow building ISA drivers it with COMPILE_TEST

On Sun, 22 Apr 2018 20:05:03 +0200, kbuild test robot wrote: > > Hi Mauro, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on linuxtv-media/master] > [also build test WARNING on v4.17-rc1 next-20180420] > [if your patch is applied to the wrong git tree, please

Re: [PATCH] sound, isapnp: allow building more drivers with COMPILE_TEST

> > So, remove such dependencies when COMPILE_TEST. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Takashi Iwai <ti...@suse.de> thanks, Takashi > --- > drivers/pnp/isapnp/Kconfig | 2 +- > sound/isa/Kconfig | 6 +++---

Re: [PATCH 3/4] sound, media: allow building ISA drivers it with COMPILE_TEST

On Fri, 20 Apr 2018 15:01:22 +0200, Mauro Carvalho Chehab wrote: > > Em Fri, 20 Apr 2018 09:51:29 -0300 > Mauro Carvalho Chehab <mche...@s-opensource.com> escreveu: > > > Em Fri, 20 Apr 2018 14:37:46 +0200 > > Takashi Iwai <ti...@suse.de> escreveu: > >

Re: [PATCH 3/4] sound, media: allow building ISA drivers it with COMPILE_TEST

On Fri, 20 Apr 2018 14:51:29 +0200, Mauro Carvalho Chehab wrote: > > Em Fri, 20 Apr 2018 14:37:46 +0200 > Takashi Iwai <ti...@suse.de> escreveu: > > > On Fri, 20 Apr 2018 14:32:15 +0200, > > Mauro Carvalho Chehab wrote: > > > > > > All sound

Re: [PATCH 3/4] sound, media: allow building ISA drivers it with COMPILE_TEST

On Fri, 20 Apr 2018 14:32:15 +0200, Mauro Carvalho Chehab wrote: > > All sound drivers that don't depend on PNP can be safelly > build with COMPILE_TEST, as ISA provides function stubs to > be used for such purposes. > > As a side effect, with this change, the radio-miropcm20 > can now be built

Re: [alsa-devel] [trivial PATCH] treewide: Align function definition open/close braces

| 6 +++--- > kernel/trace/trace_printk.c | 4 ++-- > lib/raid6/sse2.c | 14 +++--- > sound/soc/fsl/fsl_dma.c | 2 +- For sound bits, Acked-by: Takashi Iwai <ti...@suse.de> thanks, Takashi

Re: [alsa-devel] [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk

On Thu, 01 Jun 2017 22:58:24 +0200, Takashi Iwai wrote: > > The previous commit [63691587f7b0: ALSA: hda - Apply dual-codec quirk > for MSI Z270-Gaming mobo] attempted to apply the existing dual-codec > quirk for a MSI mobo. But it turned out that this isn't applied > properly

[PATCH v2 10/27] ALSA: hdsp: Convert to the new PCM ops

Replace the copy and the silence ops with the new PCM ops. The conversion is straightforward with standard helper functions. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/rme9652/hdsp.c | 67 1 file changed, 50 insertions(

[PATCH v2 23/27] ALSA: pcm: Direct in-kernel read/write support

simple because of the code refactoring until now. Signed-off-by: Takashi Iwai <ti...@suse.de> --- include/sound/pcm.h | 38 +- sound/core/pcm_lib.c | 26 +- 2 files changed, 58 insertions(+), 6 deletions(-) diff --git a/include

[PATCH v2 17/27] ALSA: pcm: Check PCM state by a common helper function

Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/core/pcm_lib.c | 81 +++- 1 file changed, 29 insertions(+), 52 deletions(-) diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c index 0db8d4e0fca2..e4f5c43b6448 100644 --- a/soun

[PATCH v2 03/27] ALSA: dummy: Convert to new PCM copy ops

It's a dummy ops, so just replacing it. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/drivers/dummy.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c index 172dacd925f5..dd5ed037adf2

[PATCH v2 02/27] ALSA: pcm: Introduce copy_user, copy_kernel and fill_silence ops

nify the implementations of both interleaved and non-interleaved cases, as we'll see in the later patch. As of this stage, copy_kernel ops isn't referred yet, but only copy_user is used. Signed-off-by: Takashi Iwai <ti...@suse.de> --- include/sound/pcm.h | 7 + sound/core/pcm_

[PATCH v2 15/27] [media] solo6x10: Convert to the new PCM ops

Replace the copy and the silence ops with the new PCM ops. The device supports only 1 channel and 8bit sample, so it's always bytes=frames, and we need no conversion of unit in the callback. Also, it's a capture stream, thus no silence is needed. Signed-off-by: Takashi Iwai <ti...@suse

[PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk

lfschmidt.com> Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/hda/patch_realtek.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 918e45268915..a57988d617e9 100644 --- a/sound/pci/hda/patch

[PATCH v2 08/27] ALSA: rme96: Convert to the new PCM ops

Replace the copy and the silence ops with the new PCM ops. The conversion is straightforward with standard helper functions, and now we can drop the bytes <-> frames conversions in callbacks. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/

[PATCH v2 04/27] ALSA: es1938: Convert to the new PCM copy ops

Replace the copy ops with the new copy_user and copy_kernel ops. It's used only for a capture stream (for some hardware workaround), thus we need no silence operation. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/es1938.c | 33 + 1 file chang

[PATCH v2 19/27] ALSA: pcm: Call directly the common read/write helpers

Make snd_pcm_lib_read() and *_write() static inline functions that call the common helper functions directly. This reduces a slight amount of codes, and at the same time, it's a preparation for the further cleanups / fixes. Signed-off-by: Takashi Iwai <ti...@suse.de> --- include/sound

[PATCH v2 14/27] ASoC: blackfin: Convert to the new PCM ops

Replace the copy and the silence ops with the new PCM ops. In AC97 and I2S-TDM mode, we need to convert back to frames, but otherwise the conversion is pretty straightforward. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/soc/blackfin/bf5xx-ac97-pcm.

[PATCH v2 00/27] Revised full patchset for PCM in-kernel copy support

. I'm Cc'ing the media and the USB people since it touches solo6x10 and usb-gadget drivers. The previous ACK was dropped as each patch was rewritten again. Sorry for the doubly patch-review labours. thanks, Takashi === Takashi Iwai (26): ALSA: pcm: Introduce copy_user, copy_kernel

[PATCH v2 12/27] ALSA: sb: Convert to the new PCM ops

Replace the copy and the silence ops with the new PCM ops. For avoiding the code redundancy, slightly hackish macros are introduced. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/isa/sb/emu8000_pcm.c | 190 ++--- 1 file changed, 109 inse

[PATCH v2 11/27] ALSA: gus: Convert to the new PCM ops

Replace the copy and the silence ops with the new PCM ops. For simplifying the code a bit, two local helpers are introduced here: get_bpos() and playback_copy_ack(). Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/isa/gus/gus_pcm.c | 97 ++

[PATCH v2 13/27] ALSA: sh: Convert to the new PCM ops

Replace the copy and the silence ops with the new PCM ops. Fixed also the user-space buffer copy with the proper copy_from_user*() variant. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/sh/sh_dac_audio.c | 54 +++-- 1 file chang

[PATCH v2 24/27] usb: gadget: u_uac1: Kill set_fs() usage

With the new API to perform the in-kernel buffer copy, we can get rid of set_fs() usage in this driver, finally. Signed-off-by: Takashi Iwai <ti...@suse.de> --- drivers/usb/gadget/function/u_uac1.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/

[PATCH v2 05/27] ALSA: nm256: Convert to new PCM copy ops

Replace the copy and the silence ops with the new ops. The conversion is straightforward with standard helper functions, and now we can drop the bytes <-> frames conversions in callbacks. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/nm256/

[PATCH v2 20/27] ALSA: pcm: More unification of PCM transfer codes

the specific copy ops or it's the standard read/write. Another bonus by this change is that we now guarantee the silencing behavior when NULL buffer is passed to write helpers. It'll simplify some codes later. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/core/pcm_lib.c

[PATCH v2 18/27] ALSA: pcm: Shuffle codes

Just shuffle the codes, without any change otherwise. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/core/pcm_lib.c | 212 +-- 1 file changed, 106 insertions(+), 106 deletions(-) diff --git a/sound/core/pcm_lib.c b/sound/core/pcm

[PATCH v2 27/27] ALSA: doc: Update copy_user, copy_kernel and fill_silence PCM ops

Signed-off-by: Takashi Iwai <ti...@suse.de> --- .../sound/kernel-api/writing-an-alsa-driver.rst| 111 ++--- 1 file changed, 76 insertions(+), 35 deletions(-) diff --git a/Documentation/sound/kernel-api/writing-an-alsa-driver.rst b/Documentation/sound/kernel-api/w

[PATCH v2 22/27] ALSA: pcm: Simplify snd_pcm_playback_silence()

Use the existing silence helper codes for simplification. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/core/pcm_lib.c | 50 -- 1 file changed, 20 insertions(+), 30 deletions(-) diff --git a/sound/core/pcm_lib.c b/sound/core/pcm

[PATCH v2 25/27] ALSA: pcm: Kill set_fs() in PCM OSS layer

-by: Takashi Iwai <ti...@suse.de> --- sound/core/oss/pcm_oss.c | 77 1 file changed, 12 insertions(+), 65 deletions(-) diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c index e306f05ce51d..2d6a825cfe88 100644 --- a/sound/core/oss/pcm

[PATCH v2 26/27] ALSA: pcm: Build OSS writev/readv helpers conditionally

() directly instead. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/core/oss/io.c | 4 ++-- sound/core/oss/pcm_oss.c| 12 ++-- sound/core/oss/pcm_plugin.h | 6 ++ 3 files changed, 10 insertions(+), 12 deletions(-) diff --git a/sound/core/oss/io.c b/sound/core/os

[PATCH v2 16/27] ALSA: pcm: Drop the old copy and silence ops

Now that all users of old copy and silence ops have been converted to the new PCM ops, the old stuff can be retired and go away. Signed-off-by: Takashi Iwai <ti...@suse.de> --- include/sound/pcm.h | 5 - sound/core/pcm_lib.c | 38 +- sound/soc/soc

[PATCH v2 07/27] ALSA: rme32: Convert to the new PCM copy ops

Replace the copy and the silence ops with the new ops. The conversion is straightforward with standard helper functions, and now we can drop the bytes <-> frames conversions in callbacks. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/

[PATCH v2 06/27] ALSA: korg1212: Convert to the new PCM ops

Replace the copy and the silence ops with the new PCM ops. Although we can refactor this messy code, at this time, the changes are kept as small as possible. Let's clean up later. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/korg1212/korg1212.c

[PATCH v2 09/27] ALSA: rme9652: Convert to the new PCM ops

Replace the copy and the silence ops with the new PCM ops. The conversion is straightforward with standard helper functions. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/rme9652/rme9652.c | 71 ++--- 1 file changed, 54 insertions(

[PATCH v2 21/27] ALSA: pcm: Unify read/write loop

Both __snd_pcm_lib_read() and __snd_pcm_write() functions have almost the same code to loop over samples. For simplification, this patch unifies both as the single helper, __snd_pcm_lib_xfer(). Other than that, there should be no functional change by this patch. Signed-off-by: Takashi Iwai <

[PATCH 14/16] ASoC: blackfin: Convert to copy_silence ops

in_kernel into account on this architecture, so the conversion is easy otherwise. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/soc/blackfin/bf5xx-ac97-pcm.c | 6 ++--- sound/soc/blackfin/bf5xx-ac97.c | 18 ++- sound/soc/blackfin/bf5xx-i2s-pcm.c

[PATCH 16/16] ALSA: pcm: Drop the old copy and silence ops

Now that all users of old copy and silence ops have been converted to the new copy_silence ops, the old stuff can be retired and go away. Signed-off-by: Takashi Iwai <ti...@suse.de> --- include/sound/pcm.h | 5 - sound/core/pcm_lib.c | 38 +- sou

[PATCH 15/16] [media] solo6x10: Convert to copy_silence ops

Replace the copy and the silence ops with the new merged ops. It's a capture stream, thus no silence is needed. Signed-off-by: Takashi Iwai <ti...@suse.de> --- drivers/media/pci/solo6x10/solo6x10-g723.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/d

[PATCH 01/16] ALSA: pcm: Introduce copy_silence PCM ops

OSS code for the on-the-fly conversion. As this patch stands, only in_kernel=false is passed. The actual usage of in_kernel=true will be introduced later. Signed-off-by: Takashi Iwai <ti...@suse.de> --- include/sound/pcm.h | 3 +++ sound/core/pcm_lib.

[PATCH 12/16] ALSA: sb: Convert to copy_silence ops

Replace the copy and the silence ops with the new merged ops. We could reduce the redundant silence code by that. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/isa/sb/emu8000_pcm.c | 99 ++ 1 file changed, 30 insertions(+), 69 del

[PATCH 04/16] ALSA: es1938: Convert to copy_silence ops

Replace the copy and the silence ops with the new merged ops. It's used only for a capture stream (for some hardware workaround), thus we need no silence operation but only to add the in_kernel memcpy() handling. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/es1938.

[PATCH 10/16] ALSA: hdsp: Convert to copy_silence ops

Replace the copy and the silence ops with the new merged ops. The conversion is straightforward with standard helper functions. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/rme9652/hdsp.c | 44 1 file changed, 20 insertions(

[PATCH 02/16] ALSA: Update document about copy_silence PCM ops

Signed-off-by: Takashi Iwai <ti...@suse.de> --- .../sound/kernel-api/writing-an-alsa-driver.rst| 110 - 1 file changed, 63 insertions(+), 47 deletions(-) diff --git a/Documentation/sound/kernel-api/writing-an-alsa-driver.rst b/Documentation/sound/kernel-api/w

[PATCH 08/16] ALSA: rme96: Convert to copy_silence ops

Replace the copy and the silence ops with the new merged ops. The conversion is straightforward with standard helper functions. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/rme96.c | 52 ++-- 1 file changed, 26 insertions(

[PATCH 06/16] ALSA: nm256: Convert to copy_silence ops

Replace the copy and the silence ops with the new merged ops. The conversion is straightforward with standard helper functions. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/nm256/nm256.c | 35 ++- 1 file changed, 14 insertions(+), 21 del

[PATCH 09/16] ALSA: rme9652: Convert to copy_silence ops

Replace the copy and the silence ops with the new merged ops. The conversion is straightforward with standard helper functions. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/rme9652/rme9652.c | 46 - 1 file changed, 20 insertions(

[PATCH 05/16] ALSA: korg1212: Convert to copy_silence ops

Replace the copy and the silence ops with the new merged ops. The redundant function calls are reduced and the copy/silence are handled directly in callback functions now. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/korg1212/korg1212.c

[PATCH 11/16] ALSA: gus: Convert to copy_silence ops

Replace the copy and the silence ops with the new merged ops. The conversion is straightforward with standard helper functions. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/isa/gus/gus_pcm.c | 43 +-- 1 file changed, 9 insertions(+), 34 del

[PATCH 13/16] ALSA: sh: Convert to copy_silence ops

Replace the copy and the silence ops with the new merged ops. A straightforward conversion with standard helper functions. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/sh/sh_dac_audio.c | 40 +--- 1 file changed, 9 insertions(+), 31 deletions(-)

[PATCH 07/16] ALSA: rme32: Convert to copy_silence ops

Replace the copy and the silence ops with the new merged ops. The conversion is straightforward with standard helper functions. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/rme32.c | 49 - 1 file changed, 24 insertions(+), 25 del

[PATCH 03/16] ALSA: dummy: Convert to copy_silence ops

It's a dummy ops, so just replacing it. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/drivers/dummy.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c index 172dacd925f5..68519689a9ea 100644 --- a

[PATCH 00/16] ALSA: Convert to new copy_silence PCM ops

copy, so that the PCM drivers can pass the buffer in kernel-space later directly without set_fs() hackery. The latest codes are found in topic/kill-set_fs branch of sound git tree. The media people are Cc'ed for solo6x10 changes. Takashi === Takashi Iwai (16): ALSA: pcm: Introduce

Re: [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources

On Tue, 06 Dec 2016 19:41:37 +0100, Shuah Khan wrote: > > Hi Takashi, > > On 12/05/2016 11:50 PM, Takashi Iwai wrote: > > On Wed, 30 Nov 2016 23:01:16 +0100, > > Shuah Khan wrote: > >> > >> --- a/sound/usb/card.c > >> +++ b/sound/usb/car

Re: [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources

On Mon, 05 Dec 2016 23:44:30 +0100, Shuah Khan wrote: > > On 11/30/2016 03:01 PM, Shuah Khan wrote: > > Change ALSA driver to use Media Controller API to share media resources > > with DVB, and V4L2 drivers on a AU0828 media device. > > > > Media Controller specific initialization is done after

Re: [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources

On Wed, 30 Nov 2016 23:01:16 +0100, Shuah Khan wrote: > > --- a/sound/usb/card.c > +++ b/sound/usb/card.c (snip) > @@ -616,6 +617,11 @@ static int usb_audio_probe(struct usb_interface *intf, > if (err < 0) > goto __error; > > + if (quirk && quirk->media_device) { > +

Re: [RFC][PATCH 0/2] ALSA: control: export all of TLV related macros to user land

On Sun, 11 Sep 2016 05:06:41 +0200, Takashi Sakamoto wrote: > > On Sep 10 2016 22:41, Takashi Iwai wrote: > > On Sat, 10 Sep 2016 09:25:31 +0200, > > Takashi Sakamoto wrote: > >> > >> On Sep 10 2016 15:44, Takashi Iwai wrote: > >>> On Sat, 10 Sep 2

Re: [RFC][PATCH 0/2] ALSA: control: export all of TLV related macros to user land

On Sat, 10 Sep 2016 09:25:31 +0200, Takashi Sakamoto wrote: > > On Sep 10 2016 15:44, Takashi Iwai wrote: > > On Sat, 10 Sep 2016 06:50:14 +0200, > > Takashi Sakamoto wrote: > >> > >> Hi, > >> > >> Currently, TLV related protocol is not

Re: [RFC][PATCH 0/2] ALSA: control: export all of TLV related macros to user land

On Sat, 10 Sep 2016 06:50:14 +0200, Takashi Sakamoto wrote: > > Hi, > > Currently, TLV related protocol is not shared to user land. This is not > good in a point of application interfaces, because application developers > can't realize the protocol just to see UAPI headers. > > For this

Re: [alsa-devel] [very-RFC 0/8] TSN driver for the kernel

On Tue, 21 Jun 2016 08:38:57 +0200, Richard Cochran wrote: > > On Tue, Jun 21, 2016 at 07:54:32AM +0200, Takashi Iwai wrote: > > > I still would appreciate an answer to my other questions, though... > > > > Currently HD-audio (both ASoC and legacy ones) are the

Re: [alsa-devel] [very-RFC 0/8] TSN driver for the kernel

On Mon, 20 Jun 2016 17:21:26 +0200, Richard Cochran wrote: > > On Mon, Jun 20, 2016 at 02:31:48PM +0200, Richard Cochran wrote: > > Where is this "audio_time" program of which you speak? > > Never mind, found it in alsa-lib. > > I still would appreciate an answer to my other questions,

Re: [RFC PATCH v2 0/5] Media Device Allocator API

On Tue, 05 Apr 2016 05:35:55 +0200, Shuah Khan wrote: > > There are known problems with media device life time management. When media > device is released while an media ioctl is in progress, ioctls fail with > use-after-free errors and kernel hangs in some cases. > > Media Device can be in any

Re: [alsa-devel] [PATCH] sound/usb: Fix memory leak in media_snd_stream_delete() during unbind

unpoison_shadow+0x36/0x50 > [ 1445.086890] [] ? kasan_unpoison_shadow+0x36/0x50 > [ 1445.086895] [] ? kasan_kmalloc+0x5e/0x70 > > Signed-off-by: Shuah Khan <shua...@osg.samsung.com> Mauro, please take it through your tree. Acked-by: Takashi Iwai <ti...@suse.de> thanks, Ta

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

On Mon, 14 Mar 2016 11:13:58 +0100, Mauro Carvalho Chehab wrote: > > Em Mon, 14 Mar 2016 09:22:37 +0200 > Sakari Ailus escreveu: > > > Hi Shuah, > > > > On Sat, Mar 12, 2016 at 06:48:09PM -0700, Shuah Khan wrote: > > > Add GFP flags to media_create_pad_link(),

Re: [PATCH 26/31] sound/usb: Update ALSA driver to use Managed Media Controller API

On Wed, 06 Jan 2016 22:05:35 +0100, Shuah Khan wrote: > > diff --git a/sound/usb/Makefile b/sound/usb/Makefile > index 2d2d122..665fdd9 100644 > --- a/sound/usb/Makefile > +++ b/sound/usb/Makefile > @@ -2,6 +2,18 @@ > # Makefile for ALSA > # > > +# Media Controller > +ifeq

Re: [alsa-devel] [PATCH MC Next Gen] sound/usb: Fix out of bounds access in media_entity_init()

On Sat, 05 Dec 2015 01:00:29 +0100, Shuah Khan wrote: > > Fix the out of bounds access in media_entity_init() found > by KASan. This is a result of media_mixer_init() failing > to allocate memory for all 3 of its pads before calling > media_entity_init(). Fix it to allocate memory for the > right

Re: [PATCH] media, sound: tea575x: constify snd_tea575x_ops structures

On Sun, 22 Nov 2015 11:32:53 +0100, Julia Lawall wrote: > > The snd_tea575x_ops structures are never modified, so declare them as > const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Reviewed-by: Takashi Iwai <ti.

Re: [PATCH MC Next Gen v2 2/3] sound/usb: Create media mixer function and control interface entities

On Tue, 03 Nov 2015 17:06:45 +0100, Shuah Khan wrote: > > On 10/25/2015 03:37 PM, Shuah Khan wrote: > > On 10/22/2015 01:16 AM, Takashi Iwai wrote: > >> On Wed, 21 Oct 2015 01:25:15 +0200, > >> Shuah Khan wrote: > >>> > >>> Add support for

Re: [PATCH MC Next Gen v2 2/3] sound/usb: Create media mixer function and control interface entities

On Wed, 21 Oct 2015 01:25:15 +0200, Shuah Khan wrote: > > Add support for creating MEDIA_ENT_F_AUDIO_MIXER entity for > each mixer and a MEDIA_INTF_T_ALSA_CONTROL control interface > entity that links to mixer entities. MEDIA_INTF_T_ALSA_CONTROL > entity corresponds to the control device for the

[PATCH] [media] c8sectpfe: Remove select on CONFIG_FW_LOADER_USER_HELPER_FALLBACK

selects by itself. Let's remove it. Fixes: 850a3f7d5911 ('[media] c8sectpfe: Add Kconfig and Makefile for the driver') Signed-off-by: Takashi Iwai <ti...@suse.de> --- drivers/media/platform/sti/c8sectpfe/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platfo

Re: Linux 4.2 ALSA snd-usb-audio inconsistent lock state warn in PCM nonatomic mode

On Tue, 01 Sep 2015 00:48:30 +0200, Shuah Khan wrote: > > Hi Takashi, > > I am seeing the following inconsistent lock state warning when PCM > is run in nonatomic mode. This is on 4.2.0 and with the following > change to force PCM on nonatomic mode: > > diff --git a/sound/usb/stream.c

Re: [PATCH 7/7] sound/usb: Update ALSA driver to use Managed Media Controller API

On Mon, 20 Jul 2015 10:47:46 +0200, Dan Carpenter wrote: On Tue, Jul 14, 2015 at 06:34:06PM -0600, Shuah Khan wrote: + ret = media_entity_setup_link(link, flags); + if (ret) { + dev_err(mctl-media_dev-dev, + Couldn't change

Re: [PATCH 2/2] sound/usb: Update ALSA driver to use media controller API

At Fri, 8 May 2015 13:31:31 -0600, Shuah Khan wrote: Change ALSA driver to use media controller API to share tuner with DVB and V4L2 drivers that control AU0828 media device. Media device is created based on a newly added field value in the struct snd_usb_audio_quirk. Using this approach,

Re: DVB suspend/resume regression on 3.19

At Fri, 13 Feb 2015 16:12:40 +0100, Takashi Iwai wrote: At Fri, 13 Feb 2015 12:41:25 -0200, Mauro Carvalho Chehab wrote: Em Fri, 13 Feb 2015 15:02:42 +0100 Takashi Iwai ti...@suse.de escreveu: At Mon, 09 Feb 2015 11:59:07 +0100, Takashi Iwai wrote: Hi, we've

Re: DVB suspend/resume regression on 3.19

At Mon, 09 Feb 2015 11:59:07 +0100, Takashi Iwai wrote: Hi, we've got a bug report about the suspend/resume regression of DVB device with 3.19. The symptom is VLC doesn't work after S3 or S4 resume. strace shows that /dev/dvb/adaptor0/dvr returns -ENODEV. The reporter confirmed

Re: DVB suspend/resume regression on 3.19

At Fri, 13 Feb 2015 12:41:25 -0200, Mauro Carvalho Chehab wrote: Em Fri, 13 Feb 2015 15:02:42 +0100 Takashi Iwai ti...@suse.de escreveu: At Mon, 09 Feb 2015 11:59:07 +0100, Takashi Iwai wrote: Hi, we've got a bug report about the suspend/resume regression of DVB device

DVB suspend/resume regression on 3.19

Hi, we've got a bug report about the suspend/resume regression of DVB device with 3.19. The symptom is VLC doesn't work after S3 or S4 resume. strace shows that /dev/dvb/adaptor0/dvr returns -ENODEV. The reporter confirmed that 3.18 works fine, so the regression must be in 3.19. There is a

Re: [PATCH 1/2] [media] sound: simplify au0828 quirk table

At Thu, 30 Oct 2014 08:53:04 -0200, Mauro Carvalho Chehab wrote: From: Mauro Carvalho Chehab m.che...@samsung.com Add a macro to simplify au0828 quirk table. That makes easier to check it against the USB IDs at drivers/media/usb/au0828-card.c Cc: sta...@vger.kernel.org Signed-off-by:

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

At Sat, 25 Oct 2014 11:41:15 -0200, Mauro Carvalho Chehab wrote: (re-sending from my third e-mail - somehow, the two emails I have at Samsung didn't seem to be delivering to vger.kernel.org today) Em Wed, 22 Oct 2014 14:26:41 -0500 Pierre-Louis Bossart pierre-louis.boss...@linux.intel.com

[PATCH] [media] uvc: Fix destruction order in uvc_delete()

orders in uvc_delete() so that the child is removed before the parent. Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=897736 Reported-and-tested-by: Martin Pluskal mplus...@suse.com Cc: sta...@vger.kernel.org Signed-off-by: Takashi Iwai ti...@suse.de --- drivers/media/usb/uvc/uvc_driver.c | 6

Re: [PATCH v2 1/6] media: add media token device resource framework

At Tue, 21 Oct 2014 12:46:03 +0200, Hans Verkuil wrote: Hi Shuah, As promised, here is my review for this patch series. On 10/14/2014 04:58 PM, Shuah Khan wrote: Add media token device resource framework to allow sharing resources such as tuner, dma, audio etc. across media drivers

Re: [PATCH v2 1/6] media: add media token device resource framework

At Tue, 21 Oct 2014 13:58:59 +0200, Hans Verkuil wrote: On 10/21/2014 01:51 PM, Takashi Iwai wrote: At Tue, 21 Oct 2014 12:46:03 +0200, Hans Verkuil wrote: Hi Shuah, As promised, here is my review for this patch series. On 10/14/2014 04:58 PM, Shuah Khan wrote: Add media

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

At Tue, 21 Oct 2014 17:42:51 +0200, Hans Verkuil wrote: On 10/16/2014 04:48 PM, Takashi Iwai wrote: At Thu, 16 Oct 2014 08:39:14 -0600, Shuah Khan wrote: On 10/16/2014 08:16 AM, Takashi Iwai wrote: At Thu, 16 Oct 2014 08:10:52 -0600, Shuah Khan wrote: On 10/16/2014 08:01 AM

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

At Tue, 21 Oct 2014 12:08:59 -0400, Devin Heitmueller wrote: Sorry, I'm not convinced by that. If the device has to be controlled exclusively, the right position is the open/close. Otherwise, the program cannot know when it becomes inaccessible out of sudden during its operation. I

[PATCH] DocBook: Reduce noise from make cleandocs

I've got a harmless warning when running make cleandocs on an already cleaned tree: Documentation/DocBook/media/Makefile:28: recipe for target 'cleanmediadocs' failed make[1]: [cleanmediadocs] Error 1 (ignored) Suppress this by passing -f to rm. Signed-off-by: Takashi Iwai ti...@suse.de

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

At Sat, 18 Oct 2014 20:49:58 +0200, Mauro Carvalho Chehab wrote: Em Thu, 16 Oct 2014 08:59:29 -0600 Shuah Khan shua...@osg.samsung.com escreveu: On 10/16/2014 08:48 AM, Takashi Iwai wrote: At Thu, 16 Oct 2014 08:39:14 -0600, Shuah Khan wrote: On 10/16/2014 08:16 AM, Takashi

Re: [PATCH v2 1/6] media: add media token device resource framework

At Wed, 15 Oct 2014 18:53:28 -0600, Shuah Khan wrote: On 10/15/2014 11:05 AM, Takashi Iwai wrote: +#if defined(CONFIG_MEDIA_SUPPORT) +extern int media_tknres_create(struct device *dev); +extern int media_tknres_destroy(struct device *dev); + +extern int media_get_tuner_tkn(struct

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

At Thu, 16 Oct 2014 07:10:37 -0600, Shuah Khan wrote: On 10/16/2014 06:00 AM, Lars-Peter Clausen wrote: On 10/14/2014 04:58 PM, Shuah Khan wrote: [...] switch (cmd) { case SNDRV_PCM_TRIGGER_START: +err = media_get_audio_tkn(subs-dev-dev); +if (err ==

Re: [PATCH v2 0/6] media token resource framework

At Wed, 15 Oct 2014 14:21:34 -0600, Shuah Khan wrote: On 10/15/2014 10:48 AM, Takashi Iwai wrote: At Tue, 14 Oct 2014 08:58:36 -0600, Shuah Khan wrote: Add media token device resource framework to allow sharing resources such as tuner, dma, audio etc. across media drivers and non

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

At Thu, 16 Oct 2014 08:10:52 -0600, Shuah Khan wrote: On 10/16/2014 08:01 AM, Takashi Iwai wrote: At Thu, 16 Oct 2014 07:10:37 -0600, Shuah Khan wrote: On 10/16/2014 06:00 AM, Lars-Peter Clausen wrote: On 10/14/2014 04:58 PM, Shuah Khan wrote: [...] switch (cmd

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

At Thu, 16 Oct 2014 08:39:14 -0600, Shuah Khan wrote: On 10/16/2014 08:16 AM, Takashi Iwai wrote: At Thu, 16 Oct 2014 08:10:52 -0600, Shuah Khan wrote: On 10/16/2014 08:01 AM, Takashi Iwai wrote: At Thu, 16 Oct 2014 07:10:37 -0600, Shuah Khan wrote: On 10/16/2014 06:00 AM, Lars

Re: [PATCH v2 0/6] media token resource framework

At Tue, 14 Oct 2014 08:58:36 -0600, Shuah Khan wrote: Add media token device resource framework to allow sharing resources such as tuner, dma, audio etc. across media drivers and non-media sound drivers that control media hardware. The Media token resource is created at the main struct

Re: [PATCH v2 1/6] media: add media token device resource framework

At Tue, 14 Oct 2014 08:58:37 -0600, Shuah Khan wrote: Add media token device resource framework to allow sharing resources such as tuner, dma, audio etc. across media drivers and non-media sound drivers that control media hardware. The Media token resource is created at the main struct

[ANNOUNCE] Linux Audio Mini Summit 2014, Oct. 14, Düsseldorf, Germany

Hi, like previous years, we're going to hold a meeting to discuss lowlevel audio on Linux. This time it's along with Linux Plumbers conference, but for avoiding the conflicts with other LPC mini conferences (including Media Mini-summit, of course :), it'll be held on Tuesday October 14, at the

[PATCH] [media] ivtv: Fix Oops when no firmware is loaded

of this driver. Bugzilla: https://apibugzilla.novell.com/show_bug.cgi?id=875440 Cc: sta...@vger.kernel.org Signed-off-by: Takashi Iwai ti...@suse.de --- drivers/media/pci/ivtv/ivtv-alsa-pcm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/pci/ivtv/ivtv-alsa-pcm.c b

Re: [PATCH][RESEND 6/8] ALSA: memalloc: use gen_pool_dma_alloc() to allocate iram buffer

At Fri, 1 Nov 2013 19:48:19 +0800, Nicolin Chen wrote: Since gen_pool_dma_alloc() is introduced, we implement it to simplify code. Signed-off-by: Nicolin Chen b42...@freescale.com Acked-by: Takashi Iwai ti...@suse.de --- sound/core/memalloc.c | 6 +- 1 file changed, 1 insertion

Re: [PATCH 6/8] ALSA: ppc: keywest: Don't use i2c_client-driver

Acked-by: Takashi Iwai ti...@suse.de thanks, Takashi --- sound/ppc/keywest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/ppc/keywest.c b/sound/ppc/keywest.c index 01aecc2..0d1c27e 100644 --- a/sound/ppc/keywest.c +++ b/sound/ppc/keywest.c @@ -65,7

Re: [PATCH] [media] sound/pci/Kconfig: select RADIO_ADAPTERS if needed

) That happens because a radio driver is selected, without selecting the RADIO_ADAPTERS menu. Reported-by: kbuild test robot fengguang...@intel.com Cc: Takashi Iwai ti...@suse.de Feel free to take my ACK, if any. Acked-by: Takashi Iwai ti...@suse.de thanks, Takashi Signed-off-by: Mauro

Re: [alsa-devel] [PATCH 0/2] tea575x: Move from sound to media

patches, Acked-by: Takashi Iwai ti...@suse.de Feel free to move them into media git tree for 3.12 kernel. thanks, Takashi -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

  1   2   >