[PATCH] [media] mtk-vcodec: fix vp9 decode error

Fix The camera has a blurry screen phenomenon when we video chat with apprtc using vp9 codec Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- .../media/platform/mtk-vcodec/vdec/vdec_vp9_if.c | 37 -- 1 file changed, 35 insertions(+), 2 deletions(-) diff

Re: [PATCH v2] [media] mtk-vcodec: Show mtk driver error without DEBUG definition

On Tue, 2017-05-30 at 18:53 +0900, Hirokazu Honda wrote: > A driver error message is shown without DEBUG definition > to find an error and debug easily. > > Signed-off-by: Hirokazu Honda <hi...@chromium.org> Acked-by: Tiffany Lin <tiffany@mediatek.com> > --- &g

Re: [PATCH] media: mtk-vcodec: remove informative log

On Wed, 2017-04-19 at 07:56 -0300, Mauro Carvalho Chehab wrote: > Em Wed, 5 Apr 2017 19:09:59 +0800 > Tiffany Lin <tiffany@mediatek.com> escreveu: > > > On Wed, 2017-04-05 at 18:54 +0800, Minghsiu Tsai wrote: > > > Driver is stable. Remov

Re: [PATCH] [media] mtk-vcodec: avoid warnings because of empty macros

-#define mtk_vcodec_debug(h, fmt, args...) > -#define mtk_vcodec_err(h, fmt, args...) > -#define mtk_vcodec_debug_enter(h) > -#define mtk_vcodec_debug_leave(h) > +#define mtk_vcodec_debug(h, fmt, args...) {} > +#define mtk_vcodec_err(h, fmt, args...) {} > +#define mtk_vcodec_debug_enter(h) {} > +#define mtk_vcodec_debug_leave(h) {} > > #endif > Acked-by: Tiffany Lin <tiffany@mediatek.com>

Re: [PATCH] media: mtk-vcodec: remove informative log

On Wed, 2017-04-05 at 18:54 +0800, Minghsiu Tsai wrote: > Driver is stable. Remove DEBUG definition from driver. > > There are debug message in /var/log/messages if DEBUG is defined, > such as: > [MTK_V4L2] level=0 fops_vcodec_open(),170: decoder capability 0 > [MTK_V4L2] level=0

Re: [PATCH v3 1/1] mtk-vcodec: check the vp9 decoder buffer index from VPU.

On Wed, 2017-03-08 at 11:40 +0800, Wu-Cheng Li wrote: > From: Wu-Cheng Li <wuchen...@google.com> > > VPU firmware has a bug and may return invalid buffer index for > some vp9 videos. Check the buffer indexes before accessing the > buffer. > Acked-by: Tiffany Lin &

Re: [PATCH v2 1/1] mtk-vcodec: check the vp9 decoder buffer index from VPU.

On Tue, 2017-03-07 at 22:42 +0800, Wu-Cheng Li wrote: > From: Wu-Cheng Li > > VPU firmware has a bug and may return invalid buffer index for > some vp9 videos. Check the buffer indexes before accessing the > buffer. > > Signed-off-by: Wu-Cheng Li >

Re: [PATCH 1/1] mtk-vcodec: check the vp9 decoder buffer index from VPU.

On Tue, 2017-03-07 at 14:03 +0800, Wu-Cheng Li wrote: > From: Wu-Cheng Li > > VPU firmware has a bug and may return invalid buffer index for > some vp9 videos. Check the buffer indexes before accessing the > buffer. > > Signed-off-by: Wu-Cheng Li >

Re: [PATCH -next] [media] mtk-vcodec: remove redundant return value check of platform_get_resource()

On Tue, 2017-02-07 at 15:16 +, Wei Yongjun wrote: > From: Wei Yongjun > > Remove unneeded error handling on the result of a call > to platform_get_resource() when the value is passed to > devm_ioremap_resource(). > > Signed-off-by: Wei Yongjun

Re: [bug report] [media] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver

Hi Hans, Dan, On Wed, 2016-11-09 at 14:45 +0100, Hans Verkuil wrote: > On 11/09/16 14:28, Dan Carpenter wrote: > > Hello Tiffany Lin, > > > > The patch 590577a4e525: "[media] vcodec: mediatek: Add Mediatek V4L2 > > Video Decoder Driver" from Sep 2, 2016, lead

Re: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver

Hi Mauro, On Mon, 2016-10-24 at 07:05 -0200, Mauro Carvalho Chehab wrote: > Em Mon, 24 Oct 2016 11:22:08 +0800 > Tiffany Lin <tiffany@mediatek.com> escreveu: > > > Hi Mauro, > > > > On Fri, 2016-10-21 at 11:01 -0200, Mauro Carvalho Chehab wrote: > &

Re: FW: [PATCH] mtk-vcodec: fix some smatch warnings

^~~ > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Tiffany Lin <tiffany@mediatek.com> > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 2 -- > drivers/media/platform/mtk-vcodec/vdec_drv_if.c | 1 + > 2

Re: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver

Hi Mauro, On Fri, 2016-10-21 at 11:01 -0200, Mauro Carvalho Chehab wrote: > Em Fri, 2 Sep 2016 20:19:54 +0800 > Tiffany Lin <tiffany@mediatek.com> escreveu: > > > Add v4l2 layer decoder driver for MT8173 > > > > Signed-off-by: Tiffany Lin <tiffany@me

Re: [PATCH] pixfmt-reserved.rst: Improve MT21C documentation

Hi Hans, On Mon, 2016-09-19 at 09:22 +0200, Hans Verkuil wrote: > Improve the MT21C documentation, making it clearer that this format requires > the MDP > for further processing. > > Also fix the fourcc (it was a fivecc :-) ) > reviewed-by: Tiffany Lin <tiffany@mediate

Re: [PATCH v2 2/4] docs-rst: Add compressed video formats used on MT8173 codec driver

Hi Hans, On Wed, 2016-09-14 at 13:51 +0200, Hans Verkuil wrote: > Hi Tiffany, > > On 09/09/2016 05:48 PM, Tiffany Lin wrote: > > Add V4L2_PIX_FMT_MT21C documentation > > > > Signed-off-by: Tiffany Lin <tiffany@mediatek.com> > > --- > > Doc

Re: [PATCH 0/4] Add V4L2_PIX_FMT_MT21C format for MT8173 codec driver

Hi Hans, On Thu, 2016-09-08 at 11:27 +0200, Hans Verkuil wrote: > On 09/08/16 11:11, Tiffany Lin wrote: > > Hi Hans, > > > > On Thu, 2016-09-08 at 09:21 +0200, Hans Verkuil wrote: > >> Hi Tiffany, > >> > >> On 09/07/2016 08:56 AM, Tiffany Lin wrote:

[PATCH v2 4/4] arm64: dts: mediatek: Add Video Decoder for MT8173

Add video decoder node for MT8173 Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 ++ 1 file changed, 44 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/me

[PATCH v2 3/4] vcodec: mediatek: Add V4L2_PIX_FMT_MT21C support for v4l2 decoder

Add V4L2_PIX_FMT_MT21C support Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/pl

[PATCH v2 2/4] docs-rst: Add compressed video formats used on MT8173 codec driver

Add V4L2_PIX_FMT_MT21C documentation Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- Documentation/media/uapi/v4l/pixfmt-reserved.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/media/uapi/v4l/pixfmt-reserved.rst b/Documentation/media/ua

[PATCH v2 0/4] Add V4L2_PIX_FMT_MT21C format for MT8173 codec driver

2M/NV21M/YUV420M/YVU420M -> Encoder -> H264/VP8 When playback, the pipeline will be: H264/VP8/VP9 -> Decoder driver -> MT21C -> MDP Driver -> DRM [1]https://patchwork.kernel.org/patch/9305329/ --- v2: add more information for MT21C in docs-rst --- Tiffany Lin (4): v4l: add Mediate

Re: [PATCH 0/4] Add V4L2_PIX_FMT_MT21C format for MT8173 codec driver

Hi Hans, On Thu, 2016-09-08 at 09:21 +0200, Hans Verkuil wrote: > Hi Tiffany, > > On 09/07/2016 08:56 AM, Tiffany Lin wrote: > > This patch series add Mediatek compressed block format V4L2_PIX_FMT_MT21C, > > the > > decoder driver will decoded bitstream t

Re: [PATCH 2/4] docs-rst: Add compressed video formats used on MT8173 codec driver

Hi Hans, On Wed, 2016-09-07 at 11:23 +0200, Hans Verkuil wrote: > On 09/07/16 08:56, Tiffany Lin wrote: > > Add V4L2_PIX_FMT_MT21C documentation > > > > Signed-off-by: Tiffany Lin <tiffany@mediatek.com> > > --- > > Documentation/media/uapi/v4l/pixfmt

Re: [PATCH] [media] VPU: mediatek: fix null pointer dereference on pdev

On Wed, 2016-09-07 at 18:10 +0100, Colin King wrote: > From: Colin Ian King > > pdev is being null checked, however, prior to that it is being > dereferenced by platform_get_drvdata. Move the assignments of > vpu and run to after the pdev null check to avoid a

[PATCH v3] vcodec: mediatek: add Maintainers entry for Mediatek MT8173 vcodec drivers

Add Tiffany Lin and Andrew-CT Chen as maintainers for Mediatek MT8173 vcodec drivers Signed-off-by: Tiffany Lin <tiffany@mediatek.com> Signed-off-by: Andrew-CT Chen <andrew-ct.c...@mediatek.com> --- v3: Move MEDIATEK MEDIA DRIVER after MEDIATEK ETHERNET DRIVER to follow alpha

[PATCH 3/4] vcodec: mediatek: Add V4L2_PIX_FMT_MT21C support for v4l2 decoder

Add V4L2_PIX_FMT_MT21C support Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/pl

[PATCH 0/4] Add V4L2_PIX_FMT_MT21C format for MT8173 codec driver

2M/NV21M/YUV420M/YVU420M -> Encoder -> H264/VP8 When playback, the pipeline will be: H264/VP8/VP9 -> Decoder driver -> MT21C -> MDP Driver -> DRM [1]https://patchwork.kernel.org/patch/9305329/ Tiffany Lin (4): v4l: add Mediatek compressed video block format docs-rst: Add compressed

[PATCH 4/4] arm64: dts: mediatek: Add Video Decoder for MT8173

Add video decoder node for MT8173 Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 ++ 1 file changed, 44 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/me

[PATCH 1/4] v4l: add Mediatek compressed video block format

Add V4L2_PIX_FMT_MT21C format used on MT8173 driver. It is compressed format and need MT8173 MDP driver to transfer to other standard format. Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/v4l2-core/v4l2-ioctl.c |1 + include/uapi/linux/videodev2.h |

[PATCH 2/4] docs-rst: Add compressed video formats used on MT8173 codec driver

Add V4L2_PIX_FMT_MT21C documentation Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- Documentation/media/uapi/v4l/pixfmt-reserved.rst |6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/media/uapi/v4l/pixfmt-reserved.rst b/Documentation/media/uapi/v4l/

[PATCH v2] vcodec: mediatek: add Maintainers entry for Mediatek MT8173 vcodec drivers

Add Tiffany Lin and Andrew-CT Chen as maintainers for Mediatek MT8173 vcodec drivers Signed-off-by: Tiffany Lin <tiffany@mediatek.com> Signed-off-by: Andrew-CT Chen <andrew-ct.c...@mediatek.com> --- v2: Rename MT8173 MEDIA DRIVER to MEDIATEK MEDIA DRIVER --- MAINTAINERS |9

[PATCH] vcodec: mediatek: Fix decoder compiler/sparse warnings

This patch fix decoder compiler/sparse warnings Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- .../media/platform/mtk-vcodec/vdec/vdec_h264_if.c |7 --- .../media/platform/mtk-vcodec/vdec/vdec_vp8_if.c |1 + .../media/platform/mtk-vcodec/vdec/vdec_vp9_if.c

Re: [PATCH] vcodec: mediatek: fix odd_ptr_err.cocci warnings

On Tue, 2016-09-06 at 22:51 +0800, Julia Lawall wrote: > PTR_ERR should access the value just tested by IS_ERR > > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > > CC: Tiffany Lin <tiffany@mediatek.com> > Signed-off-by: Julia Lawall <julia.l

[PATCH] vcodec: mediatek: add Maintainers entry for Mediatek MT8173 vcodec drivers

Add Tiffany Lin and Andrew-CT Chen as maintainers for Mediatek MT8173 vcodec drivers Signed-off-by: Tiffany Lin <tiffany@mediatek.com> Signed-off-by: Andrew-CT Chen <andrew-ct.c...@mediatek.com> --- MAINTAINERS |9 + 1 file changed, 9 insertions(+) diff --git a/M

[PATCH] vcodec: mediatek: Add V4L2_CAP_TIMEPERFRAME capability setting

This patch setting V4L2_CAP_TIMEPERFRAME capability in vidioc_venc_s/g_parm functions Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/mtk-

Re: [PATCH v5 0/9] Add MT8173 Video Decoder Driver

Hi Hans, On Mon, 2016-09-05 at 13:26 +0200, Hans Verkuil wrote: > On 09/05/2016 12:52 PM, Tiffany Lin wrote: > > Hi Hans, > > > > On Mon, 2016-09-05 at 12:09 +0200, Hans Verkuil wrote: > >> On 09/05/2016 11:53 AM, Hans Verkuil wrote: > >>> On 09/05/2

Re: [PATCH v5 0/9] Add MT8173 Video Decoder Driver

Hi Hans, On Mon, 2016-09-05 at 12:09 +0200, Hans Verkuil wrote: > On 09/05/2016 11:53 AM, Hans Verkuil wrote: > > On 09/05/2016 11:50 AM, Tiffany Lin wrote: > >> Hi Hans, > >> > >> On Mon, 2016-09-05 at 11:33 +0200, Hans Verkuil wrote: > >&g

Re: [PATCH v5 0/9] Add MT8173 Video Decoder Driver

Hi Hans, On Mon, 2016-09-05 at 11:33 +0200, Hans Verkuil wrote: > On 09/02/2016 02:19 PM, Tiffany Lin wrote: > > == > > Introduction > > == > > > > The purpose of this series is to add the driver for video codec hw embedded

[PATCH v5 8/9] Add documentation for V4L2_PIX_FMT_VP9.

Add documentation for V4L2_PIX_FMT_VP9. Signed-off-by: Tiffany Lin <tiffany@mediatek.com> Signed-off-by: Wu-Cheng Li <wuchen...@chromium.org> --- Documentation/media/uapi/v4l/pixfmt-013.rst |8 1 file changed, 8 insertions(+) diff --git a/Documentation/media/uapi/v4

[PATCH v5 5/9] vcodec: mediatek: Add Mediatek VP8 Video Decoder Driver

Add vp8 decoder driver for MT8173 Signed-off-by: PC Chen <pc.c...@mediatek.com> Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/Makefile |1 + .../media/platform/mtk-vcodec/vdec/vdec_vp8_if.c | 633 d

[PATCH v5 6/9] videodev2.h: add V4L2_PIX_FMT_VP9 format.

From: Wu-Cheng Li <wuchen...@chromium.org> This adds VP9 video coding format, a successor to VP8. Signed-off-by: Wu-Cheng Li <wuchen...@chromium.org> Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- include/uapi/linux/videodev2.h |1 + 1 file changed, 1 insert

[PATCH v5 0/9] Add MT8173 Video Decoder Driver

setting 2. Refine vp9 codec driver 3. Refine v4l2 codec driver Change in v2: 1. Add documentation for V4L2_PIX_FMT_MT21 2. Remove DRM_FORMAT_MT21 2. Refine code according to review comments Andrew-CT Chen (1): VPU: mediatek: Add decode support Tiffany Lin (10): dt-bindings: Add a binding

[PATCH v5 2/9] dt-bindings: Add a binding for Mediatek Video Decoder

Add a DT binding documentation of Video Decoder for the MT8173 SoC from Mediatek. Signed-off-by: Tiffany Lin <tiffany@mediatek.com> Acked-by: Rob Herring <r...@kernel.org> --- .../devicetree/bindings/media/mediatek-vcodec.txt | 57 ++-- 1 file changed, 53 inse

[PATCH v5 7/9] v4l2-ioctl: add VP9 format description.

From: Wu-Cheng Li <wuchen...@chromium.org> VP9 is a video coding format and a successor to VP8. Signed-off-by: Wu-Cheng Li <wuchen...@chromium.org> Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/v4l2-core/v4l2-ioctl.c |1 + 1 file changed, 1 insert

[PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver

Add v4l2 layer decoder driver for MT8173 Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/Makefile | 12 +- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 1433 drivers/media/platform/mtk-vcodec/mtk_vcodec

[PATCH v5 1/9] VPU: mediatek: Add decode support

From: Andrew-CT Chen <andrew-ct.c...@mediatek.com> VPU driver add decode support Signed-off-by: Andrew-CT Chen <andrew-ct.c...@mediatek.com> Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vpu/mtk_vpu.c | 12 drivers/medi

[PATCH v5 9/9] vcodec: mediatek: Add Mediatek VP9 Video Decoder Driver

Add vp9 decoder driver for MT8173 Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/Makefile |1 + drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 10 + .../media/platform/mtk-vcodec/vdec/vdec_vp9_if.c

[PATCH v5 4/9] vcodec: mediatek: Add Mediatek H264 Video Decoder Drive

Add h264 decoder driver for MT8173 Signed-off-by: PC Chen <pc.c...@mediatek.com> Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/Makefile |3 +- .../media/platform/mtk-vcodec/vdec/vdec_h264_if.c | 506 d

Re: [PATCH v3 0/9] Add MT8173 Video Decoder Driver

Hi Hans, On Mon, 2016-08-15 at 11:07 +0200, Hans Verkuil wrote: > On 08/15/2016 11:03 AM, Tiffany Lin wrote: > > Hi Hans, > > > > I upstream v4 on 8/10, I don't know why this version is not shown in > > https://patchwork.kernel.org. > > But I cou

Re: [PATCH v3 0/9] Add MT8173 Video Decoder Driver

se > needs to be updated as well due to the move to sphinx. > > Thanks! > > Hans > > On 05/30/2016 02:29 PM, Tiffany Lin wrote: > > == > > Introduction > > == > > > > The purpose of this series is to add the driver for vid

Re: [PATCH] vcodec: mediatek: bug fix and code refine for mt8173 v4l2 Encoder

Hi Hans, On Sun, 2016-08-14 at 13:40 +0200, Hans Verkuil wrote: > On 08/12/2016 04:35 PM, Tiffany Lin wrote: > > This patch include fixs: > > 1. Remove unused include in mtk_vcodec_drv.h > > 2. Fix visible_height larger than coded_height issue in s_fmt_out >

[PATCH for v4.8] vcodec:mediatek: Refine VP8 encoder driver

This patch remove field and function that unused anymore Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- .../media/platform/mtk-vcodec/venc/venc_vp8_if.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/media/platform/mtk-vcode

[PATCH for v4.8] vcodec:mediatek: Refine H264 encoder driver

This patch : 1. remove field and function that unused anymore 2. add support V4L2_MPEG_VIDEO_H264_LEVEL_4_2 Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- .../media/platform/mtk-vcodec/venc/venc_h264_if.c | 16 1 file changed, 8 insertions(+), 8 deletions(-)

[PATCH for v4.8] vcodec:mediatek: change H264 profile default to profile high

This patch change default H264 profile from V4L2_MPEG_VIDEO_H264_PROFILE_MAIN to V4L2_MPEG_VIDEO_H264_PROFILE_HIGH Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH for v4.8] vcodec:mediatek: Add timestamp and timecode copy for V4L2 Encoder

This patch add copying timestamp and timecode from src buffer to dst buffer Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 23 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH for v4.8] vcodec:mediatek: Fix visible_height larger than coded_height issue in s_fmt_out

) So remove extend visible_height or coded_height, user space should just use sizeimage to get real buffer size needed Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 10 -- 1 file changed, 10 deletions(-) diff

[PATCH for v4.8] vcodec:mediatek: Fix fops_vcodec_release flow for V4L2 Encoder

This patch fix that mtk_vcodec_venc_release should be called after v4l2_m2m_ctx_release Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c |7 ++- .../media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c |6 +- 2 files c

[PATCH for v4.8] vcodec:mediatek:code refine for v4l2 Encoder driver

This patch remove unused header and define from haeder files Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h |1 - .../media/platform/mtk-vcodec/mtk_vcodec_intr.h|1 - 2 files changed, 2 deletions(-) diff --git a/d

[PATCH v6] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

This patch add g/s_selection for MT8173 V4L2 Encoder. Only output queue support g/s_selection to configure crop. The top/left of active rectangle should always be (0,0) Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- v6: - remove unused err variable from s_selection v5: -

[PATCH] vcodec: mediatek: bug fix and code refine for mt8173 v4l2 Encoder

MTK_INST_WORK_THREAD_ABORT_DONE 6. Add support V4L2_MPEG_VIDEO_H264_LEVEL_4_2 4. Refine venc_h264_if.c and venc_vp8_if.c Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h |1 - drivers/media/platform/mtk-vcodec/mtk_vcodec

[PATCH v5] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

This patch add g/s_selection for MT8173 V4L2 Encoder. Only output queue support g/s_selection to configure crop. The top/left of active rectangle should always be (0,0). Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- v5: - remove visible_height change to a separate patch v4

Re: [PATCH v4 9/9] arm64: dts: mediatek: Add Video Decoder for MT8173

Hi Matthias, On Thu, 2016-08-11 at 17:44 +0200, Matthias Brugger wrote: > > On 10/08/16 16:48, Tiffany Lin wrote: > > Add video decoder node for MT8173 > > > > Signed-off-by: Tiffany Lin <tiffany@mediatek.com> > > --- > > arch/

Re: [PATCHv2] v4l2-common: add s_selection helper function

Hi Hans, On Fri, 2016-08-05 at 15:57 +0200, Hans Verkuil wrote: > Hi Tiffany, > > We just had a long discussion about whether or not -ERANGE should be returned > if the constraint flags could not be satisfied, and the end result was that > the driver should not return an error in that case, but

Re: [PATCH v3] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

Hi Hans, On Thu, 2016-08-04 at 15:00 +0200, Hans Verkuil wrote: > > On 08/04/2016 12:08 PM, Tiffany Lin wrote: > > This patch add g/s_selection support for MT8173 v4l2 encoder > > > > Signed-off-by: Tiffany Lin <tiffany@mediatek.com> > > --- > &g

[PATCH v3] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

This patch add g/s_selection support for MT8173 v4l2 encoder Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- v3: - add v4l2_s_selection to check constraint flags - remove visible_height modification in s_fmt_out --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c

Re: [PATCH v3 5/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver

Hi Hans, On Mon, 2016-08-01 at 12:39 +0200, Hans Verkuil wrote: > Hi Tiffany, > > On 08/01/2016 11:38 AM, Tiffany Lin wrote: > > Hi Hans, > > > > >>> +static int vidioc_vdec_g_selection(struct file *file, void *priv, > >>> + s

Re: [PATCH v3 5/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver

Hi Hans, On Fri, 2016-07-08 at 13:06 +0200, Hans Verkuil wrote: > On 05/30/2016 02:29 PM, Tiffany Lin wrote: > > Add v4l2 layer decoder driver for MT8173 > > > > Signed-off-by: Tiffany Lin <tiffany@mediatek.com> > > --- > > drivers/media/plat

[PATCH v2] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 83 ++-- 1 file changed, 78 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mtk-

Re: [PATCH v3 0/9] Add MT8173 Video Decoder Driver

Hi Hans, On Fri, 2016-07-08 at 13:44 +0200, Hans Verkuil wrote: > On 07/07/2016 12:16 PM, tiffany lin wrote: > > Hi Hans, > > > > > > On Wed, 2016-07-06 at 15:19 +0200, Hans Verkuil wrote: > >> Hi Tiffany, > >> > >> I plan to review

Re: [PATCH] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

Hi Hans, On Mon, 2016-07-18 at 14:44 +0200, Hans Verkuil wrote: > On 07/18/2016 02:28 PM, tiffany lin wrote: > > Understood now. > > > > Now I am trying to figure out how to make this function right. > > Our encoder only support crop range from (0, 0) to (width, height

Re: [PATCH] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

On Fri, 2016-07-15 at 19:50 +0200, Hans Verkuil wrote: > On 07/14/2016 08:27 AM, tiffany lin wrote: > > Hi Hans, > > > > > > On Mon, 2016-07-11 at 06:32 +0200, Hans Verkuil wrote: > >> Hi Tiffany, > >> > >> My apologies for the delay, but he

Re: [PATCH] [media] mtk-vcodec: fix type mismatches

On Mon, 2016-07-11 at 23:37 +0200, Arnd Bergmann wrote: > The newly added mtk-vcodec driver produces a number of warnings in an ARM > allmodconfig build, mainly since it assumes that dma_addr_t is 32-bit wide: > > mtk-vcodec/venc/venc_vp8_if.c: In function 'vp8_enc_alloc_work_buf': >

Re: [PATCH v3 3/9] DocBook/v4l: Add compressed video formats used on MT8173 codec driver

Hi Nicolas, On Wed, 2016-07-13 at 09:55 -0400, Nicolas Dufresne wrote: > Le mercredi 13 juillet 2016 à 10:00 +0800, tiffany lin a écrit : > > Hi Nicolas, > > > > On Tue, 2016-07-12 at 15:14 -0400, Nicolas Dufresne wrote: > > > Le mardi 12 juillet 2016 à 15:08 -

Re: [PATCH] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

Hi Hans, On Mon, 2016-07-11 at 06:32 +0200, Hans Verkuil wrote: > Hi Tiffany, > > My apologies for the delay, but here is my review at last: > > On 05/30/2016 09:52 AM, Tiffany Lin wrote: > > This patch add g/s_selection support for MT8173 > > > > Si

Re: [PATCH] [media] mtk-vcodec: fix type mismatches

Hi Arnd, On Wed, 2016-07-13 at 15:08 +0200, Arnd Bergmann wrote: > On Wednesday, July 13, 2016 5:56:26 PM CEST tiffany lin wrote: > > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c > > > b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c >

Re: [PATCH] [media] mtk-vcodec: fix type mismatches

Hi Arnd, On Mon, 2016-07-11 at 23:37 +0200, Arnd Bergmann wrote: > The newly added mtk-vcodec driver produces a number of warnings in an ARM > allmodconfig build, mainly since it assumes that dma_addr_t is 32-bit wide: > > mtk-vcodec/venc/venc_vp8_if.c: In function 'vp8_enc_alloc_work_buf': >

[PATCH] [media] mtk-vcodec: fix default OUTPUT buffer size

When calculate OUTPUT buffer size in vidioc_try_fmt, it will add more size hw need in each plane. But in mtk_vcodec_enc_set_default_params, it do not add same size in each plane. This makes v4l2-compliance test fail. This patch fix the issue. Signed-off-by: Tiffany Lin <tiffany@mediatek.

Re: [PATCH v3 3/9] DocBook/v4l: Add compressed video formats used on MT8173 codec driver

On Tue, 2016-07-12 at 16:16 +0800, Wu-Cheng Li (李務誠) wrote: > On Mon, Jul 11, 2016 at 10:56 AM, tiffany lin <tiffany@mediatek.com> > wrote: > > Hi Hans, > > > > On Fri, 2016-07-08 at 12:23 +0200, Hans Verkuil wrote: > >> On 05/30/2016 02:29 PM, Tiffany

Re: [PATCH v3 3/9] DocBook/v4l: Add compressed video formats used on MT8173 codec driver

Hi Nicolas, On Tue, 2016-07-12 at 15:14 -0400, Nicolas Dufresne wrote: > Le mardi 12 juillet 2016 à 15:08 -0400, Nicolas Dufresne a écrit : > > Le mardi 12 juillet 2016 à 16:16 +0800, Wu-Cheng Li (李務誠) a écrit : > > > Decoder hardware produces MT21 (compressed). Image processor can > > > convert

Re: [PATCH v3 3/9] DocBook/v4l: Add compressed video formats used on MT8173 codec driver

Hi Nicolas, On Tue, 2016-07-12 at 15:08 -0400, Nicolas Dufresne wrote: > Le mardi 12 juillet 2016 à 16:16 +0800, Wu-Cheng Li (李務誠) a écrit : > > Decoder hardware produces MT21 (compressed). Image processor can > > convert it to a format that can be input of display driver. Tiffany. > > When do

Re: [PATCH -next] [media] mtk-vcodec: remove redundant dev_err call in mtk_vcodec_probe()

Reviewed-by: Tiffany Lin <tiffany@mediatek.com> On Tue, 2016-07-12 at 11:02 +, weiyj...@163.com wrote: > From: Wei Yongjun <yongjun_...@trendmicro.com.cn> > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid r

Re: [PATCH -next] [media] vcodec: mediatek: Fix return value check in mtk_vcodec_init_enc_pm()

Reviewed-by:Tiffany Lin On Tue, 2016-07-12 at 11:02 +, weiyj...@163.com wrote: > From: Wei Yongjun > > In case of error, the function devm_clk_get() returns ERR_PTR() > and not returns NULL. The NULL test in the return value check >

Re: [PATCH] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

Hi Hans, On Mon, 2016-07-11 at 06:32 +0200, Hans Verkuil wrote: > Hi Tiffany, > > My apologies for the delay, but here is my review at last: > > On 05/30/2016 09:52 AM, Tiffany Lin wrote: > > This patch add g/s_selection support for MT8173 > > > > Si

Re: [PATCH v3 0/9] Add MT8173 Video Decoder Driver

Hi Hans, On Fri, 2016-07-08 at 13:44 +0200, Hans Verkuil wrote: > On 07/07/2016 12:16 PM, tiffany lin wrote: > > Hi Hans, > > > > > > On Wed, 2016-07-06 at 15:19 +0200, Hans Verkuil wrote: > >> Hi Tiffany, > >> > >> I plan to review

Re: [PATCH 1/2] mtk-vcodec: convert driver to use the new vb2_queue dev field

reviewed-by: Tiffany Lin <tiffany@mediatek.com> May I know why and how we use struct device *alloc_devs[] in queue_setup callback function? best regards, Tiffany On Fri, 2016-07-08 at 21:11 +0200, Hans Verkuil wrote: > From: Hans Verkuil <hans.verk...@cisco.com> > &g

Re: [PATCH 2/2] drivers/media/platform/Kconfig: fix VIDEO_MEDIATEK_VCODEC dependency

config > @@ -168,7 +168,7 @@ config VIDEO_MEDIATEK_VPU > > config VIDEO_MEDIATEK_VCODEC > tristate "Mediatek Video Codec driver" > - depends on MTK_IOMMU > + depends on MTK_IOMMU || COMPILE_TEST > depends on VIDEO_DEV && VIDEO_V4L2 > de

Re: [PATCH 1/2] mtk-vcodec: fix two compiler warnings

Size=%zu", > frm_buf.fb_addr[0].va, > (u64)frm_buf.fb_addr[0].dma_addr, > frm_buf.fb_addr[0].size, reviewed-by: Tiffany Lin <tiffany@mediatek.com> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] mtk-vcodec: fix compiler warning

gt; + struct venc_vpu_inst *vpu = > + (struct venc_vpu_inst *)(unsigned long)msg->venc_inst; > reviewed-by: Tiffany Lin <tiffany@mediatek.com> > mtk_vcodec_debug(vpu, "msg_id %x inst %p status %d", >msg->msg_id,

Re: [PATCH v3 3/9] DocBook/v4l: Add compressed video formats used on MT8173 codec driver

Hi Hans, On Fri, 2016-07-08 at 12:23 +0200, Hans Verkuil wrote: > On 05/30/2016 02:29 PM, Tiffany Lin wrote: > > Add V4L2_PIX_FMT_MT21 documentation > > > > Signed-off-by: Tiffany Lin <tiffany@mediatek.com> > > --- > > Documentation/DocBook/media/v

Re: [PATCH v2 2/9] [media] : v4l: add Mediatek compressed video block format

Hi Hans, On Fri, 2016-07-08 at 12:18 +0200, Hans Verkuil wrote: > On 05/12/2016 01:24 PM, Tiffany Lin wrote: > > Add V4L2_PIX_FMT_MT21 format used on MT8173 driver. > > It is compressed format and need MT8173 MDP driver to transfer to other > > standard format. > >

Re: [PATCH v3 0/9] Add MT8173 Video Decoder Driver

Hi Hans, On Wed, 2016-07-06 at 15:19 +0200, Hans Verkuil wrote: > Hi Tiffany, > > I plan to review this patch series on Friday, but one obvious question is > what the reason for these failures is: > > > Input/Output configuration ioctls: > > test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not

Re: [PATCH v3 0/9] Add MT8173 Video Decoder Driver

Hi Mauro, On Wed, 2016-06-08 at 07:13 +0900, Hans Verkuil wrote: > > On 06/07/2016 11:22 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 30 May 2016 20:29:14 +0800 > > Tiffany Lin <tiffany@mediatek.com> escreveu: > > > >

[PATCH v3 0/9] Add MT8173 Video Decoder Driver

TE_BUFS/QUERYBUF: OK fail: ../../../v4l-utils-1.6.0/utils/v4l2-compliance/v4l2-test-buffers.cpp(500): q.has_expbuf(node) test VIDIOC_EXPBUF: FAIL Total: 38, Succeeded: 33, Failed: 5, Warnings: 0 Andrew-CT Chen (1): VPU: mediatek: Add decode support Tiffany

[PATCH v3 4/9] dt-bindings: Add a binding for Mediatek Video Decoder

Add a DT binding documentation of Video Decoder for the MT8173 SoC from Mediatek. Signed-off-by: Tiffany Lin <tiffany@mediatek.com> Acked-by: Rob Herring <r...@kernel.org> --- .../devicetree/bindings/media/mediatek-vcodec.txt | 57 ++-- 1 file changed, 53 inse

[PATCH v3 9/9] arm64: dts: mediatek: Add Video Decoder for MT8173

Add video decoder node for MT8173 Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 ++ 1 file changed, 44 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/me

[PATCH v3 3/9] DocBook/v4l: Add compressed video formats used on MT8173 codec driver

Add V4L2_PIX_FMT_MT21 documentation Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- Documentation/DocBook/media/v4l/pixfmt.xml |6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/DocBook/media/v4l/pixfmt.xml b/Documentation/DocBook/media/v4l/pixfmt.xml

[PATCH v3 2/9] v4l: add Mediatek compressed video block format

Add V4L2_PIX_FMT_MT21 format used on MT8173 driver. It is compressed format and need MT8173 MDP driver to transfer to other standard format. Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- include/uapi/linux/videodev2.h |1 + 1 file changed, 1 insertion(+) diff --git a/i

[PATCH v3 7/9] vcodec: mediatek: Add Mediatek VP8 Video Decoder Driver

Add vp8 decoder driver for MT8173 Signed-off-by: PC Chen <pc.c...@mediatek.com> Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/Makefile |1 + .../media/platform/mtk-vcodec/vdec/vdec_vp8_if.c | 630 d

[PATCH v3 8/9] vcodec: mediatek: Add Mediatek VP9 Video Decoder Driver

Add vp9 decoder driver for MT8173 Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/Makefile |1 + .../media/platform/mtk-vcodec/vdec/vdec_vp9_if.c | 967 drivers/media/platform/mtk-vcodec/vdec_drv_if.c|

[PATCH v3 6/9] vcodec: mediatek: Add Mediatek H264 Video Decoder Driver

Add h264 decoder driver for MT8173 Signed-off-by: PC Chen <pc.c...@mediatek.com> Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/Makefile |5 +- .../media/platform/mtk-vcodec/vdec/vdec_h264_if.c | 503 d

[PATCH v3 5/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver

Add v4l2 layer decoder driver for MT8173 Signed-off-by: Tiffany Lin <tiffany@mediatek.com> --- drivers/media/platform/mtk-vcodec/Makefile | 10 +- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 1348 drivers/media/platform/mtk-vcodec/mtk_vcodec

  1   2   3   >