Re: [PATCH] media: unify some sony camera sensors pattern naming

2018-11-30 Thread Tomasz Figa
Hi Bingbu, On Mon, Nov 26, 2018 at 7:56 PM wrote: > > From: Bingbu Cao > > Some Sony camera sensors have same test pattern > definitions, this patch unify the pattern naming > to make it more clear to the userspace. > > Suggested-by: Sakari Ailus > Signed-off-by: Bingbu Cao > --- >

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-29 Thread Tomasz Figa
On Thu, Nov 29, 2018 at 6:43 AM Laurent Pinchart wrote: > > Hello Yong, > > On Tuesday, 30 October 2018 00:22:54 EET Yong Zhi wrote: > > Hi, > > > > This series adds support for the Intel IPU3 (Image Processing Unit) > > ImgU which is essentially a modern memory-to-memory ISP. It implements > >

Re: [PATCH v10 4/4] media: add Rockchip VPU JPEG encoder driver

2018-11-28 Thread Tomasz Figa
On Wed, Nov 28, 2018 at 10:05 AM Ezequiel Garcia wrote: > > On Tue, 2018-11-27 at 19:09 +0900, Tomasz Figa wrote: > > On Fri, Nov 23, 2018 at 5:24 AM Ezequiel Garcia > > wrote: > > [snip] > > > > > +const struct rockchip_vpu_variant rk3288_vpu_variant

Re: [PATCH v10 4/4] media: add Rockchip VPU JPEG encoder driver

2018-11-27 Thread Tomasz Figa
On Fri, Nov 23, 2018 at 5:24 AM Ezequiel Garcia wrote: [snip] > > > +const struct rockchip_vpu_variant rk3288_vpu_variant = { > > > + .enc_offset = 0x0, > > > + .enc_fmts = rk3288_vpu_enc_fmts, > > > + .num_enc_fmts = ARRAY_SIZE(rk3288_vpu_enc_fmts), > > > + .codec_ops =

Re: [PATCH] v4l2-ioctl: Zero v4l2_pix_format_mplane reserved fields

2018-11-26 Thread Tomasz Figa
On Tue, Nov 27, 2018 at 8:29 AM Ezequiel Garcia wrote: > > On Mon, 2018-11-26 at 13:14 +0900, Tomasz Figa wrote: > > Hi Ezequiel, > > > > On Sat, Nov 24, 2018 at 2:20 AM Ezequiel Garcia > > wrote: > > > Make the core set the reserved fields

Re: [PATCH] v4l2-ioctl: Zero v4l2_pix_format_mplane reserved fields

2018-11-25 Thread Tomasz Figa
> and every driver. > > Suggested-by: Tomasz Figa > Signed-off-by: Ezequiel Garcia > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 51 > 1 file changed, 45 insertions(+), 6 deletions(-) > Thanks for the patch. Please see my comments inline. > diff

Re: is it possible to use single IOCTL to setup media pipeline?

2018-11-22 Thread Tomasz Figa
On Thu, Nov 22, 2018 at 10:46 PM Sakari Ailus wrote: > > Hi Tomasz, > > On Thu, Nov 22, 2018 at 04:06:36PM +0900, Tomasz Figa wrote: > > Hi Ning, > > > > On Thu, Nov 22, 2018 at 11:52 AM Zhang, Ning A > > wrote: > > > > > > Hello everyon

Re: [GIT PULL FOR v4.21] Add Rockchip VPU JPEG encoder

2018-11-22 Thread Tomasz Figa
On Thu, Nov 22, 2018 at 7:29 PM Hans Verkuil wrote: > > Hi Ezeguiel, > > Just saw Tomasz' in-depth review and decided to drop this pull request. > > He found a few too many issues and I prefer those are addressed first. > > Sorry, still more work for you, on to v11! I'm really sorry for the late

Re: [PATCH v10 3/4] arm64: dts: rockchip: add VPU device node for RK3399

2018-11-22 Thread Tomasz Figa
= <0x0 0xff650800 0x0 0x40>; > @@ -1233,8 +1245,8 @@ > interrupt-names = "vpu_mmu"; > clocks = < ACLK_VCODEC>, < HCLK_VCODEC>; > clock-names = "aclk", "iface"; > + power-domains = < RK3399_PD_VCODEC>; > #iommu-cells = <0>; > - status = "disabled"; > }; > > vdec_mmu: iommu@ff660480 { Reviewed-by: Tomasz Figa Best regards, Tomasz

Re: [PATCH v10 2/4] ARM: dts: rockchip: add VPU device node for RK3288

2018-11-22 Thread Tomasz Figa
t;vpu_mmu"; > clocks = < ACLK_VCODEC>, < HCLK_VCODEC>; > clock-names = "aclk", "iface"; > + power-domains = < RK3288_PD_VIDEO>; > #iommu-cells = <0>; > - status = "disabled"; > }; > > hevc_mmu: iommu@ff9c0440 { Reviewed-by: Tomasz Figa Best regards, Tomasz

Re: [PATCH v10 4/4] media: add Rockchip VPU JPEG encoder driver

2018-11-22 Thread Tomasz Figa
_CTRL_OUTPUT_SWAP32 > + | VEPU_REG_AXI_CTRL_INPUT_SWAP32 > + | VEPU_REG_AXI_CTRL_OUTPUT_SWAP8 > + | VEPU_REG_AXI_CTRL_INPUT_SWAP8; > + vepu_write_relaxed(vpu, reg, VEPU_REG_AXI_CTRL); > + > + reg = VEPU_REG_ENC_CTRL_WIDTH(

Re: is it possible to use single IOCTL to setup media pipeline?

2018-11-21 Thread Tomasz Figa
Hi Ning, On Thu, Nov 22, 2018 at 11:52 AM Zhang, Ning A wrote: > > Hello everyone > > when we need to setup media pipeline, eg, for camera capture, media-ctl > needs to be called multiple time to setup media link and subdev > formats, or similar code in a single application. this will use >

Re: [PATCH 1/2] vb2: add waiting_in_dqbuf flag

2018-11-19 Thread Tomasz Figa
On Mon, Nov 19, 2018 at 6:54 PM Hans Verkuil wrote: > > On 11/19/2018 09:44 AM, Hans Verkuil wrote: > > On 11/19/2018 06:27 AM, Tomasz Figa wrote: > >> On Fri, Nov 16, 2018 at 6:45 PM Hans Verkuil wrote: > >>> > >>> On 11/16/2018 09:43 AM, Tomasz Fig

Re: [PATCH 1/2] vb2: add waiting_in_dqbuf flag

2018-11-18 Thread Tomasz Figa
On Fri, Nov 16, 2018 at 6:45 PM Hans Verkuil wrote: > > On 11/16/2018 09:43 AM, Tomasz Figa wrote: > > Hi Hans, > > > > On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: > >> > >> Calling VIDIOC_DQBUF can release the core serialization lock pointed to

Re: [ANN] Edinburgh Media Summit 2018 meeting report

2018-11-18 Thread Tomasz Figa
On Sun, Nov 18, 2018 at 7:45 AM Sakari Ailus wrote: > > Hello everyone, > > > Here's the report on the Media Summit held on 25th October in Edinburgh. > The report is followed by the stateless codec discussion two days earlier. > > Note: this is bcc'd to the meeting attendees plus a few others. I

Re: [PATCHv2 0/9] vb2/cedrus: add tag support

2018-11-16 Thread Tomasz Figa
Hi Hans, On Wed, Nov 14, 2018 at 10:47 PM Hans Verkuil wrote: > > From: Hans Verkuil > > As was discussed here (among other places): > > https://lkml.org/lkml/2018/10/19/440 > > using capture queue buffer indices to refer to reference frames is > not a good idea. A better idea is to use a 'tag'

Re: [PATCH 2/2] vb2: don't allow queueing buffers when canceling queue

2018-11-16 Thread Tomasz Figa
On Fri, Nov 16, 2018 at 5:42 PM Hans Verkuil wrote: > > On 11/16/2018 09:34 AM, Tomasz Figa wrote: > > Hi Hans, > > > > On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: > >> > >> Calling the stop_streaming op can release the core serializati

Re: [PATCH 1/2] vb2: add waiting_in_dqbuf flag

2018-11-16 Thread Tomasz Figa
Hi Hans, On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: > > Calling VIDIOC_DQBUF can release the core serialization lock pointed to > by vb2_queue->lock if it has to wait for a new buffer to arrive. > > However, if userspace dup()ped the video device filehandle, then it is > possible to

Re: [PATCH 2/2] vb2: don't allow queueing buffers when canceling queue

2018-11-16 Thread Tomasz Figa
Hi Hans, On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: > > Calling the stop_streaming op can release the core serialization lock > pointed to by vb2_queue->lock if it has to wait for buffers to finish. > An example of that behavior is the vivid driver. Why would vb2_queue->lock have to

Re: [PATCH v3] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-14 Thread Tomasz Figa
ll in processing. > > > > To let userspace know that the kernel now supports orphaning buffers > > that are still in use, add a new V4L2_BUF_CAP_SUPPORTS_ORPHANED_BUFS > > to be set by reqbufs and create_bufs. > > > > Signed-off-by: John Sheu > > Reviewe

Re: [PATCH 2/5] v4l: controls: Add support for exponential bases, prefixes and units

2018-11-14 Thread Tomasz Figa
Hi Sakari, On Fri, Sep 28, 2018 at 11:00 PM Hans Verkuil wrote: > > On 09/25/2018 12:14 PM, Sakari Ailus wrote: > > Add support for exponential bases, prefixes as well as units for V4L2 > > controls. This makes it possible to convey information on the relation > > between the control value and

Re: [RFC PATCH 0/3] Media Controller Properties

2018-11-14 Thread Tomasz Figa
Hi Hans, On Fri, Aug 3, 2018 at 11:36 PM Hans Verkuil wrote: > > From: Hans Verkuil > > This RFC patch series implements properties for the media controller. > > This is not finished, but I wanted to post this so people can discuss > this further. > > No documentation yet (too early for that).

Re: [PATCH] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-13 Thread Tomasz Figa
ocessing. > > > > > > To let userspace know that the kernel now supports orphaning buffers > > > that are still in use, add a new V4L2_BUF_CAP_SUPPORTS_ORPHANED_BUFS > > > to be set by reqbufs and create_bufs. > > > > > > Signed-off-by: John She

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-11-10 Thread Tomasz Figa
On Sat, Nov 10, 2018 at 6:06 AM Nicolas Dufresne wrote: > > Le jeudi 08 novembre 2018 à 16:45 +0900, Tomasz Figa a écrit : > > > In this patch we should consider a way to tell userspace that this has > > > been opt in, otherwise existing userspace will have to remain usin

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-11-07 Thread Tomasz Figa
Hi Nicolas, On Sat, Oct 27, 2018 at 6:38 PM Nicolas Dufresne wrote: > > Le lundi 22 octobre 2018 à 12:37 +0900, Tomasz Figa a écrit : > > Hi Philipp, > > > > On Mon, Oct 22, 2018 at 1:28 AM Philipp Zabel wrote: > > > > > > On Wed, Oct 03, 2

Re: [PATCH v7 06/16] intel-ipu3: mmu: Implement driver

2018-11-05 Thread Tomasz Figa
t; > Subject: Re: [PATCH v7 06/16] intel-ipu3: mmu: Implement driver > > > > Hi Yong, > > > > On Mon, Oct 29, 2018 at 03:23:00PM -0700, Yong Zhi wrote: > > > From: Tomasz Figa > > > > > > This driver translates IO virtua

Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-02 Thread Tomasz Figa
Hi Mauro, On Fri, Nov 2, 2018 at 10:49 PM Mauro Carvalho Chehab wrote: > > Em Mon, 29 Oct 2018 15:22:57 -0700 > Yong Zhi escreveu: [snip] > > +struct ipu3_uapi_awb_config_s { > > + __u16 rgbs_thr_gr; > > + __u16 rgbs_thr_r; > > + __u16 rgbs_thr_gb; > > + __u16 rgbs_thr_b; > > +

Re: VIVID/VIMC and media fuzzing

2018-10-31 Thread Tomasz Figa
Hi Dmitry, On Wed, Oct 31, 2018 at 6:46 PM Hans Verkuil wrote: > > On 10/30/2018 03:02 PM, Dmitry Vyukov wrote: [snip] > > > > Do I understand it correctly that when a process opens /dev/video* or > > /dev/media* it gets a private instance of the device? In particular, > > if several processes

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-10-26 Thread Tomasz Figa
On Thu, Sep 20, 2018 at 11:42 PM Hans Verkuil wrote: > > Some parts of the V4L2 API are awkward to use and I think it would be > a good idea to look at possible candidates for that. > > Examples are the ioctls that use struct v4l2_buffer: the multiplanar support > is > really horrible, and

Re: [PATCH 1/2] vicodec: Have decoder propagate changes to the CAPTURE queue

2018-10-26 Thread Tomasz Figa
On Fri, Oct 19, 2018 at 10:00 PM Ezequiel Garcia wrote: > > On Fri, 2018-10-19 at 09:14 +0200, Hans Verkuil wrote: > > On 10/18/2018 06:08 PM, Ezequiel Garcia wrote: > > > The decoder interface (not yet merged) specifies that > > > width and height values set on the OUTPUT queue, must > > > be

Re: [RFC] Informal meeting during ELCE to discuss userspace support for stateless codecs

2018-10-23 Thread Tomasz Figa
On Tue, Oct 23, 2018 at 6:17 AM Hans Verkuil wrote: > > A quick update: > > As said in my previous email: we'll meet at 11 am at the registration desk. > From there we go to the Platform 5 Cafe. If that's too crowded/noisy, then > we'll try the Sheraton hotel. > > Tomasz, I'll ping you on irc

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-10-21 Thread Tomasz Figa
Hi Philipp, On Mon, Oct 22, 2018 at 1:28 AM Philipp Zabel wrote: > > On Wed, Oct 03, 2018 at 05:24:39PM +0900, Tomasz Figa wrote: > [...] > > > Yes, but that would fall in a complete redesign I guess. The buffer > > > allocation scheme is very inflexible. Yo

Re: [PATCH v7] media: add imx319 camera sensor driver

2018-10-20 Thread Tomasz Figa
On Sun, Oct 21, 2018 at 6:53 AM Sakari Ailus wrote: > > Hi Tomasz, > > On Thu, Oct 18, 2018 at 12:24:31PM +0900, Tomasz Figa wrote: > > On Tue, Oct 16, 2018 at 8:50 PM Sakari Ailus > > wrote: > > > > > > Hi Tomasz, > > > > > >

Re: [PATCH v7] media: add imx319 camera sensor driver

2018-10-17 Thread Tomasz Figa
On Tue, Oct 16, 2018 at 8:50 PM Sakari Ailus wrote: > > Hi Tomasz, > > On Fri, Oct 12, 2018 at 05:06:56PM +0900, Tomasz Figa wrote: > > On Fri, Oct 12, 2018 at 4:58 PM Sakari Ailus > > wrote: > > > > > > Hi Tomasz, > > > > > >

Re: [RFC] Informal meeting during ELCE to discuss userspace support for stateless codecs

2018-10-15 Thread Tomasz Figa
+Alexandre Courbot On Wed, Oct 10, 2018 at 3:55 PM Hans Verkuil wrote: > > On 10/08/2018 01:53 PM, Hans Verkuil wrote: > > Hi all, > > > > I would like to meet up somewhere during the ELCE to discuss userspace > > support > > for stateless (and perhaps stateful as well?) codecs. > > > > It is

Re: [PATCH v7] media: add imx319 camera sensor driver

2018-10-12 Thread Tomasz Figa
On Fri, Oct 12, 2018 at 4:58 PM Sakari Ailus wrote: > > Hi Tomasz, > > On Fri, Oct 12, 2018 at 01:51:10PM +0900, Tomasz Figa wrote: > > Hi Sakari, > > > > On Wed, Sep 26, 2018 at 11:38 AM wrote: > > > > > > From: Bingbu Cao > > > >

Re: [PATCH v7] media: add imx319 camera sensor driver

2018-10-11 Thread Tomasz Figa
30fps > - 1936x1096, 1920x1080 @ 60fps > - 1640x1232, 1640x922, 1296x736, 1280x720 @ 120fps > - support 4 bayer orders output (via change v/hflip) > - SRGGB10(default), SGRBG10, SGBRG10, SBGGR10 > > Cc: Tomasz Figa > Cc: Sakari Ailus > Signed-off-by: Bingbu Cao > Signed-o

Re: [RFC] Informal meeting during ELCE to discuss userspace support for stateless codecs

2018-10-09 Thread Tomasz Figa
Hi Hans, On Mon, Oct 8, 2018 at 8:53 PM Hans Verkuil wrote: > > Hi all, > > I would like to meet up somewhere during the ELCE to discuss userspace support > for stateless (and perhaps stateful as well?) codecs. > > It is also planned as a topic during the summit, but I would prefer to prepare >

Re: s5p_mfc and H.264 frame cropping question

2018-10-05 Thread Tomasz Figa
On Fri, Oct 5, 2018 at 5:38 PM Hans Verkuil wrote: > > On 10/05/2018 10:16 AM, Tomasz Figa wrote: > > On Fri, Oct 5, 2018 at 3:58 PM Hans Verkuil wrote: > >> > >> On 10/05/2018 05:12 AM, Tomasz Figa wrote: > >>> Hi Hans, > >>> &g

Re: s5p_mfc and H.264 frame cropping question

2018-10-05 Thread Tomasz Figa
On Fri, Oct 5, 2018 at 3:58 PM Hans Verkuil wrote: > > On 10/05/2018 05:12 AM, Tomasz Figa wrote: > > Hi Hans, > > > > On Fri, Oct 5, 2018 at 5:02 AM Hans Verkuil wrote: > >> > >> Hi all, > >> > >> I'm looking at removing the last us

Re: [RFC PATCH] media: v4l2-ctrl: Add control for specific V4L2_EVENT_SRC_CH_RESOLUTION support

2018-10-04 Thread Tomasz Figa
On Wed, Oct 3, 2018 at 7:02 PM Maxime Jourdan wrote: > > On Tue, Oct 2, 2018 at 1:43 PM Hans Verkuil wrote: > > > > On 10/02/18 13:31, Maxime Jourdan wrote: > > > For drivers that expose both an OUTPUT queue and > > > V4L2_EVENT_SRC_CH_RESOLUTION such as video decoders, it is > > > possible that

Re: [PATCH 0/5] Add units to controls

2018-10-03 Thread Tomasz Figa
On Tue, Sep 25, 2018 at 9:30 PM Sakari Ailus wrote: [snip] > On Tue, Sep 25, 2018 at 01:48:02PM +0200, Helmut Grohne wrote: > > On Tue, Sep 25, 2018 at 12:14:29PM +0200, Sakari Ailus wrote: [snip] > > > Regarding Ricardo's suggestion --- I was thinking of adding a control flag > > > (yes, there

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-10-03 Thread Tomasz Figa
On Fri, Sep 21, 2018 at 3:14 AM Nicolas Dufresne wrote: > > Le jeudi 20 septembre 2018 à 16:42 +0200, Hans Verkuil a écrit : > > Some parts of the V4L2 API are awkward to use and I think it would be > > a good idea to look at possible candidates for that. > > > > Examples are the ioctls that use

Re: [RFC PATCH] media: v4l2-ctrl: Add control for specific V4L2_EVENT_SRC_CH_RESOLUTION support

2018-10-03 Thread Tomasz Figa
On Tue, Oct 2, 2018 at 8:44 PM Hans Verkuil wrote: > > On 10/02/18 13:31, Maxime Jourdan wrote: > > For drivers that expose both an OUTPUT queue and > > V4L2_EVENT_SRC_CH_RESOLUTION such as video decoders, it is > > possible that support for this event is limited to a subset > > of the enumerated

Re: [PATCH v5] media: add imx319 camera sensor driver

2018-09-21 Thread Tomasz Figa
On Fri, Sep 21, 2018 at 11:28 AM Bing Bu Cao wrote: > > > On 09/18/2018 05:49 PM, Tomasz Figa wrote: > > Hi Bingbu, > > > > On Mon, Sep 17, 2018 at 2:53 PM wrote: > >> From: Bingbu Cao > >> > >> Add a v4l2 sub-device driver for the Sony i

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Tomasz Figa
[+Laurent and Sylwester] On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: [snip] > + > +/* Digital gain control */ > +#define IMX208_REG_GR_DIGITAL_GAIN 0x020e > +#define IMX208_REG_R_DIGITAL_GAIN 0x0210 > +#define IMX208_REG_B_DIGITAL_GAIN 0x0212 > +#define

Re: [PATCH v5 5/6] media: Add controls for JPEG quantization tables

2018-09-18 Thread Tomasz Figa
On Thu, Sep 13, 2018 at 9:15 PM Paul Kocialkowski wrote: > > Hi, > > On Wed, 2018-09-05 at 19:00 -0300, Ezequiel Garcia wrote: > > From: Shunqian Zheng > > > > Add V4L2_CID_JPEG_QUANTIZATION compound control to allow userspace > > configure the JPEG quantization tables. > > > > Signed-off-by:

Re: [PATCH v5 5/6] media: Add controls for JPEG quantization tables

2018-09-18 Thread Tomasz Figa
On Sun, Sep 16, 2018 at 1:48 AM Paul Kocialkowski wrote: > > Hi, > > On Mon, 2018-09-10 at 10:25 -0300, Ezequiel Garcia wrote: > > Hi Hans, > > > > Thanks for the review. > > > > On Mon, 2018-09-10 at 14:42 +0200, Hans Verkuil wrote: > > > On 09/06/2018 12:00 AM, Ezequiel Garcia wrote: > > > >

Re: [PATCH v5] media: add imx319 camera sensor driver

2018-09-18 Thread Tomasz Figa
Hi Bingbu, On Mon, Sep 17, 2018 at 2:53 PM wrote: [snip] > +static int imx319_update_digital_gain(struct imx319 *imx319, u32 d_gain) > +{ > + int ret; > + > + ret = imx319_write_reg(imx319, IMX319_REG_DPGA_USE_GLOBAL_GAIN, 1, 1); > + if (ret) > + return ret; > + >

Re: [PATCH v6 12/12] intel-ipu3: Add imgu top level pci device driver

2018-09-18 Thread Tomasz Figa
On Mon, Sep 17, 2018 at 5:20 AM Zhi, Yong wrote: > > Hi, Tomasz, > > Thanks for the code review. > > > -Original Message- > > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > > ow...@vger.kernel.org] On Behalf Of Tomasz Figa > > Sent: M

Re: [PATCH v6 11/12] intel-ipu3: Add v4l2 driver based on media framework

2018-09-18 Thread Tomasz Figa
-Original Message- > > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > > ow...@vger.kernel.org] On Behalf Of Tomasz Figa > > Sent: Monday, July 2, 2018 2:50 AM > > To: Zhi, Yong > > Cc: Linux Media Mailing List ; Sakari Ailus > > ; Mani, Rajmohan >

Re: [PATCH v5] media: add imx319 camera sensor driver

2018-09-18 Thread Tomasz Figa
Hi Bingbu, On Mon, Sep 17, 2018 at 2:53 PM wrote: > > From: Bingbu Cao > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > This is a camera sensor using the i2c bus for control and the > csi-2 bus for data. Please see my comments inline. Also, I'd appreciate being CCed on

Re: [PATCHv4 09/10] media-request: EPERM -> EACCES/EBUSY

2018-09-04 Thread Tomasz Figa
equest was not found. I think the bottom-most line belongs to patch 1/10. With that fixed (possibly when applying): Reviewed-by: Tomasz Figa Best regards, Tomasz

Re: [PATCHv2 00/10] Post-v18: Request API updates

2018-08-31 Thread Tomasz Figa
split off the V4L2 specifics into a V4L2 specific > rst file. But this will take more time and is for later. For all the patches which still don't have my Reviewed-by, except patch 9/10 ("media-request: EPERM -> EACCES"): Reviewed-by: Tomasz Figa Thanks a lot for this great work! Best regards, Tomasz

Re: [PATCHv2 09/10] media-request: EPERM -> EACCES

2018-08-31 Thread Tomasz Figa
On Thu, Aug 30, 2018 at 10:04 PM Sakari Ailus wrote: > > On Thu, Aug 30, 2018 at 01:51:39PM +0200, Hans Verkuil wrote: > > On 08/30/2018 12:15 PM, Sakari Ailus wrote: > > > Hi Hans, > > > > > > Thanks a lot for working on this! > > > > > > On Tue, Aug 28, 2018 at 03:49:10PM +0200, Hans Verkuil

Re: [PATCHv2 07/10] v4l2-ctrls: use media_request_(un)lock_for_access

2018-08-31 Thread Tomasz Figa
On Fri, Aug 31, 2018 at 11:55 PM Tomasz Figa wrote: > > Hi Hans, > > On Tue, Aug 28, 2018 at 10:49 PM Hans Verkuil wrote: > > > > From: Hans Verkuil > > > > When getting control values from a completed request, we have > > to protect the request a

Re: [PATCHv2 07/10] v4l2-ctrls: use media_request_(un)lock_for_access

2018-08-31 Thread Tomasz Figa
Hi Hans, On Tue, Aug 28, 2018 at 10:49 PM Hans Verkuil wrote: > > From: Hans Verkuil > > When getting control values from a completed request, we have > to protect the request against being re-inited why it is > being accessed by calling media_request_(un)lock_for_access. > > Signed-off-by:

Re: [PATCH 4/5] videodev2.h: add new capabilities for buffer types

2018-08-29 Thread Tomasz Figa
On Tue, Aug 28, 2018 at 9:37 PM Hans Verkuil wrote: > > On 24/08/18 16:36, Tomasz Figa wrote: > > Hi Hans, > > > > On Fri, Aug 24, 2018 at 5:22 PM Hans Verkuil wrote: > >> > >> From: Hans Verkuil > >> > >> VIDIOC_REQBUFS and VIDIOC_CR

Re: [RFC] Request API and V4L2 capabilities

2018-08-28 Thread Tomasz Figa
On Fri, Aug 24, 2018 at 4:30 PM Hans Verkuil wrote: > > On 08/23/2018 07:37 PM, Nicolas Dufresne wrote: > > Le jeudi 23 août 2018 à 16:31 +0200, Hans Verkuil a écrit : > >>> I propose adding these capabilities: > >>> > >>> #define V4L2_BUF_CAP_HAS_REQUESTS 0x0001 > >>> #define

Re: [RFC] Request API and V4L2 capabilities

2018-08-28 Thread Tomasz Figa
ul Kocialkowski wrote: > > > > Hi, > > > > > > > > On Tue, 2018-08-21 at 17:52 +0900, Tomasz Figa wrote: > > > > > Hi Hans, Paul, > > > > > > > > > > On Mon, Aug 6, 2018 at 6:29 PM Paul Kocialkowski > > > > > wrote: >

Re: [RFC] Request API and V4L2 capabilities

2018-08-28 Thread Tomasz Figa
On Thu, Aug 23, 2018 at 5:05 PM Paul Kocialkowski wrote: > > Hi, > > On Wed, 2018-08-22 at 14:33 -0300, Ezequiel Garcia wrote: > > On Wed, 2018-08-22 at 16:10 +0200, Paul Kocialkowski wrote: > > > Hi, > > > > > > On Tue, 2018-08-21 at 17:52 +0

Re: [RFC] Request API and V4L2 capabilities

2018-08-28 Thread Tomasz Figa
On Wed, Aug 22, 2018 at 11:10 PM Paul Kocialkowski wrote: > > Hi, > > On Tue, 2018-08-21 at 17:52 +0900, Tomasz Figa wrote: > > Hi Hans, Paul, > > > > On Mon, Aug 6, 2018 at 6:29 PM Paul Kocialkowski > > wrote: > > > > > > On Mon, 2018-08-0

Re: [PATCH v3 6/7] media: Add controls for JPEG quantization tables

2018-08-28 Thread Tomasz Figa
On Wed, Aug 29, 2018 at 11:50 AM Ezequiel Garcia wrote: > > On Mon, 2018-08-27 at 09:47 +0200, Paul Kocialkowski wrote: > > Hi, > > > > On Wed, 2018-08-22 at 13:59 -0300, Ezequiel Garcia wrote: > > > From: Shunqian Zheng > > > > > > Add V4L2_CID_JPEG_LUMA/CHROMA_QUANTIZATION controls to allow

Re: [PATCH v1 2/2] v4l: Document Intel IPU3 meta data uAPI

2018-08-28 Thread Tomasz Figa
On Tue, Aug 14, 2018 at 5:50 AM Mauro Carvalho Chehab wrote: > > Em Mon, 13 Aug 2018 15:42:34 +0200 > Hans Verkuil escreveu: > > > On 15/06/18 05:29, Yong Zhi wrote: > > > These meta formats are used on Intel IPU3 ImgU video queues > > > to carry 3A statistics and ISP pipeline parameters. > > >

Re: [PATCH 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-08-26 Thread Tomasz Figa
On Tue, Aug 21, 2018 at 8:29 PM Stanimir Varbanov wrote: > > Hi Tomasz, > > On 08/08/2018 05:55 AM, Tomasz Figa wrote: > > On Tue, Aug 7, 2018 at 4:37 PM Hans Verkuil wrote: > > >>>>>>> +7. If all the following conditions are met, the client may

Re: [PATCH 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-08-26 Thread Tomasz Figa
Hi Philipp, On Tue, Aug 21, 2018 at 12:34 AM Philipp Zabel wrote: > > On Mon, 2018-08-20 at 23:27 +0900, Tomasz Figa wrote: > [...] > > +3. Start queuing buffers to ``OUTPUT`` queue containing stream data after > > > > > > + the seek until

Re: [PATCH 0/5] Post-v18: Request API updates

2018-08-24 Thread Tomasz Figa
r.kernel.org/msg134419.html > > and: > > https://www.spinics.net/lists/linux-media/msg138596.html > For all patches except "[PATCH 4/5] videodev2.h: add new capabilities for buffer types": Reviewed-by: Tomasz Figa Best regards, Tomasz

Re: [PATCH 4/5] videodev2.h: add new capabilities for buffer types

2018-08-24 Thread Tomasz Figa
Hi Hans, On Fri, Aug 24, 2018 at 5:22 PM Hans Verkuil wrote: > > From: Hans Verkuil > > VIDIOC_REQBUFS and VIDIOC_CREATE_BUFFERS will return capabilities > telling userspace what the given buffer type is capable of. > Please see my comments below. > Signed-off-by: Hans Verkuil > --- >

Re: [RFC] Request API and V4L2 capabilities

2018-08-22 Thread Tomasz Figa
On Wed, Aug 22, 2018 at 10:21 PM Paul Kocialkowski wrote: > > Hi, > > [...] > > On Wed, 2018-08-15 at 14:51 +0200, Maxime Jourdan wrote: > > Hi Paul, I think we need to go deeper than just exposing the supported > > profiles/levels and also include a way to query the CAPTURE pixel > > formats

Re: [RFP] Media Summit: Complex cameras

2018-08-22 Thread Tomasz Figa
Hi Mauro, On Thu, Aug 16, 2018 at 10:58 PM Mauro Carvalho Chehab wrote: > > I expect that we could have something to discuss there about complex > cameras. So, I'd reserve a 50 mins slot for it. > > The idea is to discuss about the undergoing work with complex camera > development is happening.

Re: [RFC] Request API questions

2018-08-21 Thread Tomasz Figa
On Tue, Aug 21, 2018 at 7:00 PM Sakari Ailus wrote: > > On Fri, Aug 17, 2018 at 12:09:40PM +0200, Hans Verkuil wrote: > > On 17/08/18 12:02, Tomasz Figa wrote: > > > On Thu, Aug 16, 2018 at 8:15 PM Mauro Carvalho Chehab > > > wrote: > > >> > > &

Re: [RFC] Request API and V4L2 capabilities

2018-08-21 Thread Tomasz Figa
On Mon, Aug 6, 2018 at 5:32 PM Hans Verkuil wrote: > > On 08/06/2018 10:16 AM, Paul Kocialkowski wrote: > > Hi Hans and all, > > > > On Sat, 2018-08-04 at 15:50 +0200, Hans Verkuil wrote: > >> Hi all, > >> > >> While the Request API patch series addresses all the core API issues, there > >> are

Re: [RFC] Request API and V4L2 capabilities

2018-08-21 Thread Tomasz Figa
On Wed, Aug 15, 2018 at 11:18 PM Hans Verkuil wrote: > > On 15/08/18 14:11, Mauro Carvalho Chehab wrote: > > Em Sat, 4 Aug 2018 15:50:04 +0200 > > Hans Verkuil escreveu: > > > >> Hi all, > >> > >> While the Request API patch series addresses all the core API issues, there > >> are some

Re: [RFC] Request API and V4L2 capabilities

2018-08-21 Thread Tomasz Figa
Hi Hans, Paul, On Mon, Aug 6, 2018 at 6:29 PM Paul Kocialkowski wrote: > > On Mon, 2018-08-06 at 11:23 +0200, Hans Verkuil wrote: > > On 08/06/2018 11:13 AM, Paul Kocialkowski wrote: > > > Hi, > > > > > > On Mon, 2018-08-06 at 10:32 +0200, Hans Verkuil wrote: > > > > On 08/06/2018 10:16 AM, Paul

Re: [RFC] Request API questions

2018-08-20 Thread Tomasz Figa
Hi Hans, On Fri, Aug 17, 2018 at 7:09 PM Hans Verkuil wrote: > > On 17/08/18 12:02, Tomasz Figa wrote: > > On Thu, Aug 16, 2018 at 8:15 PM Mauro Carvalho Chehab > > wrote: > >> > >> Em Thu, 16 Aug 2018 12:25:25 +0200 > >> Hans Verkuil escreveu: &g

Re: [RFC] Request API questions

2018-08-17 Thread Tomasz Figa
On Thu, Aug 16, 2018 at 8:15 PM Mauro Carvalho Chehab wrote: > > Em Thu, 16 Aug 2018 12:25:25 +0200 > Hans Verkuil escreveu: > > > Laurent raised a few API issues/questions in his review of the > > documentation. > > > > I've consolidated those in this RFC. I would like to know what others

Re: [PATCH v2 5/6] media: Add controls for jpeg quantization tables

2018-08-16 Thread Tomasz Figa
Hi Ezequiel, On Fri, Aug 3, 2018 at 5:00 AM Ezequiel Garcia wrote: > > From: Shunqian Zheng > > Add V4L2_CID_JPEG_LUMA/CHROMA_QUANTIZATION controls to allow userspace > configure the JPEG quantization tables. > > Signed-off-by: Shunqian Zheng > Signed-off-by: Ezequiel Garcia > --- >

Re: [PATCHv16 01/34] Documentation: v4l: document request API

2018-08-03 Thread Tomasz Figa
Hi Hans, On Fri, Jul 6, 2018 at 1:04 AM Hans Verkuil wrote: > > From: Alexandre Courbot > > Document the request API for V4L2 devices, and amend the documentation > of system calls influenced by it. > > Signed-off-by: Alexandre Courbot > Signed-off-by: Hans Verkuil > --- >

Re: [RESEND PATCH v4] media: imx208: Add imx208 camera sensor driver

2018-08-02 Thread Tomasz Figa
link_freq_menu_items[] = { > + [IMX208_LINK_FREQ_384MHZ_INDEX] = IMX208_LINK_FREQ_384MHZ, > + [IMX208_LINK_FREQ_384MHZ_INDEX] = IMX208_LINK_FREQ_96MHZ, IMX208_LINK_FREQ_96MHZ_INDEX? With this fixed (and if there are no other changes), feel free to add Reviewed-by: Tomasz Figa Best regards, Tomasz

Re: [PATCH v3] media: imx208: Add imx208 camera sensor driver

2018-08-01 Thread Tomasz Figa
Hi Ping-chung, On Wed, Aug 1, 2018 at 11:31 AM Ping-chung Chen wrote: > > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Ping-Chung Chen > --- >

Re: [PATCH v2] media: imx208: Add imx208 camera sensor driver

2018-07-30 Thread Tomasz Figa
On Tue, Jul 31, 2018 at 12:54 PM Chen, Ping-chung wrote: > > Hi Tomasz, > > >-Original Message- > > +/* Get bayer order based on flip setting. */ static __u32 > > +imx208_get_format_code(struct imx208 *imx208) > > >Why not just "u32"? > > Its return value will be assigned to the variable

Re: [PATCH 1/1] i2c: Fix pm_runtime_get_if_in_use() usage in sensor drivers

2018-07-30 Thread Tomasz Figa
/media/i2c/ov7740.c | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) Thanks! Reviewed-by: Tomasz Figa Best regards, Tomasz

Re: [PATCH v2] media: imx208: Add imx208 camera sensor driver

2018-07-30 Thread Tomasz Figa
On Mon, Jul 30, 2018 at 8:39 PM Sakari Ailus wrote: > > Hi Tomasz, > > On Mon, Jul 30, 2018 at 07:19:56PM +0900, Tomasz Figa wrote: > ... > > > +static int imx208_set_ctrl(struct v4l2_ctrl *ctrl) > > > +{ > > > + struct imx208 *imx208 = > &

Re: [PATCH v2] media: imx208: Add imx208 camera sensor driver

2018-07-30 Thread Tomasz Figa
Hi Ping-chung, On Mon, Jul 30, 2018 at 6:19 PM Ping-chung Chen wrote: > > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > Please see my comments inline. [snip] >

Re: [PATCH 0/2] Document memory-to-memory video codec interfaces

2018-07-25 Thread Tomasz Figa
Hi Philipp, On Wed, Jul 25, 2018 at 10:28 PM Philipp Zabel wrote: > > Hi Tomasz, > > On Tue, 2018-07-24 at 23:06 +0900, Tomasz Figa wrote: > > This series attempts to add the documentation of what was discussed > > during Media Workshops at LinuxCon Europe 2012 in Barc

Re: [PATCH] media: imx208: Add imx208 camera sensor driver

2018-07-19 Thread Tomasz Figa
Hi Ping-chung, On Tue, Jul 17, 2018 at 3:53 PM Chen, Ping-chung wrote: > > Hi Sakari, > > Some of suggestions below has been added in to [PATCH v2] or [PATCH v3]. > We will fix others in PATCH v4 soon. I don't see v2 or v3 on linux-media (or my inbox). Where were they sent? I'd like to review

Re: [PATCH v1 2/2] v4l: Document Intel IPU3 meta data uAPI

2018-07-18 Thread Tomasz Figa
Hi Mauro, Hans, On Fri, Jun 15, 2018 at 12:30 PM Yong Zhi wrote: > > These meta formats are used on Intel IPU3 ImgU video queues > to carry 3A statistics and ISP pipeline parameters. > > V4L2_META_FMT_IPU3_3A > V4L2_META_FMT_IPU3_PARAMS > > Signed-off-by: Yong Zhi > Signed-off-by: Chao C Li >

Re: [PATCHv15 07/35] v4l2-dev: lock req_queue_mutex

2018-07-02 Thread Tomasz Figa
Hi Hans, On Mon, Jun 4, 2018 at 8:48 PM Hans Verkuil wrote: [snip] > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c > b/drivers/media/v4l2-core/v4l2-ioctl.c > index 965fd301f617..27a893aa0664 100644 > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c >

Re: [PATCHv15 05/35] media-request: add media_request_object_find

2018-07-02 Thread Tomasz Figa
Hi Hans, On Mon, Jun 4, 2018 at 8:48 PM Hans Verkuil wrote: > > From: Hans Verkuil > > Add media_request_object_find to find a request object inside a > request based on ops and/or priv values. Current code seems to always find based on both ops and priv values. Best regards, Tomasz

Re: [PATCHv15 02/35] media-request: implement media requests

2018-07-02 Thread Tomasz Figa
On Mon, Jul 2, 2018 at 6:11 PM Hans Verkuil wrote: > > On 02/07/18 10:58, Tomasz Figa wrote: > > Hi Hans, > > > > On Fri, Jun 15, 2018 at 4:09 PM Hans Verkuil wrote: > >> > >> On 04/06/18 13:46, Hans Verkuil wrote: > >>> From: Hans

Re: [PATCHv15 02/35] media-request: implement media requests

2018-07-02 Thread Tomasz Figa
Hi Hans, On Mon, Jun 4, 2018 at 8:47 PM Hans Verkuil wrote: [snip] > +static void media_request_object_release(struct kref *kref) > +{ > + struct media_request_object *obj = > + container_of(kref, struct media_request_object, kref); > + struct media_request *req =

Re: [PATCHv15 02/35] media-request: implement media requests

2018-07-02 Thread Tomasz Figa
Hi Hans, On Fri, Jun 15, 2018 at 4:09 PM Hans Verkuil wrote: > > On 04/06/18 13:46, Hans Verkuil wrote: > > From: Hans Verkuil > > > > Add initial media request support: > > > > 1) Add MEDIA_IOC_REQUEST_ALLOC ioctl support to media-device.c > > 2) Add struct media_request to store request

Re: [PATCH v6 12/12] intel-ipu3: Add imgu top level pci device driver

2018-07-02 Thread Tomasz Figa
Hi Yong, On Fri, Mar 30, 2018 at 11:15 AM Yong Zhi wrote: > +/* > + * Queue as many buffers to CSS as possible. If all buffers don't fit into > + * CSS buffer queues, they remain unqueued and will be queued later. > + */ > +int imgu_queue_buffers(struct imgu_device *imgu, bool initial) > +{ > +

Re: [PATCH v6 11/12] intel-ipu3: Add v4l2 driver based on media framework

2018-07-02 Thread Tomasz Figa
Hi Yong, On Fri, Mar 30, 2018 at 11:15 AM Yong Zhi wrote: [snip] > +static int ipu3_vidioc_enum_input(struct file *file, void *fh, > + struct v4l2_input *input) > +{ > + if (input->index > 0) > + return -EINVAL; > + strlcpy(input->name,

Re: [PATCH v6 06/12] intel-ipu3: css: Add support for firmware management

2018-07-02 Thread Tomasz Figa
Hi Yong, Continuing my review. Sorry for the delay. On Fri, Mar 30, 2018 at 11:15 AM Yong Zhi wrote: > > Introduce functions to load and install ImgU FW blobs. > > Signed-off-by: Yong Zhi > --- > drivers/media/pci/intel/ipu3/ipu3-abi.h| 1888 > >

Re: Software-only image processing for Intel "complex" cameras

2018-06-29 Thread Tomasz Figa
Hi Pavel, On Fri, Jun 29, 2018 at 6:18 PM Pavel Machek wrote: > > Hi! > > > > On Nokia N900, I have similar problems as Intel IPU3 hardware. > > > > > > Meeting notes say that pure software implementation is not fast > > > enough, but that it may be useful for debugging. It would be also > > >

Re: Software-only image processing for Intel "complex" cameras

2018-06-29 Thread Tomasz Figa
Hi Pavel, On Thu, Jun 21, 2018 at 5:38 AM Pavel Machek wrote: > > Hi! > > On Nokia N900, I have similar problems as Intel IPU3 hardware. > > Meeting notes say that pure software implementation is not fast > enough, but that it may be useful for debugging. It would be also > useful for me on

Re: [PATCH v6 04/12] intel-ipu3: Implement DMA mapping functions

2018-06-19 Thread Tomasz Figa
On Tue, Jun 19, 2018 at 12:42 AM Zhi, Yong wrote: > > Hi, Tomasz, > > Thanks for the review. > > > -Original Message----- > > From: Tomasz Figa [mailto:tf...@chromium.org] > > Sent: Monday, June 18, 2018 12:09 AM > > To: Zhi, Yong > > Cc: Linux

Re: [ANN v2] Complex Camera Workshop - Tokyo - Jun, 19

2018-06-18 Thread Tomasz Figa
Hi Paul, On Mon, Jun 18, 2018 at 5:42 PM Paul Elder wrote: > > > > Hello all, > > On June 4, 2018 10:33:03 PM GMT+09:00, Mauro Carvalho Chehab > wrote: > >Hi all, > > > >I consolidated hopefully all comments I receive on the past > >announcement > >with regards to the complex camera workshop

Re: [PATCH v6 04/12] intel-ipu3: Implement DMA mapping functions

2018-06-18 Thread Tomasz Figa
On Fri, Mar 30, 2018 at 11:15 AM Yong Zhi wrote: > > From: Tomasz Figa > > This driver uses IOVA space for buffer mapping through IPU3 MMU > to transfer data between imaging pipelines and system DDR. > > Signed-off-by: Tomasz Figa > Signed-off-by: Yong Zhi > --- >

  1   2   3   4   >