Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Trent Piepho
d the last > > > active people to see if they care. In a few cases people do, but > > > most often no one does. > > > > Let's start with this one (zoran) then, as Mauro is keen on having > > all media drivers compile-testable on x86-64 and arm. > &

Re: [ANNOUNCE] git tree repositories

2010-01-20 Thread Trent Piepho
On Thu, 21 Jan 2010, Mauro Carvalho Chehab wrote: OTOH, since with git it is common to have multiple branches within one repository, I'm not sure how it works. It would be cool if git would support per-branch descriptions, and git web could display them. I don't think git supports it. In

Re: How to use saa7134 gpio via gpio-sysfs?

2010-01-16 Thread Trent Piepho
On Sat, 16 Jan 2010, hermann pitton wrote: Am Freitag, den 15.01.2010, 17:27 -0800 schrieb Trent Piepho: On Sat, 16 Jan 2010, hermann pitton wrote: Am Dienstag, den 12.01.2010, 04:13 +0100 schrieb hermann pitton: gpio-sysfs creates /sys/class/gpio/export /sys/class

Re: How to use saa7134 gpio via gpio-sysfs?

2010-01-15 Thread Trent Piepho
On Sat, 16 Jan 2010, hermann pitton wrote: Am Dienstag, den 12.01.2010, 04:13 +0100 schrieb hermann pitton: gpio-sysfs creates /sys/class/gpio/export /sys/class/gpio/import but no gpion entries so far. You have to explictly export the GPIO lines to get them to appear. Either

Re: [RFC v2] Another approach to IR

2009-12-02 Thread Trent Piepho
On Wed, 2 Dec 2009, Jarod Wilson wrote: My main point is that each of these devices has device ID that can be determined without having to first do some protocol analysis and table lookups to figure out which device some random IR input is actually coming from. Heh, right back

Re: [RFC v2] Another approach to IR

2009-12-02 Thread Trent Piepho
On Wed, 2 Dec 2009, Jon Smirl wrote: A bluetooth remote has a specific device ID that the receiver has to pair with. Your usb mouse and keyboard each have specific device IDs. A usb IR *receiver* has a specific device ID, the remotes do not. So there's the major difference from your

Re: Replace Mercurial with GIT as SCM

2009-12-01 Thread Trent Piepho
On Tue, 1 Dec 2009, Patrick Boettcher wrote: To start right away: I'm in favour of using GIT because of difficulties I have with my daily work with v4l-dvb. It is in my nature do to mistakes, so I need a tool which assists me in fixing those, I have not found a simple way to do my stuff with

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-26 Thread Trent Piepho
On Thu, 26 Nov 2009, Mauro Carvalho Chehab wrote: See above. Also, several protocols have a way to check if a keystroke were properly received. When handling just one protocol, we can use this to double check the key. However, on a multiprotocol mode, we'll need to disable this feature.

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-26 Thread Trent Piepho
On Thu, 26 Nov 2009, Mauro Carvalho Chehab wrote: lircd supports input layer interface. Yet, patch 3/3 exports both devices that support only pulse/space raw mode and devices that generate scan codes via the raw mode interface. It does it by generating artificial pulse codes. Nonsense!

Re: IR raw input is not sutable for input system

2009-11-24 Thread Trent Piepho
On Wed, 25 Nov 2009, Maxim Levitsky wrote: Its not the case. There are many protocols, I know that by experimenting with my universal remote. There are many receivers, and all have different accuracy. Most remotes aren't designed to be used with PC, thus user has to invent mapping between

Re: [PATCH] tuner-simple: possible read buffer overflow?

2009-10-03 Thread Trent Piepho
On Sat, 3 Oct 2009, Roel Kluin wrote: Prevent read from t_params-ranges[-1]. Signed-off-by: Roel Kluin roel.kl...@gmail.com --- This is only required when t_params-count can be 0, can it? Shouldn't be possible, or the tuner would be useless. - if (i == t_params-count) { + if (i ==

Re: V4L2 drivers: potentially dangerous and inefficient msecs_to_jiffies() calculation

2009-09-14 Thread Trent Piepho
On Mon, 14 Sep 2009, Andreas Mohr wrote: cam-module_param.frame_timeout * 1000 * msecs_to_jiffies(1) ); multiple times each. What they should do instead is frame_timeout * msecs_to_jiffies(1000), I'd think. msecs_to_jiffies(1) is quite

Re: [RFC] Infrared Keycode standardization

2009-08-27 Thread Trent Piepho
On Thu, 27 Aug 2009, Devin Heitmueller wrote: The biggest challenge with that approach is that lirc is still maintained out-of-kernel, and the inputdev solution does not require lirc at all (which is good for inexperienced end users who want their product to just work). If distros started

Re: [linux-dvb] Can ir polling be turned off in cx88 module for Leadtek 1000DTV card?

2009-08-26 Thread Trent Piepho
On Wed, 26 Aug 2009, Andy Walls wrote: On Wed, 2009-08-26 at 07:33 -0700, Dalton Harvie wrote: If there isn't, would it be a good idea? Maybe. Thanks for any help. Try this. It adds a module option noir that accepts an array of int's. For a 0, that card's IR is set up as normal;

Re: [patch review 6/6] radio-mr800: redesign radio-users counter

2009-08-08 Thread Trent Piepho
On Sat, 8 Aug 2009, Alexey Klimov wrote: Redesign radio-users counter. Don't allow more that 5 users on radio in Why? -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb

2009-08-06 Thread Trent Piepho
On Thu, 6 Aug 2009, Hans Verkuil wrote: On Thursday 06 August 2009 20:10:38 Trent Piepho wrote: On Thu, 6 Aug 2009, Hans Verkuil wrote: Why do you need two routines that will always return zero? Why to create a code that will never be used? v4l2-compat-ioctl32.c is already

Re: double unlock in bttv_poll() and in saa7134-video.c

2009-07-29 Thread Trent Piepho
On Sat, 25 Jul 2009, Dan Carpenter wrote: My source code checker, smatch (http://repo.or.cz/w/smatch.git), complains about a double unlock in bttv_poll() from drivers/media/video/bt8xx/bttv-driver.c. It unlocks on line 3190 and again on 3201. How about this:

Re: lsmod path hardcoded in v4l/Makefile

2009-07-28 Thread Trent Piepho
On Mon, 27 Jul 2009, Mauro Carvalho Chehab wrote: Em Tue, 21 Jul 2009 09:14:36 +0200 Matthias Schwarzott z...@gentoo.org escreveu: It is not a good idea to run as root. Most people compile everything with a normal user and then use sudo command to install/remove/insert modules. Unfortunately,

Re: [Bugme-new] [Bug 13709] New: b2c2-flexcop: no frontend driver found for this B2C2/FlexCop adapter w/ kernel-2.6.31-rc2

2009-07-22 Thread Trent Piepho
On Mon, 20 Jul 2009, Andrew Morton wrote: On Mon, 20 Jul 2009 13:21:33 -0700 (PDT) Trent Piepho xy...@speakeasy.org wrote: On Mon, 20 Jul 2009, Andrew Morton wrote: I produced a patch that fixed this problem over a month ago, http://www.linuxtv.org/hg/~tap/v4l-dvb/rev/748c762fcf3e Where

Re: [Bugme-new] [Bug 13709] New: b2c2-flexcop: no frontend driver found for this B2C2/FlexCop adapter w/ kernel-2.6.31-rc2

2009-07-20 Thread Trent Piepho
On Mon, 20 Jul 2009, Andrew Morton wrote: (switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). Guys, this is reportedly a post-2.6.30 regression - I'll ask Rafael to add it to the regression tracking list. btw, does the flexcop driver have a

Re: [PATCH 1/2] Compatibility layer for hrtimer API

2009-07-05 Thread Trent Piepho
On Fri, 3 Jul 2009, Jean Delvare wrote: Kernels 2.6.22 to 2.6.24 (inclusive) need some compatibility quirks for the hrtimer API. For older kernels, some required functions were not exported so there's nothing we can do. This means that drivers using the hrtimer infrastructure will no longer

Re: lsmod path hardcoded in v4l/Makefile

2009-06-23 Thread Trent Piepho
On Tue, 23 Jun 2009, Matthias Schwarzott wrote: On Mon, 2009-06-22 at 16:36 +0200, Matthias Schwarzott wrote: It seems the path to lsmod tool is hardcoded in the Makefile for out-of-tree building of v4l-dvb. Shouldn't $PATH of root be considered safe? Else the distro or the system I

Re: lsmod path hardcoded in v4l/Makefile

2009-06-22 Thread Trent Piepho
On Mon, 22 Jun 2009, Andy Walls wrote: On Mon, 2009-06-22 at 16:36 +0200, Matthias Schwarzott wrote: Hi list! It seems the path to lsmod tool is hardcoded in the Makefile for out-of-tree building of v4l-dvb. Now at least gentoo has moved lsmod from /sbin to /bin. Won't your patch cause

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-misc

2009-06-20 Thread Trent Piepho
On Sat, 20 Jun 2009, Hans Verkuil wrote: - compat: fix __fls check for the arm architecture. This one isn't quite right. The __fls defined for arm in 2.6.27 (between v2.6.26-7260-g0c65f45 and v2.6.28-rc6-187-g94fc733) isn't the same as the __fls() used everwhere else in the kernel. This

Re: [PATCH] af9015: avoid magically sized temporal buffer in eeprom_dump

2009-06-18 Thread Trent Piepho
On Thu, 18 Jun 2009, Jan Nikitenko wrote: Replace printing to magically sized temporal buffer with use of KERN_CONT temporary not temporal. - sprintf(buf2, %02x , val); + deb_info(KERN_CONT, %02x, val); No comma after KERN_CONT else -

Re: [PATCH] adding support for setting bus parameters in sub device

2009-06-17 Thread Trent Piepho
On Wed, 17 Jun 2009, Guennadi Liakhovetski wrote: On Wed, 17 Jun 2009, Hans Verkuil wrote: It is my strong opinion that while autonegotiation is easy to use, it is not a wise choice to make. Filling in a single struct with the bus settings to use for each board-subdev combination (usually

Re: [PULL] generic image bounds setting and alignment function

2009-06-17 Thread Trent Piepho
On Wed, 17 Jun 2009, Guennadi Liakhovetski wrote: On Tue, 16 Jun 2009, Trent Piepho wrote: /* up the smaller alignment until we have enough */ do { - if (walign = halign walign wmaxa) { + if (halign = hmaxa

Re: bttv problem loading takes about several minutes

2009-06-17 Thread Trent Piepho
On Wed, 17 Jun 2009, Halim Sahin wrote: Hi, In the past I could use this card by typing modprobe bttv card=34 tuner=24 gbuffers=16 What card do you actually have? What is the PCI subsystem vendor/device and what tuner does it actually have? Hans, the problem might be with bttv audio probing.

Re: [PULL] generic image bounds setting and alignment function

2009-06-17 Thread Trent Piepho
On Wed, 17 Jun 2009, Guennadi Liakhovetski wrote: On Tue, 16 Jun 2009, Trent Piepho wrote: On Tue, 16 Jun 2009, Guennadi Liakhovetski wrote: 01/14: compat: handle __fls http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=c4b55ce6c273 02/14: v4l2: Create helper function

Re: [PATCHv7 2/9] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-06-16 Thread Trent Piepho
On Tue, 16 Jun 2009, Eduardo Valentin wrote: On Sun, Jun 14, 2009 at 06:59:13PM +0200, ext Hans Verkuil wrote: On Sunday 14 June 2009 18:23:41 Trent Piepho wrote: similar V4L2_CID_MPEG_EMPHASIS control and others might well appear in the future, so I think this name should

Re: [PULL] http://kernellabs.com/hg/~mkrufky/k2c2

2009-06-16 Thread Trent Piepho
On Tue, 16 Jun 2009, Mauro Carvalho Chehab wrote: Em Tue, 16 Jun 2009 11:19:29 -0400 Michael Krufky mkru...@linuxtv.org escreveu: +static int cx23885_dvb_set_frontend(struct dvb_frontend *fe, + struct dvb_frontend_parameters *param) You could make this an

Re: [PULL] generic image bounds setting and alignment function

2009-06-16 Thread Trent Piepho
On Tue, 16 Jun 2009, Mauro Carvalho Chehab wrote: Em Tue, 16 Jun 2009 17:57:20 +0200 (CEST) Guennadi Liakhovetski g.liakhovet...@gmx.de escreveu: On Sat, 30 May 2009, Trent Piepho wrote: + if (walign + halign salign) { + /* Max walign where there is still a valid width

Re: [PATCH] High resolution timer for cx88 remotes

2009-06-16 Thread Trent Piepho
On Tue, 16 Jun 2009, Mauro Carvalho Chehab wrote: Em Sat, 23 May 2009 14:06:01 +0200 AH andrzej.ha...@wp.pl escreveu: Patched driver seems to work on my system, with kernel 2.6.28. I have removed kernel checks for versions below 2.6.20 - they were because of API changes in scheduler. If

Re: [PATCHv7 2/9] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-06-14 Thread Trent Piepho
On Sun, 14 Jun 2009, Eduardo Valentin wrote: +/* FM Modulator class control IDs */ +#define V4L2_CID_FM_TX_CLASS_BASE (V4L2_CTRL_CLASS_FM_TX | 0x900) +#define V4L2_CID_FM_TX_CLASS ? ? ? ? ? ? ? ? (V4L2_CTRL_CLASS_FM_TX | 1) + +#define V4L2_CID_RDS_ENABLED ? ? ? ? ? ? ? ?

Re: [PATCH -next] v4l: expose function outside of ifdef/endif block

2009-06-12 Thread Trent Piepho
+987,3 @@ void v4l_bound_align_image(u32 *w, unsig } } EXPORT_SYMBOL_GPL(v4l_bound_align_image); - -#endif# HG changeset patch # User Trent Piepho xy...@speakeasy.org # Date 1244834958 25200 # Node ID 23bd6516eafcc06ffb590073e744c7e17382aef9 # Parent

Re: PULL request - http://linuxtv.org/hg/~pb/v4l-dvb/

2009-06-11 Thread Trent Piepho
On Thu, 11 Jun 2009, Patrick Boettcher wrote: On Wed, 27 May 2009, Trent Piepho wrote: On Tue, 26 May 2009, Patrick Boettcher wrote: Does this patch to fix these problems look ok? In fact, everything looks correct in my eyes. I'll ask Mauro to pull any minute from now. I even have

Re: S_FMT vs. S_CROP

2009-06-10 Thread Trent Piepho
On Wed, 10 Jun 2009, Hans Verkuil wrote: On Wednesday 10 June 2009 18:02:39 Guennadi Liakhovetski wrote: This question - how S_FMT and S_CROP affest image geometry - has been discussed at least twice before - that's only with my participation, don't know if and how often it has come up

Re: [PULL] http://linuxtv.org/hg/~pinchartl/uvcvideo/

2009-06-09 Thread Trent Piepho
On Tue, 9 Jun 2009, Mauro Carvalho Chehab wrote: Em Tue, 9 Jun 2009 18:08:38 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: Should I submit a patch that implement VIDIOC_S_JPEGCOMP support in the UVC driver and implement a JPEG compression quality control later, or would you

Re: [PATCH] bt8xx: Add support for the Conexant Fusion 878a / Twinhan VP 1025 DVB-S

2009-06-07 Thread Trent Piepho
On Sun, 7 Jun 2009, Michael Stapelberg wrote: Add fefe:0001 to the list of identifiers for the bt8xx driver. The chip is named Conexant Fusion 878a, the card is a Twinhan VP 1025 DVB-S PCI. Please commit the attached patch. You can remove Conexant Fusion from the board name. All the boards

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Trent Piepho
On Sat, 6 Jun 2009, Hans Verkuil wrote: On Saturday 06 June 2009 13:59:19 Hans Verkuil wrote: I propose to change the API as follows: #define V4L2_I2C_ADDRS(addr, addrs...) \ ((const unsigned short []){ addr, ## addrs, I2C_CLIENT_END }) struct v4l2_subdev

Re: RFC: proposal for new i2c.h macro to initialize i2c address lists on the fly

2009-06-06 Thread Trent Piepho
On Sat, 6 Jun 2009, Hans Verkuil wrote: For video4linux we sometimes need to probe for a single i2c address. Normally you would do it like this: static const unsigned short addrs[] = { addr, I2C_CLIENT_END }; client = i2c_new_probed_device(adapter, info, addrs); This is a bit

Re: [PULL] generic image bounds setting and alignment function

2009-06-03 Thread Trent Piepho
On Mon, 1 Jun 2009, Robert Jarzmik wrote: Trent Piepho xy...@speakeasy.org writes: Please pull from http://linuxtv.org/hg/~tap/v4l-dvb This series adds a function for bounding and alignment image sizes and modifies a number of drivers to use it. It came up when the pxa patches to deal

Re: webcam drivers and V4L2_MEMORY_USERPTR support

2009-06-01 Thread Trent Piepho
On Mon, 1 Jun 2009, Stefan Kost wrote: I have implemented support for V4L2_MEMORY_USERPTR buffers in gstreamers v4l2src [1]. This allows to request shared memory buffers from xvideo, capture into those and therefore save a memcpy. This works great with the v4l2 driver on our embedded device.

Re: [PATCH] Leadtek WinFast DTV-1800H support

2009-05-31 Thread Trent Piepho
On Sun, 31 May 2009, Miroslav [UTF-8] ??ustek wrote: Trent Piepho xyzzy at speakeasy.org writes: Instead of raising the reset line here, why not change the gpio settings in the card definition to have it high? Change gpio1 for television to 0x7050 and radio to 0x7010. Personally, I

Re: [PATCH] bttv-driver.c :poll method lose race condition for capture video

2009-05-31 Thread Trent Piepho
On Sun, 31 May 2009, Figo.zhang wrote: bttv-driver.c,cx23885-video.c,cx88-video.c: poll method lose race condition for capture video. Please use patch titles that are not so long. It would be nice if you could describe this race condition. Signed-off-by: Figo.zhang figo1...@gmail.com ---

[PULL] generic image bounds setting and alignment function

2009-05-30 Thread Trent Piepho
Mauro, Please pull from http://linuxtv.org/hg/~tap/v4l-dvb This series adds a function for bounding and alignment image sizes and modifies a number of drivers to use it. It came up when the pxa patches to deal with the alignment issues for that driver were posted. I haven't tested these

Re: PULL request - http://linuxtv.org/hg/~pb/v4l-dvb/

2009-05-25 Thread Trent Piepho
On Mon, 25 May 2009, Mauro Carvalho Chehab wrote: + if (params-frequency = 4800 params-frequency = 15400) \ + bs = 0x09; + if (params-frequency = 16100 params-frequency = 43900) \ + bs = 0x0a; + if (params-frequency =

Re: [RFC,PATCH] VIDIOC_G_EXT_CTRLS does not handle NULL pointer correctly

2009-05-25 Thread Trent Piepho
On Mon, 25 May 2009, Laurent Pinchart wrote: diff -r e0d881b21bc9 linux/drivers/media/video/v4l2-ioctl.c --- a/linux/drivers/media/video/v4l2-ioctl.c Tue May 19 15:12:17 2009 +0200 +++ b/linux/drivers/media/video/v4l2-ioctl.c Sun May 24 18:26:29 2009 +0200 @@ -402,6 +402,10 @@

Re: [PATCH 1/5 - part 2] V4L2 patches for Intel Moorestown Camera Imaging Drivers

2009-05-23 Thread Trent Piepho
On Sat, 23 May 2009, Mauro Carvalho Chehab wrote: + + if (intel-open) { + ++intel-open; + DBG_DD((device has opened already - %d\n, intel-open)); + return 0; + } + + file-private_data = dev; + /* increment our usage count for the driver */ + ++intel-open; + DBG_DD((intel_open is %d\n,

Re: Sound capture with Osprey 230

2009-05-14 Thread Trent Piepho
On Mon, 11 May 2009, Sverker Abrahamsson wrote: Hi all, I've been using Osprey 230 cards for AV capture for several years, earlier with a modified version of Viewcast's driver but it was never very stable. When doing a new setup I therefore wanted to get the Alsa driver to work. I found that

Re: [PULL] http://endr...@linuxtv.org/hg/~endriss/v4l-dvb

2009-05-13 Thread Trent Piepho
On Wed, 13 May 2009, Oliver Endriss wrote: 02/05: dvb-ttpci: Check transport error indicator flag http://endr...@linuxtv.org/hg/~endriss/v4l-dvb?cmd=changeset;node=8a742338523d Are you sure this is a good idea? The cx88 driver doesn't do this. -- To unsubscribe from this list: send the line

Re: [patch 4/4] zoran: fix /|| error

2009-05-12 Thread Trent Piepho
On Tue, 12 May 2009, Mauro Carvalho Chehab wrote: Em Tue, 12 May 2009 17:18:20 -0400 Devin Heitmueller dheitmuel...@kernellabs.com escreveu: On Tue, May 12, 2009 at 4:39 PM, a...@linux-foundation.org wrote: From: Roel Kluin roel.kl...@gmail.com Fix /|| typo. `default_norm' can be 0

Re: [PATCH] v4l2: fill the reserved fields of VIDIOC_REQBUFS ioctl

2009-04-30 Thread Trent Piepho
On Wed, 29 Apr 2009, [UTF-8] N??meth M??rton wrote: The parameter of VIDIOC_REQBUFS is a pointer to struct v4l2_requestbuffers. This structure has reserved fields which has to be filled with zeros according to the V4L2 API specification, revision 0.24 [1]. As I read the spec, the reserved

Re: [PATCH] v4l2: fill the reserved fields of VIDIOC_REQBUFS ioctl

2009-04-30 Thread Trent Piepho
On Thu, 30 Apr 2009, Trent Piepho wrote: On Wed, 29 Apr 2009, [UTF-8] N??meth M??rton wrote: The parameter of VIDIOC_REQBUFS is a pointer to struct v4l2_requestbuffers. This structure has reserved fields which has to be filled with zeros according to the V4L2 API specification, revision

[pull] http://linuxtv.org/hg/~tap/v4l-dvb

2009-04-30 Thread Trent Piepho
Mauro, Please pull from http://linuxtv.org/hg/~tap/v4l-dvb for the following 4 changesets: 01/04: compat: Add DMA_BIT_MASK() macro http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=486add0e3f1f 02/04: zoran: fix bug when enumerating format -1

Re: [PATCH] [0904_14] Siano: assemble all components to one kernel module

2009-04-28 Thread Trent Piepho
On Mon, 27 Apr 2009, Uri Shkolnik wrote: --- On Tue, 4/21/09, Mauro Carvalho Chehab mche...@infradead.org wrote: If the system includes SDIO and OMAP SPI/SPP, the module build will discard the USB interface driver, but the SDIO and the OMAP SPI will be built. The patch you've provided

Re: [Mjpeg-users] [PATCH] zoran: invalid test on unsigned

2009-04-27 Thread Trent Piepho
. It's simpler this way too. The unnecessary check for (unsigned)fmt-index 0 found by Roel Kluin roel.kl...@gmail.com is removed this way too. Signed-off-by: Trent Piepho xy...@speakeasy.org diff -r 63eba6df4b8a -r c247021eb11c linux/drivers/media/video/zoran/zoran_driver.c --- a/linux/drivers

Re: [PATCH] zoran: invalid test on unsigned

2009-04-26 Thread Trent Piepho
this in it. Patch is fine. Acked-by: Trent Piepho xy...@speakeasy.org diff --git a/drivers/media/video/zoran/zoran_driver.c b/drivers/media/video/zoran/zoran_driver.c index 092333b..0db5d0f 100644 --- a/drivers/media/video/zoran/zoran_driver.c +++ b/drivers/media/video/zoran/zoran_driver.c @@ -1871,7

Re: [PATCH] [0904_14] Siano: assemble all components to one kernel module

2009-04-20 Thread Trent Piepho
On Mon, 20 Apr 2009, Uri Shkolnik wrote: better to have the BUS configurable, e. g. just because you have USB interface, it doesn't mean that you want siano for USB, instead of using SDIO. Since the module is using dynamic registration, I don't find it a problem. When the system has both

Re: patch: s2255drv high quality mode and video status querying

2009-04-07 Thread Trent Piepho
On Tue, 7 Apr 2009, Dean A. wrote: +static int vidioc_g_parm(struct file *file, void *priv, + struct v4l2_streamparm *sp) +{ + struct s2255_fh *fh = priv; + struct s2255_dev *dev = fh-dev; + if (sp-type != V4L2_BUF_TYPE_VIDEO_CAPTURE) + return

Re: [PATCH] [0904_16] Siano: smsdvb - additional case of endian handling.

2009-04-05 Thread Trent Piepho
On Sun, 5 Apr 2009, Uri Shkolnik wrote: PidMsg.xMsgHeader.msgLength = sizeof(PidMsg); PidMsg.msgData[0] = feed-pid; - /* smsendian_handle_tx_message((struct SmsMsgHdr_ST *)PidMsg); */ + smsendian_handle_tx_message((struct SmsMsgHdr_ST *)PidMsg); return

Re: [PATCH 3/6] ir-kbd-i2c: Switch to the new-style device binding model

2009-04-05 Thread Trent Piepho
On Sun, 5 Apr 2009, Andy Walls wrote: Here is where LIRC may be its own worst enemy. LIRC has filled some shortcomings in the kernel for support of IR device functions for so long (LWN says LIRC is 10 years old), that large numbers of users have come to depend on its operation, while at the

Re: [PATCH 3/6] ir-kbd-i2c: Switch to the new-style device binding model

2009-04-05 Thread Trent Piepho
On Sun, 5 Apr 2009, Mike Isely wrote: 1. The switch statement in ir-kbd-i2c.c:ir_attach() is apparently implicitly trying to assume a particular type of remote based on the I2C address of the IR receiver it's talking to. Yuck. That's really not right at all. The IR receiver used does not

Re: When is a wake_up() not a wake up?

2009-04-04 Thread Trent Piepho
On Fri, 3 Apr 2009, Andy Walls wrote: 1. A work queue thread or read() call needs to send a command to the CX23418 using the cx18_api_call() function 2. It fills out a mailbox with a command for the CX23418 3. It prepares to wait, just in case a wait is needed 4. A SW1 interrupt is sent to

Re: [linuxtv-commits] [hg:v4l-dvb] v4l2-ioctl: Check format for S_PARM and G_PARM

2009-03-30 Thread Trent Piepho
On Sun, 29 Mar 2009, Hans Verkuil wrote: On Sunday 29 March 2009 13:03:13 Trent Piepho wrote: How does overlay depend on video capture in any way? It's perfectly reasonable for a driver to support _only_ overlay and not video capture. The zr36067 chip is only designed to support

Re: Problems with Hauppauge HVR 1600 and cx18 driver

2009-03-30 Thread Trent Piepho
On Sun, 29 Mar 2009, Andy Walls wrote: On Sun, 2009-03-29 at 01:24 -0700, Trent Piepho wrote: wait_event() should take care of this. wait_event(q, test) basically does: for(;;) { // point A add_me_to_waitqueue(q); set_current_state(TASK_UNINTERRUPTIBLE); if (test

Re: [PATCH 3/4] ARM: DaVinci: DM646x Video: Add VPIF display driver

2009-03-30 Thread Trent Piepho
On Mon, 30 Mar 2009, Hans Verkuil wrote: On Thursday 26 March 2009 14:22:32 Chaithrika U S wrote: + /* one field is displayed configure the next + frame if it is available else hold on current + frame */

Re: [linuxtv-commits] [hg:v4l-dvb] v4l2-ioctl: Check format for S_PARM and G_PARM

2009-03-29 Thread Trent Piepho
On Sun, 29 Mar 2009, Hans Verkuil wrote: On Sunday 29 March 2009 12:21:58 Trent Piepho wrote: On Sun, 29 Mar 2009, Hans Verkuil wrote: On Sunday 29 March 2009 10:50:02 Patch from Trent Piepho wrote: From: Trent Piepho xy...@speakeasy.org v4l2-ioctl: Check format for S_PARM

[pull] http://linuxtv.org/hg/~tap/v4l-dvb

2009-03-28 Thread Trent Piepho
Mauro, Please pull from http://linuxtv.org/hg/~tap/v4l-dvb for the following 14 changesets: 01/14: build: Fix kernel output directory support http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=346bab8698ea 02/14: v4l2-ioctl: Check format for S_PARM and G_PARM

Re: [PATCH] v4l2: fill reserved fields of VIDIOC_ENUMAUDIO also

2009-03-27 Thread Trent Piepho
On Fri, 27 Mar 2009, Mauro Carvalho Chehab wrote: On Wed, 25 Mar 2009 17:51:39 +0100 N?meth M?rton nm...@freemail.hu wrote: From: M?rton N?meth nm...@freemail.hu When enumerating audio inputs with VIDIOC_ENUMAUDIO the gspca_sunplus driver does not fill the reserved fields of the struct

Re: [PATCH] v4l2: fill reserved fields of VIDIOC_ENUMAUDIO also

2009-03-27 Thread Trent Piepho
On Fri, 27 Mar 2009, Hans Verkuil wrote: On Friday 27 March 2009 20:45:40 Trent Piepho wrote: On Fri, 27 Mar 2009, Mauro Carvalho Chehab wrote: On Wed, 25 Mar 2009 17:51:39 +0100 N?meth M?rton nm...@freemail.hu wrote: From: M?rton N?meth nm...@freemail.hu When enumerating

Re: Fw: [PATCH] cx88: Missing failure checks

2009-03-26 Thread Trent Piepho
On Thu, 26 Mar 2009, Mauro Carvalho Chehab wrote: From: Alan Cox a...@lxorguk.ukuu.org.uk To: linux-ker...@vger.kernel.org, mche...@infradead.org Subject: [PATCH] cx88: Missing failure checks The ioremap one was reported in October 2007 (Bug 9146), the kmalloc one was blindingly obvious

Re: The right way to interpret the content of SNR, signal strength and BER from HVR 4000 Lite

2009-03-20 Thread Trent Piepho
On Fri, 20 Mar 2009, Devin Heitmueller wrote: On Thu, Mar 19, 2009 at 7:06 PM, Trent Piepho xy...@speakeasy.org wrote: The argument being put forth is based on the relative efficiency of the multiply versus divide opcodes on modern CPU architectures?? ?And Maybe I just like writing

Re: Results of the 'dropping support for kernels 2.6.22' poll

2009-03-20 Thread Trent Piepho
On Fri, 20 Mar 2009, Devin Heitmueller wrote: On Fri, Mar 20, 2009 at 6:20 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: My suggestion is to keep a backporting system, but more targeted at the end-users. The reasons are the ones explained above. Basically: Ok, so just so we're all

Re: [PATCH] gspca: add missing .type field check in VIDIOC_G_PARM

2009-03-19 Thread Trent Piepho
On Thu, 19 Mar 2009, [ISO-8859-1] N?meth M?rton wrote: David Ellingsworth wrote: 2009/3/18 N?meth M?rton nm...@freemail.hu: From: M?rton N?meth nm...@freemail.hu The gspca webcam driver does not check the .type field of struct v4l2_streamparm. This field is an input parameter for the

Re: Results of the 'dropping support for kernels 2.6.22' poll

2009-03-19 Thread Trent Piepho
On Sun, 15 Mar 2009, Hans Verkuil wrote: On Sunday 15 March 2009 17:39:11 Trent Piepho wrote: Because there are patches that touch both the media tree and outside it? I don't buy it. Even for sub-systems that only use full git trees, you almost never see a patch that touches multiple areas

Re: [PATCH] gspca: add missing .type field check in VIDIOC_G_PARM

2009-03-19 Thread Trent Piepho
On Thu, 19 Mar 2009, [UTF-8] N??meth M??rton wrote: The gspca webcam driver does not check the .type field of struct v4l2_streamparm. This field is an input parameter for the driver according to V4L2 API specification, revision 0.24 [1]. Add the missing check. I think this check could go

Re: Improve DKMS build of v4l-dvb?

2009-03-17 Thread Trent Piepho
On Tue, 17 Mar 2009, Alain Kalker wrote: Op vrijdag 13-03-2009 om 02:12 uur [tijdzone -0700], schreef Trent Piepho: On Mon, 9 Mar 2009, Alain Kalker wrote: Firstly: generating a .config with just one config variable for the requested driver set to 'm' merged with the config

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-17 Thread Trent Piepho
On Tue, 17 Mar 2009, Jean Delvare wrote: On Mon, 16 Mar 2009 15:47:17 -0700 (PDT), Trent Piepho wrote: On Mon, 16 Mar 2009, Jean Delvare wrote: You are unfair. The pull request came with a short log of all the changes. short log. His entire series was decribed with fewer words than I

Re: [PULL] http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2/

2009-03-16 Thread Trent Piepho
On Sun, 15 Mar 2009, Devin Heitmueller wrote: au0828: remove memset calls in v4l2 routines. The userland callers are responsible for clearing the output buffers, so remove the unneeded memset calls. A driver should not assume that _userspace_ has cleared the buffers. In some cases userspace is

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-16 Thread Trent Piepho
On Mon, 16 Mar 2009, Hans Verkuil wrote: +++ b/linux/drivers/media/video/bt8xx/bttvp.h Sun Mar 15 13:07:15 2009 +0100 @@ -331,6 +331,7 @@ struct bttv { unsigned int tuner_type; /* tuner chip type */ unsigned int tda9887_conf; unsigned int svhs, dig; + int has_saa6588;

Re: [PATCH v2 3/4] pxa_camera: Redesign DMA handling

2009-03-16 Thread Trent Piepho
On Mon, 16 Mar 2009, Robert Jarzmik wrote: Guennadi Liakhovetski g.liakhovet...@gmx.de writes: What is QIF? Do you mean Quick Capture Interface - QCI? I also see CIF used in the datasheet, probably, for Capture InterFace, but I don't see QIF anywhere. Also, please explain the first time you

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-16 Thread Trent Piepho
On Mon, 16 Mar 2009, Jean Delvare wrote: On Mon, 16 Mar 2009 12:43:33 -0700 (PDT), Trent Piepho wrote: On Mon, 16 Mar 2009, Jean Delvare wrote: Come on, just look at ir-kbd-i2c and tvaudio again, see how great are these drivers which have been designed on top of the legacy i2c binding

Re: [PATCH] LED control

2009-03-15 Thread Trent Piepho
On Sun, 15 Mar 2009, Jean-Francois Moine wrote: On Sat, 14 Mar 2009 13:16:11 -0700 (PDT) Trent Piepho xy...@speakeasy.org wrote: There is already a sysfs led interface, you could just have the driver export the leds to the led subsystem and use that. Yes, but: - this asks to have

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-15 Thread Trent Piepho
On Sun, 15 Mar 2009, Hans Verkuil wrote: Hi Mauro, Can you review my ~hverkuil/v4l-dvb-bttv2 tree? It would be a lot easier if you would provide patch descriptions. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-15 Thread Trent Piepho
On Sun, 15 Mar 2009, Hans Verkuil wrote: On Sunday 15 March 2009 17:04:43 Trent Piepho wrote: On Sun, 15 Mar 2009, Hans Verkuil wrote: Hi Mauro, Can you review my ~hverkuil/v4l-dvb-bttv2 tree? It would be a lot easier if you would provide patch descriptions. Here it is: - bttv

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-15 Thread Trent Piepho
On Sun, 15 Mar 2009, Jean Delvare wrote: On Sun, 15 Mar 2009 13:44:01 +0100, Hans Verkuil wrote: This is the typical multifunction device problem. It isn't specifically related to I2C, the exact same problem happens for other devices, for example a PCI south bridge including hardware

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-15 Thread Trent Piepho
On Sun, 15 Mar 2009, Andy Walls wrote: On Sun, 2009-03-15 at 10:28 -0700, Trent Piepho wrote: Why are the i2c addresses from various i2c chips moved into the bttv driver? Doesn't it make more sense that the addresses for chip X should be in the driver for chip X? One reason

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-15 Thread Trent Piepho
On Sun, 15 Mar 2009, Andy Walls wrote: On Sun, 2009-03-15 at 18:12 +0100, Jean Delvare wrote: This is the typical multifunction device problem. It isn't specifically related to I2C, But the specific problem that Hans' brings up is precisely a Linux kernel I2C subsystem *software*

Re: [PATCH] LED control

2009-03-14 Thread Trent Piepho
On Sat, 14 Mar 2009, Mauro Carvalho Chehab wrote: On Sat, 14 Mar 2009 12:59:23 +0100 Jean-Francois Moine moin...@free.fr wrote: + entryconstantV4L2_CID_LEDS/constant/entry + entryinteger/entry + entrySwitch on or off the LEDs or illuminators of the device. +In the

Re: identifying camera sensor

2009-03-13 Thread Trent Piepho
On Thu, 5 Mar 2009, Hans Verkuil wrote: Reserved bits are there for a reason. If a particular bit of information it a perfect match with for that API, then it seems utterly pointless to me to decide not to use them 'just because we might run out in the future'. It would be one thing if there

Re: [PATCH] cx88: Add IR support to pcHDTV HD3000 HD5500

2009-03-13 Thread Trent Piepho
On Thu, 5 Mar 2009, Erik S. Beiser wrote: Thanks for your comments, Trent. My responses below: Trent Piepho wrote: On Sat, 28 Feb 2009, Erik S. Beiser wrote: cx88: Add IR support to pcHDTV HD3000 HD5500 Signed-off-by: Erik S. Beiser er...@bu.edu --- Idea originally from http

Re: Kconfig changes in /hg/v4l-dvb caused dvb_usb_cxusb to stop building (fwd)

2009-03-13 Thread Trent Piepho
On Mon, 9 Mar 2009, Mauro Carvalho Chehab wrote: Btw, if you look at DVB_FE_CUSTOMISE help, it is recommended tho unselect it, if you're not sure what to do. Anyways, here's what I get: $ grep ^CONFIG .config [everything is 'm'] CONFIG_DVB_VES1820=m CONFIG_DVB_STV0297=m

Re: Improve DKMS build of v4l-dvb?

2009-03-13 Thread Trent Piepho
On Mon, 9 Mar 2009, Alain Kalker wrote: Martin has an older version of the drivers packaged for building with DKMS on Ubuntu in his PPA[5], but it currently has some disadvantages: A. It builds all available drivers, no matter which hardware is actually installed in the system. This takes a

[pull] http://linuxtv.org/hg/~tap/v4l-dvb

2009-03-13 Thread Trent Piepho
Mauro, Please pull from http://linuxtv.org/hg/~tap/v4l-dvb for the following changeset: 01/01: build: have make_kconfig.pl ignore comments http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=9debb0a2ec70 make_kconfig.pl | 13 + 1 files changed, 9 insertions(+), 4 deletions(-)

Re: The right way to interpret the content of SNR, signal strength and BER from HVR 4000 Lite

2009-03-13 Thread Trent Piepho
On Fri, 13 Mar 2009, Devin Heitmueller wrote: On Fri, Mar 13, 2009 at 5:11 PM, Trent Piepho xy...@speakeasy.org wrote: I like 8.8 fixed point a lot better. ?It gives more precision. ?The range is more in line with that the range of real SNRs are. ?Computers are binary, so the math can end

Re: The right way to interpret the content of SNR, signal strength and BER from HVR 4000 Lite

2009-03-13 Thread Trent Piepho
On Fri, 13 Mar 2009, Andy Walls wrote: On Fri, 2009-03-13 at 10:27 -0400, Devin Heitmueller wrote: On Fri, Mar 13, 2009 at 12:19 AM, Ang Way Chuang wc...@nav6.org wrote: Yes, please :) Yeah, Michael Krufky and I were discussing it in more detail yesterday on the #linuxtv ML.

Re: [PATCH] Add support for ProVideo PV-183 to bttv

2009-03-12 Thread Trent Piepho
On Fri, 13 Mar 2009, Alan McIvor wrote: + +{ 0x15401830, BTTV_BOARD_PV183, Provideo PV183-1 }, +{ 0x15401831, BTTV_BOARD_PV183, Provideo PV183-2 }, +{ 0x15401832, BTTV_BOARD_PV183, Provideo PV183-3 }, +{ 0x15401833, BTTV_BOARD_PV183,

Re: [PATCH 1/4] pxa_camera: Remove YUV planar formats hole

2009-03-10 Thread Trent Piepho
On Mon, 9 Mar 2009, Robert Jarzmik wrote: Ok, this one will change I presume - new alignment calculations and line-breaking. In fact, if you adjust width and height earlier in set_fmt, maybe you'll just remove any rounding here completely. Helas, not fully. The problem is with passthrough

Re: V4L2 spec

2009-03-10 Thread Trent Piepho
On Mon, 9 Mar 2009, Hans Verkuil wrote: On Monday 09 March 2009 12:08:39 Mauro Carvalho Chehab wrote: On Fri, 6 Mar 2009, wk wrote: Hans Verkuil wrote: Hi Mauro, I noticed that there is an ancient V4L2 spec in our tree in the v4l/API directory. Is that spec used in any way? I

  1   2   >