XC4000: detect XC4100

2011-06-04 Thread istva...@mailbox.hu
Added code to detect the XC4100 chip, which is presumably an analog-only "value" version of the XC4000. It is not sure, however, if any devices using this have actually been produced and sold, so the patch may be unneeded. Signed-off-by: Istvan Varga diff -uNr xc4000_orig/drivers/media/common/tu

XC4000: removed redundant tuner reset

2011-06-04 Thread istva...@mailbox.hu
This patch causes the tuner reset command to be ignored in the firmware code, since this only happens when the BASE/INIT1 firmware is loaded by check_firmware(), and in that case check_firmware() already calls the reset callback before starting to load the firmware. Signed-off-by: Istvan Varga d

XC4000: xc_tune_channel() cleanup

2011-06-04 Thread istva...@mailbox.hu
Minor coding changes related to the xc_tune_channel() function. Signed-off-by: Istvan Varga diff -uNr xc4000_orig/drivers/media/common/tuners/xc4000.c xc4000/drivers/media/common/tuners/xc4000.c --- xc4000_orig/drivers/media/common/tuners/xc4000.c 2011-06-04 16:22:18.0 +0200 +++ xc4000/d

XC4000: implemented analog TV and radio

2011-06-04 Thread istva...@mailbox.hu
The following patch implements support for analog TV and FM radio. Signed-off-by: Istvan Varga diff -uNr xc4000_orig/drivers/media/common/tuners/xc4000.c xc4000/drivers/media/common/tuners/xc4000.c --- xc4000_orig/drivers/media/common/tuners/xc4000.c 2011-06-04 15:40:26.0 +0200 +++ xc400

XC4000: added audio_std module parameter

2011-06-04 Thread istva...@mailbox.hu
The 'audio_std' module parameter makes it possible to fine tune some audio related aspects of the driver, like setting the exact audio standard (NICAM, A2, etc.) to be used for some video standards. Signed-off-by: Istvan Varga diff -uNr xc4000_orig/drivers/media/common/tuners/xc4000.c xc4000/dri

XC4000: setting registers

2011-06-04 Thread istva...@mailbox.hu
This patch implements setting the registers in xc4000_set_params() and xc4000_set_analog_params(). A new register is defined which enables filtering of the composite video output (this is needed to avoid bad picture quality with some boards). Signed-off-by: Istvan Varga diff -uNr xc4000_orig/dri

XC4000: debug message improvements

2011-06-04 Thread istva...@mailbox.hu
The following patch makes a few minor changes to the printing of debug messages, and reporting the tuner status. The 'debug' module parameter can now be set from 0 to 2 to control the verbosity of debug messages. Signed-off-by: Istvan Varga diff -uNr xc4000_orig/drivers/media/common/tuners/xc400

XC4000: firmware initialization

2011-06-04 Thread istva...@mailbox.hu
This patch fixes/cleans up the loading of the firmware file when the driver is loaded and initialized. Signed-off-by: Istvan Varga diff -uNr xc4000_orig/drivers/media/common/tuners/xc4000.c xc4000/drivers/media/common/tuners/xc4000.c --- xc4000_orig/drivers/media/common/tuners/xc4000.c 2011-06-0

XC4000: implemented power management

2011-06-04 Thread istva...@mailbox.hu
The following patch implements the xc4000_sleep() function. The 'no_powerdown' module parameter is now interpreted differently: - 0 uses a device-specific default - 1 disables power management like before - 2 enables power management Signed-off-by: Istvan Varga diff -uNr xc4000_orig/driver

XC4000: check_firmware() cleanup

2011-06-04 Thread istva...@mailbox.hu
This patch makes the following fixes in check_firmware(): - there is only one BASE and INIT1 firmware for XC4000 - loading SCODE is needed also for FM radio Signed-off-by: Istvan Varga diff -uNr xc4000_orig/drivers/media/common/tuners/xc4000.c xc4000/drivers/media/common/tuners/xc4000.c ---

XC4000: simplified load_scode

2011-06-04 Thread istva...@mailbox.hu
Removed unused code from load_scode() (all SCODE firmwares are assumed to have the HAS_IF bit set). Signed-off-by: Istvan Varga diff -uNr xc4000_orig/drivers/media/common/tuners/xc4000.c xc4000/drivers/media/common/tuners/xc4000.c --- xc4000_orig/drivers/media/common/tuners/xc4000.c 2011-06-04 1

XC4000: simplified seek_firmware()

2011-06-04 Thread istva...@mailbox.hu
This patch simplifies the code in seek_firmware(). Signed-off-by: Istvan Varga diff -uNr xc4000_orig/drivers/media/common/tuners/xc4000.c xc4000/drivers/media/common/tuners/xc4000.c --- xc4000_orig/drivers/media/common/tuners/xc4000.c 2011-06-04 12:50:41.0 +0200 +++ xc4000/drivers/media/

XC4000: added firmware_name parameter

2011-06-04 Thread istva...@mailbox.hu
The firmware_name module parameter makes it possible to set the firmware file name. It defaults to "xc4000.fw" if not specified. Signed-off-by: Istvan Varga diff -uNr xc4000_orig/drivers/media/common/tuners/xc4000.c xc4000/drivers/media/common/tuners/xc4000.c --- xc4000_orig/drivers/media/common

XC4000: fixed frequency error

2011-06-03 Thread istva...@mailbox.hu
The xc_get_frequency_error() function reported the frequency error incorrectly. The data read from the hardware is a signed integer, in 15625 Hz units. The attached patch fixes the bug. Signed-off-by: Istvan Varga diff -uNr xc4000_orig/drivers/media/common/tuners/xc4000.c xc4000/drivers/media/co

XC4000: added mutex

2011-06-03 Thread istva...@mailbox.hu
This patch adds a mutex to xc4000_priv, to protect the driver from being accessed by multiple processes at the same time. Signed-off-by: Istvan Varga diff -uNr xc4000_orig/drivers/media/common/tuners/xc4000.c xc4000/drivers/media/common/tuners/xc4000.c --- xc4000_orig/drivers/media/common/tuners

XC4000: added support for 7 MHz DVB-T

2011-06-03 Thread istva...@mailbox.hu
The following patch implements support for DVB-T with 7 MHz bandwidth. Signed-off-by: Istvan Varga diff -uNr xc4000_orig/drivers/media/common/tuners/xc4000.c xc4000/drivers/media/common/tuners/xc4000.c --- xc4000_orig/drivers/media/common/tuners/xc4000.c 2011-06-03 15:47:04.0 +0200 +++ x

XC4000: updated standards table

2011-06-03 Thread istva...@mailbox.hu
This patch makes the following changes to the standards table: - added 'u16 int_freq' to struct XC_TV_STANDARD (needed for analog TV and radio, 0 for DVB-T) - added new standard for SECAM-D/K video with PAL-D/K audio - the 'int_freq' values are now specified in the table - changed Video

Re: XC4000: added card_type

2011-06-03 Thread istva...@mailbox.hu
On 06/03/2011 04:00 PM, Mauro Carvalho Chehab wrote: > While the xc4000 is not merged upstream, we may have such hack, but > before merging, this issue should be solved. > > However, it seems better to just do the right thing since the beginning: > > just add a patch for cx88 adding the xc4000 b

Re: [PATCH] cx88: implement sharpness control

2010-04-09 Thread istva...@mailbox.hu
On 04/09/2010 06:33 AM, Mauro Carvalho Chehab wrote: > You're not adjusting the sharpness. Instead, you're changing the vertical tap > filter, > and just for the even frames, plus the notch filter. > Tricky, and you're probably affecting the sharpness, but on an indirect and > non-linear > way,

[PATCH] cx88: fix setting input when using DVB

2010-03-27 Thread istva...@mailbox.hu
(Sorry for the double post, the previous one did not include the patch) In cx88-mpeg.c, there is code that sets core->input to CX88_VMUX_DVB. However, this may be incorrect, since core->input is actually an index to core->board.input[], which has not enough elements to be indexed by the value of C

[PATCH] cx88: fix setting input when using DVB

2010-03-27 Thread istva...@mailbox.hu
In cx88-mpeg.c, there is code that sets core->input to CX88_VMUX_DVB. However, this may be incorrect, since core->input is actually an index to core->board.input[], which has not enough elements to be indexed by the value of CX88_VMUX_DVB. So, the modified code searches core->board.input[] for an i

[PATCH] cx88: implement sharpness control

2010-03-27 Thread istva...@mailbox.hu
This patch adds support for V4L2_CID_SHARPNESS by changing the luma peak filter and notch filter. It can be set in the range 0 to 9, with 0 being the original and default mode. One minor problem is that other code that sets the registers being used (for example when switching TV channels) could res

[PATCH] cx88: fix checks for analog TV inputs

2010-03-27 Thread istva...@mailbox.hu
The following patch fixes code that checks for CX88_VMUX_TELEVISION, but not CX88_VMUX_CABLE. This prevented for example the audio standard from being set when using the cable input. Signed-off-by: Istvan Varga diff -r -d -N -U4 v4l-dvb-a79dd2ae4d0e.old/linux/drivers/media/video/cx88/cx88-core.c

Re: [PATCH] DTV2000 H Plus issues

2010-03-24 Thread istva...@mailbox.hu
An updated patch that includes the PxDVR3200 H (107d:6f39) support is now available at http://istvanv.users.sourceforge.net/v4l/xc4000.html. On 03/22/2010 07:33 PM, istva...@mailbox.hu wrote: > On 03/15/2010 05:15 AM, Devin Heitmueller wrote: > >> I'll try to go through my tree

Re: [PATCH] DTV2000 H Plus issues

2010-03-22 Thread istva...@mailbox.hu
On 03/15/2010 05:15 AM, Devin Heitmueller wrote: > I'll try to go through my tree and see if I can get something upstream > this week which you could build on. Are there any news on this ? By the way, I have just received this mail from Mirek Slugen, with a patch for PxDVR3200 with XC4000 tuner.

Re: [PATCH] DTV2000 H Plus issues

2010-03-16 Thread istva...@mailbox.hu
On 03/15/2010 05:15 AM, Devin Heitmueller wrote: > I've done essentially no analysis into the tuning performance of the > current driver - validating different frequency ranges and modulation > types or bandwidths. I've done no testing of tuning lock time, > minimal application validation Well,

Re: [PATCH] DTV2000 H Plus issues

2010-03-14 Thread istva...@mailbox.hu
On 02/18/2010 01:11 AM, Devin Heitmueller wrote: > Yeah, my plan at this point was to submit a PULL request once I felt > the driver is stable For those particular cards that my patch adds support for, it seems to be stable, and I have been using it for months. Perhaps stability issues in xc4000.

Re: [PATCH] DTV2000 H Plus issues

2010-03-14 Thread istva...@mailbox.hu
OK, so should I write a new xc4000.c/h from scratch and sign that off ? On 02/18/2010 01:08 AM, Mauro Carvalho Chehab wrote: > Devin Heitmueller wrote: >> On Wed, Feb 17, 2010 at 6:51 PM, Mauro Carvalho Chehab >> wrote: >>> Hi Istvan, >>> >>> istva.

Re: [PATCH] DTV2000 H Plus issues

2010-03-10 Thread istva...@mailbox.hu
I have finally received some feedback on DVB-T, and it reportedly works, although with a minor bug: it was necessary to use the "cable" connector instead of the "antenna" one. There is an updated patch at the web page http://www.sharemation.com/IstvanV/v4l/xc4000.html that attempts to correct this

Re: [PATCH] DTV2000 H Plus issues

2010-02-19 Thread istva...@mailbox.hu
Well, it is not really a problem, if it is not merged, so this updated version is only for those who want to test it: http://www.sharemation.com/IstvanV/v4l/xc4000-winfast-14021dfc00f3.patch - in xc4000.c, power management may default to on or off depending on the card type - autodetects

Re: DTV2000 H Plus issues

2010-02-12 Thread istva...@mailbox.hu
A correction to the previous post: this line: if (WaitForLock(priv) == 0) should actually be: if (WaitForLock(priv) != 1) It does not have an effect on the operation of the driver, though, since the value set depending on this line is not used. -- To unsubscribe from

Re: DTV2000 H Plus issues

2010-02-12 Thread istva...@mailbox.hu
Here is another patch, with a few minor changes. It depends on the previously posted patches, so those should be applied first. diff -r -d -N -U4 v4l-dvb-28f5eca12bb0.old/linux/drivers/media/common/tuners/xc4000.c v4l-dvb-28f5eca12bb0/linux/drivers/media/common/tuners/xc4000.c --- v4l-dvb-28f5eca12

Re: DTV2000 H Plus issues

2010-02-11 Thread istva...@mailbox.hu
On 02/11/2010 08:21 PM, Devin Heitmueller wrote: > Is the DTV7 support actually tested? Or are you just blindly adding > the code in the hope that it works? I'm just asking because the last > time I spoke to you, you actually didn't have access to a DVB-T signal > source. Hi! It is indeed not t

Re: DTV2000 H Plus issues

2010-02-11 Thread istva...@mailbox.hu
/2010 06:35 PM, istva...@mailbox.hu wrote: > There are two separate patches for v4l-dvb revision 28f5eca12bb0: the > first one adds the XC4000 driver, while the second one adds support for > the Leadtek WinFast DTV2000H Plus card in the CX88 driver. > > http://www.sharemation.

Re: DTV2000 H Plus issues

2010-02-09 Thread istva...@mailbox.hu
.g. hcw85bda.sys from Hauppauge, wfeaglxt.sys from Leadtek, etc.; dvb7700all.sys from Pinnacle will not work, however), and supports both v1.2 and v1.4 firmware. The tables at the beginning of the code are not necessarily fully correct, though, and may need some fixing. http://www.sharemation.com/Ist

Re: DTV2000 H Plus issues

2010-01-07 Thread istva...@mailbox.hu
On 01/07/2010 09:00 PM, Devin Heitmueller wrote: > Could you please do me a favor and rename your firmware file, both in > the patch and the file you are redistributing (perhaps as > dvb-fe-xc4000-1.4.1-istanv.fw)? I worry that by redistributing a file > with the exact same name as the "official"

Re: DTV2000 H Plus issues

2010-01-07 Thread istva...@mailbox.hu
On 01/05/2010 02:25 AM, Raena Lea-Shannon wrote: > Thanks. Will try again later. By the way, for those who would like to test it, here is a patch based on Devin Heitmueller's XC4000 driver and Mirek Slugen's older patch, that adds support for this card: http://www.sharemation.com/IstvanV/v4l/dt

Re: DTV2000 H Plus issues

2010-01-04 Thread istva...@mailbox.hu
On 01/03/2010 09:21 AM, Raena Lea-Shannon wrote: > That seems odd. This patch on the LinuxTv site > http://www.linuxtv.org/pipermail/linux-dvb/2008-June/026379.html > seems to be using the cx88 drivers? Unfortunately, this patch is for the older DTV 2000H (not Plus) card, which uses a Philips FMD

Re: DTV2000 H Plus issues

2010-01-02 Thread istva...@mailbox.hu
On 01/02/2010 05:10 PM, Raena Lea-Shannon wrote: > I have 2 TV Cards. The DTV2000 H Plus and a Technisat. The Technisat > works very well. I am trying to get the DVT working for other video > input devices such as VCR to make copies of old Videos and an inteface > for my N95 video out. > > I do n

Newbie question about choosing a TV tuner card for Linux

2009-11-16 Thread istva...@mailbox.hu
Hi! Can someone give me advice on which of these PCI TV tuner cards I should buy for use on Linux ? All are from a similar price range, but I do not know how they compare in terms of Linux support and picture quality. - Leadtek DTV 1800H A relatively cheap card based on CX2388x and XC3028 (?).