Re: [PATCH v4 2/5] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-07-19 Thread m7aalton
Hello and thanks for the comments Mauro... One quick comment: On Tue, 2010-07-06 at 04:34 +0200, ext Mauro Carvalho Chehab wrote: + core-rx_frequency = + bands[core-band].bottom_frequency + + freq * 50; + +

Re: [PATCH v4 1/5] V4L2: Add seek spacing and FM RX class.

2010-07-19 Thread m7aalton
Hello. On Tue, 2010-07-06 at 04:03 +0200, ext Mauro Carvalho Chehab wrote: Em 04-06-2010 07:34, Matti J. Aaltonen escreveu: + +#define V4L2_CID_FM_RX_BAND (V4L2_CID_FM_TX_CLASS_BASE + 1) +enum v4l2_fm_rx_band { + V4L2_FM_BAND_OTHER = 0, +

Re: [PATCH 0/3] Driver for TI WL1273 FM radio.

2010-04-23 Thread m7aalton
Hello Hans, thank you for the comments. On Fri, 2010-04-23 at 11:16 +0200, ext Hans Verkuil wrote: On Tuesday 20 April 2010 17:20:04 Matti J. Aaltonen wrote: Hi. This is the initial version of my driver for Texas Instruments WL1273 FM receiver transmitter. The driver is divided into

Re: [PATCH 1/3] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-04-21 Thread m7aalton
Hello. Thanks for the comments. On Tue, 2010-04-20 at 21:33 +0200, ext Jonathan Corbet wrote: On Tue, 20 Apr 2010 18:20:05 +0300 Matti J. Aaltonen matti.j.aalto...@nokia.com wrote: This is a parent driver for two child drivers: the V4L2 driver and the ALSA codec driver. The MFD part

v4l2 subdevices and fops

2010-03-08 Thread m7aalton
Hello. I'm writing a radio driver which uses subdevice file operations to handle RDS reception and transmission. Some IOCTL call-backs to the main device are easy to pass to the subdevice driver. To me it seems that adding the fops pointer to the following struct in v4l2-subdev.h would make

Re: git over http from linuxtv

2010-03-04 Thread m7aalton
HI. On Wed, 2010-03-03 at 15:55 +0100, ext Mauro Carvalho Chehab wrote: m7aalton wrote: Hello. On Tue, 2010-03-02 at 20:08 +0100, ext Mauro Carvalho Chehab wrote: m7aalton wrote: Hi. Is it possible to access the linuxtv.org git repositories using http? I tried to do

Re: git over http from linuxtv

2010-03-03 Thread m7aalton
Hello. On Tue, 2010-03-02 at 20:08 +0100, ext Mauro Carvalho Chehab wrote: m7aalton wrote: Hi. Is it possible to access the linuxtv.org git repositories using http? I tried to do this: git remote add linuxtv git://linuxtv.org/v4l-dvb.git You should be able to use both URL's

V4L2 devices, subdevices, ops and fops.

2010-02-16 Thread m7aalton
Hello. I have been writing this FM radio driver and I'm now trying to implement it as a platform driver that passes IOCTL calls to a subdevice driver that handles the communication with the hardware etc. For IOCTLs there's a macro v4l2_device_call_until_err in v4l2-device.h that makes the calls

A driver for TI WL1273 FM Radio

2009-10-23 Thread m7aalton
Hi. I have written a driver for the TI WL1273 FM Radio but it's not yet quite ready for up-streaming because of its interface. Now I've started to change the interface to v4l2 and I'm following Eduardo Valentin's Si4713 TX driver as an example. However, WL1273 radio has RX and TX so there are

Re: [PATCH 1/1] FM TX: si4713: Kconfig: Fixed two typos.

2009-09-11 Thread m7aalton
Fixed two typos. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com diff -r 5582a6427a41 -r ff80edccfe24 linux/drivers/media/radio/Kconfig --- a/linux/drivers/media/radio/Kconfig Tue Sep 01 22:16:23 2009 +0200 +++ b/linux/drivers/media/radio/Kconfig Fri Sep 11 10:25:13 2009 +0300 @@

Re: [PATCHv15 7/8] FM TX: si4713: Add Kconfig and Makefile entries

2009-09-09 Thread m7aalton
On Sat, 2009-08-08 at 13:10 +0200, Valentin Eduardo (Nokia-D/Helsinki) wrote: Simple add Makefile and Kconfig entries. ... + Say Y here if you want support to Si4713 FM Radio Transmitter. + This device can transmit audio through FM. It can transmit + EDS and EBDS signals

Re: [PATCHv15 6/8] FM TX: si4713: Add files to handle si4713 i2c device

2009-08-10 Thread m7aalton
Hello. On Sat, 2009-08-08 at 13:10 +0200, Valentin Eduardo (Nokia-D/Helsinki) wrote: ... +/* + * I2C driver interface + */ +/* si4713_probe - probe for the device */ +static int si4713_probe(struct i2c_client *client, + const struct i2c_device_id *id)

Re: [PATCHv14 6/8] FM TX: si4713: Add files to handle si4713 i2c device

2009-08-07 Thread m7aalton
Hi. On Mon, 2009-07-27 at 17:12 +0200, Valentin Eduardo (Nokia-D/Helsinki) wrote: This patch adds files to control si4713 devices. Internal functions to control device properties + */ +/* si4713_probe - probe for the device */ +static int si4713_probe(struct i2c_client *client, +