Em Wed, 07 Nov 2018 21:35:32 +0200
Laurent Pinchart escreveu:
> Hi Mauro,
>
> On Wednesday, 7 November 2018 21:10:35 EET Mauro Carvalho Chehab wrote:
> > Em Wed, 07 Nov 2018 12:06:55 +0200 Laurent Pinchart escreveu:
> > > On Wednesday, 7 November 2018 10:05:12 EET Hans Verkuil wrote:
> > >>
On 11/7/18 4:36 PM, Sean Young wrote:
clang -idirafter /usr/local/include -idirafter
+/usr/lib/llvm-6.0/lib/clang/6.0.1/include -idirafter
+/usr/include/mips64el-linux-gnuabi64 -idirafter /usr/include
+-I../../../include -target bpf -O2 -c grundig.c
In file included from grundig.c:5:
In file
On Wed, 2018-11-07 at 09:05 +0100, Hans Verkuil wrote:
> On 11/06/2018 08:58 PM, Laurent Pinchart wrote:
> > Hi Hans,
> >
> > On Tuesday, 6 November 2018 15:56:34 EET Hans Verkuil wrote:
> > > On 11/06/18 14:12, Laurent Pinchart wrote:
> > > > On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus
Hi Mauro,
On Wednesday, 7 November 2018 21:10:35 EET Mauro Carvalho Chehab wrote:
> Em Wed, 07 Nov 2018 12:06:55 +0200 Laurent Pinchart escreveu:
> > On Wednesday, 7 November 2018 10:05:12 EET Hans Verkuil wrote:
> >> On 11/06/2018 08:58 PM, Laurent Pinchart wrote:
> >>> On Tuesday, 6 November
Em Wed, 07 Nov 2018 12:06:55 +0200
Laurent Pinchart escreveu:
> Hi Hans,
>
> On Wednesday, 7 November 2018 10:05:12 EET Hans Verkuil wrote:
> > On 11/06/2018 08:58 PM, Laurent Pinchart wrote:
> > > On Tuesday, 6 November 2018 15:56:34 EET Hans Verkuil wrote:
> > >> On 11/06/18 14:12,
clang -idirafter /usr/local/include -idirafter
+/usr/lib/llvm-6.0/lib/clang/6.0.1/include -idirafter
+/usr/include/mips64el-linux-gnuabi64 -idirafter /usr/include
+-I../../../include -target bpf -O2 -c grundig.c
> In file included from grundig.c:5:
> In file included from
On 11/07/18 16:04, Sakari Ailus wrote:
> The NATIVE_SIZE target is documented for mem2mem devices but no driver has
> ever apparently used it. It may be never needed; remove it for now.
>
> Suggested-by: Hans Verkuil
> Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
Thanks,
Hans
The NATIVE_SIZE target is documented for mem2mem devices but no driver has
ever apparently used it. It may be never needed; remove it for now.
Suggested-by: Hans Verkuil
Signed-off-by: Sakari Ailus
---
Documentation/media/uapi/v4l/v4l2-selection-targets.rst | 7 +--
1 file changed, 1
Hi Laurent,
On 06/11/2018 23:13, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Tuesday, 6 November 2018 23:27:19 EET Kieran Bingham wrote:
>> From: Kieran Bingham
>>
>> We have both uvc_init_video() and uvc_video_init() calls which can be
>> quite confusing to
The use of flush_schedule_work() made no sense and caused a syzkaller error.
Replace with the correct cancel_delayed_work_sync().
Signed-off-by: Hans Verkuil
Reported-by: syzbot+69780d144754b8071...@syzkaller.appspotmail.com
---
diff --git a/drivers/media/platform/vim2m.c
Hi Laurent,
On 06/11/2018 23:21, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Tuesday, 6 November 2018 23:27:20 EET Kieran Bingham wrote:
>> From: Kieran Bingham
>>
>> A new iterator is available for processing UVC URB structures. This
>> simplifies the processing
On Wed, Nov 07, 2018 at 12:02:14PM +, Sean Young wrote:
> keytable.c: In function ‘parse_opt’:
> keytable.c:835:7: warning: ‘param’ may be used uninitialized in this function
> [-Wuninitialized]
>
> Signed-off-by: Sean Young
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail:
On 06/11/2018 22:58, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Tuesday, 6 November 2018 23:27:17 EET Kieran Bingham wrote:
>> From: Kieran Bingham
>>
>> Newer high definition cameras, and cameras with multiple lenses such as
>> the range of stereo-vision cameras
Hi Laurent,
On 06/11/2018 23:08, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Tuesday, 6 November 2018 23:27:18 EET Kieran Bingham wrote:
>> From: Kieran Bingham
>>
>> uvc_video_enable() is used both to start and stop the video stream
>> object, however the single
Hi Peter,
On Tue, Nov 06, 2018 at 10:43:58PM +0100, Peter Seiderer wrote:
> On Tue, 6 Nov 2018 10:38:56 +, Sean Young wrote:
>
> > On Mon, Nov 05, 2018 at 09:30:47PM +0100, Peter Seiderer wrote:
> > > Copy from [1], needed by bpf.h.
> > >
> > > [1]
> > >
keytable.c: In function ‘parse_opt’:
keytable.c:835:7: warning: ‘param’ may be used uninitialized in this function
[-Wuninitialized]
Signed-off-by: Sean Young
---
utils/keytable/keytable.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utils/keytable/keytable.c
It currently does not build on mips and some platforms do not have
BPF support yet (risc-v, for example).
Signed-off-by: Sean Young
---
configure.ac | 17 +
utils/keytable/Makefile.am | 7 ---
utils/keytable/keytable.c | 5 -
3 files changed, 21
Hi Philipp,
On Tue, Nov 06, 2018 at 03:44:07PM +0100, Philipp Zabel wrote:
> Hi Sakari,
>
> On Tue, 2018-11-06 at 16:01 +0200, Sakari Ailus wrote:
> [...]
> > @@ -290,6 +294,35 @@ static int capture_s_std(struct file *file, void *fh,
> > v4l2_std_id std)
> > > return
On Fri, Aug 10, 2018 at 03:20:38PM +0100, Rui Miguel Silva wrote:
> Add bindings documentation for i.MX7 media drivers.
> The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface.
>
> Reviewed-by: Rob Herring
> Signed-off-by: Rui Miguel Silva
Acked-by: Sakari Ailus -
--
Sakari Ailus
Hi Jason,
Thanks for the patch.
On Wed, Nov 07, 2018 at 03:22:23PM +0800, jasonx.z.c...@intel.com wrote:
> From: "Chen, JasonX Z"
>
> Test Pattern mode be picked at HAL instead of driver.
> do a FLIP when userspace use test pattern mode.
> add entity_ops for validating imx258 link.
>
>
Just one note: the "cec: keep track of outstanding transmits" is CC-ed to stable
for v4.18 and up, but I prefer to wait until v4.21 before merging it to give it
more test time. It is not something that happens in normal usage, so delaying
this isn't a problem.
Regards,
Hans
The
On Tue, Nov 06, 2018 at 09:12:56AM -0800, Yong Zhi wrote:
> Also add V4L2_COLORSPACE_RAW to the colorspaces[].
>
> Signed-off-by: Yong Zhi
> ---
> utils/media-ctl/libv4l2subdev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/utils/media-ctl/libv4l2subdev.c
Hi Hans,
On Wednesday, 7 November 2018 10:05:12 EET Hans Verkuil wrote:
> On 11/06/2018 08:58 PM, Laurent Pinchart wrote:
> > On Tuesday, 6 November 2018 15:56:34 EET Hans Verkuil wrote:
> >> On 11/06/18 14:12, Laurent Pinchart wrote:
> >>> On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus
Hi Hans,
On Wed 07 Nov 2018 at 09:58, Hans Verkuil wrote:
Hi Rui,
On 08/10/18 16:20, Rui Miguel Silva wrote:
Hi,
This series introduces the Media driver to work with the i.MX7
SoC. it uses the
already existing imx media core drivers but since the i.MX7,
contrary to
i.MX5/6, do not have an
Hi Rui,
On 08/10/18 16:20, Rui Miguel Silva wrote:
> Hi,
> This series introduces the Media driver to work with the i.MX7 SoC. it uses
> the
> already existing imx media core drivers but since the i.MX7, contrary to
> i.MX5/6, do not have an IPU and because of that some changes in the imx media
Hi Yong,
On Tue, Nov 06, 2018 at 09:12:56AM -0800, Yong Zhi wrote:
> Also add V4L2_COLORSPACE_RAW to the colorspaces[].
>
> Signed-off-by: Yong Zhi
> ---
> utils/media-ctl/libv4l2subdev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/utils/media-ctl/libv4l2subdev.c
On 11/06/2018 08:58 PM, Laurent Pinchart wrote:
> Hi Hans,
>
> On Tuesday, 6 November 2018 15:56:34 EET Hans Verkuil wrote:
>> On 11/06/18 14:12, Laurent Pinchart wrote:
>>> On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus wrote:
On Tue, Nov 06, 2018 at 09:37:07AM +0100, Hans Verkuil
From: "Chen, JasonX Z"
Test Pattern mode be picked at HAL instead of driver.
do a FLIP when userspace use test pattern mode.
add entity_ops for validating imx258 link.
Signed-off-by: Chen, JasonX Z
---
drivers/media/i2c/imx258.c | 28
1 file changed, 8
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Wed Nov 7 05:00:11 CET 2018
media-tree git hash:fbe57dde7126d1b2712ab5ea93fb9d15f89de708
media_build
On 11/01/2018 08:03 PM, Sakari Ailus wrote:
> Hi Yong,
>
> Thanks for the update!
>
> On Mon, Oct 29, 2018 at 03:22:54PM -0700, Yong Zhi wrote:
>> Hi,
>>
>> This series adds support for the Intel IPU3 (Image Processing Unit)
>> ImgU which is essentially a modern memory-to-memory ISP. It
Hi Kieran,
Thank you for the patches.
On Tuesday, 6 November 2018 23:27:11 EET Kieran Bingham wrote:
> From: Kieran Bingham
>
> The Linux UVC driver has long provided adequate performance capabilities for
> web-cams and low data rate video devices in Linux while resolutions were
> low.
>
>
Hi Sakari,
> Subject: Re: [PATCH v7 05/16] intel-ipu3: abi: Add structs
>
> Hi Raj,
>
> On Mon, Nov 05, 2018 at 07:05:53PM +, Mani, Rajmohan wrote:
> > Hi Sakari,
> >
> > > Subject: Re: [PATCH v7 05/16] intel-ipu3: abi: Add structs
> > >
> > > Hi Yong,
> > >
> > > On Mon, Oct 29, 2018 at
Hi Mauro,
Thanks for the reviews.
> Subject: Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI
>
> Hi Mauro,
>
> On Fri, Nov 2, 2018 at 10:49 PM Mauro Carvalho Chehab
> wrote:
> >
> > Em Mon, 29 Oct 2018 15:22:57 -0700
> > Yong Zhi escreveu:
> [snip]
> > > +struct
Hi Kieran,
Thank you for the patch.
On Tuesday, 6 November 2018 23:27:20 EET Kieran Bingham wrote:
> From: Kieran Bingham
>
> A new iterator is available for processing UVC URB structures. This
> simplifies the processing of the internal stream data.
>
> Convert the manual loop iterators to
Hi Kieran,
Thank you for the patch.
On Tuesday, 6 November 2018 23:27:19 EET Kieran Bingham wrote:
> From: Kieran Bingham
>
> We have both uvc_init_video() and uvc_video_init() calls which can be
> quite confusing to determine the process for each. Now that video
> uvc_video_enable() has been
Hi Kieran,
Thank you for the patch.
On Tuesday, 6 November 2018 23:27:18 EET Kieran Bingham wrote:
> From: Kieran Bingham
>
> uvc_video_enable() is used both to start and stop the video stream
> object, however the single function entry point shares no code between
> the two operations.
>
>
Hi Kieran,
Thank you for the patch.
On Tuesday, 6 November 2018 23:27:17 EET Kieran Bingham wrote:
> From: Kieran Bingham
>
> Newer high definition cameras, and cameras with multiple lenses such as
> the range of stereo-vision cameras now available have ever increasing
> data rates.
>
> The
Hi Kieran,
Thank you for the patch.
On Tuesday, 6 November 2018 23:27:16 EET Kieran Bingham wrote:
> From: Kieran Bingham
>
> The buffer queue interface currently operates sequentially, processing
> buffers after they have fully completed.
>
> In preparation for supporting parallel tasks
Limes Asset Ltd is a Registered UK company currently delivering business
financing and financing.
We are currently funding start-up, Growth stage companies and Individual
funding.
Do you need to pay for our services?
Website: limesassetltd.co.uk
Email: i...@limesassetltd.co.uk
John Pratt
File needed by linux/bpf.h, add copy from linux-4.19.1 (and add
to sync-with-kernel Makefile target).
Signed-off-by: Peter Seiderer
---
Changes v1 -> v2:
- add linux/bpf_common.h to sync-with-kernel target
---
Makefile.am| 4 ++-
include/linux/bpf_common.h | 57
Hello Sean,
On Tue, 6 Nov 2018 10:38:56 +, Sean Young wrote:
> On Mon, Nov 05, 2018 at 09:30:47PM +0100, Peter Seiderer wrote:
> > Copy from [1], needed by bpf.h.
> >
> > [1]
> >
Hi Mauro,
A new driver for the usb IR receiver for the original XBox, and a few
minor fixes.
Thanks,
Sean
The following changes since commit ef86eaf97acd6d82cd3fd40f997b1c8c4895a443:
media: Rename vb2_m2m_request_queue -> v4l2_m2m_request_queue (2018-11-06
05:24:22 -0500)
are available in
From: Kieran Bingham
uvc_video_enable() is used both to start and stop the video stream
object, however the single function entry point shares no code between
the two operations.
Split the function into two distinct calls, and rename to
uvc_video_start_streaming() and uvc_video_stop_streaming()
From: Kieran Bingham
A new iterator is available for processing UVC URB structures. This
simplifies the processing of the internal stream data.
Convert the manual loop iterators to the new helper, adding an index
helper to keep the existing debug print.
Signed-off-by: Kieran Bingham
---
This
From: Kieran Bingham
We have both uvc_init_video() and uvc_video_init() calls which can be
quite confusing to determine the process for each. Now that video
uvc_video_enable() has been renamed to uvc_video_start_streaming(),
adapt these calls to suit the new flow.
Rename uvc_init_video() to
From: Kieran Bingham
The Linux UVC driver has long provided adequate performance capabilities for
web-cams and low data rate video devices in Linux while resolutions were low.
Modern USB cameras are now capable of high data rates thanks to USB3 with
1080p, and even 4k capture resolutions
From: Kieran Bingham
The URB completion handlers currently reference the stream context.
Now that each URB has its own context structure, convert the decode (and
one encode) functions to utilise this context for URB management.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
From: Kieran Bingham
We currently store three separate arrays for each URB reference we hold.
Objectify the data needed to track URBs into a single uvc_urb structure,
allowing better object management and tracking of the URB.
All accesses to the data pointers through stream, are converted to
From: Kieran Bingham
Both uvc_start_streaming(), and uvc_stop_streaming() are called from
userspace context, with interrupts enabled. As such, they do not need to
save the IRQ state, and can use spin_lock_irq() and spin_unlock_irq()
respectively.
Signed-off-by: Kieran Bingham
Reviewed-by:
From: Kieran Bingham
The URB completion operation obtains the current buffer by reading
directly into the queue internal interface.
Protect this queue abstraction by providing a helper
uvc_queue_get_current_buffer() which can be used by both the decode
task, and the uvc_queue_next_buffer()
From: Kieran Bingham
Newer high definition cameras, and cameras with multiple lenses such as
the range of stereo-vision cameras now available have ever increasing
data rates.
The inclusion of a variable length packet header in URB packets mean
that we must memcpy the frame data out to our
From: Kieran Bingham
The buffer queue interface currently operates sequentially, processing
buffers after they have fully completed.
In preparation for supporting parallel tasks operating on the buffers,
we will need to support buffers being processed on multiple CPUs.
Adapt the
Hi Hans,
On Tuesday, 6 November 2018 15:56:34 EET Hans Verkuil wrote:
> On 11/06/18 14:12, Laurent Pinchart wrote:
> > On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus wrote:
> >> On Tue, Nov 06, 2018 at 09:37:07AM +0100, Hans Verkuil wrote:
> >>> Hi all,
> >>>
> >>> After the media summit
Hi, Mauro,
Thanks for your review.
> -Original Message-
> From: Mauro Carvalho Chehab [mailto:mchehab+sams...@kernel.org]
> Sent: Friday, November 2, 2018 6:49 AM
> To: Zhi, Yong
> Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com;
> tf...@chromium.org;
Also add V4L2_COLORSPACE_RAW to the colorspaces[].
Signed-off-by: Yong Zhi
---
utils/media-ctl/libv4l2subdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/utils/media-ctl/libv4l2subdev.c b/utils/media-ctl/libv4l2subdev.c
index a989efb..46668eb 100644
---
This pull request adds CEC support to SECO devices, in particular UDOO X86.
The pull request is identical to the v4 of this series:
https://lkml.org/lkml/2018/10/21/143
Just rebased.
Regards,
Hans
The following changes since commit fbe57dde7126d1b2712ab5ea93fb9d15f89de708:
media:
Hi Sakari,
On Tue, 2018-11-06 at 16:01 +0200, Sakari Ailus wrote:
[...]
> @@ -290,6 +294,35 @@ static int capture_s_std(struct file *file, void *fh,
> v4l2_std_id std)
> > return v4l2_subdev_call(priv->src_sd, video, s_std, std);
> > }
> >
> > +static int capture_g_selection(struct file
If you create multiple vivid instances, each with their own media
device, then there was no way to tell them apart.
Fill in the bus_info so each instance has a unique bus_info string.
Signed-off-by: Hans Verkuil
---
diff --git a/drivers/media/platform/vivid/vivid-core.c
Hi Philipp,
On Mon, Nov 05, 2018 at 04:20:53PM +0100, Philipp Zabel wrote:
> Allowing to compose captured images into larger memory buffers
> will let us lift alignment restrictions on CSI crop width.
>
> Signed-off-by: Philipp Zabel
> ---
> drivers/staging/media/imx/imx-ic-prpencvf.c | 3
On 11/06/18 14:12, Laurent Pinchart wrote:
> Hello,
>
> On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus wrote:
>> On Tue, Nov 06, 2018 at 09:37:07AM +0100, Hans Verkuil wrote:
>>> Hi all,
>>>
>>> After the media summit (heavy on test discussions) and the V4L2 event
>>> regression we just
On Tue, 2018-11-06 at 09:37 +0100, Hans Verkuil wrote:
> Hi all,
>
> After the media summit (heavy on test discussions) and the V4L2 event
> regression
> we just found it is clear we need to do a better job with testing.
>
> All the pieces are in place, so what is needed is to combine it and
This pull request converts the last remaining drivers that use g/s_crop and
cropcap to g/s_selection.
The first two patches do some minor code cleanup.
The third patch adds a new video_device flag to indicate that the driver
inverts the normal usage of g/s_crop/cropcap. This applies to the old
Hello,
On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus wrote:
> On Tue, Nov 06, 2018 at 09:37:07AM +0100, Hans Verkuil wrote:
> > Hi all,
> >
> > After the media summit (heavy on test discussions) and the V4L2 event
> > regression we just found it is clear we need to do a better job with
>
On Tue, Nov 06, 2018 at 06:21:29AM -0500, Mauro Carvalho Chehab wrote:
> As warned by static code analizer checkers:
> drivers/staging/media/sunxi/cedrus/cedrus.c:
> drivers/staging/media/sunxi/cedrus/cedrus.c:93 cedrus_init_ctrls() error:
> potential null dereference 'ctx->ctrls'.
On 11/06/18 11:55, Mauro Carvalho Chehab wrote:
> Shut up this warning:
>
> drivers/staging/media/davinci_vpfe/dm365_ipipeif.c: In function
> 'ipipeif_hw_setup':
> drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:298:3: warning: this
> statement may fall through
Hi Mauro,
Here are a few sensor and ISP driver patches for 4.21, plus a documentation
fix. The noteworthy change in the sea of bugfixes is the imx214 driver.
Please pull.
The following changes since commit dafb7f9aef2fd44991ff1691721ff765a23be27b:
v4l2-controls: add a missing include
Hi Hans,
On Tue, Nov 06, 2018 at 09:37:07AM +0100, Hans Verkuil wrote:
> Hi all,
>
> After the media summit (heavy on test discussions) and the V4L2 event
> regression
> we just found it is clear we need to do a better job with testing.
>
> All the pieces are in place, so what is needed is to
As warned by static code analizer checkers:
drivers/staging/media/sunxi/cedrus/cedrus.c:
drivers/staging/media/sunxi/cedrus/cedrus.c:93 cedrus_init_ctrls() error:
potential null dereference 'ctx->ctrls'. (kzalloc returns null)
The problem is that it assumes that kzalloc() will always
Shut up this warning:
drivers/staging/media/davinci_vpfe/dm365_ipipeif.c: In function
'ipipeif_hw_setup':
drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:298:3: warning: this
statement may fall through [-Wimplicit-fallthrough=]
switch (isif_port_if) {
Hi Mauro,
There turns out to have been an issue in the event subscription fix; in
particular the first control event is missed due to a subtle bug in the
patch.
This patch fixes it. Once it's in, I'll submit the corresponding patches to
the stable kernels.
Please pull.
The following changes
The ffz() return value is undefined if the instance mask does not
contain any zeros. If it returned 32, the following set_bit would
corrupt the debugfs_root pointer.
Switch to IDA for context index allocation. This also removes the
artificial 32 instance limit for all except CodaDx6.
On Mon, 2018-11-05 at 16:32 +, Ian Arkver wrote:
> Hi Philipp,
>
> On 05/11/2018 15:24, Philipp Zabel wrote:
> > The ffz() return value is undefined if the instance mask does not
> > contain any zeros. If it returned 32, the following set_bit would
> > corrupt the debugfs_root pointer.
> >
On Mon, Nov 05, 2018 at 09:30:47PM +0100, Peter Seiderer wrote:
> Copy from [1], needed by bpf.h.
>
> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/include/uapi/linux/bpf_common.h?h=v4.19
So bpf.h does include this file, but we don't use anything from it in
On 11/06/18 11:15, Mauro Carvalho Chehab wrote:
> As warned by gcc:
>
> drivers/staging/media/davinci_vpfe/dm365_ipipeif.c: In function
> 'ipipeif_hw_setup':
> drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:298:3: warning: this
> statement may fall through [-Wimplicit-fallthrough=]
>
It currently does not build on mips and some platforms do not have
BPF support yet (risc-v, for example).
Signed-off-by: Sean Young
---
configure.ac | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 387f8539..4100db06 100644
---
On Tue, 6 Nov 2018 at 08:00, Sakari Ailus wrote:
>
> Patch ad608fbcf166 changed how events were subscribed to address an issue
> elsewhere. As a side effect of that change, the "add" callback was called
> before the event subscription was added to the list of subscribed events,
> causing the
As warned by gcc:
drivers/staging/media/davinci_vpfe/dm365_ipipeif.c: In function
'ipipeif_hw_setup':
drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:298:3: warning: this
statement may fall through [-Wimplicit-fallthrough=]
switch (isif_port_if) {
^~
pxp_soft_reset() may fail with a timeout, so it is better to propagate
the error in this case.
Signed-off-by: Fabio Estevam
Reviewed-by: Philipp Zabel
---
Changes since v2:
- Jump to err_clck when pxp_soft_reset() fails. (Philipp)
drivers/media/platform/imx-pxp.c | 12 +---
1 file
clk_prepare_enable() may fail, so we should better check its return value
and propagate it in the case of error.
Signed-off-by: Fabio Estevam
Reviewed-by: Philipp Zabel
---
Changes since v2:
- None
drivers/media/platform/imx-pxp.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
Improve the pxp_soft_reset() error message by moving it to the
caller function, associating it with a proper device and also
by displaying the error code.
Signed-off-by: Fabio Estevam
Reviewed-by: Philipp Zabel
---
Changes since v2:
- None (only rebased against the change made in 2/3)
On Mon, 2018-11-05 at 18:45 -0200, Fabio Estevam wrote:
> Improve the pxp_soft_reset() error message by moving it to the
> caller function, associating it with a proper device and also
> by displaying the error code.
>
> Signed-off-by: Fabio Estevam
> ---
> Changes since v1:
> - Newly introduced
On Mon, 2018-11-05 at 18:45 -0200, Fabio Estevam wrote:
> pxp_soft_reset() may fail with a timeout, so it is better to propagate
> the error in this case.
>
> Signed-off-by: Fabio Estevam
> ---
> Changes since v1:
> - None
>
> drivers/media/platform/imx-pxp.c | 12 +---
> 1 file
Hi Fabio,
thank you for the fixes!
On Mon, 2018-11-05 at 18:45 -0200, Fabio Estevam wrote:
> clk_prepare_enable() may fail, so we should better check its return value
> and propagate it in the case of error.
>
> Signed-off-by: Fabio Estevam
> ---
> Changes since v1:
> - Properly enumerate the
Hi all,
After the media summit (heavy on test discussions) and the V4L2 event regression
we just found it is clear we need to do a better job with testing.
All the pieces are in place, so what is needed is to combine it and create a
script that anyone of us as core developers can run to check
On 11/06/2018 09:00 AM, Sakari Ailus wrote:
> Patch ad608fbcf166 changed how events were subscribed to address an issue
> elsewhere. As a side effect of that change, the "add" callback was called
> before the event subscription was added to the list of subscribed events,
> causing the first event
Hi Raj,
On Mon, Nov 05, 2018 at 07:05:53PM +, Mani, Rajmohan wrote:
> Hi Sakari,
>
> > -Original Message-
> > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com]
> > Sent: Monday, November 05, 2018 12:28 AM
> > To: Zhi, Yong
> > Cc: linux-media@vger.kernel.org;
Patch ad608fbcf166 changed how events were subscribed to address an issue
elsewhere. As a side effect of that change, the "add" callback was called
before the event subscription was added to the list of subscribed events,
causing the first event queued by the add callback (and possibly other
Patch ad608fbcf166 changed how events were subscribed to address an issue
elsewhere. As a side effect of that change, the "add" callback was called
before the event subscription was added to the list of subscribed events,
causing the first event (and possibly other events arriving soon
afterwards)
On Tue, Nov 6, 2018 at 2:50 PM Zhi, Yong wrote:
>
> Hi, Sakari,
>
> Thanks for the feedback.
>
> > -Original Message-
> > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com]
> > Sent: Monday, November 5, 2018 3:55 AM
> > To: Zhi, Yong
> > Cc: linux-media@vger.kernel.org;
Hi, Sakari,
Thanks for the feedback.
> -Original Message-
> From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com]
> Sent: Monday, November 5, 2018 3:55 AM
> To: Zhi, Yong
> Cc: linux-media@vger.kernel.org; tf...@chromium.org;
> mche...@kernel.org; hans.verk...@cisco.com;
>
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Nov 6 05:00:10 CET 2018
media-tree git hash:dafb7f9aef2fd44991ff1691721ff765a23be27b
media_build
Hi Philipp,
Thanks, I've been meaning this too. Comments below.
On 11/5/18 7:03 AM, Philipp Zabel wrote:
While subdevice and video device are in the same pipeline, pass
subdevice events on to userspace via the video device node.
Signed-off-by: Philipp Zabel
---
This would allow to see
On Sat, Nov 03, 2018 at 07:55:32AM -0700, Derek Kelly wrote:
> The following patch adds event codes for common buttons found on various
> provider and universal remote controls. They represent functions not
> covered by existing event codes. Once added, rc_keymaps can be updated
> accordingly
clk_prepare_enable() may fail, so we should better check its return value
and propagate it in the case of error.
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Properly enumerate the series
drivers/media/platform/imx-pxp.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff
pxp_soft_reset() may fail with a timeout, so it is better to propagate
the error in this case.
Signed-off-by: Fabio Estevam
---
Changes since v1:
- None
drivers/media/platform/imx-pxp.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git
Improve the pxp_soft_reset() error message by moving it to the
caller function, associating it with a proper device and also
by displaying the error code.
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Newly introduced in this version
drivers/media/platform/imx-pxp.c | 8
1 file
pxp_soft_reset() may fail with a timeout, so it is better to propagate
the error in this case.
Signed-off-by: Fabio Estevam
---
drivers/media/platform/imx-pxp.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/imx-pxp.c
clk_prepare_enable() may fail, so we should better check its return value
and propagate it in the case of error.
Signed-off-by: Fabio Estevam
---
drivers/media/platform/imx-pxp.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/imx-pxp.c
Copy from [1], needed by bpf.h.
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/include/uapi/linux/bpf_common.h?h=v4.19
Signed-off-by: Peter Seiderer
---
include/linux/bpf_common.h | 57 ++
1 file changed, 57 insertions(+)
Enable Sony CXD2837ER slave demon on the Astrometa DVB-T2, known as the 2018
update.
Originally based on the patch by kapitanf at
https://github.com/torvalds/linux/pull/567, it was not quite right. This is
more correct, but probably still wrong. I'm not a kernel dev, but someone may
be better
901 - 1000 of 130834 matches
Mail list logo
