Re: [GIT PULL FOR v4.21] Rockchip VPU JPEG encoder driver
Em Wed, 05 Dec 2018 17:02:46 -0300
Ezequiel Garcia escreveu:
> On Wed, 2018-12-05 at 16:37 -0200, Mauro Carvalho Chehab wrote:
> > Em Wed, 5 Dec 2018 16:34:04 -0200
> > Mauro Carvalho Chehab escreveu:
> >
> > > Em Wed, 5 Dec 2018 17:29:38 +0100
> > > Hans Verkuil escreveu:
> > >
> > > > Note regarding the first 'Revert' patch: that is this patch:
> > > >
> > > > https://patchwork.linuxtv.org/patch/52869/
> > > >
> > > > It is currently pending for 4.20 as a fix, but since it is not merged
> > > > upstream
> > > > yet, our master branch still has those old bindings.
> > > >
> > > > I decided to first apply the Revert patch, then add the new patch on
> > > > top.
> > > >
> > > > Regards,
> > > >
> > > > Hans
> > > >
> > > > The following changes since commit
> > > > da2c94c8f9739e4099ea3cfefc208fc721b22a9c:
> > > >
> > > > media: v4l2: async: remove locking when initializing async notifier
> > > > (2018-12-05 06:51:28 -0500)
> > > >
> > > > are available in the Git repository at:
> > > >
> > > > git://linuxtv.org/hverkuil/media_tree.git tags/br-rkjpeg2
> > > >
> > > > for you to fetch changes up to 7f608cfd52c08e7d84bd38438e330c26263eddcb:
> > > >
> > > > media: add Rockchip VPU JPEG encoder driver (2018-12-05 17:18:46
> > > > +0100)
> > > >
> > > >
> > > > Tag branch
> > > >
> > > >
> > > > Ezequiel Garcia (3):
> > > > Revert "media: dt-bindings: Document the Rockchip VPU bindings"
> > > > media: dt-bindings: Document the Rockchip VPU bindings
> > > > media: add Rockchip VPU JPEG encoder driver
> > >
> > > Checkpatch produces a few warnings:
> > >
> > > # CHECK: Alignment should match open parenthesis
> > > # #385: FILE:
> > > drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c:109:
> > > # + rk3288_vpu_jpeg_enc_set_qtable(vpu,
> > > # + rockchip_vpu_jpeg_get_qtable(_ctx, 0),
> > > #
> > > # CHECK: Alignment should match open parenthesis
> > > # #1124: FILE:
> > > drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_jpeg_enc.c:140:
> > > # + rk3399_vpu_jpeg_enc_set_qtable(vpu,
> > > # + rockchip_vpu_jpeg_get_qtable(_ctx, 0),
> > > #
> > > # WARNING: DT compatible string "rockchip,rk3399-vpu" appears
> > > un-documented -- check ./Documentation/devicetree/bindings/
> > > # #2359: FILE: drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:326:
> > > # + { .compatible = "rockchip,rk3399-vpu", .data =
> > > _vpu_variant, },
> > > #
> > > # WARNING: DT compatible string "rockchip,rk3288-vpu" appears
> > > un-documented -- check ./Documentation/devicetree/bindings/
> > > # #2360: FILE: drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:327:
> > > # + { .compatible = "rockchip,rk3288-vpu", .data =
> > > _vpu_variant, },
> > > #
> > > # CHECK: Unnecessary parentheses around 'formats[i].codec_mode !=
> > > RK_VPU_MODE_NONE'
> > > # #2721: FILE: drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c:145:
> > > # + if (bitstream == (formats[i].codec_mode !=
> > > RK_VPU_MODE_NONE))
> > > #
> > > # total: 0 errors, 2 warnings, 3 checks, 3469 lines checked
> > >
>
> Please note that this last one is a false positive,
> the code needs those parenthesis.
Yes, I know. that "Unnecessary parentheses" warning should always be
taken with caution.
I've seen several cases where it was right, but, for the sake of a
better code readability, it was better to preserve it.
Thanks,
Mauro
Re: [GIT PULL FOR v4.21] Rockchip VPU JPEG encoder driver
On Wed, 2018-12-05 at 16:37 -0200, Mauro Carvalho Chehab wrote:
> Em Wed, 5 Dec 2018 16:34:04 -0200
> Mauro Carvalho Chehab escreveu:
>
> > Em Wed, 5 Dec 2018 17:29:38 +0100
> > Hans Verkuil escreveu:
> >
> > > Note regarding the first 'Revert' patch: that is this patch:
> > >
> > > https://patchwork.linuxtv.org/patch/52869/
> > >
> > > It is currently pending for 4.20 as a fix, but since it is not merged
> > > upstream
> > > yet, our master branch still has those old bindings.
> > >
> > > I decided to first apply the Revert patch, then add the new patch on top.
> > >
> > > Regards,
> > >
> > > Hans
> > >
> > > The following changes since commit
> > > da2c94c8f9739e4099ea3cfefc208fc721b22a9c:
> > >
> > > media: v4l2: async: remove locking when initializing async notifier
> > > (2018-12-05 06:51:28 -0500)
> > >
> > > are available in the Git repository at:
> > >
> > > git://linuxtv.org/hverkuil/media_tree.git tags/br-rkjpeg2
> > >
> > > for you to fetch changes up to 7f608cfd52c08e7d84bd38438e330c26263eddcb:
> > >
> > > media: add Rockchip VPU JPEG encoder driver (2018-12-05 17:18:46 +0100)
> > >
> > >
> > > Tag branch
> > >
> > >
> > > Ezequiel Garcia (3):
> > > Revert "media: dt-bindings: Document the Rockchip VPU bindings"
> > > media: dt-bindings: Document the Rockchip VPU bindings
> > > media: add Rockchip VPU JPEG encoder driver
> >
> > Checkpatch produces a few warnings:
> >
> > # CHECK: Alignment should match open parenthesis
> > # #385: FILE:
> > drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c:109:
> > # + rk3288_vpu_jpeg_enc_set_qtable(vpu,
> > # + rockchip_vpu_jpeg_get_qtable(_ctx, 0),
> > #
> > # CHECK: Alignment should match open parenthesis
> > # #1124: FILE:
> > drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_jpeg_enc.c:140:
> > # + rk3399_vpu_jpeg_enc_set_qtable(vpu,
> > # + rockchip_vpu_jpeg_get_qtable(_ctx, 0),
> > #
> > # WARNING: DT compatible string "rockchip,rk3399-vpu" appears un-documented
> > -- check ./Documentation/devicetree/bindings/
> > # #2359: FILE: drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:326:
> > # + { .compatible = "rockchip,rk3399-vpu", .data = _vpu_variant, },
> > #
> > # WARNING: DT compatible string "rockchip,rk3288-vpu" appears un-documented
> > -- check ./Documentation/devicetree/bindings/
> > # #2360: FILE: drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:327:
> > # + { .compatible = "rockchip,rk3288-vpu", .data = _vpu_variant, },
> > #
> > # CHECK: Unnecessary parentheses around 'formats[i].codec_mode !=
> > RK_VPU_MODE_NONE'
> > # #2721: FILE: drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c:145:
> > # + if (bitstream == (formats[i].codec_mode != RK_VPU_MODE_NONE))
> > #
> > # total: 0 errors, 2 warnings, 3 checks, 3469 lines checked
> >
Please note that this last one is a false positive,
the code needs those parenthesis.
Thanks!
Ezequiel
Re: [GIT PULL FOR v4.21] Rockchip VPU JPEG encoder driver
Em Wed, 5 Dec 2018 16:34:04 -0200
Mauro Carvalho Chehab escreveu:
> Em Wed, 5 Dec 2018 17:29:38 +0100
> Hans Verkuil escreveu:
>
> > Note regarding the first 'Revert' patch: that is this patch:
> >
> > https://patchwork.linuxtv.org/patch/52869/
> >
> > It is currently pending for 4.20 as a fix, but since it is not merged
> > upstream
> > yet, our master branch still has those old bindings.
> >
> > I decided to first apply the Revert patch, then add the new patch on top.
> >
> > Regards,
> >
> > Hans
> >
> > The following changes since commit da2c94c8f9739e4099ea3cfefc208fc721b22a9c:
> >
> > media: v4l2: async: remove locking when initializing async notifier
> > (2018-12-05 06:51:28 -0500)
> >
> > are available in the Git repository at:
> >
> > git://linuxtv.org/hverkuil/media_tree.git tags/br-rkjpeg2
> >
> > for you to fetch changes up to 7f608cfd52c08e7d84bd38438e330c26263eddcb:
> >
> > media: add Rockchip VPU JPEG encoder driver (2018-12-05 17:18:46 +0100)
> >
> >
> > Tag branch
> >
> >
> > Ezequiel Garcia (3):
> > Revert "media: dt-bindings: Document the Rockchip VPU bindings"
> > media: dt-bindings: Document the Rockchip VPU bindings
> > media: add Rockchip VPU JPEG encoder driver
>
> Checkpatch produces a few warnings:
>
> # CHECK: Alignment should match open parenthesis
> # #385: FILE: drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c:109:
> # + rk3288_vpu_jpeg_enc_set_qtable(vpu,
> # + rockchip_vpu_jpeg_get_qtable(_ctx, 0),
> #
> # CHECK: Alignment should match open parenthesis
> # #1124: FILE:
> drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_jpeg_enc.c:140:
> # + rk3399_vpu_jpeg_enc_set_qtable(vpu,
> # + rockchip_vpu_jpeg_get_qtable(_ctx, 0),
> #
> # WARNING: DT compatible string "rockchip,rk3399-vpu" appears un-documented
> -- check ./Documentation/devicetree/bindings/
> # #2359: FILE: drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:326:
> # + { .compatible = "rockchip,rk3399-vpu", .data = _vpu_variant, },
> #
> # WARNING: DT compatible string "rockchip,rk3288-vpu" appears un-documented
> -- check ./Documentation/devicetree/bindings/
> # #2360: FILE: drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:327:
> # + { .compatible = "rockchip,rk3288-vpu", .data = _vpu_variant, },
> #
> # CHECK: Unnecessary parentheses around 'formats[i].codec_mode !=
> RK_VPU_MODE_NONE'
> # #2721: FILE: drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c:145:
> # + if (bitstream == (formats[i].codec_mode != RK_VPU_MODE_NONE))
> #
> # total: 0 errors, 2 warnings, 3 checks, 3469 lines checked
>
> The more weird ones are the ones related to the DT bindings.
Hmm... those were my fault.
/me needs caffeine
>
> Regards,
> Mauro
>
> Thanks,
> Mauro
Thanks,
Mauro
Re: [GIT PULL FOR v4.21] Rockchip VPU JPEG encoder driver
Em Wed, 5 Dec 2018 17:29:38 +0100
Hans Verkuil escreveu:
> Note regarding the first 'Revert' patch: that is this patch:
>
> https://patchwork.linuxtv.org/patch/52869/
>
> It is currently pending for 4.20 as a fix, but since it is not merged upstream
> yet, our master branch still has those old bindings.
>
> I decided to first apply the Revert patch, then add the new patch on top.
>
> Regards,
>
> Hans
>
> The following changes since commit da2c94c8f9739e4099ea3cfefc208fc721b22a9c:
>
> media: v4l2: async: remove locking when initializing async notifier
> (2018-12-05 06:51:28 -0500)
>
> are available in the Git repository at:
>
> git://linuxtv.org/hverkuil/media_tree.git tags/br-rkjpeg2
>
> for you to fetch changes up to 7f608cfd52c08e7d84bd38438e330c26263eddcb:
>
> media: add Rockchip VPU JPEG encoder driver (2018-12-05 17:18:46 +0100)
>
>
> Tag branch
>
>
> Ezequiel Garcia (3):
> Revert "media: dt-bindings: Document the Rockchip VPU bindings"
> media: dt-bindings: Document the Rockchip VPU bindings
> media: add Rockchip VPU JPEG encoder driver
Checkpatch produces a few warnings:
# CHECK: Alignment should match open parenthesis
# #385: FILE: drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c:109:
# + rk3288_vpu_jpeg_enc_set_qtable(vpu,
# + rockchip_vpu_jpeg_get_qtable(_ctx, 0),
#
# CHECK: Alignment should match open parenthesis
# #1124: FILE: drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_jpeg_enc.c:140:
# + rk3399_vpu_jpeg_enc_set_qtable(vpu,
# + rockchip_vpu_jpeg_get_qtable(_ctx, 0),
#
# WARNING: DT compatible string "rockchip,rk3399-vpu" appears un-documented --
check ./Documentation/devicetree/bindings/
# #2359: FILE: drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:326:
# + { .compatible = "rockchip,rk3399-vpu", .data = _vpu_variant, },
#
# WARNING: DT compatible string "rockchip,rk3288-vpu" appears un-documented --
check ./Documentation/devicetree/bindings/
# #2360: FILE: drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:327:
# + { .compatible = "rockchip,rk3288-vpu", .data = _vpu_variant, },
#
# CHECK: Unnecessary parentheses around 'formats[i].codec_mode !=
RK_VPU_MODE_NONE'
# #2721: FILE: drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c:145:
# + if (bitstream == (formats[i].codec_mode != RK_VPU_MODE_NONE))
#
# total: 0 errors, 2 warnings, 3 checks, 3469 lines checked
The more weird ones are the ones related to the DT bindings.
Regards,
Mauro
Thanks,
Mauro
[GIT PULL FOR v4.21] Rockchip VPU JPEG encoder driver
Note regarding the first 'Revert' patch: that is this patch: https://patchwork.linuxtv.org/patch/52869/ It is currently pending for 4.20 as a fix, but since it is not merged upstream yet, our master branch still has those old bindings. I decided to first apply the Revert patch, then add the new patch on top. Regards, Hans The following changes since commit da2c94c8f9739e4099ea3cfefc208fc721b22a9c: media: v4l2: async: remove locking when initializing async notifier (2018-12-05 06:51:28 -0500) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-rkjpeg2 for you to fetch changes up to 7f608cfd52c08e7d84bd38438e330c26263eddcb: media: add Rockchip VPU JPEG encoder driver (2018-12-05 17:18:46 +0100) Tag branch Ezequiel Garcia (3): Revert "media: dt-bindings: Document the Rockchip VPU bindings" media: dt-bindings: Document the Rockchip VPU bindings media: add Rockchip VPU JPEG encoder driver MAINTAINERS | 7 + drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile | 1 + drivers/staging/media/rockchip/vpu/Kconfig | 13 + drivers/staging/media/rockchip/vpu/Makefile | 10 + drivers/staging/media/rockchip/vpu/TODO | 13 + drivers/staging/media/rockchip/vpu/rk3288_vpu_hw.c | 118 +++ drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c | 130 drivers/staging/media/rockchip/vpu/rk3288_vpu_regs.h| 442 ++ drivers/staging/media/rockchip/vpu/rk3399_vpu_hw.c | 118 +++ drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_jpeg_enc.c | 164 ++ drivers/staging/media/rockchip/vpu/rk3399_vpu_regs.h| 600 +++ drivers/staging/media/rockchip/vpu/rockchip_vpu.h | 232 ++ drivers/staging/media/rockchip/vpu/rockchip_vpu_common.h| 29 ++ drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c | 537 +++ drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c | 676 drivers/staging/media/rockchip/vpu/rockchip_vpu_hw.h| 58 drivers/staging/media/rockchip/vpu/rockchip_vpu_jpeg.c | 290 + drivers/staging/media/rockchip/vpu/rockchip_vpu_jpeg.h | 14 + 19 files changed, 3454 insertions(+) create mode 100644 drivers/staging/media/rockchip/vpu/Kconfig create mode 100644 drivers/staging/media/rockchip/vpu/Makefile create mode 100644 drivers/staging/media/rockchip/vpu/TODO create mode 100644 drivers/staging/media/rockchip/vpu/rk3288_vpu_hw.c create mode 100644 drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c create mode 100644 drivers/staging/media/rockchip/vpu/rk3288_vpu_regs.h create mode 100644 drivers/staging/media/rockchip/vpu/rk3399_vpu_hw.c create mode 100644 drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_jpeg_enc.c create mode 100644 drivers/staging/media/rockchip/vpu/rk3399_vpu_regs.h create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu.h create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_common.h create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_hw.h create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_jpeg.c create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_jpeg.h
