Re: [PATCH] [media] si2165: Refactoring for si2165_writereg_mask8()

[Matthias Schwarzott]

Am 27.12.2015 um 18:33 schrieb SF Markus Elfring:
> From: Markus Elfring 
> Date: Sun, 27 Dec 2015 18:23:57 +0100
> 
> This issue was detected by using the Coccinelle software.
> 
> 1. Let us return directly if a call of the si2165_readreg8()
>function failed.
> 
> 2. Reduce the scope for the local variables "ret" and "tmp" to one branch
>of an if statement.
> 
> 3. Delete the jump label "err" then.
> 
> 4. Return the value from a call of the si2165_writereg8() function
>without using an extra assignment for the variable "ret" at the end.
> 
> Signed-off-by: Markus Elfring 

The patch looks fine.

Signed-off-by: Matthias Schwarzott 

Regards
Matthias

PS: I am going to switch to regmap, but this change is not yet polished
and until now does not touch this function.

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] [media] si2165: Refactoring for si2165_writereg_mask8()

[SF Markus Elfring]

From: Markus Elfring 
Date: Sun, 27 Dec 2015 18:23:57 +0100

This issue was detected by using the Coccinelle software.

1. Let us return directly if a call of the si2165_readreg8()
   function failed.

2. Reduce the scope for the local variables "ret" and "tmp" to one branch
   of an if statement.

3. Delete the jump label "err" then.

4. Return the value from a call of the si2165_writereg8() function
   without using an extra assignment for the variable "ret" at the end.

Signed-off-by: Markus Elfring 
---
 drivers/media/dvb-frontends/si2165.c | 14 +-
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/drivers/media/dvb-frontends/si2165.c 
b/drivers/media/dvb-frontends/si2165.c
index 2b93241..e8518ae 100644
--- a/drivers/media/dvb-frontends/si2165.c
+++ b/drivers/media/dvb-frontends/si2165.c
@@ -225,22 +225,18 @@ static int si2165_writereg32(struct si2165_state *state, 
const u16 reg, u32 val)
 static int si2165_writereg_mask8(struct si2165_state *state, const u16 reg,
 u8 val, u8 mask)
 {
-   int ret;
-   u8 tmp;
-
if (mask != 0xff) {
-   ret = si2165_readreg8(state, reg, );
+   u8 tmp;
+   int ret = si2165_readreg8(state, reg, );
+
if (ret < 0)
-   goto err;
+   return ret;
 
val &= mask;
tmp &= ~mask;
val |= tmp;
}
-
-   ret = si2165_writereg8(state, reg, val);
-err:
-   return ret;
+   return si2165_writereg8(state, reg, val);
 }
 
 #define REG16(reg, val) { (reg), (val) & 0xff }, { (reg)+1, (val)>>8 & 0xff }
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html