Re: [PATCH 01/11] dt: binding: add binding for ImgTec IR block
On 22/12/13 12:48, Tomasz Figa wrote: diff --git a/Documentation/devicetree/bindings/media/img-ir.txt b/Documentation/devicetree/bindings/media/img-ir.txt new file mode 100644 index ..6f623b094ea6 --- /dev/null +++ b/Documentation/devicetree/bindings/media/img-ir.txt @@ -0,0 +1,20 @@ +* ImgTec Infrared (IR) decoder + +Required properties: +- compatible: Should be img,ir This compatible string isn't really very specific. Is there some IP revision string that could be added, to account for possible design changes that may require binding change? Yes, agreed. I'll try and find a more unambiguous name for the IP block. +- reg: Physical base address of the controller and length of +memory mapped region. +- interrupts: The interrupt specifier to the cpu. + +Optional properties: +- clocks: Clock specifier for base clock. +Defaults to 32.768KHz if not specified. To make the binding less fragile and allow interoperability with non-DT platforms it may be better to provide also clock-names property (so you can use clk_get(); that's a Linux implementation detail, though, but to make our lives easier IMHO they should be sometimes considered too). Good idea. Looking at the hardware manual it actually describes 3 clock inputs, and although only one is needed by the driver it makes sense for the DT binding to be able to describe them all. I'll probably go with these clock-names values: core: Core clock (32.867kHz) sys: System side (fast) clock mod: Power modulation clock Cheers James -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 01/11] dt: binding: add binding for ImgTec IR block
Em Fri, 13 Dec 2013 15:12:49 +
James Hogan james.ho...@imgtec.com escreveu:
Add device tree binding for ImgTec Consumer Infrared block.
Signed-off-by: James Hogan james.ho...@imgtec.com
Cc: Mauro Carvalho Chehab m.che...@samsung.com
Cc: linux-media@vger.kernel.org
Cc: Rob Herring rob.herr...@calxeda.com
Cc: Pawel Moll pawel.m...@arm.com
Cc: Mark Rutland mark.rutl...@arm.com
Cc: Stephen Warren swar...@wwwdotorg.org
Cc: Ian Campbell ijc+devicet...@hellion.org.uk
Cc: devicet...@vger.kernel.org
Cc: Rob Landley r...@landley.net
Cc: linux-...@vger.kernel.org
It looks ok for me, but we should wait for a DT maintainer ack for
this one.
Regards,
Mauro
---
Documentation/devicetree/bindings/media/img-ir.txt | 20
1 file changed, 20 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/img-ir.txt
diff --git a/Documentation/devicetree/bindings/media/img-ir.txt
b/Documentation/devicetree/bindings/media/img-ir.txt
new file mode 100644
index ..6f623b094ea6
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/img-ir.txt
@@ -0,0 +1,20 @@
+* ImgTec Infrared (IR) decoder
+
+Required properties:
+- compatible:Should be img,ir
+- reg: Physical base address of the controller and
length of
+ memory mapped region.
+- interrupts:The interrupt specifier to the cpu.
+
+Optional properties:
+- clocks:Clock specifier for base clock.
+ Defaults to 32.768KHz if not specified.
+
+Example:
+
+ ir@02006200 {
+ compatible = img,ir;
+ reg = 0x02006200 0x100;
+ interrupts = 29 4;
+ clocks = clk_32khz;
+ };
--
Cheers,
Mauro
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 01/11] dt: binding: add binding for ImgTec IR block
Hi James, On Friday 13 of December 2013 15:12:49 James Hogan wrote: Add device tree binding for ImgTec Consumer Infrared block. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org Cc: Rob Herring rob.herr...@calxeda.com Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Stephen Warren swar...@wwwdotorg.org Cc: Ian Campbell ijc+devicet...@hellion.org.uk Cc: devicet...@vger.kernel.org Cc: Rob Landley r...@landley.net Cc: linux-...@vger.kernel.org --- Documentation/devicetree/bindings/media/img-ir.txt | 20 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/img-ir.txt diff --git a/Documentation/devicetree/bindings/media/img-ir.txt b/Documentation/devicetree/bindings/media/img-ir.txt new file mode 100644 index ..6f623b094ea6 --- /dev/null +++ b/Documentation/devicetree/bindings/media/img-ir.txt @@ -0,0 +1,20 @@ +* ImgTec Infrared (IR) decoder + +Required properties: +- compatible:Should be img,ir This compatible string isn't really very specific. Is there some IP revision string that could be added, to account for possible design changes that may require binding change? +- reg: Physical base address of the controller and length of + memory mapped region. +- interrupts:The interrupt specifier to the cpu. + +Optional properties: +- clocks:Clock specifier for base clock. + Defaults to 32.768KHz if not specified. To make the binding less fragile and allow interoperability with non-DT platforms it may be better to provide also clock-names property (so you can use clk_get(); that's a Linux implementation detail, though, but to make our lives easier IMHO they should be sometimes considered too). Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 01/11] dt: binding: add binding for ImgTec IR block
Add device tree binding for ImgTec Consumer Infrared block.
Signed-off-by: James Hogan james.ho...@imgtec.com
Cc: Mauro Carvalho Chehab m.che...@samsung.com
Cc: linux-media@vger.kernel.org
Cc: Rob Herring rob.herr...@calxeda.com
Cc: Pawel Moll pawel.m...@arm.com
Cc: Mark Rutland mark.rutl...@arm.com
Cc: Stephen Warren swar...@wwwdotorg.org
Cc: Ian Campbell ijc+devicet...@hellion.org.uk
Cc: devicet...@vger.kernel.org
Cc: Rob Landley r...@landley.net
Cc: linux-...@vger.kernel.org
---
Documentation/devicetree/bindings/media/img-ir.txt | 20
1 file changed, 20 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/img-ir.txt
diff --git a/Documentation/devicetree/bindings/media/img-ir.txt
b/Documentation/devicetree/bindings/media/img-ir.txt
new file mode 100644
index ..6f623b094ea6
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/img-ir.txt
@@ -0,0 +1,20 @@
+* ImgTec Infrared (IR) decoder
+
+Required properties:
+- compatible: Should be img,ir
+- reg: Physical base address of the controller and length of
+ memory mapped region.
+- interrupts: The interrupt specifier to the cpu.
+
+Optional properties:
+- clocks: Clock specifier for base clock.
+ Defaults to 32.768KHz if not specified.
+
+Example:
+
+ ir@02006200 {
+ compatible = img,ir;
+ reg = 0x02006200 0x100;
+ interrupts = 29 4;
+ clocks = clk_32khz;
+ };
--
1.8.1.2
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
