Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
On 12/31/2010 01:11 AM, Dan Carpenter wrote: On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote: On 12/30/2010 10:45 PM, Grant Likely wrote: On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote: The below patch fixes a typo diable to disable. Please let me know if this is correct or not. Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com applied, thanks. g. ahh.. thanks.. just cleared up the left out diabled that I had thought I forgotten(ended up separating comments and code and forgot) This is really just defensiveness and random grumbling and grumpiness on my part, but one reason I may have missed the first patch is because your subject lines are crap. Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable. Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable regards, dan carpenter alright.. so having the backlash is alright for the subject Thanks for the pointer on this.. Justin P. Mattock -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
On Fri, 2010-12-31 at 06:17 -0800, Justin P. Mattock wrote: On 12/31/2010 01:11 AM, Dan Carpenter wrote: On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote: On 12/30/2010 10:45 PM, Grant Likely wrote: On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote: The below patch fixes a typo diable to disable. Please let me know if this is correct or not. Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com applied, thanks. g. ahh.. thanks.. just cleared up the left out diabled that I had thought I forgotten(ended up separating comments and code and forgot) This is really just defensiveness and random grumbling and grumpiness on my part, but one reason I may have missed the first patch is because your subject lines are crap. Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable. Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable regards, dan carpenter alright.. so having the backlash is alright for the subject Thanks for the pointer on this.. There is actually no specific form. Most of us edit this part of the subject line anyway to conform to whatever (nonuniform) conventions we use. I just use component: with no scsi or drivers prefix because the git tree is tagged [SCSI]; others are different. James -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
On Fri, Dec 31, 2010 at 06:17:58AM -0800, Justin P. Mattock wrote: Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable. Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable regards, dan carpenter alright.. so having the backlash is alright for the subject Well really my point is not so much about backslashes vs colons, it's about getting the *one* correct prefix. This stuff is probably scriptable most of the time, but you may still be required to think a little on the corner cases. Here is a script to get you started. git log --format=%s drivers/spi/dw_spi.c | \ head -n 20 | \ perl -ne 's/(.*):.*/$1/; print' |\ sort | uniq -c | sort -rn | \ perl -ne 's/^\W+\d+ //; print' | \ head -n 1 regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
The below patch fixes a typo diable to disable. Please let me know if this is correct or not. Signed-off-by: Justin P. Mattock justinmatt...@gmail.com --- drivers/spi/dw_spi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c index 0838c79..7c3cf21 100644 --- a/drivers/spi/dw_spi.c +++ b/drivers/spi/dw_spi.c @@ -592,7 +592,7 @@ static void pump_transfers(unsigned long data) spi_set_clk(dws, clk_div ? clk_div : chip-clk_div); spi_chip_sel(dws, spi-chip_select); - /* Set the interrupt mask, for poll mode just diable all int */ + /* Set the interrupt mask, for poll mode just disable all int */ spi_mask_intr(dws, 0xff); if (imask) spi_umask_intr(dws, imask); -- 1.6.5.2.180.gc5b3e -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote: The below patch fixes a typo diable to disable. Please let me know if this is correct or not. Signed-off-by: Justin P. Mattock justinmatt...@gmail.com applied, thanks. g. --- drivers/spi/dw_spi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c index 0838c79..7c3cf21 100644 --- a/drivers/spi/dw_spi.c +++ b/drivers/spi/dw_spi.c @@ -592,7 +592,7 @@ static void pump_transfers(unsigned long data) spi_set_clk(dws, clk_div ? clk_div : chip-clk_div); spi_chip_sel(dws, spi-chip_select); - /* Set the interrupt mask, for poll mode just diable all int */ + /* Set the interrupt mask, for poll mode just disable all int */ spi_mask_intr(dws, 0xff); if (imask) spi_umask_intr(dws, imask); -- 1.6.5.2.180.gc5b3e -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl ___ spi-devel-general mailing list spi-devel-gene...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
On 12/30/2010 10:45 PM, Grant Likely wrote: On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote: The below patch fixes a typo diable to disable. Please let me know if this is correct or not. Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com applied, thanks. g. ahh.. thanks.. just cleared up the left out diabled that I had thought I forgotten(ended up separating comments and code and forgot) --- drivers/spi/dw_spi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c index 0838c79..7c3cf21 100644 --- a/drivers/spi/dw_spi.c +++ b/drivers/spi/dw_spi.c @@ -592,7 +592,7 @@ static void pump_transfers(unsigned long data) spi_set_clk(dws, clk_div ? clk_div : chip-clk_div); spi_chip_sel(dws, spi-chip_select); - /* Set the interrupt mask, for poll mode just diable all int */ + /* Set the interrupt mask, for poll mode just disable all int */ spi_mask_intr(dws, 0xff); if (imask) spi_umask_intr(dws, imask); -- 1.6.5.2.180.gc5b3e -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl ___ spi-devel-general mailing list spi-devel-gene...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general Justin P. Mattock -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
