Re: [PATCH 03/57] [media] firewire: don't break long lines

[Stefan Richter]

On Oct 15 Takashi Sakamoto wrote:
> On Oct 15 2016 05:19, Mauro Carvalho Chehab wrote:
> > Due to the 80-cols checkpatch warnings, several strings
> > were broken into multiple lines. This is not considered
> > a good practice anymore, as it makes harder to grep for
> > strings at the source code. So, join those continuation
> > lines.
> > 
> > Signed-off-by: Mauro Carvalho Chehab   
> 
> I prefer this patch because of the same reason in patch comment.
> 
> Reviewed-by: Takashi Sakamoto 

Acked-by: Stefan Richter 

> > ---
> >  drivers/media/firewire/firedtv-avc.c | 5 +++--
> >  drivers/media/firewire/firedtv-rc.c  | 5 +++--
> >  2 files changed, 6 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/media/firewire/firedtv-avc.c 
> > b/drivers/media/firewire/firedtv-avc.c
> > index 251a556112a9..e04235ea23fb 100644
> > --- a/drivers/media/firewire/firedtv-avc.c
> > +++ b/drivers/media/firewire/firedtv-avc.c
> > @@ -1181,8 +1181,9 @@ int avc_ca_pmt(struct firedtv *fdtv, char *msg, int 
> > length)
> > if (es_info_length > 0) {
> > pmt_cmd_id = msg[read_pos++];
> > if (pmt_cmd_id != 1 && pmt_cmd_id != 4)
> > -   dev_err(fdtv->device, "invalid pmt_cmd_id %d "
> > -   "at stream level\n", pmt_cmd_id);
> > +   dev_err(fdtv->device,
> > +   "invalid pmt_cmd_id %d at stream 
> > level\n",
> > +   pmt_cmd_id);
> >  
> > if (es_info_length > sizeof(c->operand) - 4 -
> >  write_pos) {
> > diff --git a/drivers/media/firewire/firedtv-rc.c 
> > b/drivers/media/firewire/firedtv-rc.c
> > index f82d4a93feb3..babfb9cee20e 100644
> > --- a/drivers/media/firewire/firedtv-rc.c
> > +++ b/drivers/media/firewire/firedtv-rc.c
> > @@ -184,8 +184,9 @@ void fdtv_handle_rc(struct firedtv *fdtv, unsigned int 
> > code)
> > else if (code >= 0x4540 && code <= 0x4542)
> > code = oldtable[code - 0x4521];
> > else {
> > -   printk(KERN_DEBUG "firedtv: invalid key code 0x%04x "
> > -  "from remote control\n", code);
> > +   printk(KERN_DEBUG
> > +  "firedtv: invalid key code 0x%04x from remote control\n",
> > +  code);
> > return;
> > }  
> 
> 
> Regards
> 
> Takashi Sakamoto
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Stefan Richter
-==- =-=- -
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 03/57] [media] firewire: don't break long lines

[Takashi Sakamoto]

Hi,

On Oct 15 2016 05:19, Mauro Carvalho Chehab wrote:
> Due to the 80-cols checkpatch warnings, several strings
> were broken into multiple lines. This is not considered
> a good practice anymore, as it makes harder to grep for
> strings at the source code. So, join those continuation
> lines.
> 
> Signed-off-by: Mauro Carvalho Chehab 

I prefer this patch because of the same reason in patch comment.

Reviewed-by: Takashi Sakamoto 

> ---
>  drivers/media/firewire/firedtv-avc.c | 5 +++--
>  drivers/media/firewire/firedtv-rc.c  | 5 +++--
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/firewire/firedtv-avc.c 
> b/drivers/media/firewire/firedtv-avc.c
> index 251a556112a9..e04235ea23fb 100644
> --- a/drivers/media/firewire/firedtv-avc.c
> +++ b/drivers/media/firewire/firedtv-avc.c
> @@ -1181,8 +1181,9 @@ int avc_ca_pmt(struct firedtv *fdtv, char *msg, int 
> length)
>   if (es_info_length > 0) {
>   pmt_cmd_id = msg[read_pos++];
>   if (pmt_cmd_id != 1 && pmt_cmd_id != 4)
> - dev_err(fdtv->device, "invalid pmt_cmd_id %d "
> - "at stream level\n", pmt_cmd_id);
> + dev_err(fdtv->device,
> + "invalid pmt_cmd_id %d at stream 
> level\n",
> + pmt_cmd_id);
>  
>   if (es_info_length > sizeof(c->operand) - 4 -
>write_pos) {
> diff --git a/drivers/media/firewire/firedtv-rc.c 
> b/drivers/media/firewire/firedtv-rc.c
> index f82d4a93feb3..babfb9cee20e 100644
> --- a/drivers/media/firewire/firedtv-rc.c
> +++ b/drivers/media/firewire/firedtv-rc.c
> @@ -184,8 +184,9 @@ void fdtv_handle_rc(struct firedtv *fdtv, unsigned int 
> code)
>   else if (code >= 0x4540 && code <= 0x4542)
>   code = oldtable[code - 0x4521];
>   else {
> - printk(KERN_DEBUG "firedtv: invalid key code 0x%04x "
> -"from remote control\n", code);
> + printk(KERN_DEBUG
> +"firedtv: invalid key code 0x%04x from remote control\n",
> +code);
>   return;
>   }


Regards

Takashi Sakamoto
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 03/57] [media] firewire: don't break long lines

[Mauro Carvalho Chehab]

Due to the 80-cols checkpatch warnings, several strings
were broken into multiple lines. This is not considered
a good practice anymore, as it makes harder to grep for
strings at the source code. So, join those continuation
lines.

Signed-off-by: Mauro Carvalho Chehab 
---
 drivers/media/firewire/firedtv-avc.c | 5 +++--
 drivers/media/firewire/firedtv-rc.c  | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/media/firewire/firedtv-avc.c 
b/drivers/media/firewire/firedtv-avc.c
index 251a556112a9..e04235ea23fb 100644
--- a/drivers/media/firewire/firedtv-avc.c
+++ b/drivers/media/firewire/firedtv-avc.c
@@ -1181,8 +1181,9 @@ int avc_ca_pmt(struct firedtv *fdtv, char *msg, int 
length)
if (es_info_length > 0) {
pmt_cmd_id = msg[read_pos++];
if (pmt_cmd_id != 1 && pmt_cmd_id != 4)
-   dev_err(fdtv->device, "invalid pmt_cmd_id %d "
-   "at stream level\n", pmt_cmd_id);
+   dev_err(fdtv->device,
+   "invalid pmt_cmd_id %d at stream 
level\n",
+   pmt_cmd_id);
 
if (es_info_length > sizeof(c->operand) - 4 -
 write_pos) {
diff --git a/drivers/media/firewire/firedtv-rc.c 
b/drivers/media/firewire/firedtv-rc.c
index f82d4a93feb3..babfb9cee20e 100644
--- a/drivers/media/firewire/firedtv-rc.c
+++ b/drivers/media/firewire/firedtv-rc.c
@@ -184,8 +184,9 @@ void fdtv_handle_rc(struct firedtv *fdtv, unsigned int code)
else if (code >= 0x4540 && code <= 0x4542)
code = oldtable[code - 0x4521];
else {
-   printk(KERN_DEBUG "firedtv: invalid key code 0x%04x "
-  "from remote control\n", code);
+   printk(KERN_DEBUG
+  "firedtv: invalid key code 0x%04x from remote control\n",
+  code);
return;
}
 
-- 
2.7.4


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html