Re: [PATCH 1/2] gspca pac7302: allow controlling LED separately

2010-02-27 Thread Németh Márton
Hi, I missed the CONFIG_LEDS_CLASS_MODULE configuration option in the previous version of this patch, now it is added. Regards, Márton Németh --- From: Márton Németh nm...@freemail.hu On Labtec Webcam 2200 there is a feedback LED which can be controlled independent from the streaming.

Re: [PATCH 1/2] gspca pac7302: allow controlling LED separately

2010-02-27 Thread Németh Márton
Hi, Hans de Goede wrote: Hi, On 02/27/2010 01:20 AM, Németh Márton wrote: From: Márton Némethnm...@freemail.hu On Labtec Webcam 2200 there is a feedback LED which can be controlled independent from the streaming. This is true for a lot of cameras, so if we are going to add a way to

Re: [PATCH 1/2] gspca pac7302: allow controlling LED separately

2010-02-27 Thread Jean-Francois Moine
On Sat, 27 Feb 2010 08:53:16 +0100 Hans de Goede hdego...@redhat.com wrote: This is true for a lot of cameras, so if we are going to add a way to support control of the LED separate of the streaming state, we should do that at the gspca_main level, and let sub drivers which support this

Re: [PATCH 1/2] gspca pac7302: allow controlling LED separately

2010-02-27 Thread Németh Márton
Hi, Jean-Francois Moine wrote: On Sat, 27 Feb 2010 08:53:16 +0100 Hans de Goede hdego...@redhat.com wrote: This is true for a lot of cameras, so if we are going to add a way to support control of the LED separate of the streaming state, we should do that at the gspca_main level, and let sub

Re: [PATCH 1/2] gspca pac7302: allow controlling LED separately

2010-02-27 Thread Hans de Goede
Hi, On 02/27/2010 04:35 PM, Németh Márton wrote: Hi, Jean-Francois Moine wrote: On Sat, 27 Feb 2010 08:53:16 +0100 Hans de Goedehdego...@redhat.com wrote: This is true for a lot of cameras, so if we are going to add a way to support control of the LED separate of the streaming state, we

Re: [PATCH 1/2] gspca pac7302: allow controlling LED separately

2010-02-27 Thread Jean-Francois Moine
On Sat, 27 Feb 2010 20:12:05 +0100 Hans de Goede hdego...@redhat.com wrote: [snip] I would like to note that even if we go the v4l2 control way it still makes sense to handle this in gspca_main, rather then implementing it separately in every sub driver. There is nothing to do in the

[PATCH 1/2] gspca pac7302: allow controlling LED separately

2010-02-26 Thread Németh Márton
From: Márton Németh nm...@freemail.hu On Labtec Webcam 2200 there is a feedback LED which can be controlled independent from the streaming. The feedback LED can be used from user space application to show for example detected motion or to distinguish between the preview and on-air state of the

Re: [PATCH 1/2] gspca pac7302: allow controlling LED separately

2010-02-26 Thread Hans de Goede
Hi, On 02/27/2010 01:20 AM, Németh Márton wrote: From: Márton Némethnm...@freemail.hu On Labtec Webcam 2200 there is a feedback LED which can be controlled independent from the streaming. This is true for a lot of cameras, so if we are going to add a way to support control of the LED