Re: [PATCH 5/9] cx231xx: Switch to using new dvb i2c helpers

2018-04-23 Thread Brad Love
Hi Matthias, On 2018-04-19 12:09, Matthias Schwarzott wrote: > Am 17.04.2018 um 18:39 schrieb Brad Love: >> Mostly very straight forward replace of blocks with equivalent code. >> >> Cleanup added at end of dvb_init in case of failure. >> > Hi Brad, > > I have some suggestions. See below. > >

Re: [PATCH 5/9] cx231xx: Switch to using new dvb i2c helpers

2018-04-19 Thread Matthias Schwarzott
Am 17.04.2018 um 18:39 schrieb Brad Love: > Mostly very straight forward replace of blocks with equivalent code. > > Cleanup added at end of dvb_init in case of failure. > Hi Brad, I have some suggestions. See below. Matthias > Signed-off-by: Brad Love > --- >

[PATCH 5/9] cx231xx: Switch to using new dvb i2c helpers

2018-04-17 Thread Brad Love
Mostly very straight forward replace of blocks with equivalent code. Cleanup added at end of dvb_init in case of failure. Signed-off-by: Brad Love --- drivers/media/usb/cx231xx/cx231xx-dvb.c | 331 1 file changed, 82 insertions(+), 249