Re: [PATCH 53/57] [media] i2c: don't break long lines

[Laurent Pinchart]

Hi Mauro,

Thank you for the patch.

On Friday 14 Oct 2016 17:20:41 Mauro Carvalho Chehab wrote:
> Due to the 80-cols checkpatch warnings, several strings
> were broken into multiple lines. This is not considered
> a good practice anymore, as it makes harder to grep for
> strings at the source code. So, join those continuation
> lines.
> 
> Signed-off-by: Mauro Carvalho Chehab 
> ---
>  drivers/media/i2c/as3645a.c  | 9 +++--
>  drivers/media/i2c/msp3400-kthreads.c | 3 +--
>  drivers/media/i2c/mt9m032.c  | 3 +--
>  drivers/media/i2c/mt9p031.c  | 3 +--
>  drivers/media/i2c/saa7115.c  | 3 +--
>  drivers/media/i2c/saa717x.c  | 3 +--
>  drivers/media/i2c/ths8200.c  | 4 +---
>  drivers/media/i2c/tvp5150.c  | 3 +--
>  drivers/media/i2c/tvp7002.c  | 3 +--
>  drivers/media/i2c/upd64083.c | 3 +--
>  10 files changed, 12 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/media/i2c/as3645a.c b/drivers/media/i2c/as3645a.c
> index 2e90e4094b79..95fcb8f68a1a 100644
> --- a/drivers/media/i2c/as3645a.c
> +++ b/drivers/media/i2c/as3645a.c
> @@ -299,8 +299,7 @@ static int as3645a_read_fault(struct as3645a *flash)
>   dev_dbg(>dev, "Inductor Peak limit fault\n");
> 
>   if (rval & AS_FAULT_INFO_INDICATOR_LED)
> - dev_dbg(>dev, "Indicator LED fault: "
> - "Short circuit or open loop\n");
> + dev_dbg(>dev, "Indicator LED fault: Short circuit or 
open
> loop\n");
> 
>   dev_dbg(>dev, "%u connected LEDs\n",
>   rval & AS_FAULT_INFO_LED_AMOUNT ? 2 : 1);
> @@ -315,8 +314,7 @@ static int as3645a_read_fault(struct as3645a *flash)
>   dev_dbg(>dev, "Short circuit fault\n");
> 
>   if (rval & AS_FAULT_INFO_OVER_VOLTAGE)
> - dev_dbg(>dev, "Over voltage fault: "
> - "Indicates missing capacitor or open connection\n");
> + dev_dbg(>dev, "Over voltage fault: Indicates missing 
capacitor or
> open connection\n");
> 
>   return rval;
>  }
> @@ -588,8 +586,7 @@ static int as3645a_registered(struct v4l2_subdev *sd)
> 
>   /* Verify the chip model and version. */
>   if (model != 0x01 || rfu != 0x00) {
> - dev_err(>dev, "AS3645A not detected "
> - "(model %d rfu %d)\n", model, rfu);
> + dev_err(>dev, "AS3645A not detected (model %d rfu 
%d)\n", model,
> rfu); rval = -ENODEV;
>   goto power_off;
>   }
> diff --git a/drivers/media/i2c/msp3400-kthreads.c
> b/drivers/media/i2c/msp3400-kthreads.c index 17120804fab7..022bea68cbf0
> 100644
> --- a/drivers/media/i2c/msp3400-kthreads.c
> +++ b/drivers/media/i2c/msp3400-kthreads.c
> @@ -775,8 +775,7 @@ int msp3410d_thread(void *data)
>   if (msp_amsound && !state->radio &&
>   (state->v4l2_std & V4L2_STD_SECAM) && (val != 0x0009)) {
>   /* autodetection has failed, let backup */
> - v4l_dbg(1, msp_debug, client, "autodetection failed,"
> - " switching to backup standard: %s 
(0x%04x)\n",
> + v4l_dbg(1, msp_debug, client, "autodetection failed, 
switching to backup
> standard: %s (0x%04x)\n", msp_stdlist[8].name ?
>   msp_stdlist[8].name : "unknown", val);
>   state->std = val = 0x0009;
> diff --git a/drivers/media/i2c/mt9m032.c b/drivers/media/i2c/mt9m032.c
> index da076796999e..a045425887d5 100644
> --- a/drivers/media/i2c/mt9m032.c
> +++ b/drivers/media/i2c/mt9m032.c
> @@ -746,8 +746,7 @@ static int mt9m032_probe(struct i2c_client *client,
> 
>   chip_version = mt9m032_read(client, MT9M032_CHIP_VERSION);
>   if (chip_version != MT9M032_CHIP_VERSION_VALUE) {
> - dev_err(>dev, "MT9M032 not detected, wrong version "
> - "0x%04x\n", chip_version);
> + dev_err(>dev, "MT9M032 not detected, wrong version 
0x%04x\n",
> chip_version); ret = -ENODEV;
>   goto error_sensor;
>   }
> diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c
> index 237737fec09c..4d7b56b96a92 100644
> --- a/drivers/media/i2c/mt9p031.c
> +++ b/drivers/media/i2c/mt9p031.c
> @@ -929,8 +929,7 @@ static int mt9p031_registered(struct v4l2_subdev
> *subdev) mt9p031_power_off(mt9p031);
> 
>   if (data != MT9P031_CHIP_VERSION_VALUE) {
> - dev_err(>dev, "MT9P031 not detected, wrong version "
> - "0x%04x\n", data);
> + dev_err(>dev, "MT9P031 not detected, wrong version 
0x%04x\n",
> data); return -ENODEV;
>   }
> 
> diff --git a/drivers/media/i2c/saa7115.c b/drivers/media/i2c/saa7115.c
> index 58062b41c923..5db914b7d5ae 100644
> --- a/drivers/media/i2c/saa7115.c
> +++ b/drivers/media/i2c/saa7115.c
> @@ -53,8 +53,7 @@
>  #define VRES_60HZ(480+16)
> 
>  MODULE_DESCRIPTION("Philips SAA7111/SAA7113/SAA7114/SAA7115/SAA7118 video
> 

[PATCH 53/57] [media] i2c: don't break long lines

[Mauro Carvalho Chehab]

Due to the 80-cols checkpatch warnings, several strings
were broken into multiple lines. This is not considered
a good practice anymore, as it makes harder to grep for
strings at the source code. So, join those continuation
lines.

Signed-off-by: Mauro Carvalho Chehab 
---
 drivers/media/i2c/as3645a.c  | 9 +++--
 drivers/media/i2c/msp3400-kthreads.c | 3 +--
 drivers/media/i2c/mt9m032.c  | 3 +--
 drivers/media/i2c/mt9p031.c  | 3 +--
 drivers/media/i2c/saa7115.c  | 3 +--
 drivers/media/i2c/saa717x.c  | 3 +--
 drivers/media/i2c/ths8200.c  | 4 +---
 drivers/media/i2c/tvp5150.c  | 3 +--
 drivers/media/i2c/tvp7002.c  | 3 +--
 drivers/media/i2c/upd64083.c | 3 +--
 10 files changed, 12 insertions(+), 25 deletions(-)

diff --git a/drivers/media/i2c/as3645a.c b/drivers/media/i2c/as3645a.c
index 2e90e4094b79..95fcb8f68a1a 100644
--- a/drivers/media/i2c/as3645a.c
+++ b/drivers/media/i2c/as3645a.c
@@ -299,8 +299,7 @@ static int as3645a_read_fault(struct as3645a *flash)
dev_dbg(>dev, "Inductor Peak limit fault\n");
 
if (rval & AS_FAULT_INFO_INDICATOR_LED)
-   dev_dbg(>dev, "Indicator LED fault: "
-   "Short circuit or open loop\n");
+   dev_dbg(>dev, "Indicator LED fault: Short circuit or 
open loop\n");
 
dev_dbg(>dev, "%u connected LEDs\n",
rval & AS_FAULT_INFO_LED_AMOUNT ? 2 : 1);
@@ -315,8 +314,7 @@ static int as3645a_read_fault(struct as3645a *flash)
dev_dbg(>dev, "Short circuit fault\n");
 
if (rval & AS_FAULT_INFO_OVER_VOLTAGE)
-   dev_dbg(>dev, "Over voltage fault: "
-   "Indicates missing capacitor or open connection\n");
+   dev_dbg(>dev, "Over voltage fault: Indicates missing 
capacitor or open connection\n");
 
return rval;
 }
@@ -588,8 +586,7 @@ static int as3645a_registered(struct v4l2_subdev *sd)
 
/* Verify the chip model and version. */
if (model != 0x01 || rfu != 0x00) {
-   dev_err(>dev, "AS3645A not detected "
-   "(model %d rfu %d)\n", model, rfu);
+   dev_err(>dev, "AS3645A not detected (model %d rfu 
%d)\n", model, rfu);
rval = -ENODEV;
goto power_off;
}
diff --git a/drivers/media/i2c/msp3400-kthreads.c 
b/drivers/media/i2c/msp3400-kthreads.c
index 17120804fab7..022bea68cbf0 100644
--- a/drivers/media/i2c/msp3400-kthreads.c
+++ b/drivers/media/i2c/msp3400-kthreads.c
@@ -775,8 +775,7 @@ int msp3410d_thread(void *data)
if (msp_amsound && !state->radio &&
(state->v4l2_std & V4L2_STD_SECAM) && (val != 0x0009)) {
/* autodetection has failed, let backup */
-   v4l_dbg(1, msp_debug, client, "autodetection failed,"
-   " switching to backup standard: %s (0x%04x)\n",
+   v4l_dbg(1, msp_debug, client, "autodetection failed, 
switching to backup standard: %s (0x%04x)\n",
msp_stdlist[8].name ?
msp_stdlist[8].name : "unknown", val);
state->std = val = 0x0009;
diff --git a/drivers/media/i2c/mt9m032.c b/drivers/media/i2c/mt9m032.c
index da076796999e..a045425887d5 100644
--- a/drivers/media/i2c/mt9m032.c
+++ b/drivers/media/i2c/mt9m032.c
@@ -746,8 +746,7 @@ static int mt9m032_probe(struct i2c_client *client,
 
chip_version = mt9m032_read(client, MT9M032_CHIP_VERSION);
if (chip_version != MT9M032_CHIP_VERSION_VALUE) {
-   dev_err(>dev, "MT9M032 not detected, wrong version "
-   "0x%04x\n", chip_version);
+   dev_err(>dev, "MT9M032 not detected, wrong version 
0x%04x\n", chip_version);
ret = -ENODEV;
goto error_sensor;
}
diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c
index 237737fec09c..4d7b56b96a92 100644
--- a/drivers/media/i2c/mt9p031.c
+++ b/drivers/media/i2c/mt9p031.c
@@ -929,8 +929,7 @@ static int mt9p031_registered(struct v4l2_subdev *subdev)
mt9p031_power_off(mt9p031);
 
if (data != MT9P031_CHIP_VERSION_VALUE) {
-   dev_err(>dev, "MT9P031 not detected, wrong version "
-   "0x%04x\n", data);
+   dev_err(>dev, "MT9P031 not detected, wrong version 
0x%04x\n", data);
return -ENODEV;
}
 
diff --git a/drivers/media/i2c/saa7115.c b/drivers/media/i2c/saa7115.c
index 58062b41c923..5db914b7d5ae 100644
--- a/drivers/media/i2c/saa7115.c
+++ b/drivers/media/i2c/saa7115.c
@@ -53,8 +53,7 @@
 #define VRES_60HZ  (480+16)
 
 MODULE_DESCRIPTION("Philips SAA7111/SAA7113/SAA7114/SAA7115/SAA7118 video 
decoder driver");
-MODULE_AUTHOR(  "Maxim Yevtyushkin, Kevin Thayer, Chris Kennedy, "
-   "Hans Verkuil, Mauro Carvalho