Re: [PATCH for v4.20 1/5] vb2: don't call __vb2_queue_cancel if vb2_start_streaming failed

2018-11-28 Thread Sakari Ailus
On Wed, Nov 28, 2018 at 09:37:43AM +0100, hverkuil-ci...@xs4all.nl wrote: > From: Hans Verkuil > > vb2_start_streaming() already rolls back the buffers, so there is no > need to call __vb2_queue_cancel(). Especially since __vb2_queue_cancel() > does too much, such as zeroing the q->queued_count

[PATCH for v4.20 1/5] vb2: don't call __vb2_queue_cancel if vb2_start_streaming failed

2018-11-28 Thread hverkuil-cisco
From: Hans Verkuil vb2_start_streaming() already rolls back the buffers, so there is no need to call __vb2_queue_cancel(). Especially since __vb2_queue_cancel() does too much, such as zeroing the q->queued_count value, causing vb2 to think that no buffers have been queued. It appears that this