Re: [PATCH v2 3/7] v4l: Clean up raw bayer pixel format definitions

[Hans Verkuil]

On 06/20/2016 06:20 PM, Sakari Ailus wrote:
> - Explicitly state that the most significant n bits are zeroed on 10 and
>   12 bpp formats.
> - Remove extra comma from the last entry of the format list
> - Add a missing colon before a list
> 
> Signed-off-by: Sakari Ailus 

Acked-by: Hans Verkuil 

Hans

> ---
>  Documentation/DocBook/media/v4l/pixfmt-srggb10.xml  | 5 +++--
>  Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml | 2 +-
>  Documentation/DocBook/media/v4l/pixfmt-srggb12.xml  | 5 +++--
>  3 files changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb10.xml 
> b/Documentation/DocBook/media/v4l/pixfmt-srggb10.xml
> index f34d03e..cd3f915 100644
> --- a/Documentation/DocBook/media/v4l/pixfmt-srggb10.xml
> +++ b/Documentation/DocBook/media/v4l/pixfmt-srggb10.xml
> @@ -23,7 +23,7 @@ unused high bits filled with zeros. Each n-pixel row 
> contains n/2 green samples
>  and n/2 blue or red samples, with alternating red and blue rows. Bytes are
>  stored in memory in little endian order. They are conventionally described
>  as GRGR... BGBG..., RGRG... GBGB..., etc. Below is an example of one of these
> -formats
> +formats:
>  
>  
>V4L2_PIX_FMT_SBGGR10 4  4
> @@ -31,7 +31,8 @@ pixel image
>  
>
>   Byte Order.
> - Each cell is one byte, high 6 bits in high bytes are 0.
> + Each cell is one byte, the 6 most significant bits in the high
> +   bytes are 0.
> 
>   
> 
> diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml 
> b/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
> index 747822b..18bb722 100644
> --- a/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
> +++ b/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
> @@ -3,7 +3,7 @@
>   V4L2_PIX_FMT_SRGGB10P ('pRAA'),
>V4L2_PIX_FMT_SGRBG10P ('pgAA'),
>V4L2_PIX_FMT_SGBRG10P ('pGAA'),
> -  V4L2_PIX_FMT_SBGGR10P ('pBAA'),
> +  V4L2_PIX_FMT_SBGGR10P ('pBAA')
>
>   
>
> diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb12.xml 
> b/Documentation/DocBook/media/v4l/pixfmt-srggb12.xml
> index 4394101..2d8efeb 100644
> --- a/Documentation/DocBook/media/v4l/pixfmt-srggb12.xml
> +++ b/Documentation/DocBook/media/v4l/pixfmt-srggb12.xml
> @@ -23,7 +23,7 @@ unused high bits filled with zeros. Each n-pixel row 
> contains n/2 green samples
>  and n/2 blue or red samples, with alternating red and blue rows. Bytes are
>  stored in memory in little endian order. They are conventionally described
>  as GRGR... BGBG..., RGRG... GBGB..., etc. Below is an example of one of these
> -formats
> +formats:
>  
>  
>V4L2_PIX_FMT_SBGGR12 4  4
> @@ -31,7 +31,8 @@ pixel image
>  
>
>   Byte Order.
> - Each cell is one byte, high 4 bits in high bytes are 0.
> + Each cell is one byte, the 4 most significant bits in the high
> +   bytes are 0.
> 
>   
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 3/7] v4l: Clean up raw bayer pixel format definitions

[Sakari Ailus]

- Explicitly state that the most significant n bits are zeroed on 10 and
  12 bpp formats.
- Remove extra comma from the last entry of the format list
- Add a missing colon before a list

Signed-off-by: Sakari Ailus 
---
 Documentation/DocBook/media/v4l/pixfmt-srggb10.xml  | 5 +++--
 Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml | 2 +-
 Documentation/DocBook/media/v4l/pixfmt-srggb12.xml  | 5 +++--
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb10.xml 
b/Documentation/DocBook/media/v4l/pixfmt-srggb10.xml
index f34d03e..cd3f915 100644
--- a/Documentation/DocBook/media/v4l/pixfmt-srggb10.xml
+++ b/Documentation/DocBook/media/v4l/pixfmt-srggb10.xml
@@ -23,7 +23,7 @@ unused high bits filled with zeros. Each n-pixel row contains 
n/2 green samples
 and n/2 blue or red samples, with alternating red and blue rows. Bytes are
 stored in memory in little endian order. They are conventionally described
 as GRGR... BGBG..., RGRG... GBGB..., etc. Below is an example of one of these
-formats
+formats:
 
 
   V4L2_PIX_FMT_SBGGR10 4  4
@@ -31,7 +31,8 @@ pixel image
 
   
Byte Order.
-   Each cell is one byte, high 6 bits in high bytes are 0.
+   Each cell is one byte, the 6 most significant bits in the high
+ bytes are 0.
  

  
diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml 
b/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
index 747822b..18bb722 100644
--- a/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
+++ b/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
@@ -3,7 +3,7 @@
V4L2_PIX_FMT_SRGGB10P ('pRAA'),
 V4L2_PIX_FMT_SGRBG10P ('pgAA'),
 V4L2_PIX_FMT_SGBRG10P ('pGAA'),
-V4L2_PIX_FMT_SBGGR10P ('pBAA'),
+V4L2_PIX_FMT_SBGGR10P ('pBAA')
 

   
diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb12.xml 
b/Documentation/DocBook/media/v4l/pixfmt-srggb12.xml
index 4394101..2d8efeb 100644
--- a/Documentation/DocBook/media/v4l/pixfmt-srggb12.xml
+++ b/Documentation/DocBook/media/v4l/pixfmt-srggb12.xml
@@ -23,7 +23,7 @@ unused high bits filled with zeros. Each n-pixel row contains 
n/2 green samples
 and n/2 blue or red samples, with alternating red and blue rows. Bytes are
 stored in memory in little endian order. They are conventionally described
 as GRGR... BGBG..., RGRG... GBGB..., etc. Below is an example of one of these
-formats
+formats:
 
 
   V4L2_PIX_FMT_SBGGR12 4  4
@@ -31,7 +31,8 @@ pixel image
 
   
Byte Order.
-   Each cell is one byte, high 4 bits in high bytes are 0.
+   Each cell is one byte, the 4 most significant bits in the high
+ bytes are 0.
  

  
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html