RE: [PATCH v3 0/2] Mem-to-mem device framework
-Original Message- From: Pawel Osciak [mailto:p.osc...@samsung.com] Sent: Monday, March 29, 2010 1:07 PM To: linux-media@vger.kernel.org Cc: p.osc...@samsung.com; m.szyprow...@samsung.com; kyungmin.p...@samsung.com; Hiremath, Vaibhav Subject: [PATCH v3 0/2] Mem-to-mem device framework Hello, this is the third version of the mem-to-mem memory device framework. It addresses previous comments and issues raised in Norway as well. It is rather independent from videobuf so I believe it can be merged separately. Changes in v3: - streamon, streamoff now have to be called for both queues separately - added automatic rescheduling of an instance after finish (if ready) - tweaked up locking - addressed Andy Walls' comments We have been using v2 for three different devices on an embedded system. I did some additional testing of v3 on a 4-core SMP as well. The series contains: [PATCH v3 1/2] v4l: Add memory-to-memory device helper framework for videobuf. [PATCH v3 2/2] v4l: Add a mem-to-mem videobuf framework test device. [Hiremath, Vaibhav] I have reviewed the changes and also tested it here at my end, even I have tested it with real hardware module (OMAP3 Resizer driver) so I think we can merge these patches now. I have cleanup patch (Submitting shortly), I just changed while reviewing/testing the code. So you can directly merge the patch into your next version. Also it would be really great if we could add documentation for this. You can also add, Reviewed-by: Hiremath Vaibhav hvaib...@ti.com Tested-by: Hiremath Vaibhav hvaib...@ti.com Thanks, Vaibhav Best regards -- Pawel Osciak Linux Platform Group Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3 0/2] Mem-to-mem device framework
Hello, this is the third version of the mem-to-mem memory device framework. It addresses previous comments and issues raised in Norway as well. It is rather independent from videobuf so I believe it can be merged separately. Changes in v3: - streamon, streamoff now have to be called for both queues separately - added automatic rescheduling of an instance after finish (if ready) - tweaked up locking - addressed Andy Walls' comments We have been using v2 for three different devices on an embedded system. I did some additional testing of v3 on a 4-core SMP as well. The series contains: [PATCH v3 1/2] v4l: Add memory-to-memory device helper framework for videobuf. [PATCH v3 2/2] v4l: Add a mem-to-mem videobuf framework test device. Best regards -- Pawel Osciak Linux Platform Group Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v3 0/2] Mem-to-mem device framework
-Original Message- From: Pawel Osciak [mailto:p.osc...@samsung.com] Sent: Monday, March 29, 2010 1:07 PM To: linux-media@vger.kernel.org Cc: p.osc...@samsung.com; m.szyprow...@samsung.com; kyungmin.p...@samsung.com; Hiremath, Vaibhav Subject: [PATCH v3 0/2] Mem-to-mem device framework Hello, this is the third version of the mem-to-mem memory device framework. It addresses previous comments and issues raised in Norway as well. It is rather independent from videobuf so I believe it can be merged separately. Changes in v3: - streamon, streamoff now have to be called for both queues separately - added automatic rescheduling of an instance after finish (if ready) - tweaked up locking - addressed Andy Walls' comments We have been using v2 for three different devices on an embedded system. I did some additional testing of v3 on a 4-core SMP as well. The series contains: [PATCH v3 1/2] v4l: Add memory-to-memory device helper framework for videobuf. [PATCH v3 2/2] v4l: Add a mem-to-mem videobuf framework test device. [Hiremath, Vaibhav] pawel, Thanks for the updated patch series; I will rebase my code onto this. As I mentioned I had started with migrating OMAP Resizer module to this framework (V2) and I could use it without any major issues. I am now cleaning up the patches and also before submitting the patch I had to merge/rebase it with Sakari's omap3camer/devel branch, since I have my version of ISP (required for Resizer module and bit hard-coded) which I think need to merge. Today I have pulled in latest changes from Sakari's branch, I am working on this and soon I will post patches for the same. Also, I have done some minor cleanups in your patches which also I will submit. Thanks, Vaibhav Hiremath Best regards -- Pawel Osciak Linux Platform Group Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v3 0/2] Mem-to-mem device framework
-Original Message- From: Pawel Osciak [mailto:p.osc...@samsung.com] Sent: Monday, March 29, 2010 1:07 PM To: linux-media@vger.kernel.org Cc: p.osc...@samsung.com; m.szyprow...@samsung.com; kyungmin.p...@samsung.com; Hiremath, Vaibhav Subject: [PATCH v3 0/2] Mem-to-mem device framework Hello, this is the third version of the mem-to-mem memory device framework. It addresses previous comments and issues raised in Norway as well. It is rather independent from videobuf so I believe it can be merged separately. Changes in v3: - streamon, streamoff now have to be called for both queues separately - added automatic rescheduling of an instance after finish (if ready) - tweaked up locking - addressed Andy Walls' comments We have been using v2 for three different devices on an embedded system. I did some additional testing of v3 on a 4-core SMP as well. The series contains: [PATCH v3 1/2] v4l: Add memory-to-memory device helper framework for videobuf. [PATCH v3 2/2] v4l: Add a mem-to-mem videobuf framework test device. [Hiremath, Vaibhav] pawel, Thanks for the updated patch series; I will rebase my code onto this. As I mentioned I had started with migrating OMAP Resizer module to this framework (V2) and I could use it without any major issues. I am now cleaning up the patches and also before submitting the patch I had to merge/rebase it with Sakari's omap3camer/devel branch, since I have my version of ISP (required for Resizer module and bit hard-coded) which I think need to merge. Today I have pulled in latest changes from Sakari's branch, I am working on this and soon I will post patches for the same. Also, I have done some minor cleanups in your patches which also I will submit. Hiremath, Be aware that the omap3 tree with media controller support that Laurent is working on does not use these mem-to-mem devices. Instead you have separate input and output devices. You should probably talk to Laurent about this before you do work that will not be needed eventually. Regards, Hans Thanks, Vaibhav Hiremath Best regards -- Pawel Osciak Linux Platform Group Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v3 0/2] Mem-to-mem device framework
-Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Monday, March 29, 2010 5:36 PM To: Hiremath, Vaibhav Cc: Pawel Osciak; linux-media@vger.kernel.org; m.szyprow...@samsung.com; kyungmin.p...@samsung.com Subject: RE: [PATCH v3 0/2] Mem-to-mem device framework -Original Message- From: Pawel Osciak [mailto:p.osc...@samsung.com] Sent: Monday, March 29, 2010 1:07 PM To: linux-media@vger.kernel.org Cc: p.osc...@samsung.com; m.szyprow...@samsung.com; kyungmin.p...@samsung.com; Hiremath, Vaibhav Subject: [PATCH v3 0/2] Mem-to-mem device framework Hello, this is the third version of the mem-to-mem memory device framework. It addresses previous comments and issues raised in Norway as well. It is rather independent from videobuf so I believe it can be merged separately. Changes in v3: - streamon, streamoff now have to be called for both queues separately - added automatic rescheduling of an instance after finish (if ready) - tweaked up locking - addressed Andy Walls' comments We have been using v2 for three different devices on an embedded system. I did some additional testing of v3 on a 4-core SMP as well. The series contains: [PATCH v3 1/2] v4l: Add memory-to-memory device helper framework for videobuf. [PATCH v3 2/2] v4l: Add a mem-to-mem videobuf framework test device. [Hiremath, Vaibhav] pawel, Thanks for the updated patch series; I will rebase my code onto this. As I mentioned I had started with migrating OMAP Resizer module to this framework (V2) and I could use it without any major issues. I am now cleaning up the patches and also before submitting the patch I had to merge/rebase it with Sakari's omap3camer/devel branch, since I have my version of ISP (required for Resizer module and bit hard-coded) which I think need to merge. Today I have pulled in latest changes from Sakari's branch, I am working on this and soon I will post patches for the same. Also, I have done some minor cleanups in your patches which also I will submit. Hiremath, Be aware that the omap3 tree with media controller support that Laurent is working on does not use these mem-to-mem devices. Instead you have separate input and output devices. You should probably talk to Laurent about this before you do work that will not be needed eventually. [Hiremath, Vaibhav] Thanks Hans and yes I am aware that, this branch/repo doesn't have Mem-to-Mem support. I just cloned whole tree here, and reviewing the code. Especially I will try to re-use the underneath ISP part of it for my Mem-to-Mem driver interface. And definitely I will talk to Laurent if I have any issues/questions. Thanks, Vaibhav Regards, Hans Thanks, Vaibhav Hiremath Best regards -- Pawel Osciak Linux Platform Group Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
