Re: [PATCH v6 05/10] media: uvcvideo: queue: Support asynchronous buffer handling

2018-11-10 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday, 9 November 2018 19:05:28 EET Kieran Bingham wrote: > The buffer queue interface currently operates sequentially, processing > buffers after they have fully completed. > > In preparation for supporting parallel tasks operating on the buffers, > we

Re: [RFC v2 1/4] media: Introduce helpers to fill pixel format structs

2018-11-10 Thread Ezequiel Garcia
On Fri, 2018-11-02 at 12:52 -0300, Ezequiel Garcia wrote: > Add two new API helpers, v4l2_fill_pixfmt and v4l2_fill_pixfmt_mp, > to be used by drivers to calculate plane sizes and bytes per lines. > > Note that driver-specific paddig and alignment are not yet > taken into account. > >

Re: [PATCH v4l-utils] Introduce v4l2-get-device tool

2018-11-10 Thread Ezequiel Garcia
On Sat, 2018-11-10 at 12:09 +0100, Hans Verkuil wrote: > On 11/10/2018 12:01 PM, Ezequiel Garcia wrote: > > On Sat, 2018-11-10 at 11:29 +0100, Hans Verkuil wrote: > > > On 11/09/2018 10:52 PM, Ezequiel Garcia wrote: > > > > This tool allows to find a device by driver name, > > > > this is useful

Re: [PATCH v4l-utils] Introduce v4l2-get-device tool

2018-11-10 Thread Hans Verkuil
On 11/10/2018 12:01 PM, Ezequiel Garcia wrote: > On Sat, 2018-11-10 at 11:29 +0100, Hans Verkuil wrote: >> On 11/09/2018 10:52 PM, Ezequiel Garcia wrote: >>> This tool allows to find a device by driver name, >>> this is useful for scripts to be written in a generic way. >> >> Why not add support

Re: [PATCH v4l-utils] Introduce v4l2-get-device tool

2018-11-10 Thread Ezequiel Garcia
On Sat, 2018-11-10 at 11:29 +0100, Hans Verkuil wrote: > On 11/09/2018 10:52 PM, Ezequiel Garcia wrote: > > This tool allows to find a device by driver name, > > this is useful for scripts to be written in a generic way. > > Why not add support for this to v4l2-sysfs-path? And improve it at the

Re: [PATCH v4l-utils] Introduce v4l2-get-device tool

2018-11-10 Thread Hans Verkuil
On 11/09/2018 10:52 PM, Ezequiel Garcia wrote: > This tool allows to find a device by driver name, > this is useful for scripts to be written in a generic way. Why not add support for this to v4l2-sysfs-path? And improve it at the same time (swradio devices do not show up when I run

Re: VIVID/VIMC and media fuzzing

2018-11-10 Thread Hans Verkuil
ingle planar API and >>> one using >>> the multiplanar API. That will improve the test coverage. >> >> Re this and collisions between multiple test processes. We actually >> would like to have moar devices and partition them between test >> proce

RE: [PATCH v7 14/16] intel-ipu3: Add v4l2 driver based on media framework

2018-11-09 Thread Zhi, Yong
.verk...@cisco.com; > laurent.pinch...@ideasonboard.com; Mani, Rajmohan > ; Zheng, Jian Xu ; Hu, > Jerry W ; Toivonen, Tuukka > ; Qiu, Tian Shu ; Cao, > Bingbu > Subject: Re: [PATCH v7 14/16] intel-ipu3: Add v4l2 driver based on media > framework > > Hi Yong, > > On Mo

RE: [PATCH v7 08/16] intel-ipu3: css: Add dma buff pool utility functions

2018-11-09 Thread Zhi, Yong
h...@ideasonboard.com; Mani, Rajmohan > ; Zheng, Jian Xu ; Hu, > Jerry W ; Toivonen, Tuukka > ; Qiu, Tian Shu ; Cao, > Bingbu > Subject: Re: [PATCH v7 08/16] intel-ipu3: css: Add dma buff pool utility > functions > > Hi Yong, > > On Mon, Oct 29, 2018 at 03:23:02PM -07

Re: [PATCH v3.16 0/2] V4L2 event subscription fixes

2018-11-09 Thread Ben Hutchings
On Thu, 2018-11-08 at 14:03 +0200, Sakari Ailus wrote: > Hi Ben, > > The two patches fix a use-after-free issue in V4L2 event handling. The > first patch that fixes that issue is already in the other stable trees (as > well as Linus's tree) whereas the second that fixes a bug in the first > one,

Re: [PATCH] media: Use wait_queue_head_t for media_request

2018-11-09 Thread Jasmin J.
Hi! Temporary add this patch to media-build until it is integrated in mainline. This should fix the build errors for Kernels older than 4.12. BR, Jasmin

Re: VIVID/VIMC and media fuzzing

2018-11-09 Thread Dmitry Vyukov
gt; As of now (Fri Nov 9 14:47:31 CET 2018) I fixed all media-related syzbot >> issues with the exception of >> https://syzkaller.appspot.com/bug?extid=f9966a25169b6d66d61f > > This is great! > I will look into that one, or maybe syzbot will come up with a repro > later. Bu

Re: [PATCH v4l-utils] Add missing linux/bpf_common.h

2018-11-09 Thread Peter Seiderer
Hello Sean, On Fri, 9 Nov 2018 12:10:38 +, Sean Young wrote: > Hi Peter, > > On Thu, Nov 08, 2018 at 10:13:38PM +0100, Peter Seiderer wrote: > > Thanks, works for the buildroot use case (disabling > > bpf support unconditionally)... > > > > The reason to provide copies of the linux kernel

Re: VIVID/VIMC and media fuzzing

2018-11-09 Thread Dmitry Vyukov
it's probably either a subtle race, or requires interaction between several test processes (we generally try to keep them isolated, but since this is a global device collisions are possible). > There is no reproducer for that one and I couldn't figure out how it could > happen. > > I

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-11-09 Thread Nicolas Dufresne
Le jeudi 08 novembre 2018 à 16:45 +0900, Tomasz Figa a écrit : > > In this patch we should consider a way to tell userspace that this has > > been opt in, otherwise existing userspace will have to remain using > > sub-optimal copy based reclaiming in order to ensure that renegotiation > > can work

Re: [PATCH 3/3] media: imx: lift CSI width alignment restriction

2018-11-09 Thread Steve Longerbeam
On 11/9/18 6:50 AM, Philipp Zabel wrote: On Thu, 2018-11-08 at 21:46 -0800, Steve Longerbeam wrote: On 11/5/18 7:20 AM, Philipp Zabel wrote: The CSI subdevice shouldn't have to care about IDMAC line start address alignment. With compose rectangle support in the capture driver, it doesn't

Re: [PATCH v6 09/10] media: uvcvideo: Rename uvc_{un,}init_video()

2018-11-09 Thread Kieran Bingham
Hi Laurent, I'm sorry - I didn't update the commit message on this one. On 09/11/2018 17:05, Kieran Bingham wrote: > We have both uvc_init_video() and uvc_video_init() calls which can be > quite confusing to determine the process for each. Now that video > uvc_video_enable() has been renamed to

Re: [PATCH v5 8/9] media: uvcvideo: Rename uvc_{un,}init_video()

2018-11-09 Thread Kieran Bingham
On 09/11/2018 15:41, Philipp Zabel wrote: > On Wed, 2018-11-07 at 22:25 +0200, Laurent Pinchart wrote: >> Hi Kieran, >> >> On Wednesday, 7 November 2018 16:30:46 EET Kieran Bingham wrote: >>> On 06/11/2018 23:13, Laurent Pinchart wrote: On Tuesday, 6 November 2018 23:27:19 EET Kieran Bingham

Re: [PATCH v5 8/9] media: uvcvideo: Rename uvc_{un,}init_video()

2018-11-09 Thread Philipp Zabel
On Wed, 2018-11-07 at 22:25 +0200, Laurent Pinchart wrote: > Hi Kieran, > > On Wednesday, 7 November 2018 16:30:46 EET Kieran Bingham wrote: > > On 06/11/2018 23:13, Laurent Pinchart wrote: > > > On Tuesday, 6 November 2018 23:27:19 EET Kieran Bingham wrote: > > > > From: Kieran Bingham > > > >

Re: [PATCH 3/3] media: imx: lift CSI width alignment restriction

2018-11-09 Thread Philipp Zabel
On Thu, 2018-11-08 at 21:46 -0800, Steve Longerbeam wrote: > On 11/5/18 7:20 AM, Philipp Zabel wrote: > > The CSI subdevice shouldn't have to care about IDMAC line start > > address alignment. With compose rectangle support in the capture > > driver, it doesn't have to anymore. > > > >

Re: VIVID/VIMC and media fuzzing

2018-11-09 Thread Hans Verkuil
Hi Dmitry, On 11/02/18 18:15, Dmitry Vyukov wrote: > On Wed, Oct 31, 2018 at 10:46 AM, Hans Verkuil wrote: >> On 10/30/2018 03:02 PM, Dmitry Vyukov wrote: >>> Hello Helen and linux-media, >>> >>> I've attended your talk "Shifting Media App Development into High >>> Gear" on OSS Summit last week

Re: [PATCH v3 0/9] TVP5150 fixes and new features

2018-11-09 Thread Marco Felsch
Hi Mauro, I don't want to spam you. Can you give me some feedback? I know the merge window is a busy time, so maybe you have some time now. Regards, Marco On 18-10-29 19:41, Marco Felsch wrote: > Hi Mauro, > > just a reminder, Rob already added his ack/rev-by tags. > > Thanks, > Marco > > On

Re: [PATCH 3/3] media: imx: lift CSI width alignment restriction

2018-11-09 Thread Philipp Zabel
Hi Steve, On Thu, 2018-11-08 at 21:46 -0800, Steve Longerbeam wrote: > > diff --git a/drivers/staging/media/imx/imx-media-csi.c > > b/drivers/staging/media/imx/imx-media-csi.c > > index c4523afe7b48..d39682192a67 100644 > > --- a/drivers/staging/media/imx/imx-media-csi.c > > +++

Re: [PATCH v5 0/9] Asynchronous UVC

2018-11-09 Thread Kieran Bingham
Hi Laurent, On 08/11/2018 17:01, Laurent Pinchart wrote: > Hi Kieran, > > On Wednesday, 7 November 2018 01:31:29 EET Laurent Pinchart wrote: >> On Tuesday, 6 November 2018 23:27:11 EET Kieran Bingham wrote: >>> From: Kieran Bingham >>> >>> The Linux UVC driver has long provided adequate

Re: [PATCH 2/3] media: imx: set compose rectangle to mbus format

2018-11-09 Thread Philipp Zabel
On Thu, 2018-11-08 at 21:33 -0800, Steve Longerbeam wrote: > Hi Philipp, > > On 11/5/18 7:20 AM, Philipp Zabel wrote: > > Prepare for mbus format being smaller than the written rectangle > > due to burst size. > > > > Signed-off-by: Philipp Zabel > > --- > >

Re: [PATCH 1/3] media: imx: add capture compose rectangle

2018-11-09 Thread Philipp Zabel
Hi Steve, thank you for the review. On Thu, 2018-11-08 at 21:33 -0800, Steve Longerbeam wrote: [...] > > --- a/drivers/staging/media/imx/imx-media-capture.c > > +++ b/drivers/staging/media/imx/imx-media-capture.c > > @@ -262,6 +262,10 @@ static int capture_s_fmt_vid_cap(struct file *file, > >

Re: [PATCH v7 15/16] intel-ipu3: Add imgu top level pci device driver

2018-11-09 Thread Sakari Ailus
map.h" > +#include "ipu3-mmu.h" > + > +#define IMGU_PCI_ID 0x1919 > +#define IMGU_PCI_BAR 0 > +#define IMGU_DMA_MASKDMA_BIT_MASK(39) > +#define IMGU_MAX_QUEUE_DEPTH (2 + 2) > + > +/* >

Re: [PATCH v7 14/16] intel-ipu3: Add v4l2 driver based on media framework

2018-11-09 Thread Sakari Ailus
Hi Yong, On Mon, Oct 29, 2018 at 03:23:08PM -0700, Yong Zhi wrote: > Implement video driver that utilizes v4l2, vb2 queue support > and media controller APIs. The driver exposes single > subdevice and six nodes. > > Signed-off-by: Yong Zhi > --- > drivers/media/pci/intel/ipu3/ipu3-v4l2.c |

Re: [PATCH v4l-utils] Add missing linux/bpf_common.h

2018-11-09 Thread Sean Young
Hi Peter, On Thu, Nov 08, 2018 at 10:13:38PM +0100, Peter Seiderer wrote: > Thanks, works for the buildroot use case (disabling > bpf support unconditionally)... > > The reason to provide copies of the linux kernel headers in v4l-utils > is to be independent of old(-er) headers provided by

Re: [PATCH v7 12/16] intel-ipu3: css: Initialize css hardware

2018-11-09 Thread Sakari Ailus
Hi Yong, On Mon, Oct 29, 2018 at 03:23:06PM -0700, Yong Zhi wrote: > This patch implements the functions to initialize > and configure IPU3 h/w such as clock, irq and power. > > Signed-off-by: Yong Zhi > Signed-off-by: Tomasz Figa > --- > drivers/media/pci/intel/ipu3/ipu3-css.c | 537 >

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-09 Thread Sakari Ailus
; Mani, Rajmohan > > ; Zheng, Jian Xu ; Hu, > > Jerry W ; Toivonen, Tuukka > > ; Qiu, Tian Shu ; Cao, > > Bingbu > > Subject: Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset > > > > > > On 11/01/2018 08:03 PM, Sakari Ailus wrote: > > >

Re: [RFC PATCH 0/5] vb2/cedrus: add cookie support

2018-11-09 Thread Hans Verkuil
On 11/09/18 10:56, Hans Verkuil wrote: > As was discussed here (among other places): > > https://lkml.org/lkml/2018/10/19/440 > > using capture queue buffer indices to refer to reference frames is > not a good idea. A better idea is to use 'cookies' (a better name is > welcome!) where the

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-09 Thread Sakari Ailus
Hi Bing Bu, On Wed, Nov 07, 2018 at 12:16:47PM +0800, Bing Bu Cao wrote: > > On 11/01/2018 08:03 PM, Sakari Ailus wrote: > > Hi Yong, > > > > Thanks for the update! > > > > On Mon, Oct 29, 2018 at 03:22:54PM -0700, Yong Zhi wrote: > >> Hi, > >> > >> This series adds support for the Intel IPU3

Re: [PATCH 3/3] media: imx: lift CSI width alignment restriction

2018-11-08 Thread Steve Longerbeam
On 11/5/18 7:20 AM, Philipp Zabel wrote: The CSI subdevice shouldn't have to care about IDMAC line start address alignment. With compose rectangle support in the capture driver, it doesn't have to anymore. Signed-off-by: Philipp Zabel --- drivers/staging/media/imx/imx-media-capture.c | 9

Re: [PATCH 2/3] media: imx: set compose rectangle to mbus format

2018-11-08 Thread Steve Longerbeam
Hi Philipp, On 11/5/18 7:20 AM, Philipp Zabel wrote: Prepare for mbus format being smaller than the written rectangle due to burst size. Signed-off-by: Philipp Zabel --- drivers/staging/media/imx/imx-media-capture.c | 55 +-- 1 file changed, 38 insertions(+), 17

Re: [PATCH 1/3] media: imx: add capture compose rectangle

2018-11-08 Thread Steve Longerbeam
Hi Philipp, On 11/5/18 7:20 AM, Philipp Zabel wrote: Allowing to compose captured images into larger memory buffers will let us lift alignment restrictions on CSI crop width. Signed-off-by: Philipp Zabel --- drivers/staging/media/imx/imx-ic-prpencvf.c | 3 +-

RE: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-08 Thread Zhi, Yong
Yong > > Cc: linux-media@vger.kernel.org; tf...@chromium.org; > mche...@kernel.org; hans.verk...@cisco.com; > laurent.pinch...@ideasonboard.com; Mani, Rajmohan > ; Zheng, Jian Xu ; Hu, > Jerry W ; Toivonen, Tuukka > ; Qiu, Tian Shu ; Cao, > Bingbu > Subject: Re: [P

Re: [PATCH v4l-utils] Add missing linux/bpf_common.h

2018-11-08 Thread Peter Seiderer
Hello Sean, On Wed, 7 Nov 2018 12:05:45 +, Sean Young wrote: > Hi Peter, > > On Tue, Nov 06, 2018 at 10:43:58PM +0100, Peter Seiderer wrote: > > On Tue, 6 Nov 2018 10:38:56 +, Sean Young wrote: > > > > > On Mon, Nov 05, 2018 at 09:30:47PM +0100, Peter Seiderer wrote: > > > > Copy

Re: [PATCH v2 v4l-utils] configure: build without BPF support in ir-keytable

2018-11-08 Thread Peter Seiderer
Hello Sean, On Wed, 7 Nov 2018 12:02:05 +, Sean Young wrote: > It currently does not build on mips and some platforms do not have > BPF support yet (risc-v, for example). > Thanks for the patch, works for the buildroot use case (disabling bpf support unconditionally), see [1]...

Re: [Outreachy kernel] [PATCH vicodec v4 0/3] Add support to more pixel formats in vicodec

2018-11-08 Thread Ezequiel Garcia
On Thu, 8 Nov 2018 at 14:54, Sasha Levin wrote: > > On Thu, Nov 08, 2018 at 10:10:10AM +0200, Dafna Hirschfeld wrote: > >On Thu, Nov 8, 2018 at 2:51 AM Ezequiel Garcia < > >ezequ...@vanguardiasur.com.ar> wrote: > > > >> Hello Dafna, > >> > >> Thanks for the patches. > >> > >> Just out of

Re: [PATCH v4.9 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-08 Thread Sasha Levin
On Thu, Nov 08, 2018 at 01:46:06PM +0200, Sakari Ailus wrote: [ upstream commit 92539d3eda2c090b382699bbb896d4b54e9bdece ] Patch ad608fbcf166 changed how events were subscribed to address an issue elsewhere. As a side effect of that change, the "add" callback was called before the event

Re: [PATCH v5 0/9] Asynchronous UVC

2018-11-08 Thread Laurent Pinchart
Hi Kieran, On Wednesday, 7 November 2018 01:31:29 EET Laurent Pinchart wrote: > On Tuesday, 6 November 2018 23:27:11 EET Kieran Bingham wrote: > > From: Kieran Bingham > > > > The Linux UVC driver has long provided adequate performance capabilities > > for web-cams and low data rate video

Re: [PATCH v7 08/16] intel-ipu3: css: Add dma buff pool utility functions

2018-11-08 Thread Sakari Ailus
Hi Yong, On Mon, Oct 29, 2018 at 03:23:02PM -0700, Yong Zhi wrote: > The pools are used to store previous parameters set by > user with the parameter queue. Due to pipelining, > there needs to be multiple sets (up to four) > of parameters which are queued in a host-to-sp queue. > >

Re: [PATCH] MAINTAINERS fixups

2018-11-08 Thread Sylwester Nawrocki
On 11/08/2018 02:23 PM, Hans Verkuil wrote: > Update file paths in MAINTAINERS. > > Signed-off-by: Hans Verkuil > Reported-by: Joe Perches Reviewed-by: Sylwester Nawrocki

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-11-07 Thread Tomasz Figa
Hi Nicolas, On Sat, Oct 27, 2018 at 6:38 PM Nicolas Dufresne wrote: > > Le lundi 22 octobre 2018 à 12:37 +0900, Tomasz Figa a écrit : > > Hi Philipp, > > > > On Mon, Oct 22, 2018 at 1:28 AM Philipp Zabel wrote: > > > > > > On Wed, Oct 03, 2018 at 05:24:39PM +0900, Tomasz Figa wrote: > > > [...]

RE: [PATCH] media: imx258: remove test pattern map from driver

2018-11-07 Thread Chen, JasonX Z
Subject: Re: [PATCH] media: imx258: remove test pattern map from driver Hi Jason, Thanks for the patch. On Wed, Nov 07, 2018 at 03:22:23PM +0800, jasonx.z.c...@intel.com wrote: > From: "Chen, JasonX Z" > > Test Pattern mode be picked at HAL instead of driver. > do a FLIP w

Re: [PATCH] media: xilinx-video: fix bad of_node_put() on endpoint error

2018-11-07 Thread Hyun Kwon
Hi Akinobu, Thanks for the patch. On Sun, 2018-11-04 at 05:11:10 -0800, Akinobu Mita wrote: > The fwnode_graph_get_next_endpoint() returns an 'endpoint' node pointer > with refcount incremented, and refcount of the passed as a previous > 'endpoint' node is decremented. > > So when iterating

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Shuah Khan
On 11/07/2018 12:10 PM, Mauro Carvalho Chehab wrote: > Em Wed, 07 Nov 2018 12:06:55 +0200 > Laurent Pinchart escreveu: > >> Hi Hans, >> >> On Wednesday, 7 November 2018 10:05:12 EET Hans Verkuil wrote: >>> On 11/06/2018 08:58 PM, Laurent Pinchart wrote: On Tuesday, 6 November 2018

Re: [PATCH v5 8/9] media: uvcvideo: Rename uvc_{un,}init_video()

2018-11-07 Thread Laurent Pinchart
Hi Kieran, On Wednesday, 7 November 2018 16:30:46 EET Kieran Bingham wrote: > On 06/11/2018 23:13, Laurent Pinchart wrote: > > On Tuesday, 6 November 2018 23:27:19 EET Kieran Bingham wrote: > >> From: Kieran Bingham > >> > >> We have both uvc_init_video() and uvc_video_init() calls which can be

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Laurent Pinchart
Hi Mauro, On Wednesday, 7 November 2018 21:53:20 EET Mauro Carvalho Chehab wrote: > Em Wed, 07 Nov 2018 21:35:32 +0200 Laurent Pinchart escreveu: > > On Wednesday, 7 November 2018 21:10:35 EET Mauro Carvalho Chehab wrote: [snip] > >> I'm with Hans on that matter: better to start with an

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Mauro Carvalho Chehab
they fit better into their test framework. > > >>>> > > >>>> The one key requirement to all this is that you should be able to run > > >>>> these tests without dependencies to all sorts of external packages/ > > >>>> librari

Re: [PATCH] keytable: fix BPF protocol compilation on mips

2018-11-07 Thread Gregor Jasny
On 11/7/18 4:36 PM, Sean Young wrote: clang -idirafter /usr/local/include -idirafter +/usr/lib/llvm-6.0/lib/clang/6.0.1/include -idirafter +/usr/include/mips64el-linux-gnuabi64 -idirafter /usr/include +-I../../../include -target bpf -O2 -c grundig.c In file included from grundig.c:5: In file

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Ezequiel Garcia
On Wed, 2018-11-07 at 09:05 +0100, Hans Verkuil wrote: > On 11/06/2018 08:58 PM, Laurent Pinchart wrote: > > Hi Hans, > > > > On Tuesday, 6 November 2018 15:56:34 EET Hans Verkuil wrote: > > > On 11/06/18 14:12, Laurent Pinchart wrote: > > > > On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Laurent Pinchart
t; >>> > >>> v4l-utils already has a set of dependencies, but those are largely > >>> manageable. For v4l2-compliance we'll install libv4l, which depends on > >>> libjpeg. > >> > >> That's already too much. You can manually build v

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Mauro Carvalho Chehab
t; libraries. > > > > > > v4l-utils already has a set of dependencies, but those are largely > > > manageable. For v4l2-compliance we'll install libv4l, which depends on > > > libjpeg. > > > > That's already too much. You can manually build v4l2-comp

Re: [PATCH 1/1] v4l: uAPI doc: Simplify NATIVE_SIZE selection target documentation

2018-11-07 Thread Hans Verkuil
On 11/07/18 16:04, Sakari Ailus wrote: > The NATIVE_SIZE target is documented for mem2mem devices but no driver has > ever apparently used it. It may be never needed; remove it for now. > > Suggested-by: Hans Verkuil > Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Thanks, Hans

Re: [PATCH v5 8/9] media: uvcvideo: Rename uvc_{un,}init_video()

2018-11-07 Thread Kieran Bingham
Hi Laurent, On 06/11/2018 23:13, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Tuesday, 6 November 2018 23:27:19 EET Kieran Bingham wrote: >> From: Kieran Bingham >> >> We have both uvc_init_video() and uvc_video_init() calls which can be >> quite confusing to

Re: [PATCH v5 9/9] media: uvcvideo: Utilise for_each_uvc_urb iterator

2018-11-07 Thread Kieran Bingham
Hi Laurent, On 06/11/2018 23:21, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Tuesday, 6 November 2018 23:27:20 EET Kieran Bingham wrote: >> From: Kieran Bingham >> >> A new iterator is available for processing UVC URB structures. This >> simplifies the processing

Re: [PATCH v4l-utils] keytable: fix compilation warning

2018-11-07 Thread Sakari Ailus
On Wed, Nov 07, 2018 at 12:02:14PM +, Sean Young wrote: > keytable.c: In function ‘parse_opt’: > keytable.c:835:7: warning: ‘param’ may be used uninitialized in this function > [-Wuninitialized] > > Signed-off-by: Sean Young Acked-by: Sakari Ailus -- Sakari Ailus e-mail:

Re: [PATCH v5 6/9] media: uvcvideo: Move decode processing to process context

2018-11-07 Thread Kieran Bingham
struct uvc_urb >> *uvc_urb, * sure buf is never dereferenced if NULL. >> */ >> >> -/* Process video data. */ >> +/* Prepare video data for processing. */ >> if (!stream->bulk.skip_payload && buf != NULL) >> -uvc_

Re: [PATCH v5 7/9] media: uvcvideo: Split uvc_video_enable into two

2018-11-07 Thread Kieran Bingham
Hi Laurent, On 06/11/2018 23:08, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Tuesday, 6 November 2018 23:27:18 EET Kieran Bingham wrote: >> From: Kieran Bingham >> >> uvc_video_enable() is used both to start and stop the video stream >> object, however the single

Re: [PATCH v4l-utils] Add missing linux/bpf_common.h

2018-11-07 Thread Sean Young
Hi Peter, On Tue, Nov 06, 2018 at 10:43:58PM +0100, Peter Seiderer wrote: > On Tue, 6 Nov 2018 10:38:56 +, Sean Young wrote: > > > On Mon, Nov 05, 2018 at 09:30:47PM +0100, Peter Seiderer wrote: > > > Copy from [1], needed by bpf.h. > > > > > > [1] > > >

Re: [PATCH 1/3] media: imx: add capture compose rectangle

2018-11-07 Thread Sakari Ailus
Hi Philipp, On Tue, Nov 06, 2018 at 03:44:07PM +0100, Philipp Zabel wrote: > Hi Sakari, > > On Tue, 2018-11-06 at 16:01 +0200, Sakari Ailus wrote: > [...] > > @@ -290,6 +294,35 @@ static int capture_s_std(struct file *file, void *fh, > > v4l2_std_id std) > > > return

Re: [PATCH v7 05/12] media: dt-bindings: add bindings for i.MX7 media driver

2018-11-07 Thread Sakari Ailus
On Fri, Aug 10, 2018 at 03:20:38PM +0100, Rui Miguel Silva wrote: > Add bindings documentation for i.MX7 media drivers. > The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. > > Reviewed-by: Rob Herring > Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus - -- Sakari Ailus

Re: [PATCH] media: imx258: remove test pattern map from driver

2018-11-07 Thread Sakari Ailus
Hi Jason, Thanks for the patch. On Wed, Nov 07, 2018 at 03:22:23PM +0800, jasonx.z.c...@intel.com wrote: > From: "Chen, JasonX Z" > > Test Pattern mode be picked at HAL instead of driver. > do a FLIP when userspace use test pattern mode. > add entity_ops for validating imx258 link. > >

Re: [PATCH] [v4l-utils] libv4l2subdev: Add MEDIA_BUS_FMT_FIXED to mbus_formats[]

2018-11-07 Thread Sakari Ailus
On Tue, Nov 06, 2018 at 09:12:56AM -0800, Yong Zhi wrote: > Also add V4L2_COLORSPACE_RAW to the colorspaces[]. > > Signed-off-by: Yong Zhi > --- > utils/media-ctl/libv4l2subdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/utils/media-ctl/libv4l2subdev.c

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Laurent Pinchart
Hi Hans, On Wednesday, 7 November 2018 10:05:12 EET Hans Verkuil wrote: > On 11/06/2018 08:58 PM, Laurent Pinchart wrote: > > On Tuesday, 6 November 2018 15:56:34 EET Hans Verkuil wrote: > >> On 11/06/18 14:12, Laurent Pinchart wrote: > >>> On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus

Re: [PATCH v7 00/12] media: staging/imx7: add i.MX7 media driver

2018-11-07 Thread Rui Miguel Silva
and repost? Please re-run v4l2-compliance as well with the latest compliance code. Yup, I may take one week or so, other things in hand, but will try to send it sooner than later. We should be able to merge this for 4.21 (finally!). Yeah!! Thanks. --- Cheers, Rui

Re: [PATCH v7 00/12] media: staging/imx7: add i.MX7 media driver

2018-11-07 Thread Hans Verkuil
6f3824e2d30d19b0df1a1 from Aug 6th > > The Media Driver fail some tests but this failures are coming from code out of > scope of this series (imx-capture), and some from the sensor OV2680 > but that I think not related with the sensor driver but with the testing and > core. > > T

Re: [PATCH] [v4l-utils] libv4l2subdev: Add MEDIA_BUS_FMT_FIXED to mbus_formats[]

2018-11-07 Thread Sakari Ailus
Hi Yong, On Tue, Nov 06, 2018 at 09:12:56AM -0800, Yong Zhi wrote: > Also add V4L2_COLORSPACE_RAW to the colorspaces[]. > > Signed-off-by: Yong Zhi > --- > utils/media-ctl/libv4l2subdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/utils/media-ctl/libv4l2subdev.c

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Hans Verkuil
On 11/06/2018 08:58 PM, Laurent Pinchart wrote: > Hi Hans, > > On Tuesday, 6 November 2018 15:56:34 EET Hans Verkuil wrote: >> On 11/06/18 14:12, Laurent Pinchart wrote: >>> On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus wrote: On Tue, Nov 06, 2018 at 09:37:07AM +0100, Hans Verkuil

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-06 Thread Bing Bu Cao
ss-fw.h >> Clean up the header files. >> Remove enum type from ABI structs. >> - ipu3-css.h and ipu3-css.c >> Disable DVS support and remove related code. >> - ipu3-v4l2.c >> Fixes of v4l2_compliance test fails on ImgU sub-dev. >> - ipu3-css-pa

Re: [PATCH v5 0/9] Asynchronous UVC

2018-11-06 Thread Laurent Pinchart
Hi Kieran, Thank you for the patches. On Tuesday, 6 November 2018 23:27:11 EET Kieran Bingham wrote: > From: Kieran Bingham > > The Linux UVC driver has long provided adequate performance capabilities for > web-cams and low data rate video devices in Linux while resolutions were > low. > >

RE: [PATCH v7 05/16] intel-ipu3: abi: Add structs

2018-11-06 Thread Mani, Rajmohan
Hi Sakari, > Subject: Re: [PATCH v7 05/16] intel-ipu3: abi: Add structs > > Hi Raj, > > On Mon, Nov 05, 2018 at 07:05:53PM +, Mani, Rajmohan wrote: > > Hi Sakari, > > > > > Subject: Re: [PATCH v7 05/16] intel-ipu3: abi: Add structs > > > > >

RE: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-06 Thread Mani, Rajmohan
Hi Mauro, Thanks for the reviews. > Subject: Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI > > Hi Mauro, > > On Fri, Nov 2, 2018 at 10:49 PM Mauro Carvalho Chehab > wrote: > > > > Em Mon, 29 Oct 2018 15:22:57 -0700 > > Yong Z

Re: [PATCH v5 9/9] media: uvcvideo: Utilise for_each_uvc_urb iterator

2018-11-06 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 6 November 2018 23:27:20 EET Kieran Bingham wrote: > From: Kieran Bingham > > A new iterator is available for processing UVC URB structures. This > simplifies the processing of the internal stream data. > > Convert the manual loop iterators to

Re: [PATCH v5 8/9] media: uvcvideo: Rename uvc_{un,}init_video()

2018-11-06 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 6 November 2018 23:27:19 EET Kieran Bingham wrote: > From: Kieran Bingham > > We have both uvc_init_video() and uvc_video_init() calls which can be > quite confusing to determine the process for each. Now that video > uvc_video_enable() has been

Re: [PATCH v5 7/9] media: uvcvideo: Split uvc_video_enable into two

2018-11-06 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 6 November 2018 23:27:18 EET Kieran Bingham wrote: > From: Kieran Bingham > > uvc_video_enable() is used both to start and stop the video stream > object, however the single function entry point shares no code between > the two operations. > >

Re: [PATCH v5 6/9] media: uvcvideo: Move decode processing to process context

2018-11-06 Thread Laurent Pinchart
* a payload size equal to the maximum) and process the header again. > @@ -1472,7 +1507,7 @@ static void uvc_video_complete(struct urb *urb) > uvc_printk(KERN_WARNING, "Non-zero status (%d) in video " > "completion handler.\n",

Re: [PATCH v5 5/9] media: uvcvideo: queue: Support asynchronous buffer handling

2018-11-06 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 6 November 2018 23:27:16 EET Kieran Bingham wrote: > From: Kieran Bingham > > The buffer queue interface currently operates sequentially, processing > buffers after they have fully completed. > > In preparation for supporting parallel tasks

Re: [PATCH v4l-utils] Add missing linux/bpf_common.h

2018-11-06 Thread Peter Seiderer
Hello Sean, On Tue, 6 Nov 2018 10:38:56 +, Sean Young wrote: > On Mon, Nov 05, 2018 at 09:30:47PM +0100, Peter Seiderer wrote: > > Copy from [1], needed by bpf.h. > > > > [1] > >

Re: [RFC] Create test script(s?) for regression testing

2018-11-06 Thread Laurent Pinchart
Hi Hans, On Tuesday, 6 November 2018 15:56:34 EET Hans Verkuil wrote: > On 11/06/18 14:12, Laurent Pinchart wrote: > > On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus wrote: > >> On Tue, Nov 06, 2018 at 09:37:07AM +0100, Hans Verkuil wrote: > >>> Hi all, > >>> > >>> After the media summit

RE: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-06 Thread Zhi, Yong
ium.org; hans.verk...@cisco.com; > laurent.pinch...@ideasonboard.com; Mani, Rajmohan > ; Zheng, Jian Xu ; Hu, > Jerry W ; Toivonen, Tuukka > ; Qiu, Tian Shu ; Cao, > Bingbu ; Li, Chao C > Subject: Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI > > Em Mon, 29 Oc

Re: [PATCH 1/3] media: imx: add capture compose rectangle

2018-11-06 Thread Philipp Zabel
Hi Sakari, On Tue, 2018-11-06 at 16:01 +0200, Sakari Ailus wrote: [...] > @@ -290,6 +294,35 @@ static int capture_s_std(struct file *file, void *fh, > v4l2_std_id std) > > return v4l2_subdev_call(priv->src_sd, video, s_std, std); > > } > > > > +static int capture_g_selection(struct file

Re: [PATCH 1/3] media: imx: add capture compose rectangle

2018-11-06 Thread Sakari Ailus
Hi Philipp, On Mon, Nov 05, 2018 at 04:20:53PM +0100, Philipp Zabel wrote: > Allowing to compose captured images into larger memory buffers > will let us lift alignment restrictions on CSI crop width. > > Signed-off-by: Philipp Zabel > --- > drivers/staging/media/imx/imx-ic-prpencvf.c | 3

Re: [RFC] Create test script(s?) for regression testing

2018-11-06 Thread Hans Verkuil
On 11/06/18 14:12, Laurent Pinchart wrote: > Hello, > > On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus wrote: >> On Tue, Nov 06, 2018 at 09:37:07AM +0100, Hans Verkuil wrote: >>> Hi all, >>> >>> After the media summit (heavy on test discussions) and the V4L2 event >>> regression we just

Re: [RFC] Create test script(s?) for regression testing

2018-11-06 Thread Ezequiel Garcia
On Tue, 2018-11-06 at 09:37 +0100, Hans Verkuil wrote: > Hi all, > > After the media summit (heavy on test discussions) and the V4L2 event > regression > we just found it is clear we need to do a better job with testing. > > All the pieces are in place, so what is needed is to combine it and

Re: [RFC] Create test script(s?) for regression testing

2018-11-06 Thread Laurent Pinchart
Hello, On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus wrote: > On Tue, Nov 06, 2018 at 09:37:07AM +0100, Hans Verkuil wrote: > > Hi all, > > > > After the media summit (heavy on test discussions) and the V4L2 event > > regression we just found it is clear we need to do a better job with >

Re: [PATCH] cedrus: check if kzalloc() fails

2018-11-06 Thread Maxime Ripard
On Tue, Nov 06, 2018 at 06:21:29AM -0500, Mauro Carvalho Chehab wrote: > As warned by static code analizer checkers: > drivers/staging/media/sunxi/cedrus/cedrus.c: > drivers/staging/media/sunxi/cedrus/cedrus.c:93 cedrus_init_ctrls() error: > potential null dereference 'ctx->ctrls'.

Re: [PATCH] media: dm365_ipipeif: better annotate a fall though

2018-11-06 Thread Hans Verkuil
On 11/06/18 11:55, Mauro Carvalho Chehab wrote: > Shut up this warning: > > drivers/staging/media/davinci_vpfe/dm365_ipipeif.c: In function > 'ipipeif_hw_setup': > drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:298:3: warning: this > statement may fall through

Re: [RFC] Create test script(s?) for regression testing

2018-11-06 Thread Sakari Ailus
Hi Hans, On Tue, Nov 06, 2018 at 09:37:07AM +0100, Hans Verkuil wrote: > Hi all, > > After the media summit (heavy on test discussions) and the V4L2 event > regression > we just found it is clear we need to do a better job with testing. > > All the pieces are in place, so what is needed is to

Re: [PATCH 01/15] media: coda: fix memory corruption in case more than 32 instances are opened

2018-11-06 Thread Philipp Zabel
On Mon, 2018-11-05 at 16:32 +, Ian Arkver wrote: > Hi Philipp, > > On 05/11/2018 15:24, Philipp Zabel wrote: > > The ffz() return value is undefined if the instance mask does not > > contain any zeros. If it returned 32, the following set_bit would > > corrupt the debugfs_root pointer. > >

Re: [PATCH v4l-utils] Add missing linux/bpf_common.h

2018-11-06 Thread Sean Young
On Mon, Nov 05, 2018 at 09:30:47PM +0100, Peter Seiderer wrote: > Copy from [1], needed by bpf.h. > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/include/uapi/linux/bpf_common.h?h=v4.19 So bpf.h does include this file, but we don't use anything from it in

Re: [PATCH] davinci_vpfe: add a missing break

2018-11-06 Thread Hans Verkuil
On 11/06/18 11:15, Mauro Carvalho Chehab wrote: > As warned by gcc: > > drivers/staging/media/davinci_vpfe/dm365_ipipeif.c: In function > 'ipipeif_hw_setup': > drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:298:3: warning: this > statement may fall through [-Wimplicit-fallthrough=] >

Re: [PATCH v3 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-06 Thread Dave Stevenson
On Tue, 6 Nov 2018 at 08:00, Sakari Ailus wrote: > > Patch ad608fbcf166 changed how events were subscribed to address an issue > elsewhere. As a side effect of that change, the "add" callback was called > before the event subscription was added to the list of subscribed events, > causing the

Re: [PATCH v2 3/3] media: imx-pxp: Improve pxp_soft_reset() error message

2018-11-06 Thread Philipp Zabel
On Mon, 2018-11-05 at 18:45 -0200, Fabio Estevam wrote: > Improve the pxp_soft_reset() error message by moving it to the > caller function, associating it with a proper device and also > by displaying the error code. > > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - Newly introduced

Re: [PATCH v2 2/3] media: imx-pxp: Check for pxp_soft_reset() error

2018-11-06 Thread Philipp Zabel
On Mon, 2018-11-05 at 18:45 -0200, Fabio Estevam wrote: > pxp_soft_reset() may fail with a timeout, so it is better to propagate > the error in this case. > > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - None > > drivers/media/platform/imx-pxp.c | 12 +--- > 1 file

Re: [PATCH v2 1/3] media: imx-pxp: Check the return value from clk_prepare_enable()

2018-11-06 Thread Philipp Zabel
Hi Fabio, thank you for the fixes! On Mon, 2018-11-05 at 18:45 -0200, Fabio Estevam wrote: > clk_prepare_enable() may fail, so we should better check its return value > and propagate it in the case of error. > > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - Properly enumerate the

Re: [PATCH v3 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-06 Thread Hans Verkuil
On 11/06/2018 09:00 AM, Sakari Ailus wrote: > Patch ad608fbcf166 changed how events were subscribed to address an issue > elsewhere. As a side effect of that change, the "add" callback was called > before the event subscription was added to the list of subscribed events, > causing the first event

Re: [PATCH v7 05/16] intel-ipu3: abi: Add structs

2018-11-06 Thread Sakari Ailus
Cc: linux-media@vger.kernel.org; tf...@chromium.org; mche...@kernel.org; > > hans.verk...@cisco.com; laurent.pinch...@ideasonboard.com; Mani, > > Rajmohan ; Zheng, Jian Xu > > ; Hu, Jerry W ; Toivonen, > > Tuukka ; Qiu, Tian Shu > > ; Cao, Bingbu > > Subject: Re: [PATCH v7 05

<    1   2   3   4   5   6   7   8   9   10   >