Re: [PATCH v7 06/16] intel-ipu3: mmu: Implement driver

2018-11-05 Thread Tomasz Figa
> > Cc: linux-media@vger.kernel.org; tf...@chromium.org; > > mche...@kernel.org; hans.verk...@cisco.com; > > laurent.pinch...@ideasonboard.com; Mani, Rajmohan > > ; Zheng, Jian Xu ; Hu, > > Jerry W ; Toivonen, Tuukka > > ; Qiu, Tian Shu ; Cao, > > Bingbu &g

RE: [PATCH v7 06/16] intel-ipu3: mmu: Implement driver

2018-11-05 Thread Zhi, Yong
.verk...@cisco.com; > laurent.pinch...@ideasonboard.com; Mani, Rajmohan > ; Zheng, Jian Xu ; Hu, > Jerry W ; Toivonen, Tuukka > ; Qiu, Tian Shu ; Cao, > Bingbu > Subject: Re: [PATCH v7 06/16] intel-ipu3: mmu: Implement driver > > Hi Yong, > > On Mon, Oct 29, 2018 at 03:23:0

Re: [RFC] media: imx: queue subdevice events on the video device in the same pipeline

2018-11-05 Thread Steve Longerbeam
Hi Philipp, Thanks, I've been meaning this too. Comments below. On 11/5/18 7:03 AM, Philipp Zabel wrote: While subdevice and video device are in the same pipeline, pass subdevice events on to userspace via the video device node. Signed-off-by: Philipp Zabel --- This would allow to see

Re: [PATCH v2] Input: Add missing event codes for common IR remote buttons

2018-11-05 Thread Sean Young
On Sat, Nov 03, 2018 at 07:55:32AM -0700, Derek Kelly wrote: > The following patch adds event codes for common buttons found on various > provider and universal remote controls. They represent functions not > covered by existing event codes. Once added, rc_keymaps can be updated > accordingly

RE: [PATCH v7 05/16] intel-ipu3: abi: Add structs

2018-11-05 Thread Mani, Rajmohan
.@ideasonboard.com; Mani, > Rajmohan ; Zheng, Jian Xu > ; Hu, Jerry W ; Toivonen, > Tuukka ; Qiu, Tian Shu > ; Cao, Bingbu > Subject: Re: [PATCH v7 05/16] intel-ipu3: abi: Add structs > > Hi Yong, > > On Mon, Oct 29, 2018 at 03:22:59PM -0700, Yong Zhi wrote: >

Re: [PATCH 01/15] media: coda: fix memory corruption in case more than 32 instances are opened

2018-11-05 Thread Ian Arkver
Hi Philipp, On 05/11/2018 15:24, Philipp Zabel wrote: The ffz() return value is undefined if the instance mask does not contain any zeros. If it returned 32, the following set_bit would corrupt the debugfs_root pointer. Switch to IDA for context index allocation. This also removes the

Re: [PATCH 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-05 Thread Dave Stevenson
uot;media: v4l: event: Prevent freeing event subscriptions > while accessed") > > Reported-by: Dave Stevenson > Signed-off-by: Sakari Ailus > --- > Hi Dave, Hans, > > This should address the issue. > > The functions can (and probably should) be re-arranged later but l

Re: [RFC PATCH 00/11] Convert last remaining g/s_crop/cropcap drivers

2018-11-05 Thread Hans Verkuil
On 11/05/2018 05:08 PM, Sylwester Nawrocki wrote: > Hi Hans, > > On 11/05/2018 02:12 PM, Hans Verkuil wrote: >> Thank you for the review. One question: have you also tested this with at >> least >> one of the affected drivers? >> >> I'd like to have at least one Tested-by line. > > I just

Re: [RFC PATCH 00/11] Convert last remaining g/s_crop/cropcap drivers

2018-11-05 Thread Sylwester Nawrocki
Hi Hans, On 11/05/2018 02:12 PM, Hans Verkuil wrote: > Thank you for the review. One question: have you also tested this with at > least > one of the affected drivers? > > I'd like to have at least one Tested-by line. I just tested it now - video playback on Exynos4210 Trats2 so it covers the

Re: [PATCH 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-05 Thread Hans Verkuil
: Prevent freeing event subscriptions > while accessed") > > Reported-by: Dave Stevenson > Signed-off-by: Sakari Ailus > --- > Hi Dave, Hans, > > This should address the issue. > > The functions can (and probably should) be re-arranged later but let's g

Re: [PATCH] media: imx: csi: fix enum_mbus_code for unknown mbus format codes

2018-11-05 Thread Philipp Zabel
Hi Steve, On Fri, 2018-02-09 at 17:43 -0800, Steve Longerbeam wrote: [...] > I *think* by implementing init_cfg in the CSI, it will prevent the > NULL deref in csi_enum_mbus_code(). However I think this patch > is a good idea in any case. Ack on both. Can we still get this patch applied?

Re: VIDIOC_SUBSCRIBE_EVENT for V4L2_EVENT_CTRL regression?

2018-11-05 Thread Sakari Ailus
Hi Dave, Hans, Thanks for reporting the issue! On Mon, Nov 05, 2018 at 01:56:40PM +, Dave Stevenson wrote: > Hi Hans > > On Mon, 5 Nov 2018 at 13:18, Hans Verkuil wrote: > > > > On 11/05/2018 01:21 PM, Dave Stevenson wrote: > > > Hi All > > > > > > I'm testing with 4.19 and finding that

Re: VIDIOC_SUBSCRIBE_EVENT for V4L2_EVENT_CTRL regression?

2018-11-05 Thread Dave Stevenson
Hi Hans On Mon, 5 Nov 2018 at 13:18, Hans Verkuil wrote: > > On 11/05/2018 01:21 PM, Dave Stevenson wrote: > > Hi All > > > > I'm testing with 4.19 and finding that testEvents in v4l2-compliance > > is failing with ""failed to find event for control '%s' type %u", ie > > it hasn't got the event

Re: VIDIOC_SUBSCRIBE_EVENT for V4L2_EVENT_CTRL regression?

2018-11-05 Thread Hans Verkuil
On 11/05/2018 02:18 PM, Hans Verkuil wrote: > On 11/05/2018 01:21 PM, Dave Stevenson wrote: >> Hi All >> >> I'm testing with 4.19 and finding that testEvents in v4l2-compliance >> is failing with ""failed to find event for control '%s' type %u", ie >> it hasn't got the event for the inital values.

Re: VIDIOC_SUBSCRIBE_EVENT for V4L2_EVENT_CTRL regression?

2018-11-05 Thread Hans Verkuil
On 11/05/2018 01:21 PM, Dave Stevenson wrote: > Hi All > > I'm testing with 4.19 and finding that testEvents in v4l2-compliance > is failing with ""failed to find event for control '%s' type %u", ie > it hasn't got the event for the inital values. This is with the > various BCM2835 drivers that

Re: [RFC PATCH 00/11] Convert last remaining g/s_crop/cropcap drivers

2018-11-05 Thread Hans Verkuil
Hi Sylwester, On 11/02/2018 05:16 PM, Sylwester Nawrocki wrote: > Hi Hans, > > On Fri, 5 Oct 2018 at 09:49, Hans Verkuil wrote: >> >> From: Hans Verkuil >> >> This patch series converts the last remaining drivers that use g/s_crop and >> cropcap to g/s_selection. > > Thank you for this clean

Re: [PATCH v7 06/16] intel-ipu3: mmu: Implement driver

2018-11-05 Thread Sakari Ailus
Hi Yong, On Mon, Oct 29, 2018 at 03:23:00PM -0700, Yong Zhi wrote: > From: Tomasz Figa > > This driver translates IO virtual address to physical > address based on two levels page tables. > > Signed-off-by: Tomasz Figa > Signed-off-by: Yong Zhi > --- ... > +static void

Re: [PATCH v7 05/16] intel-ipu3: abi: Add structs

2018-11-05 Thread Sakari Ailus
Hi Yong, On Mon, Oct 29, 2018 at 03:22:59PM -0700, Yong Zhi wrote: > This add all the structs of IPU3 firmware ABI. > > Signed-off-by: Yong Zhi > Signed-off-by: Rajmohan Mani ... > +struct imgu_abi_shd_intra_frame_operations_data { > + struct imgu_abi_acc_operation > +

Re: [RFC] [PATCH] media: rc: Improve responsiveness of Xbox DVD Remote

2018-11-04 Thread Sean Young
On Sun, Nov 04, 2018 at 09:57:46PM +0100, Benjamin Valentin wrote: > The Xbox DVD Remote feels somewhat sluggish, pressing a button > repeatedly is sometimes interpreted as it being kept pressed down. > > It seems like the RC subsystem is doing some incorrect heuristics when > in fact the data

Re: [PATCH v2 2/2] [media] CNF4 pixel format for media subsystem

2018-11-04 Thread Sergey Dorodnic
Hello Laurent, Thank you for the review and the comments. Please modify the subject / description as you see fit. I will make sure to use the right prefix in future submissions. Best regards, Sergey On Thu, Nov 1, 2018 at 9:10 AM Laurent Pinchart wrote: > > Hi Sergey, > > Thank you for the

Re: [Outreachy kernel] [PATCH] staging:media:Add SPDX-License-Identifier

2018-11-03 Thread Himanshu Jha
On Sat, Nov 03, 2018 at 11:16:48AM +, Irenge Jules Bashizi wrote: > Add SPDX-License-Identifier to fix missing license tag checkpatch warning > > Signed-off-by: Irenge Jules Bashizi > --- > drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h | 4 +--- > 1 file changed, 1 insertion(+), 3

Re: [PATCH] Input: Add missing event codes for common IR remote buttons

2018-11-03 Thread kbuild test robot
Hi Derek, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on input/next] [also build test WARNING on v4.19 next-20181102] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [RFC v2 1/4] media: Introduce helpers to fill pixel format structs

2018-11-02 Thread Nicolas Dufresne
Le vendredi 02 novembre 2018 à 12:52 -0300, Ezequiel Garcia a écrit : > Add two new API helpers, v4l2_fill_pixfmt and v4l2_fill_pixfmt_mp, > to be used by drivers to calculate plane sizes and bytes per lines. > > Note that driver-specific paddig and alignment are not yet > taken into account. >

Re: VIVID/VIMC and media fuzzing

2018-11-02 Thread Dmitry Vyukov
On Wed, Oct 31, 2018 at 12:01 PM, Sean Young wrote: > On Wed, Oct 31, 2018 at 11:05:10AM +0100, Hans Verkuil wrote: >> CC-ing Sean Young: please see question at the end. >> >> On 10/31/2018 10:46 AM, Hans Verkuil wrote: >> > On 10/30/2018 03:02 PM, Dmitry Vyukov wrote: >> >> Hello Helen and

Re: VIVID/VIMC and media fuzzing

2018-11-02 Thread Dmitry Vyukov
On Wed, Oct 31, 2018 at 10:46 AM, Hans Verkuil wrote: > On 10/30/2018 03:02 PM, Dmitry Vyukov wrote: >> Hello Helen and linux-media, >> >> I've attended your talk "Shifting Media App Development into High >> Gear" on OSS Summit last week and approached you with some questions >> if/how this can

Re: [RFC PATCH 10/11] v4l2-ioctl: remove unused vidioc_g/s_crop

2018-11-02 Thread Sylwester Nawrocki
On Fri, 5 Oct 2018 at 09:49, Hans Verkuil wrote: > > From: Hans Verkuil > > Now that all drivers have dropped vidioc_g/s_crop we can remove > support for them in the V4L2 core. > > Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki

Re: [RFC PATCH 08/11] exynos4-is: convert g/s_crop to g/s_selection

2018-11-02 Thread Sylwester Nawrocki
On Fri, 5 Oct 2018 at 09:49, Hans Verkuil wrote: > > From: Hans Verkuil > > Replace g/s_crop by g/s_selection and set the V4L2_FL_QUIRK_INVERTED_CROP > flag since this is one of the old drivers that predates the selection > API. Those old drivers allowed g_crop when it really shouldn't have

Re: [RFC PATCH 09/11] s5p-g2d: convert g/s_crop to g/s_selection

2018-11-02 Thread Sylwester Nawrocki
On Fri, 5 Oct 2018 at 09:49, Hans Verkuil wrote: > > From: Hans Verkuil > > Replace g/s_crop by g/s_selection and set the V4L2_FL_QUIRK_INVERTED_CROP > flag since this is one of the old drivers that predates the selection > API. Those old drivers allowed g_crop when it really shouldn't have

Re: [RFC PATCH 07/11] s5p_mfc_dec.c: convert g_crop to g_selection

2018-11-02 Thread Sylwester Nawrocki
On Fri, 5 Oct 2018 at 09:49, Hans Verkuil wrote: > > From: Hans Verkuil > > The g_crop really implemented composition for the CAPTURE stream. > > Replace g_crop by g_selection and set the V4L2_FL_QUIRK_INVERTED_CROP > flag since this is one of the old drivers that predates the selection > API.

Re: [RFC PATCH 06/11] exynos-gsc: replace v4l2_crop by v4l2_selection

2018-11-02 Thread Sylwester Nawrocki
On Fri, 5 Oct 2018 at 09:49, Hans Verkuil wrote: > > From: Hans Verkuil > > Replace the use of struct v4l2_crop by struct v4l2_selection. > Also drop the unused gsc_g_crop function. > > Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki

Re: [RFC PATCH 03/11] v4l2-ioctl: add QUIRK_INVERTED_CROP

2018-11-02 Thread Sylwester Nawrocki
On Fri, 5 Oct 2018 at 09:49, Hans Verkuil wrote: > > From: Hans Verkuil > > Some old Samsung drivers use the legacy crop API incorrectly: > the crop and compose targets are swapped. Normally VIDIOC_G_CROP > will return the CROP rectangle of a CAPTURE stream and the COMPOSE > rectangle of an

Re: [RFC PATCH 01/11] v4l2-ioctl: don't use CROP/COMPOSE_ACTIVE

2018-11-02 Thread Sylwester Nawrocki
On Fri, 5 Oct 2018 at 09:49, Hans Verkuil wrote: > > From: Hans Verkuil > > Drop the deprecated _ACTIVE part. > > Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki

Re: [RFC PATCH 00/11] Convert last remaining g/s_crop/cropcap drivers

2018-11-02 Thread Sylwester Nawrocki
Hi Hans, On Fri, 5 Oct 2018 at 09:49, Hans Verkuil wrote: > > From: Hans Verkuil > > This patch series converts the last remaining drivers that use g/s_crop and > cropcap to g/s_selection. Thank you for this clean up! I remember attempting conversion of those remaining drivers to selection API

Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-02 Thread Tomasz Figa
Hi Mauro, On Fri, Nov 2, 2018 at 10:49 PM Mauro Carvalho Chehab wrote: > > Em Mon, 29 Oct 2018 15:22:57 -0700 > Yong Zhi escreveu: [snip] > > +struct ipu3_uapi_awb_config_s { > > + __u16 rgbs_thr_gr; > > + __u16 rgbs_thr_r; > > + __u16 rgbs_thr_gb; > > + __u16 rgbs_thr_b; > > +

Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-02 Thread Mauro Carvalho Chehab
Em Mon, 29 Oct 2018 15:22:57 -0700 Yong Zhi escreveu: > These meta formats are used on Intel IPU3 ImgU video queues > to carry 3A statistics and ISP pipeline parameters. Just minor things. See below. > > V4L2_META_FMT_IPU3_3A > V4L2_META_FMT_IPU3_PARAMS > > Signed-off-by: Yong Zhi >

Re: [PATCH v7 01/16] v4l: Add Intel IPU3 meta buffer formats

2018-11-02 Thread Mauro Carvalho Chehab
Em Fri, 2 Nov 2018 09:59:31 -0300 Mauro Carvalho Chehab escreveu: > Hi Zhi-san, > > Em Mon, 29 Oct 2018 15:22:55 -0700 > Yong Zhi escreveu: > > > Add IPU3-specific meta formats for parameter > > processing and 3A, DVS statistics: > > > > V4L2_META_FMT_IPU3_PARAMS > >

Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-02 Thread Sakari Ailus
Hi Yong, Thanks for the update! I went through this again... a few comments below but I'd say they're mostly pretty minor issues. On Mon, Oct 29, 2018 at 03:22:57PM -0700, Yong Zhi wrote: > These meta formats are used on Intel IPU3 ImgU video queues > to carry 3A statistics and ISP pipeline

Re: [PATCH v7 01/16] v4l: Add Intel IPU3 meta buffer formats

2018-11-02 Thread Mauro Carvalho Chehab
Hi Zhi-san, Em Mon, 29 Oct 2018 15:22:55 -0700 Yong Zhi escreveu: > Add IPU3-specific meta formats for parameter > processing and 3A, DVS statistics: > > V4L2_META_FMT_IPU3_PARAMS > V4L2_META_FMT_IPU3_STAT_3A > > Signed-off-by: Yong Zhi > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 2

Re: i.MX6: can't capture on MIPI-CSI2 with DS90UB954

2018-11-02 Thread jacopo mondi
nce" (as defined by D-PHY specs), while as you reported, my understanding is that your trace shows LP signals, before any HS data transmission happens (in the right side of your trace, if I got this rigth) and we should see a stable LP-11 state transitioning to LP01 and then LP00. From my ex

Re: i.MX6: can't capture on MIPI-CSI2 with DS90UB954

2018-11-02 Thread Jean-Michel Hautbois
Hi Steve, Le mer. 31 oct. 2018 à 22:52, Steve Longerbeam a écrit : > > Hi Jean-Michel, > > We've done some work with another FPD-Link de-serializer (ds90ux940) and > IIRC we had some trouble figuring out how to coax the lanes into LP-11 > state. But on the ds90ux940 it can be done by setting bit

Re: [PATCH v2 2/2] [media] CNF4 pixel format for media subsystem

2018-11-01 Thread Laurent Pinchart
Hi Sergey, Thank you for the patch. As for patch 1/2, the subject line needs a prefix. Furthermore it doesn't really describe the patch. I propose writing it as media: uvcvideo: Add support for the CNF4 format On Wednesday, 12 September 2018 09:42:07 EET dorod...@gmail.com wrote: > From:

Re: [PATCH v2 1/2] [media] CNF4 fourcc for 4 bit-per-pixel packed depth confidence information

2018-11-01 Thread Laurent Pinchart
Hi Sergey, Thank you for the patch. The subject line should start with an appropriate prefix. I propose rewriting it as media: v4l: Add 4bpp packed depth confidence format CNF4 Apart from that the patch looks good to me, Reviewed-by: Laurent Pinchart If you're fine with the subject line

Re: [PATCH] media: rc: self test for IR encoders and decoders

2018-11-01 Thread Sean Young
Hi Shuah, On Thu, Nov 01, 2018 at 08:59:39AM -0600, Shuah Khan wrote: > On 10/16/2018 08:09 AM, Sean Young wrote: > > ir-loopback can transmit IR on one rc device and check the correct > > scancode and protocol is decoded on a different rc device. This can be > > used to check IR transmission

Re: [PATCH] media: rc: self test for IR encoders and decoders

2018-11-01 Thread Shuah Khan
On 10/16/2018 08:09 AM, Sean Young wrote: > ir-loopback can transmit IR on one rc device and check the correct > scancode and protocol is decoded on a different rc device. This can be > used to check IR transmission between two rc devices. Using rc-loopback, > we use it to check the IR encoders

Re: [PATCH v2 0/2] [media] Depth confidence pixel-format for Intel RealSense cameras

2018-11-01 Thread Sergey Dorodnic
Hello Hans, Laurent Could you please comment on this topic? If the patches require any additional work, we will be eager to address it. For now we are publishing a custom DKMS, but it would be great to see better 3D-camera hardware support in the near future. Regards, Sergey (sorry, re-sending

Re: i.MX6: can't capture on MIPI-CSI2 with DS90UB954

2018-11-01 Thread Vladimir Zapolskiy
Hi Jean-Michel, On 10/30/2018 06:41 PM, Jean-Michel Hautbois wrote: > Hi there, > > I am using the i.MX6D from Digi (connect core 6 sbc) with a mailine > kernel (well, 4.14 right now) and have an issue with mipi-csi2 > capture. > First I will give brief explanation of my setup, and then I will >

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-01 Thread Sakari Ailus
ODOs: > - Documentation on ImgU driver programming interface to configure and enable > ISP HW, which will include details on complete V4L2 Kernel driver interface > and IO-Control parameters, except for the ISP internal algorithm and its > parameters (which is Intel proprieta

Re: uvcvideo: IR camera lights only every second frame

2018-11-01 Thread Ricardo Ribalda Delgado
Hi On Tue, Oct 30, 2018 at 4:49 PM Kieran Bingham wrote: > > Hi Jiri, > > On 30/10/2018 14:36, Jiri Slaby wrote: > > Hi, > > > > I have a Dell Lattitude 7280 with two webcams. The standard one works > > fine (/dev/video0). The other one is an IR camera (/dev/video1). The > > camera proper works

Re: VIVID/VIMC and media fuzzing

2018-10-31 Thread Tomasz Figa
Hi Dmitry, On Wed, Oct 31, 2018 at 6:46 PM Hans Verkuil wrote: > > On 10/30/2018 03:02 PM, Dmitry Vyukov wrote: [snip] > > > > Do I understand it correctly that when a process opens /dev/video* or > > /dev/media* it gets a private instance of the device? In particular, > > if several processes

Re: i.MX6: can't capture on MIPI-CSI2 with DS90UB954

2018-10-31 Thread Steve Longerbeam
Hi Jean-Michel, We've done some work with another FPD-Link de-serializer (ds90ux940) and IIRC we had some trouble figuring out how to coax the lanes into LP-11 state. But on the ds90ux940 it can be done by setting bit 7 in the CSI Enable Port registers (offsets 0x13 and 0x14). But the

Re: VIVID/VIMC and media fuzzing

2018-10-31 Thread Helen Koike
Hi Dmitry, On 10/31/18 7:46 AM, Hans Verkuil wrote: > On 10/30/2018 03:02 PM, Dmitry Vyukov wrote: >> Hello Helen and linux-media, >> >> I've attended your talk "Shifting Media App Development into High >> Gear" on OSS Summit last week and approached you with some questions >> if/how this can be

Re: VIVID/VIMC and media fuzzing

2018-10-31 Thread Sean Young
On Wed, Oct 31, 2018 at 11:05:10AM +0100, Hans Verkuil wrote: > CC-ing Sean Young: please see question at the end. > > On 10/31/2018 10:46 AM, Hans Verkuil wrote: > > On 10/30/2018 03:02 PM, Dmitry Vyukov wrote: > >> Hello Helen and linux-media, > >> > >> I've attended your talk "Shifting Media

Re: [PATCH 4/4] SoC camera: Tidy the header

2018-10-31 Thread Mauro Carvalho Chehab
Em Wed, 31 Oct 2018 11:00:22 +0100 Hans Verkuil escreveu: > On 10/31/2018 10:40 AM, Mauro Carvalho Chehab wrote: > > Em Wed, 31 Oct 2018 11:29:45 +0200 > > Sakari Ailus escreveu: > > > >> Hi Mauro, > >> > >> On Tue, Oct 30, 2018 at 09:06:18AM -0300, Mauro Carvalho Chehab wrote: > >>> Em

Re: VIVID/VIMC and media fuzzing

2018-10-31 Thread Hans Verkuil
CC-ing Sean Young: please see question at the end. On 10/31/2018 10:46 AM, Hans Verkuil wrote: > On 10/30/2018 03:02 PM, Dmitry Vyukov wrote: >> Hello Helen and linux-media, >> >> I've attended your talk "Shifting Media App Development into High >> Gear" on OSS Summit last week and approached you

Re: [PATCH 3/4] SoC camera: Remove the framework and the drivers

2018-10-31 Thread Mauro Carvalho Chehab
Em Wed, 31 Oct 2018 11:32:02 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Tue, Oct 30, 2018 at 05:35:23PM -0300, Mauro Carvalho Chehab wrote: > > Em Tue, 30 Oct 2018 21:28:57 +0100 > > jacopo mondi escreveu: > > > > > Hi Mauro, > > > > > > On Tue, Oct 30, 2018 at 09:14:09AM -0300, Mauro

Re: [PATCH 4/4] SoC camera: Tidy the header

2018-10-31 Thread Hans Verkuil
On 10/31/2018 10:40 AM, Mauro Carvalho Chehab wrote: > Em Wed, 31 Oct 2018 11:29:45 +0200 > Sakari Ailus escreveu: > >> Hi Mauro, >> >> On Tue, Oct 30, 2018 at 09:06:18AM -0300, Mauro Carvalho Chehab wrote: >>> Em Tue, 30 Oct 2018 01:00:29 +0200 >>> Sakari Ailus escreveu: >>> Clean up

Re: [PATCH 4/4] SoC camera: Tidy the header

2018-10-31 Thread Sakari Ailus
On Wed, Oct 31, 2018 at 06:40:30AM -0300, Mauro Carvalho Chehab wrote: > Em Wed, 31 Oct 2018 11:29:45 +0200 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > On Tue, Oct 30, 2018 at 09:06:18AM -0300, Mauro Carvalho Chehab wrote: > > > Em Tue, 30 Oct 2018 01:00:29 +0200 > > > Sakari Ailus

Re: [PATCH 2/4] tw9910: No SoC camera dependency

2018-10-31 Thread Hans Verkuil
On 10/31/2018 10:49 AM, Sakari Ailus wrote: > On Tue, Oct 30, 2018 at 01:03:18PM +0100, Hans Verkuil wrote: >> On 10/30/2018 12:00 AM, Sakari Ailus wrote: >>> The tw9910 driver does not depend on SoC camera framework. Don't include >>> the header, but instead include media/v4l2-async.h which the

Re: [PATCH 2/4] tw9910: No SoC camera dependency

2018-10-31 Thread Sakari Ailus
On Tue, Oct 30, 2018 at 01:03:18PM +0100, Hans Verkuil wrote: > On 10/30/2018 12:00 AM, Sakari Ailus wrote: > > The tw9910 driver does not depend on SoC camera framework. Don't include > > the header, but instead include media/v4l2-async.h which the driver really > > needs. > > You might want to

Re: VIVID/VIMC and media fuzzing

2018-10-31 Thread Hans Verkuil
On 10/30/2018 03:02 PM, Dmitry Vyukov wrote: > Hello Helen and linux-media, > > I've attended your talk "Shifting Media App Development into High > Gear" on OSS Summit last week and approached you with some questions > if/how this can be used for kernel testing. Thanks, turn out to be a > very

Re: [PATCH 4/4] SoC camera: Tidy the header

2018-10-31 Thread Mauro Carvalho Chehab
Em Wed, 31 Oct 2018 11:29:45 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Tue, Oct 30, 2018 at 09:06:18AM -0300, Mauro Carvalho Chehab wrote: > > Em Tue, 30 Oct 2018 01:00:29 +0200 > > Sakari Ailus escreveu: > > > > > Clean up the SoC camera framework header. It only exists now to keep

Re: [PATCH 3/4] SoC camera: Remove the framework and the drivers

2018-10-31 Thread Sakari Ailus
Hi Mauro, On Tue, Oct 30, 2018 at 05:35:23PM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 30 Oct 2018 21:28:57 +0100 > jacopo mondi escreveu: > > > Hi Mauro, > > > > On Tue, Oct 30, 2018 at 09:14:09AM -0300, Mauro Carvalho Chehab wrote: > > > Em Tue, 30 Oct 2018 01:21:34 +0200 > > > Sakari

Re: [PATCH 4/4] SoC camera: Tidy the header

2018-10-31 Thread Sakari Ailus
Hi Mauro, On Tue, Oct 30, 2018 at 09:06:18AM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 30 Oct 2018 01:00:29 +0200 > Sakari Ailus escreveu: > > > Clean up the SoC camera framework header. It only exists now to keep board > > code compiling. The header can be removed once the board code

Re: [PATCH 3/4] SoC camera: Remove the framework and the drivers

2018-10-31 Thread Hans Verkuil
On 10/30/2018 10:17 PM, jacopo mondi wrote: > On Tue, Oct 30, 2018 at 05:35:23PM -0300, Mauro Carvalho Chehab wrote: >> Em Tue, 30 Oct 2018 21:28:57 +0100 >> jacopo mondi escreveu: >> >>> Hi Mauro, >>> >>> On Tue, Oct 30, 2018 at 09:14:09AM -0300, Mauro Carvalho Chehab wrote: Em Tue, 30 Oct

Re: [PATCH] lirc.4: remove ioctls and feature bits which were never implemented

2018-10-30 Thread Michael Kerrisk (man-pages)
Hello Sean, On 4/23/18 12:26 PM, Sean Young wrote:> The lirc header file included ioctls and feature bits which were never > implemented by any driver. They were removed in commit: > >

Re: [PATCH v3 2/9] media: tvp5150: fix irq_request error path during probe

2018-10-30 Thread Laurent Pinchart
Hi Marco, Thank you for the patch. On Tuesday, 18 September 2018 16:14:46 EEST Marco Felsch wrote: > Commit 37c65802e76a ("media: tvp5150: Add sync lock interrupt handling") > introduced the interrupt handling. But we have to free the > v4l2_ctrl_handler before we can return the error code. > >

Re: [PATCH v2 6/6] dt-bindings: media: mt9m111: add pclk-sample property

2018-10-30 Thread Rob Herring
On Mon, 29 Oct 2018 19:24:10 +0100, Marco Felsch wrote: > Add the pclk-sample property to the list of optional properties > for the mt9m111 camera sensor. > > Signed-off-by: Marco Felsch > --- > Documentation/devicetree/bindings/media/i2c/mt9m111.txt | 5 + > 1 file changed, 5 insertions(+)

Re: [PATCH v2 5/6] dt-bindings: media: mt9m111: adapt documentation to be more clear

2018-10-30 Thread Rob Herring
On Mon, Oct 29, 2018 at 07:24:09PM +0100, Marco Felsch wrote: > Replace the vague binding by a more verbose. Remove the remote property > from the example since the driver don't support such a property. Also > remove the bus-width property from the endpoint since the driver don't > take care of

Re: [PATCH 3/4] SoC camera: Remove the framework and the drivers

2018-10-30 Thread jacopo mondi
On Tue, Oct 30, 2018 at 05:35:23PM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 30 Oct 2018 21:28:57 +0100 > jacopo mondi escreveu: > > > Hi Mauro, > > > > On Tue, Oct 30, 2018 at 09:14:09AM -0300, Mauro Carvalho Chehab wrote: > > > Em Tue, 30 Oct 2018 01:21:34 +0200 > > > Sakari Ailus

Re: [PATCH 3/4] SoC camera: Remove the framework and the drivers

2018-10-30 Thread jacopo mondi
Hi Mauro, On Tue, Oct 30, 2018 at 09:14:09AM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 30 Oct 2018 01:21:34 +0200 > Sakari Ailus escreveu: > > > The SoC camera framework has been obsolete for some time and it is no > > longer functional. A few drivers have been converted to the V4L2 > >

Re: uvcvideo: IR camera lights only every second frame

2018-10-30 Thread Laurent Pinchart
Hello, On Tuesday, 30 October 2018 17:48:12 EET Kieran Bingham wrote: > On 30/10/2018 14:36, Jiri Slaby wrote: > > Hi, > > > > I have a Dell Lattitude 7280 with two webcams. The standard one works > > fine (/dev/video0). The other one is an IR camera (/dev/video1). The > > camera proper works

Re: uvcvideo: IR camera lights only every second frame

2018-10-30 Thread Kieran Bingham
Hi Jiri, On 30/10/2018 14:36, Jiri Slaby wrote: > Hi, > > I have a Dell Lattitude 7280 with two webcams. The standard one works > fine (/dev/video0). The other one is an IR camera (/dev/video1). The > camera proper works fine and produces 340x374 frames. But there is an IR > led supposed to

Re: [PATCH 4/4] SoC camera: Tidy the header

2018-10-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Oct 2018 01:00:29 +0200 Sakari Ailus escreveu: > Clean up the SoC camera framework header. It only exists now to keep board > code compiling. The header can be removed once the board code dependencies > to it has been removed. > > Signed-off-by: Sakari Ailus > --- >

Re: [PATCH 3/4] SoC camera: Remove the framework and the drivers

2018-10-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Oct 2018 01:21:34 +0200 Sakari Ailus escreveu: > The SoC camera framework has been obsolete for some time and it is no > longer functional. A few drivers have been converted to the V4L2 > sub-device API but for the rest the conversion has not taken place yet. > > In order to keep the

Re: Adding to input-event-codes.h - feedback welcome

2018-10-30 Thread Mauro Carvalho Chehab
Em Tue, 23 Oct 2018 06:55:13 -0700 VDR User escreveu: > Hi, > > I've noticed a lot of common & useful remote control buttons are > missing. I'd like to suggest or submit patches to add some of them > since Linux is so wildly used for media playback (via remote > controls). I've spoken to Sean

Re: [PATCH] dvb: Allow MAC addresses to be mapped to stable device names with udev

2018-10-30 Thread Mauro Carvalho Chehab
Em Mon, 24 Sep 2018 11:10:31 +0100 David Howells escreveu: > Some devices, such as the DVBSky S952 and T982 cards, are dual port cards > that provide two cx23885 devices on the same PCI device, which means the > attributes available for writing udev rules are exactly the same, apart > from the

Re: [PATCH 3/4] SoC camera: Remove the framework and the drivers

2018-10-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Oct 2018 09:06:08 -0300 Mauro Carvalho Chehab escreveu: > Em Tue, 30 Oct 2018 06:43:41 -0300 > Mauro Carvalho Chehab escreveu: Please ignore this e-mail. I'm experiencing some e-mail troubles today. Will resend it properly. Regards, Mauro

Re: [PATCH 3/4] SoC camera: Remove the framework and the drivers

2018-10-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Oct 2018 06:43:41 -0300 Mauro Carvalho Chehab escreveu: > Em Tue, 30 Oct 2018 01:21:34 +0200 > Sakari Ailus escreveu: > > > The SoC camera framework has been obsolete for some time and it is no > > longer functional. A few drivers have been converted to the V4L2 > > sub-device API

Re: [PATCH 4/4] SoC camera: Tidy the header

2018-10-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Oct 2018 01:00:29 +0200 Sakari Ailus escreveu: > Clean up the SoC camera framework header. It only exists now to keep board > code compiling. The header can be removed once the board code dependencies > to it has been removed. > > Signed-off-by: Sakari Ailus > --- >

Re: [PATCH 3/4] SoC camera: Remove the framework and the drivers

2018-10-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Oct 2018 01:21:34 +0200 Sakari Ailus escreveu: > The SoC camera framework has been obsolete for some time and it is no > longer functional. A few drivers have been converted to the V4L2 > sub-device API but for the rest the conversion has not taken place yet. > > In order to keep the

Re: [PATCH 2/4] tw9910: No SoC camera dependency

2018-10-30 Thread Hans Verkuil
On 10/30/2018 12:00 AM, Sakari Ailus wrote: > The tw9910 driver does not depend on SoC camera framework. Don't include > the header, but instead include media/v4l2-async.h which the driver really > needs. You might want to make a note of the fact that soc_camera.h includes v4l2-async.h, so

Re: [PATCH v4 00/22] i.MX media mem2mem scaler

2018-10-30 Thread Philipp Zabel
Hi Steve, On Fri, 2018-10-19 at 11:51 -0700, Steve Longerbeam wrote: > Awesome, thanks Philipp. > > For the whole series: > > Acked-by: Steve Longerbeam > Tested-by: Steve Longerbeam > on i.MX6q SabreSD. Thank you. I have added the tags where it made sense to me and applied the ipu-v3

Re: [PATCH] media: dvb: fix a missing-check bug

2018-10-29 Thread Bing Bu Cao
copied again from the user space. >> However, after the copy, no check is re-enforced on the first byte of the >> copied data. Given that 'buf' is in the user space, a malicious user can >> race to change the first byte after the check in dvb_audio_write() but >> before the co

Re: [PATCH] lirc.4: remove ioctls and feature bits which were never implemented

2018-10-29 Thread Alec Leamas
Hi all, On 29/10/18 18:30, Sean Young wrote: > Hi Michael, > > On Thu, Jul 12, 2018 at 02:21:18PM +0100, Sean Young wrote: >> On Thu, Jul 12, 2018 at 09:33:32AM -0300, Mauro Carvalho Chehab wrote: >>> Hi Michael/Alec, >>> >>> Em Fri, 18 May 2018 16:25:29 +0100 >>> Sean Young escreveu: >>>

Re: [PATCH v3 0/9] TVP5150 fixes and new features

2018-10-29 Thread Marco Felsch
Hi Mauro, just a reminder, Rob already added his ack/rev-by tags. Thanks, Marco On 18-09-18 15:14, Marco Felsch wrote: > Hi, > > this is my v3 with the integrated reviews from my v2 [1]. This serie > applies to Mauro's experimental.git [2]. > > @Mauro: > Patch ("media: tvp5150: fix

Re: [PATCH] lirc.4: remove ioctls and feature bits which were never implemented

2018-10-29 Thread Sean Young
Hi Michael, On Thu, Jul 12, 2018 at 02:21:18PM +0100, Sean Young wrote: > On Thu, Jul 12, 2018 at 09:33:32AM -0300, Mauro Carvalho Chehab wrote: > > Hi Michael/Alec, > > > > Em Fri, 18 May 2018 16:25:29 +0100 > > Sean Young escreveu: > > > > > On Sun, May 06, 2018 at 12:34:53PM +0200, Michael

Re: [PATCH v4 3/6] media: v4l2-common: add V4L2_FRACT_COMPARE

2018-10-28 Thread Matt Ranostay
On Sun, Oct 28, 2018 at 9:25 AM Akinobu Mita wrote: > > 2018年10月28日(日) 12:49 Matt Ranostay : > > > > On Sat, Oct 20, 2018 at 7:26 AM Akinobu Mita wrote: > > > > > > Add macro to compare two v4l2_fract values in v4l2 common internal API. > > > The same macro FRACT_CMP() is used by vivid and

Re: [PATCH v4 3/6] media: v4l2-common: add V4L2_FRACT_COMPARE

2018-10-28 Thread Akinobu Mita
2018年10月28日(日) 12:49 Matt Ranostay : > > On Sat, Oct 20, 2018 at 7:26 AM Akinobu Mita wrote: > > > > Add macro to compare two v4l2_fract values in v4l2 common internal API. > > The same macro FRACT_CMP() is used by vivid and bcm2835-camera. This just > > renames it to V4L2_FRACT_COMPARE in order

Re: [PATCH v4 5/6] media: video-i2c: support changing frame interval

2018-10-28 Thread Akinobu Mita
2018年10月28日(日) 12:39 Matt Ranostay : > > On Sat, Oct 20, 2018 at 7:26 AM Akinobu Mita wrote: > > > > AMG88xx has a register for setting frame rate 1 or 10 FPS. > > This adds support changing frame interval. > > > > Reference specifications: > >

Re: Kaffeine: cool pull request in GitHub

2018-10-28 Thread Mauro Carvalho Chehab
Hi Antoni, Em Sun, 28 Oct 2018 01:02:39 +0200 Antoni Bella Pérez escreveu: > Hi > > I found three pull request in GitHub and this code has not been included in > the master branch. > > > > * Fix audio CD playing >

Re: [PATCH v4 3/6] media: v4l2-common: add V4L2_FRACT_COMPARE

2018-10-27 Thread Matt Ranostay
On Sat, Oct 20, 2018 at 7:26 AM Akinobu Mita wrote: > > Add macro to compare two v4l2_fract values in v4l2 common internal API. > The same macro FRACT_CMP() is used by vivid and bcm2835-camera. This just > renames it to V4L2_FRACT_COMPARE in order to avoid namespace collision. > > Cc: Matt

Re: [PATCH v4 5/6] media: video-i2c: support changing frame interval

2018-10-27 Thread Matt Ranostay
On Sat, Oct 20, 2018 at 7:26 AM Akinobu Mita wrote: > > AMG88xx has a register for setting frame rate 1 or 10 FPS. > This adds support changing frame interval. > > Reference specifications: > https://docid81hrs3j1.cloudfront.net/medialibrary/2017/11/PANA-S-A0002141979-1.pdf > > Cc: Matt Ranostay

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-10-27 Thread Nicolas Dufresne
Le lundi 22 octobre 2018 à 12:37 +0900, Tomasz Figa a écrit : > Hi Philipp, > > On Mon, Oct 22, 2018 at 1:28 AM Philipp Zabel wrote: > > > > On Wed, Oct 03, 2018 at 05:24:39PM +0900, Tomasz Figa wrote: > > [...] > > > > Yes, but that would fall in a complete redesign I guess. The buffer > > > >

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-10-26 Thread Laurent Pinchart
Hi Tomasz, On Friday, 26 October 2018 14:41:26 EEST Tomasz Figa wrote: > On Thu, Sep 20, 2018 at 11:42 PM Hans Verkuil wrote: > > Some parts of the V4L2 API are awkward to use and I think it would be > > a good idea to look at possible candidates for that. > > > > Examples are the ioctls that

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-10-26 Thread Tomasz Figa
On Thu, Sep 20, 2018 at 11:42 PM Hans Verkuil wrote: > > Some parts of the V4L2 API are awkward to use and I think it would be > a good idea to look at possible candidates for that. > > Examples are the ioctls that use struct v4l2_buffer: the multiplanar support > is > really horrible, and

Re: [PATCH 1/2] vicodec: Have decoder propagate changes to the CAPTURE queue

2018-10-26 Thread Tomasz Figa
On Fri, Oct 19, 2018 at 10:00 PM Ezequiel Garcia wrote: > > On Fri, 2018-10-19 at 09:14 +0200, Hans Verkuil wrote: > > On 10/18/2018 06:08 PM, Ezequiel Garcia wrote: > > > The decoder interface (not yet merged) specifies that > > > width and height values set on the OUTPUT queue, must > > > be

Re: [PATCH] [bug/urgent] dvb-usb-v2: Fix incorrect use of transfer_flags URB_FREE_BUFFER

2018-10-24 Thread Malcolm Priestley
edia/usb/dvb-usb-v2/usb_urb.c > b/drivers/media/usb/dvb-usb-v2/usb_urb.c > index 024c751eb165..2ad2ddeaff51 100644 > --- a/drivers/media/usb/dvb-usb-v2/usb_urb.c > +++ b/drivers/media/usb/dvb-usb-v2/usb_urb.c > @@ -155,7 +155,6 @@ static int usb_urb_alloc_bulk_urbs(struct usb_data_stream > *stream) Re sending email line wrap corruption

Re: [PATCH v3 01/16] media: imx: add mem2mem device

2018-10-23 Thread Steve Longerbeam
(resending as plain text) On 10/21/18 10:43 AM, Philipp Zabel wrote: On Fri, Oct 19, 2018 at 01:19:10PM -0700, Steve Longerbeam wrote: On 10/19/18 2:53 AM, Philipp Zabel wrote: Hi Tim, On Thu, 2018-10-18 at 15:53 -0700, Tim Harvey wrote: [...] Philipp, Thanks for submitting this! I'm

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-10-23 Thread Philipp Zabel
Hi Tomasz, On Mon, Oct 22, 2018 at 12:37:57PM +0900, Tomasz Figa wrote: [...] > On Mon, Oct 22, 2018 at 1:28 AM Philipp Zabel wrote: [...] > > REQBUFS 0 fails if the vb2 buffer is still in use, including from dmabuf > > attachments: vb2_buffer_in_use checks the num_users memop. The refcount > >

Re: [RFC] Informal meeting during ELCE to discuss userspace support for stateless codecs

2018-10-23 Thread Mauro Carvalho Chehab
Em Mon, 22 Oct 2018 22:21:04 +0100 Hans Verkuil escreveu: > On 10/22/2018 10:17 PM, Hans Verkuil wrote: > > A quick update: > > > > As said in my previous email: we'll meet at 11 am at the registration desk. > > From there we go to the Platform 5 Cafe. If that's too crowded/noisy, then > >

<    1   2   3   4   5   6   7   8   9   10   >