RE: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

2009-12-11 Thread Karicheri, Muralidharan
o:khil...@deeprootsystems.com] >Sent: Friday, December 11, 2009 1:35 PM >To: Karicheri, Muralidharan >Cc: davinci-linux-open-sou...@linux.davincidsp.com; linux- >me...@vger.kernel.org >Subject: Re: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable > >"Karicheri, Muralidharan&quo

Re: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

2009-12-11 Thread Kevin Hilman
"Karicheri, Muralidharan" writes: >>> Kevin, >>> >>> I think I have figured it out... >>> >>> First issue was that I was adding my entry at the end of dm644x_clks[] >>> array. I need to add it before the CLK(NULL, NULL, NULL) >>> >>> secondly, your suggestion didn't work as is. This is what I had

RE: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

2009-12-10 Thread Karicheri, Muralidharan
>> Kevin, >> >> I think I have figured it out... >> >> First issue was that I was adding my entry at the end of dm644x_clks[] >> array. I need to add it before the CLK(NULL, NULL, NULL) >> >> secondly, your suggestion didn't work as is. This is what I had to >> do to get it working... >> >> static

RE: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

2009-12-10 Thread Karicheri, Muralidharan
>> I thought following is correct:- >> Probe() >> clk_get() followed by clk_enable() >> Remove() >> clk_disable() followed by clk_put() >> Suspend() >> clk_disable() >> Resume() >> clk_enable() > >Yes, that is correct. > >I didn't look at the whole driver. My concern was that if the driver >was e

Re: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

2009-12-10 Thread Kevin Hilman
"Karicheri, Muralidharan" writes: > Kevin, > > I think I have figured it out... > > First issue was that I was adding my entry at the end of dm644x_clks[] > array. I need to add it before the CLK(NULL, NULL, NULL) > > secondly, your suggestion didn't work as is. This is what I had to > do to get

Re: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

2009-12-10 Thread Kevin Hilman
"Karicheri, Muralidharan" writes: > Kevin, > >>> +/** >>> + * vpfe_disable_clock() - Disable clocks for vpfe capture driver >>> + * @vpfe_dev - ptr to vpfe capture device >>> + * >>> + * Disables clocks defined in vpfe configuration. >>> + */ >>> static void vpfe_disable_clock(struct vpfe_device

RE: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

2009-12-09 Thread Karicheri, Muralidharan
phone: 301-407-9583 email: m-kariche...@ti.com >-Original Message- >From: Karicheri, Muralidharan >Sent: Wednesday, December 09, 2009 1:22 PM >To: Karicheri, Muralidharan; Kevin Hilman >Cc: davinci-linux-open-sou...@linux.davincidsp.com; linux- >me...@vger.kernel.org >Subject:

RE: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

2009-12-09 Thread Karicheri, Muralidharan
Wednesday, December 09, 2009 12:45 PM >To: Kevin Hilman >Cc: davinci-linux-open-sou...@linux.davincidsp.com; linux- >me...@vger.kernel.org >Subject: RE: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable > >Kevin, > >>> +/** >>> + * vpfe_disable_clock() - Disable clo

RE: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

2009-12-09 Thread Karicheri, Muralidharan
Kevin, >> +/** >> + * vpfe_disable_clock() - Disable clocks for vpfe capture driver >> + * @vpfe_dev - ptr to vpfe capture device >> + * >> + * Disables clocks defined in vpfe configuration. >> + */ >> static void vpfe_disable_clock(struct vpfe_device *vpfe_dev) >> { >> struct vpfe_config *

RE: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

2009-12-09 Thread Karicheri, Muralidharan
ibhav >Subject: Re: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable > >m-kariche...@ti.com writes: > >> From: Muralidharan Karicheri >> >> v1 - updated based on comments from Vaibhav Hiremath. >> >> On DM365 we use only vpss master clock, w

Re: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

2009-12-09 Thread Kevin Hilman
m-kariche...@ti.com writes: > From: Muralidharan Karicheri > > v1 - updated based on comments from Vaibhav Hiremath. > > On DM365 we use only vpss master clock, where as on DM355 and > DM6446, we use vpss master and slave clocks for vpfe capture and AM3517 > we use internal clock and pixel clock

RE: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

2009-12-03 Thread Karicheri, Muralidharan
Hans, Please hold on to this. I will send you an updated patch. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com >-Original Message- >From: Karicheri, Muralidharan >Sent: Tuesday, December 01, 2009 12:22