RE: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-timings

2009-12-03 Thread Karicheri, Muralidharan
Hans,

Thanks for sending this pull request. No problem in my name being mentioned in 
the spec.

Thanks. 

Murali Karicheri
Software Design Engineer
Texas Instruments Inc.
Germantown, MD 20874
phone: 301-407-9583
email: m-kariche...@ti.com
-Original Message-
From: Hans Verkuil [mailto:hverk...@xs4all.nl]
Sent: Wednesday, December 02, 2009 11:40 PM
To: linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab; Karicheri, Muralidharan
Subject: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-timings

Hi Mauro,

Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-timings for
the following:

- v4l: Adding Digital Video Timings APIs
- v4l2-spec: Digital Video Timings API documentation
- v4l2-spec: updated revision history, updated version to 2.6.33.

Murali, I've added you as one of the authors of the v4l2-spec (you did this
timings API after all) and included your email as well. If that is a
problem
for you (either being mentioned at all, or that your email is mentioned),
then
let me know asap and I'll remove it. I don't expect it to be a problem
since
all this information is already public.

Mauro, before adding these documentation patches it is probably a good idea
to build and release a final 2.6.32 version of the documentation on
http://www.linuxtv.org/docs.php.

If you want to see an example of this api being used, then take a look at
the
tvp7002 driver patches that have been posted recently. I expect that driver
to be merged soon after this pull request is merged.

Thanks,

Hans

diffstat:
 b/linux/Documentation/DocBook/v4l/vidioc-enum-dv-presets.xml |  238
+++
 b/linux/Documentation/DocBook/v4l/vidioc-g-dv-preset.xml |  111 +
 b/linux/Documentation/DocBook/v4l/vidioc-g-dv-timings.xml|  224
++
 b/linux/Documentation/DocBook/v4l/vidioc-query-dv-preset.xml |   85 +++
 linux/Documentation/DocBook/media-entities.tmpl  |   18
 linux/Documentation/DocBook/media-indices.tmpl   |4
 linux/Documentation/DocBook/v4l/common.xml   |   35 +
 linux/Documentation/DocBook/v4l/compat.xml   |   16
 linux/Documentation/DocBook/v4l/v4l2.xml |   26 +
 linux/Documentation/DocBook/v4l/videodev2.h.xml  |  116 +
 linux/Documentation/DocBook/v4l/vidioc-enuminput.xml |   36 +
 linux/Documentation/DocBook/v4l/vidioc-enumoutput.xml|   36 +
 linux/drivers/media/video/v4l2-compat-ioctl32.c  |6
 linux/drivers/media/video/v4l2-ioctl.c   |  147 ++
 linux/include/linux/videodev2.h  |  116 +
 linux/include/media/v4l2-ioctl.h |   15
 linux/include/media/v4l2-subdev.h|   21
 media-specs/Makefile |   14
 18 files changed, 1252 insertions(+), 12 deletions(-)



Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-timings

2009-11-24 Thread Mauro Carvalho Chehab
Hans Verkuil wrote:
 Hi Mauro,
 
 Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-timings for
 the following:
 
 - v4l: Adding Digital Video Timings APIs
 
 This adds an important missing piece to the V4L2 API: the ability to
 receive and transmit HDTV video.
 
 The documentation needs another review cycle, mostly for grammar and
 style, but that should prevent this patch from going in.

I had some bad experiences of not merging both specs and patches at the same
time... DVB S2 API were added one year ago, and the promises were that the
doc patches would be sent 1-2 weeks after the merge... we're still waiting
for it...

So, please submit both specs and code changes at the same pull request.

As a bonus, reviewing both docs and patches at the same time are easier
than doing it in separate.

 
 Many thanks to Murali and everyone else who has been involved in the
 discussions and reviews for this new API.
 
 Thanks,
 
 Hans
 
 diffstat:
  drivers/media/video/v4l2-compat-ioctl32.c |6 +
  drivers/media/video/v4l2-ioctl.c  |  147
 ++
  include/linux/videodev2.h |  116 +++
  include/media/v4l2-ioctl.h|   15 +++
  include/media/v4l2-subdev.h   |   21 
  5 files changed, 303 insertions(+), 2 deletions(-)
 
 
 

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-timings

2009-11-24 Thread Karicheri, Muralidharan
Mauro,

I have submitted the doc patch for review. But no comments so far.

Murali Karicheri
Software Design Engineer
Texas Instruments Inc.
Germantown, MD 20874
phone: 301-407-9583
email: m-kariche...@ti.com

-Original Message-
From: Mauro Carvalho Chehab [mailto:mche...@infradead.org]
Sent: Tuesday, November 24, 2009 11:42 AM
To: Hans Verkuil
Cc: v4l-dvb; Karicheri, Muralidharan
Subject: Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-timings

Hans Verkuil wrote:
 Hi Mauro,

 Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-timings for
 the following:

 - v4l: Adding Digital Video Timings APIs

 This adds an important missing piece to the V4L2 API: the ability to
 receive and transmit HDTV video.

 The documentation needs another review cycle, mostly for grammar and
 style, but that should prevent this patch from going in.

I had some bad experiences of not merging both specs and patches at the
same
time... DVB S2 API were added one year ago, and the promises were that the
doc patches would be sent 1-2 weeks after the merge... we're still waiting
for it...

So, please submit both specs and code changes at the same pull request.

As a bonus, reviewing both docs and patches at the same time are easier
than doing it in separate.


 Many thanks to Murali and everyone else who has been involved in the
 discussions and reviews for this new API.

 Thanks,

 Hans

 diffstat:
  drivers/media/video/v4l2-compat-ioctl32.c |6 +
  drivers/media/video/v4l2-ioctl.c  |  147
 ++
  include/linux/videodev2.h |  116 +++
  include/media/v4l2-ioctl.h|   15 +++
  include/media/v4l2-subdev.h   |   21 
  5 files changed, 303 insertions(+), 2 deletions(-)




--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-timings

2009-11-24 Thread Hans Verkuil

 Mauro,

 I have submitted the doc patch for review. But no comments so far.

I'll review it tomorrow. I did a quick scan earlier and saw several things
that needs improvement, but I simply did not have time to write it all
down in a review.

Regards,

Hans


 Murali Karicheri
 Software Design Engineer
 Texas Instruments Inc.
 Germantown, MD 20874
 phone: 301-407-9583
 email: m-kariche...@ti.com

-Original Message-
From: Mauro Carvalho Chehab [mailto:mche...@infradead.org]
Sent: Tuesday, November 24, 2009 11:42 AM
To: Hans Verkuil
Cc: v4l-dvb; Karicheri, Muralidharan
Subject: Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-timings

Hans Verkuil wrote:
 Hi Mauro,

 Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-timings
 for
 the following:

 - v4l: Adding Digital Video Timings APIs

 This adds an important missing piece to the V4L2 API: the ability to
 receive and transmit HDTV video.

 The documentation needs another review cycle, mostly for grammar and
 style, but that should prevent this patch from going in.

I had some bad experiences of not merging both specs and patches at the
same
time... DVB S2 API were added one year ago, and the promises were that
 the
doc patches would be sent 1-2 weeks after the merge... we're still
 waiting
for it...

So, please submit both specs and code changes at the same pull request.

As a bonus, reviewing both docs and patches at the same time are easier
than doing it in separate.


 Many thanks to Murali and everyone else who has been involved in the
 discussions and reviews for this new API.

 Thanks,

 Hans

 diffstat:
  drivers/media/video/v4l2-compat-ioctl32.c |6 +
  drivers/media/video/v4l2-ioctl.c  |  147
 ++
  include/linux/videodev2.h |  116
 +++
  include/media/v4l2-ioctl.h|   15 +++
  include/media/v4l2-subdev.h   |   21 
  5 files changed, 303 insertions(+), 2 deletions(-)








-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-timings

2009-11-24 Thread Hans Verkuil

 Hans Verkuil wrote:
 Hi Mauro,

 Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-timings for
 the following:

 - v4l: Adding Digital Video Timings APIs

 This adds an important missing piece to the V4L2 API: the ability to
 receive and transmit HDTV video.

 The documentation needs another review cycle, mostly for grammar and
 style, but that should prevent this patch from going in.

 I had some bad experiences of not merging both specs and patches at the
 same
 time... DVB S2 API were added one year ago, and the promises were that the
 doc patches would be sent 1-2 weeks after the merge... we're still waiting
 for it...

 So, please submit both specs and code changes at the same pull request.

The big difference is that the documentation patch is available already.
It just needs one extra round of editing.

Regards,

Hans

 As a bonus, reviewing both docs and patches at the same time are easier
 than doing it in separate.


 Many thanks to Murali and everyone else who has been involved in the
 discussions and reviews for this new API.

 Thanks,

 Hans

 diffstat:
  drivers/media/video/v4l2-compat-ioctl32.c |6 +
  drivers/media/video/v4l2-ioctl.c  |  147
 ++
  include/linux/videodev2.h |  116
 +++
  include/media/v4l2-ioctl.h|   15 +++
  include/media/v4l2-subdev.h   |   21 
  5 files changed, 303 insertions(+), 2 deletions(-)




 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-timings

2009-11-24 Thread Mauro Carvalho Chehab
Hi Murali,

Karicheri, Muralidharan wrote:
 Mauro,
 
 I have submitted the doc patch for review. But no comments so far.

It is very hard to track massive sets of individual patches. That's why
we offer some hosting space for developer trees at linuxtv website. This way,
we can better analyze such patches.

Due to the very high traffic of OMAP messages at the ML, and due to the large
number of versions OMAP patches are taking to be mature, and due to the fact
that all those patches require dedicated hardware that only the developers 
that are actually doing the work have for testing, I've opted to keep away
from such discussions and to mark every patch related to it at Patchwork 
as RFC, waiting for the patches to be more mature for me to review.

So, I'm basically trusting that one of you will do the sub-maintainers job of
adding the patches on a tree and asking me to pull. Currently, Sakari and
Hans have accounts at linuxtv that can be used for that purpose. You may
also host your -hg trees on any other place and ask me to pull from it.

If you (TI) think that you need another -hg account, feel free to send me a
private email for me to create it, but please don't ask me to dig into 
individual patches, since it won't scale.

In the specific case of the V4L/DVB timings API, if you think that the current
doc proposal is OK, please merge it with the patches into some -hg tree
and ask me to pull from it.

Thanks,
Mauro.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-timings

2009-11-24 Thread Karicheri, Muralidharan
Mauro,

So, I'm basically trusting that one of you will do the sub-maintainers job
of
adding the patches on a tree and asking me to pull. Currently, Sakari and
Hans have accounts at linuxtv that can be used for that purpose. You may
also host your -hg trees on any other place and ask me to pull from it.


Currently all the patches go through Hans. 

If you (TI) think that you need another -hg account, feel free to send me a
private email for me to create it, but please don't ask me to dig into

I think we will have to do it eventually. We will work on this and let you
know once we have this ready. Even in that case, H

individual patches, since it won't scale.


In the specific case of the V4L/DVB timings API, if you think that the
current
doc proposal is OK, please merge it with the patches into some -hg tree
and ask me to pull from it.
See email from Hans. Once he gives me his comments, I will work on it and
provide an updated patch. But IMO you should go ahead and merge the video
timing API patch for which Hans had sent you a pull request (since we have the 
documentation part being reviewed in the list). We are waiting
for this to be merged to send additional patches that depends on it. So
this is a high priority patch for 2.6.33.

Thanks and regards,

Murali

Thanks,
Mauro.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html