Re: [PATCH 2/4] [media] usbvision-core: Use common error handling code in usbvision_set_compress_params()

2017-09-22 Thread SF Markus Elfring 
>> @@ -1913,11 +1908,12 @@ static int usbvision_set_compress_params(struct 
>> usb_usbvision *usbvision)
>>   USB_DIR_OUT | USB_TYPE_VENDOR |
>>   USB_RECIP_ENDPOINT, 0,
>>   (__u16) USBVISION_PCM_THR1, value, 6, HZ);
>> +if (rc < 0)
>> +report_failure:
>> +dev_err(>dev->dev,
>> +"%s: ERROR=%d. USBVISION stopped - reconnect or reload 
>> driver.\n",
>> +__func__, rc);
> 
> You've been asked several times not to write code like this.

This suggestion occurred a few times.

Do you prefer to move this place to the end together with a duplicated 
statement “return rc;”?


> You do it later in the patch series as well.

To which update step do you refer here?

Regards,
Markus

Re: [PATCH 2/4] [media] usbvision-core: Use common error handling code in usbvision_set_compress_params()

2017-09-22 Thread Dan Carpenter 
On Thu, Sep 21, 2017 at 05:07:06PM +0200, SF Markus Elfring wrote:
> @@ -1913,11 +1908,12 @@ static int usbvision_set_compress_params(struct 
> usb_usbvision *usbvision)
>USB_DIR_OUT | USB_TYPE_VENDOR |
>USB_RECIP_ENDPOINT, 0,
>(__u16) USBVISION_PCM_THR1, value, 6, HZ);
> + if (rc < 0)
> +report_failure:
> + dev_err(>dev->dev,
> + "%s: ERROR=%d. USBVISION stopped - reconnect or reload 
> driver.\n",
> + __func__, rc);

You've been asked several times not to write code like this.  You do
it later in the patch series as well.

regards,
dan carpenter