Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl

2010-07-06 Thread Jarod Wilson
On Mon, Jun 21, 2010 at 7:04 AM, Andy Walls awa...@md.metrocast.net wrote: On Sun, 2010-06-20 at 23:51 -0400, Jarod Wilson wrote: On Sun, Jun 20, 2010 at 8:47 PM, Andy Walls awa...@md.metrocast.net wrote: As for the building your own kernel thing... I've been doing my work mainly on a pair

Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl

2010-06-21 Thread Andy Walls
On Sun, 2010-06-20 at 23:51 -0400, Jarod Wilson wrote: On Sun, Jun 20, 2010 at 8:47 PM, Andy Walls awa...@md.metrocast.net wrote: As for the building your own kernel thing... I've been doing my work mainly on a pair of x86_64 systems, one a ThinkPad T61 running Fedora 13, and the other an HP

Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl

2010-06-20 Thread Jarod Wilson
On Sun, Jun 20, 2010 at 8:47 PM, Andy Walls awa...@md.metrocast.net wrote: On Thu, 2010-06-17 at 11:11 -0400, Jarod Wilson wrote: On Thu, Jun 17, 2010 at 8:14 AM, Andy Walls awa...@md.metrocast.net wrote: A fully functional tree carrying both of David's patches and the entire stack of other

Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl

2010-06-17 Thread Andy Walls
On Wed, 2010-06-16 at 16:41 -0400, Jarod Wilson wrote: On Wed, Jun 16, 2010 at 4:04 PM, Jarod Wilson ja...@wilsonet.com wrote: ... I have another suggestion, let's keep the client register/unregister callbacks for decoders (but add a comment that they're only used for lirc). Then teach

Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl

2010-06-17 Thread Jarod Wilson
On Thu, Jun 17, 2010 at 8:14 AM, Andy Walls awa...@md.metrocast.net wrote: On Wed, 2010-06-16 at 16:41 -0400, Jarod Wilson wrote: On Wed, Jun 16, 2010 at 4:04 PM, Jarod Wilson ja...@wilsonet.com wrote: ... I have another suggestion, let's keep the client register/unregister callbacks for

Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl

2010-06-16 Thread Jarod Wilson
On Sun, Jun 13, 2010 at 4:29 PM, David Härdeman da...@hardeman.nu wrote: On Wed, Jun 09, 2010 at 09:25:44PM -0400, Jarod Wilson wrote: On Wed, Jun 9, 2010 at 2:15 PM, Jarod Wilson ja...@redhat.com wrote: On Wed, Jun 09, 2010 at 07:56:21PM +0200, David Härdeman wrote: On Wed, Jun 09, 2010 at

Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl

2010-06-16 Thread Jarod Wilson
On Wed, Jun 16, 2010 at 4:04 PM, Jarod Wilson ja...@wilsonet.com wrote: ... I have another suggestion, let's keep the client register/unregister callbacks for decoders (but add a comment that they're only used for lirc). Then teach drivers/media/IR/ir-raw-event.c to keep track of the raw

Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl

2010-06-13 Thread David Härdeman
On Wed, Jun 09, 2010 at 09:25:44PM -0400, Jarod Wilson wrote: On Wed, Jun 9, 2010 at 2:15 PM, Jarod Wilson ja...@redhat.com wrote: On Wed, Jun 09, 2010 at 07:56:21PM +0200, David Härdeman wrote: On Wed, Jun 09, 2010 at 09:29:08AM -0400, Jarod Wilson wrote: ... So this definitely

Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl

2010-06-09 Thread David Härdeman
On Wed, Jun 09, 2010 at 09:29:08AM -0400, Jarod Wilson wrote: On Tue, Jun 08, 2010 at 11:46:36PM -0400, Jarod Wilson wrote: On Tue, Jun 8, 2010 at 1:50 PM, David Härdeman da...@hardeman.nu wrote: b) Mauro mentioned in 4bdf28c0.4060...@redhat.com that:        I liked the idea of your

Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl

2010-06-09 Thread Jarod Wilson
On Wed, Jun 09, 2010 at 07:56:21PM +0200, David Härdeman wrote: On Wed, Jun 09, 2010 at 09:29:08AM -0400, Jarod Wilson wrote: On Tue, Jun 08, 2010 at 11:46:36PM -0400, Jarod Wilson wrote: On Tue, Jun 8, 2010 at 1:50 PM, David Härdeman da...@hardeman.nu wrote: b) Mauro mentioned in

Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl

2010-06-09 Thread Jarod Wilson
On Wed, Jun 9, 2010 at 2:15 PM, Jarod Wilson ja...@redhat.com wrote: On Wed, Jun 09, 2010 at 07:56:21PM +0200, David Härdeman wrote: On Wed, Jun 09, 2010 at 09:29:08AM -0400, Jarod Wilson wrote: ... So this definitely negatively impacts my ir-core-to-lirc_dev (ir-lirc-codec.c) bridge driver,

Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl

2010-06-08 Thread David Härdeman
On Mon, Jun 07, 2010 at 04:15:30PM -0400, Jarod Wilson wrote: On Mon, Jun 07, 2010 at 09:00:03PM +0200, David Härdeman wrote: On Mon, May 03, 2010 at 05:00:05PM -0300, Mauro Carvalho Chehab wrote: David Härdeman wrote: This patch moves the state from each raw decoder into the

Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl

2010-06-08 Thread Jarod Wilson
On Tue, Jun 8, 2010 at 1:50 PM, David Härdeman da...@hardeman.nu wrote: On Mon, Jun 07, 2010 at 04:15:30PM -0400, Jarod Wilson wrote: On Mon, Jun 07, 2010 at 09:00:03PM +0200, David Härdeman wrote: On Mon, May 03, 2010 at 05:00:05PM -0300, Mauro Carvalho Chehab wrote: David Härdeman wrote:

Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl

2010-06-07 Thread David Härdeman
On Mon, May 03, 2010 at 05:00:05PM -0300, Mauro Carvalho Chehab wrote: David Härdeman wrote: This patch moves the state from each raw decoder into the ir_raw_event_ctrl struct. This allows the removal of code like this: spin_lock(decoder_lock);

Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl

2010-06-07 Thread Jarod Wilson
On Mon, Jun 07, 2010 at 09:00:03PM +0200, David Härdeman wrote: On Mon, May 03, 2010 at 05:00:05PM -0300, Mauro Carvalho Chehab wrote: David Härdeman wrote: This patch moves the state from each raw decoder into the ir_raw_event_ctrl struct. This allows the removal of code like

Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl

2010-05-03 Thread Mauro Carvalho Chehab
David Härdeman wrote: This patch moves the state from each raw decoder into the ir_raw_event_ctrl struct. This allows the removal of code like this: spin_lock(decoder_lock); list_for_each_entry(data, decoder_list, list) { if (data-ir_dev == ir_dev)