Re: [REVIEW] v4l2 loopback

2009-05-07 Thread Antonio Ospite
On Thu, 7 May 2009 02:54:00 +0300 Vasily vas...@gmail.com wrote: This patch introduces v4l2 loopback module Hi Vasily, next time it would be useful to summarize what you changed from the previous version, and put a revision number in the Subject, like [PATCH v2] [PATCH v3], etc. Also, the

Re: [REVIEW] v4l2 loopback

2009-05-07 Thread vasaka
On Thu, May 7, 2009 at 9:28 PM, Antonio Ospite osp...@studenti.unina.it wrote: On Thu, 7 May 2009 02:54:00 +0300 Vasily vas...@gmail.com wrote: This patch introduces v4l2 loopback module Hi Vasily, next time it would be useful to summarize what you changed from the previous version, and  

Re: [REVIEW] v4l2 loopback

2009-05-06 Thread Vasily
This patch introduces v4l2 loopback module From: Vasily Levin vas...@gmail.com This is v4l2 loopback driver which can be used to make available any userspace video as v4l2 device. Initialy it was written to make videoeffects available to Skype, but in fact it have many more uses. Priority:

Re: [REVIEW] v4l2 loopback

2009-04-27 Thread Antonio Ospite
Hi Vasily, Your patch seems to be reversed, not a big deal for review purposes, of course. I think you know that if you are working on a hg clone you can simply issue hg diff to get the right patch, or you could even use 'quilt' to ease your work. Just very few comments about syntax and style,

Re: [REVIEW] v4l2 loopback

2009-04-27 Thread Hans Verkuil
Hi Vasily, Your patch seems to be reversed, not a big deal for review purposes, of course. I think you know that if you are working on a hg clone you can simply issue hg diff to get the right patch, or you could even use 'quilt' to ease your work. Just very few comments about syntax and

Re: [REVIEW] v4l2 loopback

2009-04-16 Thread Mauro Carvalho Chehab
On Tue, 14 Apr 2009 16:04:50 +0200 Antonio Ospite osp...@studenti.unina.it wrote: On Tue, 14 Apr 2009 15:53:00 +0300 vas...@gmail.com wrote: On Tue, Apr 14, 2009 at 3:12 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: The issue I see is that the V4L drivers are meant to

Re: [REVIEW] v4l2 loopback

2009-04-14 Thread Mauro Carvalho Chehab
On Tue, 14 Apr 2009 04:08:41 +0300 vas...@gmail.com wrote: On Mon, Apr 13, 2009 at 2:17 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Thursday 26 March 2009 19:49:10 Vasily wrote: Hello, please review the new version of v4l2 loopback driver. I fixed up comments to the previous submission,

Re: [REVIEW] v4l2 loopback

2009-04-14 Thread vasaka
On Tue, Apr 14, 2009 at 3:12 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: On Tue, 14 Apr 2009 04:08:41 +0300 vas...@gmail.com wrote: On Mon, Apr 13, 2009 at 2:17 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Thursday 26 March 2009 19:49:10 Vasily wrote: Hello, please review the

Re: [REVIEW] v4l2 loopback

2009-04-14 Thread Antonio Ospite
On Tue, 14 Apr 2009 15:53:00 +0300 vas...@gmail.com wrote: On Tue, Apr 14, 2009 at 3:12 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: The issue I see is that the V4L drivers are meant to support real devices. This driver that is a loopback for some userspace driver. I don't

Re: [REVIEW] v4l2 loopback

2009-04-13 Thread Hans Verkuil
On Thursday 26 March 2009 19:49:10 Vasily wrote: Hello, please review the new version of v4l2 loopback driver. I fixed up comments to the previous submission, waiting for the new ones :-), reposting for patchwork tool --- This patch introduces v4l2 loopback module From: Vasily Levin

Re: [REVIEW] v4l2 loopback

2009-04-13 Thread vasaka
On Mon, Apr 13, 2009 at 2:17 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Thursday 26 March 2009 19:49:10 Vasily wrote: Hello, please review the new version of v4l2 loopback driver. I fixed up comments to the previous submission, waiting for the new ones :-), reposting for patchwork tool

Re: [REVIEW] v4l2 loopback

2009-03-24 Thread vasaka
On Wed, Mar 25, 2009 at 1:07 AM, Alexey Klimov klimov.li...@gmail.com wrote: Hello, Vasily On Tue, 2009-03-24 at 21:27 +0200, vas...@gmail.com wrote: Hello, please review new version of v4l2 loopback driver. driver works fine but there are things which I am not shure in. Is it ok not to