> The code for the special v1p8 / v2p8 gpios is ugly as sin, it operates on
> a global v2p8_gpio value rather then storing info in the gmin_subdev struct,
> as such passing the subdev->dev pointer would be simply wrong. AFAICT the
> v1p8 / v2p8 gpio code is the only caller passing in a NULL
Hi,
On 28-05-17 19:08, Alan Cox wrote:
On Sun, 28 May 2017 14:30:35 +0200
Hans de Goede wrote:
Do not call dev_warn with a NULL device, this silence the following 2
warnings:
[ 14.392194] (NULL device *): Failed to find gmin variable gmin_V2P8GPIO
[ 14.392257] (NULL
>On Sun, May 28, 2017 at 3:31 PM, Hans de Goede
wrote:
>> Do not call dev_warn with a NULL device, this silence the following 2
>> warnings:
>>
>> [ 14.392194] (NULL device *): Failed to find gmin variable gmin_V2P8GPIO
>> [ 14.392257] (NULL device *): Failed to find gmin
On Sun, May 28, 2017 at 3:31 PM, Hans de Goede wrote:
> Do not call dev_warn with a NULL device, this silence the following 2
> warnings:
>
> [ 14.392194] (NULL device *): Failed to find gmin variable gmin_V2P8GPIO
> [ 14.392257] (NULL device *): Failed to find gmin
Do not call dev_warn with a NULL device, this silence the following 2
warnings:
[ 14.392194] (NULL device *): Failed to find gmin variable gmin_V2P8GPIO
[ 14.392257] (NULL device *): Failed to find gmin variable gmin_V1P8GPIO
We could switch to using pr_warn for dev == NULL instead, but as