Re: [GIT PATCHES FOR 2.6.39] Remove se401, usbvideo, dabusb, firedtv-1394 and VIDIOC_OLD
On Feb 05 Hans Verkuil wrote: > The following changes since commit ffd14aab03dbb8bb1bac5284603835f94d833bd6: > Devin Heitmueller (1): > [media] au0828: fix VBI handling when in V4L2 streaming mode > > are available in the git repository at: > > ssh://linuxtv.org/git/hverkuil/media_tree.git v4l1 > > Hans Verkuil (4): > se401/usbvideo: remove last V4L1 drivers > dabusb: remove obsolete driver > firedtv: remove dependency on the deleted ieee1394 stack. > v4l: removal of old, obsolete ioctls. On commit f02c316436eef3baf349c489545edc7ade419ff6 "firedtv: remove dependency on the deleted ieee1394 stack.": The diff is correct and runtime-tested it. But, as discussed, the changelog is wrong and the shortlog somewhat misleading. I suggest something along the lines of: 8< firedtv: remove obsolete ieee1394 backend code drivers/ieee1394/ has been removed in Linux 2.6.37. The corresponding backend code in firedtv is no longer built in now and can be deleted. Firedtv continues to work with drivers/firewire/. Also, fix a Kconfig menu comment: Removal of CONFIG_IEEE1394 made the "Supported FireWire (IEEE 1394) Adapters" comment disappear; bring it back with corrected dependency. >8 A minor note: firedtv-dvb.c::fdtv_init() can now be shortened further, and firedtv-fw.c::fdtv_fw_exit() can receive an __exit annotation. However, these changes can wait for (or will be superseded by) a subsequent simplification of firedtv which throws out the fdtv->backend abstraction. I tend to think that the three parts of firedtv-fw.c (asynchronous I/O, isochronous I/O, device probe/update/removal) can be moved into firedtv-avc.c, -fe.c, and -dvb.c. I will post something. If you rewrite the changelog, you can add Reviewed-by: Stefan Richter if you like. -- Stefan Richter -=-==-== --=- --==- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PATCHES FOR 2.6.39] Remove se401, usbvideo, dabusb, firedtv-1394 and VIDIOC_OLD
On Saturday, February 05, 2011 15:29:47 Stefan Richter wrote: > On Feb 05 Hans Verkuil wrote: > > (Second attempt: fixes a link issue with firedtv and adds removal of the > > old ioctls) > > > > This patch series removes the last V4L1 drivers (Yay!), the obsolete dabusb > > driver, > > the ieee1394-stack part of the firedtv driver (the IEEE1394 stack was > > removed in > > 2.6.37), and the VIDIOC_*_OLD ioctls. > > > > Stefan, I went ahead with this since after further research I discovered > > that > > this driver hasn't been compiled at all since 2.6.37! The Kconfig had a > > dependency on IEEE1394, so when that config was removed, the driver no > > longer > > appeared in the config. > > > > I removed any remaining reference to IEEE1394 and changed the Kconfig > > dependency > > to FIREWIRE. At least it compiles again :-) > > Thanks for doing the firedtv cleanup. However, the effect should just be > that of dead code elimination. Was there any build problem that I missed? You missed something, but it turns out not to be a build problem as such on closer inspection. I got confused by this code in drivers/media/dvb/Kconfig: comment "Supported FireWire (IEEE 1394) Adapters" depends on DVB_CORE && IEEE1394 source "drivers/media/dvb/firewire/Kconfig" Since the comment depends on IEEE1394 it disappeared once IEEE1394 was removed. So when I looked for this comment in the menu is was no longer there. But the actual driver still is, and I missed that. So it was just the comment dependency that was wrong, not the driver itself. Sorry for the confusion. Regards, Hans > AFAICS, firedtv builds and works fine in mainline 2.6.37(-rc) and > 2.6.38(-rc). From when I implemented the drivers/firewire/ backend of > firedtv, it should have been possible to build firedtv for a kernel with > one or both of drivers/{ieee1394,firewire}; controlled by whether > CONFIG_{IEEE1394,FIREWIRE} are defined or not. > > I will have a look at your changes later. > -- Hans Verkuil - video4linux developer - sponsored by Cisco -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PATCHES FOR 2.6.39] Remove se401, usbvideo, dabusb, firedtv-1394 and VIDIOC_OLD
On Feb 05 Hans Verkuil wrote: > (Second attempt: fixes a link issue with firedtv and adds removal of the old > ioctls) > > This patch series removes the last V4L1 drivers (Yay!), the obsolete dabusb > driver, > the ieee1394-stack part of the firedtv driver (the IEEE1394 stack was removed > in > 2.6.37), and the VIDIOC_*_OLD ioctls. > > Stefan, I went ahead with this since after further research I discovered that > this driver hasn't been compiled at all since 2.6.37! The Kconfig had a > dependency on IEEE1394, so when that config was removed, the driver no longer > appeared in the config. > > I removed any remaining reference to IEEE1394 and changed the Kconfig > dependency > to FIREWIRE. At least it compiles again :-) Thanks for doing the firedtv cleanup. However, the effect should just be that of dead code elimination. Was there any build problem that I missed? AFAICS, firedtv builds and works fine in mainline 2.6.37(-rc) and 2.6.38(-rc). From when I implemented the drivers/firewire/ backend of firedtv, it should have been possible to build firedtv for a kernel with one or both of drivers/{ieee1394,firewire}; controlled by whether CONFIG_{IEEE1394,FIREWIRE} are defined or not. I will have a look at your changes later. -- Stefan Richter -=-==-== --=- --=-= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.39] Remove se401, usbvideo, dabusb, firedtv-1394 and VIDIOC_OLD
(Second attempt: fixes a link issue with firedtv and adds removal of the old ioctls) This patch series removes the last V4L1 drivers (Yay!), the obsolete dabusb driver, the ieee1394-stack part of the firedtv driver (the IEEE1394 stack was removed in 2.6.37), and the VIDIOC_*_OLD ioctls. Stefan, I went ahead with this since after further research I discovered that this driver hasn't been compiled at all since 2.6.37! The Kconfig had a dependency on IEEE1394, so when that config was removed, the driver no longer appeared in the config. I removed any remaining reference to IEEE1394 and changed the Kconfig dependency to FIREWIRE. At least it compiles again :-) Regards, Hans The following changes since commit ffd14aab03dbb8bb1bac5284603835f94d833bd6: Devin Heitmueller (1): [media] au0828: fix VBI handling when in V4L2 streaming mode are available in the git repository at: ssh://linuxtv.org/git/hverkuil/media_tree.git v4l1 Hans Verkuil (4): se401/usbvideo: remove last V4L1 drivers dabusb: remove obsolete driver firedtv: remove dependency on the deleted ieee1394 stack. v4l: removal of old, obsolete ioctls. Documentation/feature-removal-schedule.txt | 36 - drivers/media/dvb/Kconfig |2 +- drivers/media/dvb/firewire/Kconfig |8 +- drivers/media/dvb/firewire/Makefile|5 +- drivers/media/dvb/firewire/firedtv-1394.c | 300 drivers/media/dvb/firewire/firedtv-dvb.c |5 - drivers/media/dvb/firewire/firedtv.h | 14 - drivers/media/video/v4l2-common.c |1 - drivers/media/video/v4l2-compat-ioctl32.c | 15 - drivers/media/video/v4l2-ioctl.c | 38 - drivers/staging/Kconfig|6 - drivers/staging/Makefile |3 - drivers/staging/dabusb/Kconfig | 14 - drivers/staging/dabusb/Makefile|2 - drivers/staging/dabusb/TODO|5 - drivers/staging/dabusb/dabusb.c| 914 drivers/staging/dabusb/dabusb.h| 85 -- drivers/staging/easycap/easycap_ioctl.c|5 - drivers/staging/se401/Kconfig | 13 - drivers/staging/se401/Makefile |1 - drivers/staging/se401/TODO |5 - drivers/staging/se401/se401.c | 1492 --- drivers/staging/se401/se401.h | 236 --- drivers/staging/se401/videodev.h | 318 drivers/staging/usbvideo/Kconfig | 15 - drivers/staging/usbvideo/Makefile |2 - drivers/staging/usbvideo/TODO |5 - drivers/staging/usbvideo/usbvideo.c| 2230 drivers/staging/usbvideo/usbvideo.h| 395 - drivers/staging/usbvideo/vicam.c | 952 drivers/staging/usbvideo/videodev.h| 318 include/linux/videodev2.h | 10 - 32 files changed, 3 insertions(+), 7447 deletions(-) delete mode 100644 drivers/media/dvb/firewire/firedtv-1394.c delete mode 100644 drivers/staging/dabusb/Kconfig delete mode 100644 drivers/staging/dabusb/Makefile delete mode 100644 drivers/staging/dabusb/TODO delete mode 100644 drivers/staging/dabusb/dabusb.c delete mode 100644 drivers/staging/dabusb/dabusb.h delete mode 100644 drivers/staging/se401/Kconfig delete mode 100644 drivers/staging/se401/Makefile delete mode 100644 drivers/staging/se401/TODO delete mode 100644 drivers/staging/se401/se401.c delete mode 100644 drivers/staging/se401/se401.h delete mode 100644 drivers/staging/se401/videodev.h delete mode 100644 drivers/staging/usbvideo/Kconfig delete mode 100644 drivers/staging/usbvideo/Makefile delete mode 100644 drivers/staging/usbvideo/TODO delete mode 100644 drivers/staging/usbvideo/usbvideo.c delete mode 100644 drivers/staging/usbvideo/usbvideo.h delete mode 100644 drivers/staging/usbvideo/vicam.c delete mode 100644 drivers/staging/usbvideo/videodev.h -- Hans Verkuil - video4linux developer - sponsored by Cisco -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html