Re: [PATCH/RFC v10 08/19] leds: Add support for max77693 mfd flash cell

2015-02-05 Thread Sakari Ailus
Hi Jacek, A few comments below. On Fri, Jan 09, 2015 at 04:22:58PM +0100, Jacek Anaszewski wrote: This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface. Device supports up to two leds which can work in flash

Re: [PATCH/RFC v10 08/19] leds: Add support for max77693 mfd flash cell

2015-02-05 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 02/05/2015 04:34 PM, Sakari Ailus wrote: Hi Jacek, A few comments below. On Fri, Jan 09, 2015 at 04:22:58PM +0100, Jacek Anaszewski wrote: This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED

Re: [PATCH/RFC v10 08/19] leds: Add support for max77693 mfd flash cell

2015-01-12 Thread Jacek Anaszewski
Hi Pavel, Thanks for the review. On 01/09/2015 07:46 PM, Pavel Machek wrote: On Fri 2015-01-09 16:22:58, Jacek Anaszewski wrote: This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface. Device supports up to two

Re: [PATCH/RFC v10 08/19] leds: Add support for max77693 mfd flash cell

2015-01-12 Thread Pavel Machek
Hi! +struct max77693_sub_led { + /* related FLED output identifier */ -flash LED, about 4x. +/* split composite current @i into two @iout according to @imax weights */ +static void __max77693_calc_iout(u32 iout[2], u32 i, u32 imax[2]) +{ + u64 t = i; + + t *= imax[1]; +

Re: [PATCH/RFC v10 08/19] leds: Add support for max77693 mfd flash cell

2015-01-12 Thread Jacek Anaszewski
On 01/12/2015 02:25 PM, Pavel Machek wrote: Hi! +struct max77693_sub_led { + /* related FLED output identifier */ -flash LED, about 4x. +/* split composite current @i into two @iout according to @imax weights */ +static void __max77693_calc_iout(u32 iout[2], u32 i, u32 imax[2]) +{ +

[PATCH/RFC v10 08/19] leds: Add support for max77693 mfd flash cell

2015-01-09 Thread Jacek Anaszewski
This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface. Device supports up to two leds which can work in flash and torch mode. The leds can be triggered externally or by software. Signed-off-by: Jacek Anaszewski

Re: [PATCH/RFC v10 08/19] leds: Add support for max77693 mfd flash cell

2015-01-09 Thread Pavel Machek
On Fri 2015-01-09 16:22:58, Jacek Anaszewski wrote: This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface. Device supports up to two leds which can work in flash and torch mode. The leds can be triggered