Re: [PATCH/RFC v2 0/8] dsbr100: driver cleanup and fixes
David Ellingsworth writes: >> I will also check your patches soon. I have this old hardware at home. >> > > The sooner the better. These patches have been waiting for review > since May. I'd rather not have to rebase them and resend them a third > time. The current review process for drivers abandoned by the original author is not working. I really, really fail too see the problem with just letting a clean compile-tested patchset like yours through after, let's say, a week without any comments at all. That's probably the only way it is ever going to be tested by someone with the actual hardware. Worst case is that some of the patches will have to be reverted in the next release (and stable point release). That's not going to be problematic at all, given that the patchset only touches a single driver in maintenance mode. Please Mauro, can you implement some sort of deadline for your review cycles? Half a year is nowhere close to acceptable for non- controversial stuff like this. Spotting the non-controversial patches is easy BTW: Just look for those with no comments at all... Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH/RFC v2 0/8] dsbr100: driver cleanup and fixes
> I will also check your patches soon. I have this old hardware at home. > The sooner the better. These patches have been waiting for review since May. I'd rather not have to rebase them and resend them a third time. Regards, David Ellingsworth -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH/RFC v2 0/8] dsbr100: driver cleanup and fixes
Hi David, On Tue, Sep 14, 2010 at 11:56 AM, David Ellingsworth wrote: > Alexey, > > Can you review/test this patch series? Patches 2/8, 3/8, and 5/8 are > bug fixes the rest are mainly cleanups. Patch 2/8 should fix a crash > in the normal case if the device is disconnected while not in use. I will also check your patches soon. I have this old hardware at home. Cheers Douglas -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH/RFC v2 0/8] dsbr100: driver cleanup and fixes
Alexey, Can you review/test this patch series? Patches 2/8, 3/8, and 5/8 are bug fixes the rest are mainly cleanups. Patch 2/8 should fix a crash in the normal case if the device is disconnected while not in use. Regards, David Ellingsworth On Thu, May 27, 2010 at 12:39 PM, David Ellingsworth wrote: > This patch series addresses several issues in the dsbr100 driver. > This series is based on the v4l-dvb master git branch and has been > compile tested only. It should be tested before applying. > > This is the second version of this series. An additional patch has > been added to cleanup/clarify the return values from dsbr100_start > and dsbr100_stop. > > The following patches are included in this series: > [PATCH/RFC v2 1/8] dsbr100: implement proper locking > [PATCH/RFC v2 2/8] dsbr100: fix potential use after free > [PATCH/RFC v2 3/8] dsbr100: only change frequency upon success > [PATCH/RFC v2 4/8] dsbr100: remove disconnected indicator > [PATCH/RFC v2 5/8] dsbr100: cleanup return value of start/stop handlers > [PATCH/RFC v2 6/8] dsbr100: properly initialize the radio > [PATCH/RFC v2 7/8] dsbr100: cleanup usb probe routine > [PATCH/RFC v2 8/8] dsbr100: simplify access to radio device > > Regards, > > David Ellingsworth > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH/RFC v2 0/8] dsbr100: driver cleanup and fixes
On Thu, May 27, 2010 at 12:39 PM, David Ellingsworth wrote: > This patch series addresses several issues in the dsbr100 driver. > This series is based on the v4l-dvb master git branch and has been > compile tested only. It should be tested before applying. > > This is the second version of this series. An additional patch has > been added to cleanup/clarify the return values from dsbr100_start > and dsbr100_stop. > > The following patches are included in this series: > [PATCH/RFC v2 1/8] dsbr100: implement proper locking > [PATCH/RFC v2 2/8] dsbr100: fix potential use after free > [PATCH/RFC v2 3/8] dsbr100: only change frequency upon success > [PATCH/RFC v2 4/8] dsbr100: remove disconnected indicator > [PATCH/RFC v2 5/8] dsbr100: cleanup return value of start/stop handlers > [PATCH/RFC v2 6/8] dsbr100: properly initialize the radio > [PATCH/RFC v2 7/8] dsbr100: cleanup usb probe routine > [PATCH/RFC v2 8/8] dsbr100: simplify access to radio device > Mauro, This series has not received any comments and the original author seems to have abandoned this driver. Please review these patches for approval. All changes are relatively straight forward. The second patch in this series is a bug fix for the normal case where the device is unplugged while closed. The current implementation will cause a NULL pointer dereference. The fact that no one has reported this bug is probably due to the lack of people using this driver. The rest of the changes mainly provide general cleanups and reduced overhead. Regards, David Ellingsworth -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH/RFC v2 0/8] dsbr100: driver cleanup and fixes
This patch series addresses several issues in the dsbr100 driver. This series is based on the v4l-dvb master git branch and has been compile tested only. It should be tested before applying. This is the second version of this series. An additional patch has been added to cleanup/clarify the return values from dsbr100_start and dsbr100_stop. The following patches are included in this series: [PATCH/RFC v2 1/8] dsbr100: implement proper locking [PATCH/RFC v2 2/8] dsbr100: fix potential use after free [PATCH/RFC v2 3/8] dsbr100: only change frequency upon success [PATCH/RFC v2 4/8] dsbr100: remove disconnected indicator [PATCH/RFC v2 5/8] dsbr100: cleanup return value of start/stop handlers [PATCH/RFC v2 6/8] dsbr100: properly initialize the radio [PATCH/RFC v2 7/8] dsbr100: cleanup usb probe routine [PATCH/RFC v2 8/8] dsbr100: simplify access to radio device Regards, David Ellingsworth -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
