Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-29 Thread Laurent Pinchart
Hi Florian, On Monday 29 August 2011 18:41:03 Florian Tobias Schandinat wrote: > On 08/29/2011 02:32 PM, Laurent Pinchart wrote: > > On Monday 29 August 2011 16:26:02 Geert Uytterhoeven wrote: > >> On Mon, Aug 29, 2011 at 16:17, Laurent Pinchart wrote: > >>> On Monday 29 August 2011 16:14:38 Geert

Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-29 Thread Florian Tobias Schandinat
Hi, On 08/29/2011 02:32 PM, Laurent Pinchart wrote: > Hi Geert, > > On Monday 29 August 2011 16:26:02 Geert Uytterhoeven wrote: >> On Mon, Aug 29, 2011 at 16:17, Laurent Pinchart wrote: >>> On Monday 29 August 2011 16:14:38 Geert Uytterhoeven wrote: On Mon, Aug 29, 2011 at 15:34, Laurent Pin

Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-29 Thread Laurent Pinchart
Hi Geert, On Monday 29 August 2011 16:26:02 Geert Uytterhoeven wrote: > On Mon, Aug 29, 2011 at 16:17, Laurent Pinchart wrote: > > On Monday 29 August 2011 16:14:38 Geert Uytterhoeven wrote: > >> On Mon, Aug 29, 2011 at 15:34, Laurent Pinchart wrote: > >> > On Monday 29 August 2011 15:09:04 Geert

Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-29 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Aug 29, 2011 at 16:17, Laurent Pinchart wrote: > On Monday 29 August 2011 16:14:38 Geert Uytterhoeven wrote: >> On Mon, Aug 29, 2011 at 15:34, Laurent Pinchart wrote: >> > On Monday 29 August 2011 15:09:04 Geert Uytterhoeven wrote: >> >> On Mon, Aug 29, 2011 at 14:55, Laurent

Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-29 Thread Laurent Pinchart
Hi Geert, On Monday 29 August 2011 16:14:38 Geert Uytterhoeven wrote: > On Mon, Aug 29, 2011 at 15:34, Laurent Pinchart wrote: > > On Monday 29 August 2011 15:09:04 Geert Uytterhoeven wrote: > >> On Mon, Aug 29, 2011 at 14:55, Laurent Pinchart wrote: > >> >> When will the driver report FB_{TYPE,VI

Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-29 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Aug 29, 2011 at 15:34, Laurent Pinchart wrote: > On Monday 29 August 2011 15:09:04 Geert Uytterhoeven wrote: >> On Mon, Aug 29, 2011 at 14:55, Laurent Pinchart wrote: >> >> When will the driver report FB_{TYPE,VISUAL}_FOURCC? >> >>   - When using a mode that cannot be represen

Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-29 Thread Laurent Pinchart
Hi Geert, On Monday 29 August 2011 15:09:04 Geert Uytterhoeven wrote: > On Mon, Aug 29, 2011 at 14:55, Laurent Pinchart wrote: > >> When will the driver report FB_{TYPE,VISUAL}_FOURCC? > >> - When using a mode that cannot be represented in the legacy way, > > > > Definitely. > > > >> - But w

Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-29 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Aug 29, 2011 at 14:55, Laurent Pinchart wrote: >> When will the driver report FB_{TYPE,VISUAL}_FOURCC? >>   - When using a mode that cannot be represented in the legacy way, > > Definitely. > >>   - But what with modes that can be represented? Legacy software cannot >>     han

Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-29 Thread Laurent Pinchart
Hi Geert, On Monday 29 August 2011 13:20:44 Geert Uytterhoeven wrote: > On Mon, Aug 29, 2011 at 13:08, Laurent Pinchart wrote: > > On Monday 29 August 2011 13:04:15 Geert Uytterhoeven wrote: > >> On Mon, Aug 29, 2011 at 12:09, Laurent Pinchart wrote: > >> > On Monday 29 August 2011 11:36:07 Geert

Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-29 Thread Geert Uytterhoeven
On Mon, Aug 29, 2011 at 13:08, Laurent Pinchart wrote: > On Monday 29 August 2011 13:04:15 Geert Uytterhoeven wrote: >> On Mon, Aug 29, 2011 at 12:09, Laurent Pinchart wrote: >> > On Monday 29 August 2011 11:36:07 Geert Uytterhoeven wrote: >> >> On Mon, Aug 29, 2011 at 10:50, Laurent Pinchart wrot

Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-29 Thread Laurent Pinchart
Hi Geert, On Monday 29 August 2011 13:04:15 Geert Uytterhoeven wrote: > On Mon, Aug 29, 2011 at 12:09, Laurent Pinchart wrote: > > On Monday 29 August 2011 11:36:07 Geert Uytterhoeven wrote: > >> On Mon, Aug 29, 2011 at 10:50, Laurent Pinchart wrote: > [...] > > > If my understanding is now corre

Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-29 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Aug 29, 2011 at 12:09, Laurent Pinchart wrote: > On Monday 29 August 2011 11:36:07 Geert Uytterhoeven wrote: >> On Mon, Aug 29, 2011 at 10:50, Laurent Pinchart wrote: [...] > If my understanding is now correct, a V4L2 planar YUV type where Y, U and V > components are stored

Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-29 Thread Laurent Pinchart
Hi Geert, On Monday 29 August 2011 11:36:07 Geert Uytterhoeven wrote: > On Mon, Aug 29, 2011 at 10:50, Laurent Pinchart wrote: > > On Monday 29 August 2011 10:13:07 Geert Uytterhoeven wrote: > >> On Fri, Aug 19, 2011 at 11:37, Laurent Pinchart wrote: > > [snip] > > > >> > +- FB_TYPE_PACKED_PIXELS

Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-29 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Aug 29, 2011 at 10:50, Laurent Pinchart wrote: > On Monday 29 August 2011 10:13:07 Geert Uytterhoeven wrote: >> On Fri, Aug 19, 2011 at 11:37, Laurent Pinchart wrote: > > [snip] > >> > +- FB_TYPE_PACKED_PIXELS >> > + >> > +Color components (usually RGB or YUV) are packed toget

Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-29 Thread Laurent Pinchart
Hi Geert, Thanks for the review. On Monday 29 August 2011 10:13:07 Geert Uytterhoeven wrote: > On Fri, Aug 19, 2011 at 11:37, Laurent Pinchart wrote: [snip] > > +- FB_TYPE_PACKED_PIXELS > > + > > +Color components (usually RGB or YUV) are packed together into > > macropixels +that are stored in

Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-29 Thread Geert Uytterhoeven
Hi Laurent, My comments are mainly about the documentation of the "legacy" bits. On Fri, Aug 19, 2011 at 11:37, Laurent Pinchart wrote: > diff --git a/Documentation/fb/api.txt b/Documentation/fb/api.txt > new file mode 100644 > index 000..6808492 > --- /dev/null > +++ b/Documentation/fb/api.

Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-28 Thread Laurent Pinchart
Hi Florian, Thank you for the review. On Friday 26 August 2011 19:07:01 Florian Tobias Schandinat wrote: > Hi Laurent, > > hope we're close to the final thing now. Just a few minor issues. I agree with all your comments, I'll fix the patches accordingly. -- Regards, Laurent Pinchart -- To un

Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-26 Thread Florian Tobias Schandinat
Hi Laurent, hope we're close to the final thing now. Just a few minor issues. On 08/19/2011 09:37 AM, Laurent Pinchart wrote: > This API will be used to support YUV frame buffer formats in a standard > way. > > Last but not least, create a much needed fbdev API documentation and > document the f

[PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API

2011-08-19 Thread Laurent Pinchart
This API will be used to support YUV frame buffer formats in a standard way. Last but not least, create a much needed fbdev API documentation and document the format setting APIs. Signed-off-by: Laurent Pinchart --- Documentation/fb/api.txt | 299 ++