Re: [PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag

2014-06-06 Thread Hans Verkuil
On 06/06/2014 03:42 PM, Laurent Pinchart wrote: > On Friday 06 June 2014 11:55:49 Hans Verkuil wrote: >> On 06/06/2014 11:46 AM, Laurent Pinchart wrote: >>> On Friday 06 June 2014 11:31:55 Hans Verkuil wrote: On 06/06/2014 11:19 AM, Laurent Pinchart wrote: > On Friday 06 June 2014 14:31:15

Re: [PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag

2014-06-06 Thread Laurent Pinchart
On Friday 06 June 2014 11:55:49 Hans Verkuil wrote: > On 06/06/2014 11:46 AM, Laurent Pinchart wrote: > > On Friday 06 June 2014 11:31:55 Hans Verkuil wrote: > >> On 06/06/2014 11:19 AM, Laurent Pinchart wrote: > >>> On Friday 06 June 2014 14:31:15 Pawel Osciak wrote: > Hi Laurent, > Than

Re: [PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag

2014-06-06 Thread Hans Verkuil
On 06/06/2014 11:46 AM, Laurent Pinchart wrote: > Hi Hans, > > On Friday 06 June 2014 11:31:55 Hans Verkuil wrote: >> On 06/06/2014 11:19 AM, Laurent Pinchart wrote: >>> Hi Pawel, >>> >>> On Friday 06 June 2014 14:31:15 Pawel Osciak wrote: Hi Laurent, Thanks for the patch. Did you test t

Re: [PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag

2014-06-06 Thread Laurent Pinchart
Hi Hans, On Friday 06 June 2014 11:31:55 Hans Verkuil wrote: > On 06/06/2014 11:19 AM, Laurent Pinchart wrote: > > Hi Pawel, > > > > On Friday 06 June 2014 14:31:15 Pawel Osciak wrote: > >> Hi Laurent, > >> Thanks for the patch. Did you test this to work in fileio mode? Looks > >> like it should,

Re: [PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag

2014-06-06 Thread Hans Verkuil
On 06/06/2014 11:19 AM, Laurent Pinchart wrote: > Hi Pawel, > > On Friday 06 June 2014 14:31:15 Pawel Osciak wrote: >> Hi Laurent, >> Thanks for the patch. Did you test this to work in fileio mode? Looks >> like it should, but would like to make sure. > > No, I haven't tested it. The OMAP4 ISS dr

Re: [PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag

2014-06-06 Thread Laurent Pinchart
Hi Pawel, On Friday 06 June 2014 14:31:15 Pawel Osciak wrote: > Hi Laurent, > Thanks for the patch. Did you test this to work in fileio mode? Looks > like it should, but would like to make sure. No, I haven't tested it. The OMAP4 ISS driver, which is my test target for this patch, doesn't suppor

Re: [PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag

2014-06-05 Thread Pawel Osciak
Hi Laurent, Thanks for the patch. Did you test this to work in fileio mode? Looks like it should, but would like to make sure. Thanks, Pawel On Thu, Jun 5, 2014 at 9:23 PM, Laurent Pinchart wrote: > When a fatal error occurs that render the device unusable, the only > options for a driver to sign

[PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag

2014-06-05 Thread Laurent Pinchart
When a fatal error occurs that render the device unusable, the only options for a driver to signal the error condition to userspace is to set the V4L2_BUF_FLAG_ERROR flag when dequeuing buffers and to return an error from the buffer prepare handler when queuing buffers. The buffer error flag indic