Re: [PATCH][media] SI2168: Resolve unknown chip version errors with different HVR22x5 models

2015-06-11 Thread Steven Toth
On Fri, Jun 5, 2015 at 9:40 AM, Olli Salonen wrote: > Hi Steven, > > It seems to me that that part of the code is identical to your driver, no? Sorry for the noise. I'm been swamped with a couple of things and just getting back to the ML now. You are correct. -- Steven Toth - Kernel Labs http:

Re: [PATCH][media] SI2168: Resolve unknown chip version errors with different HVR22x5 models

2015-06-06 Thread Olli Salonen
Hi, Indeed, the HVR-2205 I have works fine with that patch reverted and after setting REGLEN_0bit for the Si2168 chips in the saa7164-cards. The chip detection and firmware load is correct now. [ 2046.684246] si2168 2-0064: found a 'Silicon Labs Si2168-B40' [ 2046.684278] si2168 2-0064: download

Re: [PATCH][media] SI2168: Resolve unknown chip version errors with different HVR22x5 models

2015-06-05 Thread Antti Palosaari
On 06/05/2015 04:40 PM, Olli Salonen wrote: Hi Steven, It seems to me that that part of the code is identical to your driver, no? The media_tree driver: retval = saa7164_api_i2c_read(bus, msgs[i].addr, 0 /* reglen */, NULL /* re

Re: [PATCH][media] SI2168: Resolve unknown chip version errors with different HVR22x5 models

2015-06-05 Thread Olli Salonen
Hi Steven, It seems to me that that part of the code is identical to your driver, no? The media_tree driver: retval = saa7164_api_i2c_read(bus, msgs[i].addr, 0 /* reglen */, NULL /* reg */, msgs[i].len, msgs[i].buf); It's exactly th

Re: [PATCH][media] SI2168: Resolve unknown chip version errors with different HVR22x5 models

2015-06-04 Thread Steven Toth
On Thu, Jun 4, 2015 at 9:22 AM, Olli Salonen wrote: > I compiled an old HVR-2205 driver from my git tree: > https://github.com/trsqr/media_tree/tree/hvr2205 https://github.com/trsqr/media_tree/commit/61c2ef874b8a9620f498c9a4ab4138e97119462b That's the difference perhaps. -- Steven Toth - Kerne

Re: [PATCH][media] SI2168: Resolve unknown chip version errors with different HVR22x5 models

2015-06-04 Thread Antti Palosaari
I suspect saa7164 driver. It has some strange looking I2C hacks. It has even some logic to split register and data - which I2C adapter should not be aware at all - it just should transfer bulk bytes. regards Antti On 06/04/2015 04:22 PM, Olli Salonen wrote: I compiled an old HVR-2205 driver f

Re: [PATCH][media] SI2168: Resolve unknown chip version errors with different HVR22x5 models

2015-06-04 Thread Olli Salonen
I compiled an old HVR-2205 driver from my git tree: https://github.com/trsqr/media_tree/tree/hvr2205 And kaboom, the device is identified correctly and correct firmware is loaded: [ 882.227379] si2168 1-0064: found a 'Silicon Labs Si2168-B40' [ 882.227763] si2168 1-0064: downloading firmware fr

Re: [PATCH][media] SI2168: Resolve unknown chip version errors with different HVR22x5 models

2015-06-04 Thread Steven Toth
>> This fix works well for me and properly enables DVB-T tuning behavior >> using tzap. >> >> Thanks to Peter Faulkner-Ball for describing his workaround. > > > hymm, I am not sure that patch at all. It is Olli who has been responsible > adding support for multiple chip revisions, so I will leave t

Re: [PATCH][media] SI2168: Resolve unknown chip version errors with different HVR22x5 models

2015-06-04 Thread Olli Salonen
I'll test it with my old code I should have hanging around still somewhere. I'm sure the chip on my card has been previously been identified as Si2168-B40 by the code (I posted the logs already earlier) and it definitely has not turned into a Si2168-D40 chip somehow. I don't think there's version

Re: [PATCH][media] SI2168: Resolve unknown chip version errors with different HVR22x5 models

2015-06-04 Thread Antti Palosaari
On 06/04/2015 03:38 PM, Steven Toth wrote: We're seeing a mix of SI2168 demodulators appearing on HVR2205 and HVR2215 cards, the chips are stamped with different build dates, verified on my cards. The si2168 driver detects some cards fine, others not at all. I can reproduce the working and non-w

[PATCH][media] SI2168: Resolve unknown chip version errors with different HVR22x5 models

2015-06-04 Thread Steven Toth
We're seeing a mix of SI2168 demodulators appearing on HVR2205 and HVR2215 cards, the chips are stamped with different build dates, verified on my cards. The si2168 driver detects some cards fine, others not at all. I can reproduce the working and non-working case. The fix, if we detect a newer ca