Re: [PATCH] [media] DocBook: Use base64 for gif/png files

2011-06-16 Thread Christoph Hellwig
On Thu, Jun 16, 2011 at 11:15:19AM -0300, Mauro Carvalho Chehab wrote:
 The patch utility doesn't work with non-binary files. This causes some
 tools to break, like generating tarball targets and the scripts that
 generate diff patches at http://www.kernel.org/pub/linux/kernel/v2.6/.
 
 So, let's convert all binaries to ascii using base64, and add a
 logic at Makefile to convert them back into binaries at runtime.

Given that all the gifs are not just relatively trivial, but also things
that looks like they originated or at least should as vector graphics
I'd recommend to replace them by SVG files.  These also have the benefit
of actually beeing practically patchable.

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] [media] DocBook: Use base64 for gif/png files

2011-06-16 Thread Mauro Carvalho Chehab
Em 16-06-2011 11:25, Christoph Hellwig escreveu:
 On Thu, Jun 16, 2011 at 11:15:19AM -0300, Mauro Carvalho Chehab wrote:
 The patch utility doesn't work with non-binary files. This causes some
 tools to break, like generating tarball targets and the scripts that
 generate diff patches at http://www.kernel.org/pub/linux/kernel/v2.6/.

 So, let's convert all binaries to ascii using base64, and add a
 logic at Makefile to convert them back into binaries at runtime.
 
 Given that all the gifs are not just relatively trivial, but also things
 that looks like they originated or at least should as vector graphics
 I'd recommend to replace them by SVG files.  These also have the benefit
 of actually beeing practically patchable.

This is a good idea, but it would require to re-draw everything, as we don't
have those files vectorized (I might have one or two svg files on an older
tree, as I had to re-generate some graphics that used to be just pdf).

One of the reasons why SVG was not used in the past is that there used to have 
a 
target to generate pdf files, and I think that the DocBook tools available on 
that time weren't capable of working with svg. Not sure if xmlto currently
supports it, but, as we've removed the pdf generation for the media API, 
changing them to svg is ok.

Mauro.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html