Re: [PATCH] [media] staging/imx: remove confusing IS_ERR_OR_NULL usage

On Thu, Jun 29, 2017 at 11:13 AM, Philipp Zabel wrote: >> @@ -134,23 +134,26 @@ static void csi_idmac_put_ipu_resources(struct >> csi_priv *priv) >> static int csi_idmac_get_ipu_resources(struct csi_priv *priv) >> { >> int ch_num, ret; >> + struct ipu_smfc

Re: [PATCH] [media] staging/imx: remove confusing IS_ERR_OR_NULL usage

Hi Arnd, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20170630] [cannot apply to v4.12-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] [media] staging/imx: remove confusing IS_ERR_OR_NULL usage

Hi Arnd, thank you for the cleanup. I see two issues below: On Wed, 2017-06-28 at 22:13 +0200, Arnd Bergmann wrote: > While looking at a compiler warning, I noticed the use of > IS_ERR_OR_NULL, which is generally a sign of a bad API design > and should be avoided. > > In this driver, this is

[PATCH] [media] staging/imx: remove confusing IS_ERR_OR_NULL usage

While looking at a compiler warning, I noticed the use of IS_ERR_OR_NULL, which is generally a sign of a bad API design and should be avoided. In this driver, this is fairly easy, we can simply stop storing error pointers in persistent structures, and change the one function that might return