Re: [PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-17 Thread Lubomir Rintel
On Wed, 2013-06-12 at 09:49 +0200, Hans Verkuil wrote: ... > > > > +static int usbtv_queryctrl(struct file *file, void *priv, > > > > + struct v4l2_queryctrl *ctrl) > > > > +{ > > > > + return -EINVAL; > > > > +} > > > > > > Drop this ioctl. If it doesn't do any

Re: [PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-12 Thread Hans Verkuil
On Mon 10 June 2013 19:43:31 Lubomir Rintel wrote: > Reverse-engineered driver for cheapo video digitizer, made from observations > of > Windows XP driver. The protocol is not yet completely understood, so far we > don't provide any controls, only support a single format out of three and > don't

Re: [PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-12 Thread Hans Verkuil
On Mon 10 June 2013 19:38:54 Lubomir Rintel wrote: > On Mon, 2013-06-10 at 13:05 +0200, Hans Verkuil wrote: > > > Also, I the hardware uses V4L2_FIELD_ALTERNATE interlacing, but I > > > couldn't make > > > it work, > > > > What didn't work exactly? > > Both mplayer and gstream v4l2src displayed

[PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-10 Thread Lubomir Rintel
Reverse-engineered driver for cheapo video digitizer, made from observations of Windows XP driver. The protocol is not yet completely understood, so far we don't provide any controls, only support a single format out of three and don't support the audio device. Signed-off-by: Lubomir Rintel Cc: M

Re: [PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-10 Thread Lubomir Rintel
On Mon, 2013-06-10 at 13:05 +0200, Hans Verkuil wrote: > > Also, I the hardware uses V4L2_FIELD_ALTERNATE interlacing, but I couldn't > > make > > it work, > > What didn't work exactly? Both mplayer and gstream v4l2src displayed only half of an image. Not sure which combinations of flags did I u

Re: [PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-10 Thread Hans Verkuil
Just as I sent my reply I realized that my notes w.r.t. field handling were incomplete. So I'll try to clarify it below. On Mon June 10 2013 13:05:04 Hans Verkuil wrote: > Hi Lubomir! > > Thanks for working on this. > > I've got some review comments below... > > On Mon June 10 2013 11:52:11 Lub

Re: [PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-10 Thread Hans Verkuil
Hi Lubomir! Thanks for working on this. I've got some review comments below... On Mon June 10 2013 11:52:11 Lubomir Rintel wrote: > Reverse-engineered driver for cheapo video digitizer, made from observations > of > Windows XP driver. The protocol is not yet completely understood, so far we > d

[PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-10 Thread Lubomir Rintel
Reverse-engineered driver for cheapo video digitizer, made from observations of Windows XP driver. The protocol is not yet completely understood, so far we don't provide any controls, only support a single format out of three and don't support the audio device. Signed-off-by: Lubomir Rintel Cc: M