Re: [PATCH] [media] uvcvideo: Fix marking buffer erroneous in case of FID toggling

2014-04-01 Thread Laurent Pinchart
Hi Anton, On Saturday 29 March 2014 09:28:02 Anton Leontiev wrote: 28.03.2014 20:12, Laurent Pinchart пишет: + * Set error flag for incomplete buffer. + */ +static void uvc_buffer_check_bytesused(const struct uvc_streaming *const stream, No need for the second const keyword here.

Re: [PATCH] [media] uvcvideo: Fix marking buffer erroneous in case of FID toggling

2014-03-28 Thread Laurent Pinchart
Hi Anton, On Friday 28 March 2014 07:58:00 Anton Leontiev wrote: 26.03.2014 21:41, Laurent Pinchart wrote: On Tuesday 25 March 2014 08:40:57 Anton Leontiev wrote: Set error bit for incomplete buffers when end of buffer is detected by FID toggling (for example when last transaction with EOF

Re: [PATCH] [media] uvcvideo: Fix marking buffer erroneous in case of FID toggling

2014-03-28 Thread Anton Leontiev
28.03.2014 20:12, Laurent Pinchart пишет: + * Set error flag for incomplete buffer. + */ +static void uvc_buffer_check_bytesused(const struct uvc_streaming *const stream, No need for the second const keyword here. I would have used uvc_video_ as a prefix, to be in sync with the

Re: [PATCH] [media] uvcvideo: Fix marking buffer erroneous in case of FID toggling

2014-03-27 Thread Anton Leontiev
26.03.2014 21:41, Laurent Pinchart wrote: Hi Anton, Thank you for the patch. On Tuesday 25 March 2014 08:40:57 Anton Leontiev wrote: Set error bit for incomplete buffers when end of buffer is detected by FID toggling (for example when last transaction with EOF is lost). This prevents

Re: [PATCH] [media] uvcvideo: Fix marking buffer erroneous in case of FID toggling

2014-03-26 Thread Laurent Pinchart
Hi Anton, Thank you for the patch. On Tuesday 25 March 2014 08:40:57 Anton Leontiev wrote: Set error bit for incomplete buffers when end of buffer is detected by FID toggling (for example when last transaction with EOF is lost). This prevents passing incomplete buffers to the userspace. But

[PATCH] [media] uvcvideo: Fix marking buffer erroneous in case of FID toggling

2014-03-24 Thread Anton Leontiev
Set error bit for incomplete buffers when end of buffer is detected by FID toggling (for example when last transaction with EOF is lost). This prevents passing incomplete buffers to the userspace. Signed-off-by: Anton Leontiev bun...@t-25.ru --- drivers/media/usb/uvc/uvc_video.c | 21