Re: [PATCH] DTV2000 H Plus issues
An updated patch that includes the PxDVR3200 H (107d:6f39) support is now available at http://istvanv.users.sourceforge.net/v4l/xc4000.html. On 03/22/2010 07:33 PM, istva...@mailbox.hu wrote: On 03/15/2010 05:15 AM, Devin Heitmueller wrote: I'll try to go through my tree and see if I can get something upstream this week which you could build on. Are there any news on this ? By the way, I have just received this mail from Mirek Slugen, with a patch for PxDVR3200 with XC4000 tuner. Should that patch also be submitted ? On 03/22/2010 04:40 PM, Mirek Slugeň wrote: First I would like to thank you for your work on XC4000 Leadtek tuners, analog TV, analog FM and DVB-T works great. I created patch for new revision of Leadtek DVR3200 (xc4000) based on your patch and it works also (patch is included). After long testing I found only one small bug, signal strength is not working on DVB-T XC4000 based tuners, so i will try to fix it. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] DTV2000 H Plus issues
On 03/15/2010 05:15 AM, Devin Heitmueller wrote: I'll try to go through my tree and see if I can get something upstream this week which you could build on. Are there any news on this ? By the way, I have just received this mail from Mirek Slugen, with a patch for PxDVR3200 with XC4000 tuner. Should that patch also be submitted ? On 03/22/2010 04:40 PM, Mirek Slugeň wrote: First I would like to thank you for your work on XC4000 Leadtek tuners, analog TV, analog FM and DVB-T works great. I created patch for new revision of Leadtek DVR3200 (xc4000) based on your patch and it works also (patch is included). After long testing I found only one small bug, signal strength is not working on DVB-T XC4000 based tuners, so i will try to fix it. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] DTV2000 H Plus issues
On 03/15/2010 05:15 AM, Devin Heitmueller wrote: I've done essentially no analysis into the tuning performance of the current driver - validating different frequency ranges and modulation types or bandwidths. I've done no testing of tuning lock time, minimal application validation Well, so far it definitely seems usable and not apparently worse than on Windows. If more developers can test and review it, then it is more likely that any issues can be found and fixed or improved. and no effort toward making sure the power management works. I did implement power management (by writing to register 8, and setting a flag that forces resetting the tuner and reloading all firmware data on the next use), although it is disabled by default for the cards that I added support for (it is apparently not used on Windows, either). I'll try to go through my tree and see if I can get something upstream this week which you could build on. I think adding xc4000.c/h and the few changes shown at the end of this post to incorporate XC4000 as a tuner type should be enough. Did you review the changes I made to the XC4000 driver ? Is there something that is unneeded or should be done differently ? Do you have a fixed firmware file, or are the ones I created usable ? Once that is done, you will need to break up your huge patch into a series of small incremental patches (with proper descriptions for the changes), since there is no way a single patch is going to be accepted upstream which has all of your changes. OK. Should I also create patches for any of the unrelated cx88 fixes/changes ? Also, you should *not* be submitting board profiles that are completely unvalidated. I saw your email on Feb 19th, where you dumped out a list of tuners that you think might *possibly* work. You should only submit board definitions for devices that either you have tested or you have gotten a user to test. It is far worse to have broken code in there (creating the illusion of a product being supported), then for there to be no support at all. When users complain about a particular board not working, you can work with them to get it supported. Of the additional boards, 107d:6f38 (WinFast DTV1800 H with XC4000 tuner instead of XC3028) has been reported by one user to work in analog mode, while DVB was untested. Is that enough to keep the board profile ? I have 107d:6f42 (DTV2000 H Plus), and tested it extensively in analog and FM radio mode; another user tested DVB-T, and reported it to work well (I have got no information about details like bandwidth used, though). As far as I know, the only difference between the above two cards that is relevant to drivers is that the latter has an additional GPIO for selecting the antenna/cable RF input. I have no problems with removing the various TV2000 XP Global revisions from the patches, as I do not even know if anyone actually has one of those cards. diff -r -d -N -U4 v4l-dvb-7a58d924fb04.old/linux/drivers/media/common/tuners/Kconfig v4l-dvb-7a58d924fb04/linux/drivers/media/common/tuners/Kconfig --- v4l-dvb-7a58d924fb04.old/linux/drivers/media/common/tuners/Kconfig 2010-03-10 03:00:59.0 +0100 +++ v4l-dvb-7a58d924fb04/linux/drivers/media/common/tuners/Kconfig 2010-03-10 17:12:02.0 +0100 @@ -22,8 +22,9 @@ default VIDEO_MEDIA I2C depends on VIDEO_MEDIA I2C select MEDIA_TUNER_XC2028 if !MEDIA_TUNER_CUSTOMISE select MEDIA_TUNER_XC5000 if !MEDIA_TUNER_CUSTOMISE + select MEDIA_TUNER_XC4000 if !MEDIA_TUNER_CUSTOMISE select MEDIA_TUNER_MT20XX if !MEDIA_TUNER_CUSTOMISE select MEDIA_TUNER_TDA8290 if !MEDIA_TUNER_CUSTOMISE select MEDIA_TUNER_TEA5761 if !MEDIA_TUNER_CUSTOMISE select MEDIA_TUNER_TEA5767 if !MEDIA_TUNER_CUSTOMISE @@ -150,8 +151,17 @@ A driver for the silicon tuner XC5000 from Xceive. This device is only used inside a SiP called together with a demodulator for now. +config MEDIA_TUNER_XC4000 + tristate Xceive XC4000 silicon tuner + depends on VIDEO_MEDIA I2C + default m if MEDIA_TUNER_CUSTOMISE + help + A driver for the silicon tuner XC4000 from Xceive. + This device is only used inside a SiP called together with a + demodulator for now. + config MEDIA_TUNER_MXL5005S tristate MaxLinear MSL5005S silicon tuner depends on VIDEO_MEDIA I2C default m if MEDIA_TUNER_CUSTOMISE diff -r -d -N -U4 v4l-dvb-7a58d924fb04.old/linux/drivers/media/common/tuners/Makefile v4l-dvb-7a58d924fb04/linux/drivers/media/common/tuners/Makefile --- v4l-dvb-7a58d924fb04.old/linux/drivers/media/common/tuners/Makefile 2010-03-10 03:00:59.0 +0100 +++ v4l-dvb-7a58d924fb04/linux/drivers/media/common/tuners/Makefile 2010-03-10 17:12:02.0 +0100 @@ -15,8 +15,9 @@ obj-$(CONFIG_MEDIA_TUNER_TDA9887) += tda9887.o
Re: [PATCH] DTV2000 H Plus issues
On 02/18/2010 01:11 AM, Devin Heitmueller wrote: Yeah, my plan at this point was to submit a PULL request once I felt the driver is stable For those particular cards that my patch adds support for, it seems to be stable, and I have been using it for months. Perhaps stability issues in xc4000.c are specific to the PCTV 340e and its dib0700 I2C problems ? -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] DTV2000 H Plus issues
On Sun, Mar 14, 2010 at 1:58 PM, istva...@mailbox.hu istva...@mailbox.hu wrote: On 02/18/2010 01:11 AM, Devin Heitmueller wrote: Yeah, my plan at this point was to submit a PULL request once I felt the driver is stable For those particular cards that my patch adds support for, it seems to be stable, and I have been using it for months. Perhaps stability issues in xc4000.c are specific to the PCTV 340e and its dib0700 I2C problems ? Different people have different standards of quality. For example, I've done essentially no analysis into the tuning performance of the current driver - validating different frequency ranges and modulation types or bandwidths. I've done no testing of tuning lock time, minimal application validation, and no effort toward making sure the power management works. Sure, I can just throw the driver upstream as-is, but I've been hesitant to merge something with questionable quality, as it reflects poorly on my reputation. Right now it's in a development tree because it's what I would consider alpha quality, where only advanced users will install it and they know to proceed at your own risk. And none of the above is related to the problem with the dib0700 i2c master. All that said, the situation hasn't been helped by the fact that I'm working on five different projects currently (as102, drx-d, xc4000, em28xx, and now ngene), nor the fact that I'm also the maintainer for a variety of other tuner products (and the significant support burden that creates). Bear in mind that I am aware of the frustration that when someone has patches and cannot get the maintainer to find the time to review/comment/merge. I've been in that situation myself more than once. I'll try to go through my tree and see if I can get something upstream this week which you could build on. Once that is done, you will need to break up your huge patch into a series of small incremental patches (with proper descriptions for the changes), since there is no way a single patch is going to be accepted upstream which has all of your changes. Also, you should *not* be submitting board profiles that are completely unvalidated. I saw your email on Feb 19th, where you dumped out a list of tuners that you think might *possibly* work. You should only submit board definitions for devices that either you have tested or you have gotten a user to test. It is far worse to have broken code in there (creating the illusion of a product being supported), then for there to be no support at all. When users complain about a particular board not working, you can work with them to get it supported. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] DTV2000 H Plus issues
I have finally received some feedback on DVB-T, and it reportedly works, although with a minor bug: it was necessary to use the cable connector instead of the antenna one. There is an updated patch at the web page http://www.sharemation.com/IstvanV/v4l/xc4000.html that attempts to correct this problem. It also includes a few CX88 changes that are not related to adding support for XC4000 based cards, and could possibly be released as separate patches: - implements a sharpness control using the CX2388x peaking filter and changing the notch filter - in two places (cx88-core.c and cx88-video.c) code that checked for CX88_VMUX_TELEVISION did not also check for CX88_VMUX_CABLE; this was the reason why selecting the audio standard did not work for the cable input - in cx88-mpeg.c, there was code that set core-input to CX88_VMUX_DVB; this does not seem to make sense, since core-input is an index to an array (core-board.input), while the CX88_VMUX_* values are not intended to be used as indexes, but rather values of the 'type' member of struct cx88_input. But it is also not obvious if this has any actual effect other than what is reported as the current input when queried by an application. In any case, I changed the code to search for an input of type CX88_VMUX_DVB, or set the input to 0 if it is not found -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] DTV2000 H Plus issues
Well, it is not really a problem, if it is not merged, so this updated version is only for those who want to test it: http://www.sharemation.com/IstvanV/v4l/xc4000-winfast-14021dfc00f3.patch - in xc4000.c, power management may default to on or off depending on the card type - autodetects and (hopefully) supports cards with the following PCI IDs, based on Windows INF files: 107D:6619 WinFast TV2000 XP Global (this is actually the same as 6618 and 6F18) 107D:6F36 WinFast TV2000 XP Global with XC4100 (analog-only XC4000 ?) tuner 107D:6F38 WinFast DTV1800 H with XC4000 tuner 107D:6F42 WinFast DTV2000 H Plus 107D:6F43 WinFast TV2000 XP Global with XC4100 tuner and different GPIOs Not all of these card versions may actually exist in practice, though, only 6F38 and 6F42 are confirmed so far. - added a new sharpness control to the CX88 driver On 02/18/2010 12:59 AM, Devin Heitmueller wrote: I would hate to come across as a jerk here, but he cannot provide his SOB for this patch, as I wrote about 95% of the code here. It's derived from a tree I have been working on for the PCTV 340e: -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] DTV2000 H Plus issues
Hi Istvan, istva...@mailbox.hu wrote: The attached new patches contain all the previous changes merged, and are against the latest v4l-dvb revision. Please provide your Signed-off-by. This is a basic requirement for your driver to be accepted. Please read: http://linuxtv.org/hg/v4l-dvb/raw-file/tip/README.patches for instructions on how to submit a patch. Cheers, Mauro. By the way, someone on a forum reported having a DTV1800 H card with a PCI ID of 107d:6f38. This seems to differ from the already supported DTV1800 H version (107d:6654) by having an XC4000 tuner instead of XC3028. From the Windows INF files it seems this card is very similar to the DTV2000 H Plus, but there is no GPIO for selecting antenna/cable input. On 02/11/2010 08:16 PM, istva...@mailbox.hu wrote: Update: the following patch, which should be applied after the previous ones, makes a few additional changes to the XC4000 driver: - adds support for DTV7 - implements power management - adds a mutex and locking for tuner operations - some unused or unneeded code has been removed On 02/09/2010 06:35 PM, istva...@mailbox.hu wrote: There are two separate patches for v4l-dvb revision 28f5eca12bb0: the first one adds the XC4000 driver, while the second one adds support for the Leadtek WinFast DTV2000H Plus card in the CX88 driver. http://www.sharemation.com/IstvanV/v4l/xc4000-28f5eca12bb0.patch http://www.sharemation.com/IstvanV/v4l/cx88-dtv2000h+-28f5eca12bb0.patch These new firmware files are more complete than the previous ones, but are not compatible with the original driver. Both version 1.2 and 1.4 are available: http://www.sharemation.com/IstvanV/v4l/xc4000-1.2.fw http://www.sharemation.com/IstvanV/v4l/xc4000-1.4.fw The following simple utility was used for creating the firmware files. http://www.sharemation.com/IstvanV/v4l/xc4000fw.c -- Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] DTV2000 H Plus issues
On Wed, Feb 17, 2010 at 6:51 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Hi Istvan, istva...@mailbox.hu wrote: The attached new patches contain all the previous changes merged, and are against the latest v4l-dvb revision. Please provide your Signed-off-by. This is a basic requirement for your driver to be accepted. Please read: http://linuxtv.org/hg/v4l-dvb/raw-file/tip/README.patches for instructions on how to submit a patch. Hi Mauro, I would hate to come across as a jerk here, but he cannot provide his SOB for this patch, as I wrote about 95% of the code here. It's derived from a tree I have been working on for the PCTV 340e: http://kernellabs.com/hg/~dheitmueller/pctv-340e-2/ I know that istvan wants to see the support merged, but he is going to have to wait a bit longer since he is not the author or maintainer of the driver in question. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] DTV2000 H Plus issues
Devin Heitmueller wrote: On Wed, Feb 17, 2010 at 6:51 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Hi Istvan, istva...@mailbox.hu wrote: The attached new patches contain all the previous changes merged, and are against the latest v4l-dvb revision. Please provide your Signed-off-by. This is a basic requirement for your driver to be accepted. Please read: http://linuxtv.org/hg/v4l-dvb/raw-file/tip/README.patches for instructions on how to submit a patch. Hi Mauro, I would hate to come across as a jerk here, but he cannot provide his SOB for this patch, as I wrote about 95% of the code here. It's derived from a tree I have been working on for the PCTV 340e: http://kernellabs.com/hg/~dheitmueller/pctv-340e-2/ I know that istvan wants to see the support merged, but he is going to have to wait a bit longer since he is not the author or maintainer of the driver in question. OK. Then, I need your SOB for the 95% of the code, and his SOB for the remaining ;) -- Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] DTV2000 H Plus issues
On Wed, Feb 17, 2010 at 7:08 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: OK. Then, I need your SOB for the 95% of the code, and his SOB for the remaining ;) Yeah, my plan at this point was to submit a PULL request once I felt the driver is stable (and I had already offered to apply his incremental patches onto my tree before said pull request). Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
