Re: [PATCH] MAINTAINERS & files: Canonize the e-mails I use at files
On Fri 04-05-18 08:33:55, Mauro Carvalho Chehab wrote: > Em Fri, 04 May 2018 13:58:39 +0300 > Jani Nikulaescreveu: > > > On Fri, 04 May 2018, Mauro Carvalho Chehab > > wrote: > > > From now on, I'll start using my @kernel.org as my development e-mail. > > > > > > As such, let's remove the entries that point to the old > > > mche...@s-opensource.com at MAINTAINERS file. > > > > > > For the files written with a copyright with mchehab@s-opensource, > > > let's keep Samsung on their names, using mchehab+sams...@kernel.org, > > > in order to keep pointing to my employer, with sponsors the work. > > > > > > For the files written before I join Samsung (on July, 4 2013), > > > let's just use mche...@kernel.org. > > > > > > For bug reports, we can simply point to just kernel.org, as > > > this will reach my mchehab+samsung inbox anyway. > > > > I suppose this begs the question, why do we insist on adding our email > > addresses all over the place? On a quick grep, there are at least 40k+ > > email addresses in the sources. Do we expect them all to be up-to-date > > too? > > That's a good question. > > The usual use case is that the e-mail allows people to contact developers > if needed. Such contact could simply due to something like handling SPDX > or other license-related issues or for troubleshooting. > > There's also another reason (with IMHO, is more relevant): just the name > may not be enough to uniquely identify the author of some code. While > that might happen on occidental Countries, this is a way more relevant > for Asian Countries. For example, there are very few surnames on > some Countries there[1], and common names are usually... common. So, it > is not hard to find several people with exactly the same name working at > the same company. I've seen e-mails from those people that are things like > john.doe51@some.company, john.doe69@some.company, ... > > [1] For example: https://en.wikipedia.org/wiki/List_of_Korean_surnames. > > The e-mail is a way to uniquely identify a person. If we remove it, > then we may need to add another thing instead (like parents names, > security number or whatever), with would be weird, IMO. > > As we all use e-mails to uniquely identify contributors submissions, > IMHO, the best is to keep using e-mails. The side effect is that > we should keep those emails updated. Understood but e-mails in code get stale eventually as people rarely update those. So I think having a contact email in MAINTAINERS and git logs is enough for practical purposes. Honza -- Jan Kara SUSE Labs, CR
Re: [PATCH] MAINTAINERS & files: Canonize the e-mails I use at files
Em Fri, 04 May 2018 13:58:39 +0300 Jani Nikulaescreveu: > On Fri, 04 May 2018, Mauro Carvalho Chehab wrote: > > From now on, I'll start using my @kernel.org as my development e-mail. > > > > As such, let's remove the entries that point to the old > > mche...@s-opensource.com at MAINTAINERS file. > > > > For the files written with a copyright with mchehab@s-opensource, > > let's keep Samsung on their names, using mchehab+sams...@kernel.org, > > in order to keep pointing to my employer, with sponsors the work. > > > > For the files written before I join Samsung (on July, 4 2013), > > let's just use mche...@kernel.org. > > > > For bug reports, we can simply point to just kernel.org, as > > this will reach my mchehab+samsung inbox anyway. > > I suppose this begs the question, why do we insist on adding our email > addresses all over the place? On a quick grep, there are at least 40k+ > email addresses in the sources. Do we expect them all to be up-to-date > too? That's a good question. The usual use case is that the e-mail allows people to contact developers if needed. Such contact could simply due to something like handling SPDX or other license-related issues or for troubleshooting. There's also another reason (with IMHO, is more relevant): just the name may not be enough to uniquely identify the author of some code. While that might happen on occidental Countries, this is a way more relevant for Asian Countries. For example, there are very few surnames on some Countries there[1], and common names are usually... common. So, it is not hard to find several people with exactly the same name working at the same company. I've seen e-mails from those people that are things like john.doe51@some.company, john.doe69@some.company, ... [1] For example: https://en.wikipedia.org/wiki/List_of_Korean_surnames. The e-mail is a way to uniquely identify a person. If we remove it, then we may need to add another thing instead (like parents names, security number or whatever), with would be weird, IMO. As we all use e-mails to uniquely identify contributors submissions, IMHO, the best is to keep using e-mails. The side effect is that we should keep those emails updated. - In the specific case of this patch, as I'm now just using @kernel.org everywhere within the Kernel tree, I don't expect needing to change it in long term. Thanks, Mauro
Re: [PATCH] MAINTAINERS & files: Canonize the e-mails I use at files
On Fri, 04 May 2018, Mauro Carvalho Chehabwrote: > From now on, I'll start using my @kernel.org as my development e-mail. > > As such, let's remove the entries that point to the old > mche...@s-opensource.com at MAINTAINERS file. > > For the files written with a copyright with mchehab@s-opensource, > let's keep Samsung on their names, using mchehab+sams...@kernel.org, > in order to keep pointing to my employer, with sponsors the work. > > For the files written before I join Samsung (on July, 4 2013), > let's just use mche...@kernel.org. > > For bug reports, we can simply point to just kernel.org, as > this will reach my mchehab+samsung inbox anyway. I suppose this begs the question, why do we insist on adding our email addresses all over the place? On a quick grep, there are at least 40k+ email addresses in the sources. Do we expect them all to be up-to-date too? BR, Jani. -- Jani Nikula, Intel Open Source Technology Center
[PATCH] MAINTAINERS & files: Canonize the e-mails I use at files
>From now on, I'll start using my @kernel.org as my development e-mail. As such, let's remove the entries that point to the old mche...@s-opensource.com at MAINTAINERS file. For the files written with a copyright with mchehab@s-opensource, let's keep Samsung on their names, using mchehab+sams...@kernel.org, in order to keep pointing to my employer, with sponsors the work. For the files written before I join Samsung (on July, 4 2013), let's just use mche...@kernel.org. For bug reports, we can simply point to just kernel.org, as this will reach my mchehab+samsung inbox anyway. Signed-off-by: Mauro Carvalho ChehabSigned-off-by: Brian Warner Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/parse-headers.rst | 4 ++-- Documentation/media/uapi/rc/keytable.c.rst | 2 +- Documentation/media/uapi/v4l/v4l2grab.c.rst | 2 +- Documentation/sphinx/parse-headers.pl | 4 ++-- .../zh_CN/video4linux/v4l2-framework.txt| 4 ++-- MAINTAINERS | 17 - drivers/media/i2c/saa7115.c | 2 +- drivers/media/i2c/saa711x_regs.h| 2 +- drivers/media/i2c/tda7432.c | 2 +- drivers/media/i2c/tvp5150.c | 2 +- drivers/media/i2c/tvp5150_reg.h | 2 +- drivers/media/i2c/tvp7002.c | 2 +- drivers/media/i2c/tvp7002_reg.h | 2 +- drivers/media/media-devnode.c | 2 +- drivers/media/pci/bt8xx/bttv-audio-hook.c | 2 +- drivers/media/pci/bt8xx/bttv-audio-hook.h | 2 +- drivers/media/pci/bt8xx/bttv-cards.c| 4 ++-- drivers/media/pci/bt8xx/bttv-driver.c | 2 +- drivers/media/pci/bt8xx/bttv-i2c.c | 2 +- drivers/media/pci/cx23885/cx23885-input.c | 2 +- drivers/media/pci/cx88/cx88-alsa.c | 4 ++-- drivers/media/pci/cx88/cx88-blackbird.c | 2 +- drivers/media/pci/cx88/cx88-core.c | 2 +- drivers/media/pci/cx88/cx88-i2c.c | 2 +- drivers/media/pci/cx88/cx88-video.c | 2 +- drivers/media/radio/radio-aimslab.c | 2 +- drivers/media/radio/radio-aztech.c | 2 +- drivers/media/radio/radio-gemtek.c | 2 +- drivers/media/radio/radio-maxiradio.c | 2 +- drivers/media/radio/radio-rtrack2.c | 2 +- drivers/media/radio/radio-sf16fmi.c | 2 +- drivers/media/radio/radio-terratec.c| 2 +- drivers/media/radio/radio-trust.c | 2 +- drivers/media/radio/radio-typhoon.c | 2 +- drivers/media/radio/radio-zoltrix.c | 2 +- drivers/media/rc/keymaps/rc-avermedia-m135a.c | 2 +- drivers/media/rc/keymaps/rc-encore-enltv-fm53.c | 2 +- drivers/media/rc/keymaps/rc-encore-enltv2.c | 2 +- drivers/media/rc/keymaps/rc-kaiomy.c| 2 +- .../media/rc/keymaps/rc-kworld-plus-tv-analog.c | 2 +- drivers/media/rc/keymaps/rc-pixelview-new.c | 2 +- drivers/media/tuners/tea5761.c | 4 ++-- drivers/media/tuners/tea5767.c | 4 ++-- drivers/media/tuners/tuner-xc2028-types.h | 2 +- drivers/media/tuners/tuner-xc2028.c | 4 ++-- drivers/media/tuners/tuner-xc2028.h | 2 +- drivers/media/usb/em28xx/em28xx-camera.c| 2 +- drivers/media/usb/em28xx/em28xx-cards.c | 2 +- drivers/media/usb/em28xx/em28xx-core.c | 4 ++-- drivers/media/usb/em28xx/em28xx-dvb.c | 4 ++-- drivers/media/usb/em28xx/em28xx-i2c.c | 2 +- drivers/media/usb/em28xx/em28xx-input.c | 2 +- drivers/media/usb/em28xx/em28xx-video.c | 4 ++-- drivers/media/usb/em28xx/em28xx.h | 2 +- drivers/media/usb/gspca/zc3xx-reg.h | 2 +- drivers/media/usb/tm6000/tm6000-cards.c | 2 +- drivers/media/usb/tm6000/tm6000-core.c | 2 +- drivers/media/usb/tm6000/tm6000-i2c.c | 2 +- drivers/media/usb/tm6000/tm6000-regs.h | 2 +- drivers/media/usb/tm6000/tm6000-usb-isoc.h | 2 +- drivers/media/usb/tm6000/tm6000-video.c | 2 +- drivers/media/usb/tm6000/tm6000.h | 2 +- drivers/media/v4l2-core/v4l2-dev.c | 4 ++-- drivers/media/v4l2-core/v4l2-ioctl.c| 2 +- drivers/media/v4l2-core/videobuf-core.c | 6 +++--- drivers/media/v4l2-core/videobuf-dma-contig.c | 2 +- drivers/media/v4l2-core/videobuf-dma-sg.c | 6 +++--- drivers/media/v4l2-core/videobuf-vmalloc.c | 4 ++-- include/media/i2c/tvp7002.h | 2 +- include/media/videobuf-core.h | 4 ++-- include/media/videobuf-dma-sg.h | 4 ++-- include/media/videobuf-vmalloc.h| 2 +- scripts/extract_xc3028.pl | 2 +-