[PATCH] c8sectpfe: don't go past channel_data array

2015-08-11 Thread Mauro Carvalho Chehab
As reported by smatch:
drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c:365 
find_channel() error: buffer overflow 'fei-channel_data' 8 = 63

It seems that a cut-and-paste type of error occurred here:
the channel_data array size is C8SECTPFE_MAX_TSIN_CHAN, and not
C8SECTPFE_MAXCHANNEL.

Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com

diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c 
b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
index 3a9109356e67..955d8daf055f 100644
--- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
+++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
@@ -361,7 +361,7 @@ static struct channel_info *find_channel(struct c8sectpfei 
*fei, int tsin_num)
 {
int i;
 
-   for (i = 0; i  C8SECTPFE_MAXCHANNEL; i++) {
+   for (i = 0; i  C8SECTPFE_MAX_TSIN_CHAN; i++) {
if (!fei-channel_data[i])
continue;
 
-- 
2.4.3

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] c8sectpfe: don't go past channel_data array

2015-08-11 Thread Mauro Carvalho Chehab
As reported by smatch:
drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c:365 
find_channel() error: buffer overflow 'fei-channel_data' 8 = 63

It seems that a cut-and-paste type of error occurred here:
the channel_data array size is C8SECTPFE_MAX_TSIN_CHAN, and not
C8SECTPFE_MAXCHANNEL.

Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
---
 drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c 
b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
index 3a9109356e67..955d8daf055f 100644
--- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
+++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
@@ -361,7 +361,7 @@ static struct channel_info *find_channel(struct c8sectpfei 
*fei, int tsin_num)
 {
int i;
 
-   for (i = 0; i  C8SECTPFE_MAXCHANNEL; i++) {
+   for (i = 0; i  C8SECTPFE_MAX_TSIN_CHAN; i++) {
if (!fei-channel_data[i])
continue;
 
-- 
2.4.3

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html