Re: [PATCH] dma-buf: might_sleep() in dma_buf_unmap_attachment()

2012-09-29 Thread Sumit Semwal 

On Friday 28 September 2012 01:09 PM, Maarten Lankhorst wrote:

Op 28-09-12 09:29, Rob Clark schreef:

From: Rob Clark r...@ti.com

We never really clarified if unmap could be done in atomic context.
But since mapping might require sleeping, this implies mutex in use
to synchronize mapping/unmapping, so unmap could sleep as well.  Add
a might_sleep() to clarify this.

Signed-off-by: Rob Clark r...@ti.com
Acked-by: Daniel Vetter daniel.vet...@ffwll.ch
---
  drivers/base/dma-buf.c |2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c
index c30f3e1..877eacb 100644
--- a/drivers/base/dma-buf.c
+++ b/drivers/base/dma-buf.c
@@ -298,6 +298,8 @@ void dma_buf_unmap_attachment(struct dma_buf_attachment 
*attach,
struct sg_table *sg_table,
enum dma_data_direction direction)
  {
+   might_sleep();
+
if (WARN_ON(!attach || !attach-dmabuf || !sg_table))
return;


Looks good to me!

Reviewed-by: Maarten Lankhorst maarten.lankho...@canonical.com

Thanks Rob,

Applied to for-next.

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] dma-buf: might_sleep() in dma_buf_unmap_attachment()

2012-09-28 Thread Rob Clark 
From: Rob Clark r...@ti.com

We never really clarified if unmap could be done in atomic context.
But since mapping might require sleeping, this implies mutex in use
to synchronize mapping/unmapping, so unmap could sleep as well.  Add
a might_sleep() to clarify this.

Signed-off-by: Rob Clark r...@ti.com
Acked-by: Daniel Vetter daniel.vet...@ffwll.ch
---
 drivers/base/dma-buf.c |2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c
index c30f3e1..877eacb 100644
--- a/drivers/base/dma-buf.c
+++ b/drivers/base/dma-buf.c
@@ -298,6 +298,8 @@ void dma_buf_unmap_attachment(struct dma_buf_attachment 
*attach,
struct sg_table *sg_table,
enum dma_data_direction direction)
 {
+   might_sleep();
+
if (WARN_ON(!attach || !attach-dmabuf || !sg_table))
return;
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dma-buf: might_sleep() in dma_buf_unmap_attachment()

2012-09-28 Thread Maarten Lankhorst 
Op 28-09-12 09:29, Rob Clark schreef:
 From: Rob Clark r...@ti.com

 We never really clarified if unmap could be done in atomic context.
 But since mapping might require sleeping, this implies mutex in use
 to synchronize mapping/unmapping, so unmap could sleep as well.  Add
 a might_sleep() to clarify this.

 Signed-off-by: Rob Clark r...@ti.com
 Acked-by: Daniel Vetter daniel.vet...@ffwll.ch
 ---
  drivers/base/dma-buf.c |2 ++
  1 file changed, 2 insertions(+)

 diff --git a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c
 index c30f3e1..877eacb 100644
 --- a/drivers/base/dma-buf.c
 +++ b/drivers/base/dma-buf.c
 @@ -298,6 +298,8 @@ void dma_buf_unmap_attachment(struct dma_buf_attachment 
 *attach,
   struct sg_table *sg_table,
   enum dma_data_direction direction)
  {
 + might_sleep();
 +
   if (WARN_ON(!attach || !attach-dmabuf || !sg_table))
   return;
  
Looks good to me!

Reviewed-by: Maarten Lankhorst maarten.lankho...@canonical.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html