Re: [PATCH] e4000: implement controls via v4l2 control framework

Moi Hans On 05.02.2014 09:28, Hans Verkuil wrote: Hi Antti, Hmm, it's a bit ugly this code. I have some suggestions below... Yeah, there is some redundancy, I though also the same. But functionality is now correct what I see. It is mostly that DVB gate-control logic which I personally

[PATCH] e4000: implement controls via v4l2 control framework

Implement gain and bandwidth controls using v4l2 control framework. Pointer to control handler is provided by exported symbol. Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/tuners/e4000.c |

Re: [PATCH] e4000: implement controls via v4l2 control framework

Hi Antti, Hmm, it's a bit ugly this code. I have some suggestions below... On 02/05/2014 01:05 AM, Antti Palosaari wrote: Implement gain and bandwidth controls using v4l2 control framework. Pointer to control handler is provided by exported symbol. Cc: Mauro Carvalho Chehab